[PATCH] mmc: dw-mmc: check whether card is busy or not, before disabling clock

2012-10-29 Thread Jaehoon Chung
Before disabling clock, need to check whether card is busy on not. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mmc/host/dw_mmc.c | 53 +++- drivers/mmc/host/dw_mmc.h |1 + 2

RE: [PATCH v2] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

2012-10-29 Thread Seungwon Jeon
Monday, October 29, 2012, Jaehoon Chung jh80.ch...@samsung.com After power-on, must be ensured at least 74~80 clocks before sending any first command. To ensure, it's good that dw_mci_setup_bus() is located at dw_mci_set_ios instead of __dw_mci_start_request() After power-up, host driver sets

RE: [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support

2012-10-29 Thread Philip, Avinash
On Thu, Oct 18, 2012 at 18:56:55, Porter, Matt wrote: Adds AM33XX SPI support for am335x-bone and am335x-evm. Signed-off-by: Matt Porter mpor...@ti.com --- arch/arm/boot/dts/am335x-bone.dts | 17 +++ arch/arm/boot/dts/am335x-evm.dts |9

Re: [PATCH] dw_mmc: fix multiple drv_data NULL dereferences

2012-10-29 Thread James Hogan
On 17/10/12 10:11, Will Newton wrote: Looks good to me too. Acked-by: Will Newton will.new...@imgtec.com On Wed, Oct 17, 2012 at 3:06 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Looks good to me. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Thanks for the acks Thomas, Seungwon,

Re: [PATCH v2] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

2012-10-29 Thread Jaehoon Chung
On 10/29/2012 06:08 PM, Seungwon Jeon wrote: Monday, October 29, 2012, Jaehoon Chung jh80.ch...@samsung.com After power-on, must be ensured at least 74~80 clocks before sending any first command. To ensure, it's good that dw_mci_setup_bus() is located at dw_mci_set_ios instead of

Re: [PATCH] MMCI: fetch pinctrl handle and set default state

2012-10-29 Thread Russell King - ARM Linux
On Mon, Oct 22, 2012 at 09:52:06AM +0200, Linus Walleij wrote: + /* enable pins to be muxed in and configured */ + if (!IS_ERR(host-pins_default)) { + ret = pinctrl_select_state(host-pinctrl, host-pins_default); + if (ret) + dev_err(dev-dev,

[RESEND PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-29 Thread Hebbar, Gururaja
HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x TRM (SPRUH73F - 18.3.12 Output Signals Generation) The MMC/SD/SDIO output signals

Re: [PATCH] dw_mmc: fix multiple drv_data NULL dereferences

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 29 2012, James Hogan wrote: On 17/10/12 10:11, Will Newton wrote: Looks good to me too. Acked-by: Will Newton will.new...@imgtec.com On Wed, Oct 17, 2012 at 3:06 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Looks good to me. Acked-by: Jaehoon Chung

[PATCH] MMCI: fetch pinctrl handle and set default state

2012-10-29 Thread Linus Walleij
This fetches the pinctrl resource for the MMCI driver, and if a default state is found, it is activated. Acked-by: Ulf Hansson ulf.hans...@linaro.org Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Change dev_err() to dev_warn() when grabbing the default pins since

[PATCH] mmc: at91-mci: remove driver

2012-10-29 Thread ludovic.desroches
From: Ludovic Desroches ludovic.desroc...@atmel.com The at91-mci driver is no more needed since atmel-mci driver supports all Atmel devices. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- Hello, This patch removes the old

Re: [PATCH] mmc: at91-mci: remove driver

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 29 2012, ludovic.desroc...@atmel.com wrote: From: Ludovic Desroches ludovic.desroc...@atmel.com The at91-mci driver is no more needed since atmel-mci driver supports all Atmel devices. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com Acked-by: Nicolas Ferre

Re: [RESEND PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-29 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 06:26:48PM +0530, Hebbar, Gururaja wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x TRM

Re: [PATCH 4/4] mmc: omap_hsmmc: Fix NULL pointer dereference for dt boot

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 15 2012, Venkatraman S wrote: From: Balaji T K balaj...@ti.com dev-platform_data is NULL in case of device tree boot, instead use the saved version in struct omap_hsmmc_host. Signed-off-by: Balaji T K balaj...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com Thanks,

Re: [PATCH 1/4] MMC: omap_hsmmc: claim pinctrl at probe time

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 15 2012, Venkatraman S wrote: From: Daniel Mack zon...@gmail.com This allows DT-driven board to set up the pin mux only when the driver is in use. Signed-off-by: Daniel Mack zon...@gmail.com Thanks, pushed to mmc-next for 3.8. - Chris. -- Chris Ball c...@laptop.org

Re: [PATCH 2/4] MMC: omap_hsmmc: add DT property for max bus frequency

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 15 2012, Venkatraman S wrote: From: Daniel Mack zon...@gmail.com Maximum bus frequency can be limited by external circuitry like level shifters etc. Allow passing this value from DT. Signed-off-by: Daniel Mack zon...@gmail.com Thanks, pushed to mmc-next for 3.8. - Chris.

Re: [PATCH 3/4] mmc: omap_hsmmc: fix host reference after mmc_free_host

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 15 2012, Venkatraman S wrote: From: Balaji T K balaj...@ti.com struct omap_hsmmc_host *host should not be accessed after mmc_free_host(). Reorder mmc_free_host() after iounmap(host-base). Signed-off-by: Balaji T K balaj...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com

Re: [PATCH] mmc: mxcmmc: Fix MODULE_ALIAS

2012-10-29 Thread Sascha Hauer
On Tue, Oct 09, 2012 at 04:26:05PM -0300, Fabio Estevam wrote: The correct name for the driver is mxc-mmc. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Sascha Hauer s.ha...@pengutronix.de Sascha --- drivers/mmc/host/mxcmmc.c |2 +- 1 file changed, 1

Re: [PATCH 00/26] pstore, mmc: add mmc as backend for pstore

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 29 2012, Kirill A. Shutemov wrote: On Tue, Oct 23, 2012 at 04:47:58PM +0300, Irina Tirdea wrote: These patches enable using the mmc card to store panic information. They include changes for pstore and mmc: - add block device backend for pstore - add logic in mmc for

Re: [PATCH] mmc: mxcmmc: Fix MODULE_ALIAS

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 29 2012, Sascha Hauer wrote: On Tue, Oct 09, 2012 at 04:26:05PM -0300, Fabio Estevam wrote: The correct name for the driver is mxc-mmc. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Sascha Hauer s.ha...@pengutronix.de Thanks, pushed to mmc-next for

Re: [PATCH] MMC: fix sdhci-dove removal

2012-10-29 Thread Chris Ball
Hi Russell, On Mon, Oct 15 2012, Russell King - ARM Linux wrote: Here's an updated patch which just about fixes the sdhci-dove driver. I would not be surprised given the idiotic sdhci-pltfm API if many other drivers suffered the same bug. 8 From: Russell King rmk+ker...@arm.linux.org.uk

Re: [PATCH v2] mmc: sdhci-s3c: fix the card detection in runtime-pm

2012-10-29 Thread Chris Ball
Hi, On Fri, Oct 19 2012, Heiko Stübner wrote: Am Freitag, 19. Oktober 2012, 10:04:14 schrieb Seungwon Jeon: On Thursday, October 18, 2012, Heiko Stuebner he...@sntech.de If host clock is disabled, host cannot detect a card in case of using the internal or gpio card-detect for detection.

Re: [PATCH] mmc: sh_mmcif: fix use after free

2012-10-29 Thread Chris Ball
Hi Guennadi, On Tue, Oct 23 2012, Guennadi Liakhovetski wrote: A recent commit mmc: sh_mmcif: fix clock management has introduced a use after free bug in sh_mmcif.c: in sh_mmcif_remove() the call to mmc_free_host() frees private driver data, therefore using it afterwards is a bug. Revert that

Re: [PATCH 1/1] mmc: omap_hsmmc: remove warning message for debounce clock

2012-10-29 Thread Chris Ball
Hi, On Thu, Oct 25 2012, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [121025 09:00]: MMC debounce clock is applicable only for omap2430, warning message gets printed when enable fails for debounce clock. Remove the get debounce clock failure message as it is noisy for other platforms.

Re: [PATCH] mmc: core: debugfs: Add signal_voltage to ios dump

2012-10-29 Thread Chris Ball
Hi, On Fri, Oct 26 2012, Johan Rudholm wrote: 2012/10/26 Philip Rakity prak...@nvidia.com: On Oct 26, 2012, at 11:31 AM, Johan Rudholm johan.rudh...@stericsson.com wrote: + default: + str = invalid; would is unknown be a better str ? Maybe... Actually, I just followed

Re: [PATCH v1] mmc: fix async request mechanism for sequential read scenarios

2012-10-29 Thread Per Forlin
Hi, I would like to move the focus of my concerns from root cause analysis to the actual patch, My first reflection is that the patch is relatively complex and some of the code looks duplicated. Would it be possible to simplify it and re-use the current execution flow. Is the following flow

Re: [PATCH] MMC: fix sdhci-dove removal

2012-10-29 Thread Russell King - ARM Linux
On Mon, Oct 29, 2012 at 05:10:37PM -0400, Chris Ball wrote: Hi Russell, On Mon, Oct 15 2012, Russell King - ARM Linux wrote: Here's an updated patch which just about fixes the sdhci-dove driver. I would not be surprised given the idiotic sdhci-pltfm API if many other drivers suffered the

Re: [PATCH] MMC: fix sdhci-dove removal

2012-10-29 Thread Chris Ball
Hi, On Mon, Oct 29 2012, Russell King - ARM Linux wrote: Anyway, here's a replacement patch, updated against my cubox tree but lacking the cubox gpio changes for it. Un-tested through: (a) I can't test this on its own on the cubox, (b) I don't have a separate dove tree to test it against and

Re: [PATCH] MMC: fix sdhci-dove removal

2012-10-29 Thread Sebastian Hesselbarth
On 10/29/2012 10:49 PM, Chris Ball wrote: On Mon, Oct 29 2012, Russell King - ARM Linux wrote: Anyway, here's a replacement patch, updated against my cubox tree but lacking the cubox gpio changes for it. Un-tested through: (a) I can't test this on its own on the cubox, (b) I don't have a

Re: [PATCH v2] mmc: sdhci-s3c: fix the card detection in runtime-pm

2012-10-29 Thread Heiko Stübner
Hi Chris, Am Montag, 29. Oktober 2012, 22:16:47 schrieb Chris Ball: Hi, On Fri, Oct 19 2012, Heiko Stübner wrote: Am Freitag, 19. Oktober 2012, 10:04:14 schrieb Seungwon Jeon: On Thursday, October 18, 2012, Heiko Stuebner he...@sntech.de If host clock is disabled, host cannot detect

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-10-29 Thread wwang
Hi Chris, Samuel and Alex: Can you help to review this patchset, please? I have asked Greg to remove rts_pstor from the staging tree. So this driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card reader can not be accessed easily. BR, Wei WANG -- To unsubscribe from this list:

RE: [PATCH v2] mmc: sdhci-s3c: fix the card detection in runtime-pm

2012-10-29 Thread Seungwon Jeon
Tuesday, October 30, 2012, Heiko Stuebner he...@sntech.de wrote: Hi Chris, Am Montag, 29. Oktober 2012, 22:16:47 schrieb Chris Ball: Hi, On Fri, Oct 19 2012, Heiko Stübner wrote: Am Freitag, 19. Oktober 2012, 10:04:14 schrieb Seungwon Jeon: On Thursday, October 18, 2012, Heiko

RE: [PATCH v2] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

2012-10-29 Thread Seungwon Jeon
Monday, October 29, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: On 10/29/2012 06:08 PM, Seungwon Jeon wrote: Monday, October 29, 2012, Jaehoon Chung jh80.ch...@samsung.com After power-on, must be ensured at least 74~80 clocks before sending any first command. To ensure, it's good

[PATCH v2 2/2] mmc: sdhci-s3c: fix the card detection in runtime-pm

2012-10-29 Thread Seungwon Jeon
If host clock is disabled, host cannot detect a card in case of using CD internal for detection. Signed-off-by: Seungwon Jeon tgih@samsung.com --- Rebased with mmc-next. drivers/mmc/host/sdhci-s3c.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

2012-10-29 Thread Jaehoon Chung
Dear Seungwon, On 10/30/2012 02:27 PM, Seungwon Jeon wrote: Monday, October 29, 2012, Jaehoon Chung jh80.ch...@samsung.com wrote: On 10/29/2012 06:08 PM, Seungwon Jeon wrote: Monday, October 29, 2012, Jaehoon Chung jh80.ch...@samsung.com After power-on, must be ensured at least 74~80 clocks