Re: [PATCH V2] mmc:sdhci: Wait longer for command with busy flags

2013-08-09 Thread Barry Song
2013/8/9 Haijun Zhang haijun.zh...@freescale.com: When command with busy flags send and also data busy end interrupt will be generate, the command will be finished when data transfer complete or data busy state end, Sometimes this will expend more than 10*Hz time to finish this command, so we

Re: [PATCH V2] mmc:sdhci: Wait longer for command with busy flags

2013-08-09 Thread Zhang Haijun
On 08/09/2013 02:39 PM, Barry Song wrote: 2013/8/9 Haijun Zhang haijun.zh...@freescale.com: When command with busy flags send and also data busy end interrupt will be generate, the command will be finished when data transfer complete or data busy state end, Sometimes this will expend more than

Re: [PATCH V2] mmc:sdhci: Wait longer for command with busy flags

2013-08-09 Thread Barry Song
2013/8/9 Zhang Haijun b42...@freescale.com: On 08/09/2013 02:39 PM, Barry Song wrote: 2013/8/9 Haijun Zhang haijun.zh...@freescale.com: When command with busy flags send and also data busy end interrupt will be generate, the command will be finished when data transfer complete or data busy

Re: [PATCH V2] mmc:sdhci: Wait longer for command with busy flags

2013-08-09 Thread Jaehoon Chung
On 08/09/2013 05:30 PM, Barry Song wrote: 2013/8/9 Zhang Haijun b42...@freescale.com: On 08/09/2013 02:39 PM, Barry Song wrote: 2013/8/9 Haijun Zhang haijun.zh...@freescale.com: When command with busy flags send and also data busy end interrupt will be generate, the command will be finished

Re: [PATCH V2] mmc:sdhci: Wait longer for command with busy flags

2013-08-09 Thread Zhang Haijun
On 08/09/2013 04:53 PM, Jaehoon Chung wrote: On 08/09/2013 05:30 PM, Barry Song wrote: 2013/8/9 Zhang Haijun b42...@freescale.com: On 08/09/2013 02:39 PM, Barry Song wrote: 2013/8/9 Haijun Zhang haijun.zh...@freescale.com: When command with busy flags send and also data busy end interrupt

RE: [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing

2013-08-09 Thread Seungwon Jeon
On Fri, August 09, 2013, Jaehoon Chung wrote: Hi Dinh On 08/09/2013 07:55 AM, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Remove the samsung in samsung,dw-mshc-ciu-div, samsung,dw-mshc-sdr-timing, and samsung,dw-mshc-ddr-timing. These characteristics are not

my outstanding patches for 3.12

2013-08-09 Thread Guennadi Liakhovetski
Hi Chris There are still a number of MMC patches from me for 3.12, that still aren't in next. Unless I'm missing anything, here's the list of patches with their respective patchwork IDs: mmc: SDHI: add DT compatibility strings for further SoCs pw ID: 2828382 mmc: sh_mmcif: move header include

RE: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

2013-08-09 Thread Seungwon Jeon
On Thu, August 01, 2013, Jingoo Han wrote: Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error. drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible' Signed-off-by: Jingoo Han jg1@samsung.com Acked-by:

RE: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-09 Thread Seungwon Jeon
On Thu, August 01, 2013, Jingoo Han wrote: dw_mci_socfpga_probe() is used only in this file. Fix the following sparse warning: drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not declared. Should it be static? Signed-off-by: Jingoo Han

RE: [PATCH] mmc: dw_mmc: add specified capabilities2 of the controller

2013-08-09 Thread Seungwon Jeon
On Fri, August 02, 2013, Jaehoon Chung wrote: Add the capabilities2 of controller to use MMC_CAP2_* In future, we can use the capability like packed command with caps2. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com --- drivers/mmc/host/dw_mmc.c |3 +++ drivers/mmc/host/dw_mmc.h

RE: [PATCH] mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'

2013-08-09 Thread Seungwon Jeon
On Tue, August 06, 2013,Jingoo Han wrote: Include 'dw_mmc-pltfm.h' header file in order to fix the following sparse warnings: drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning:

RE: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-09 Thread Seungwon Jeon
On Wed, August 07, 2013, Doug Anderson wrote: The dw_mmc driver keeps a cache of the current slot-clock in order to avoid doing a whole lot of work every time set_ios() is called. However, after suspend/resume the register values are bogus so we need to ensure that the cached value is

RE: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Seungwon Jeon
On Wed, August 07, 2013, Doug Anderson wrote: If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact that we haven't enabled any wakeup events due to a silicon errata. It is safe to do

RE: [PATCH v4 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-08-09 Thread Seungwon Jeon
On Wed, August 07, 2013, Doug Anderson wrote: After suspend/resume all of the dw_mmc registers are reset to defaults. We restore most of them, but specifically don't setup the clock registers after resume unless we've got a powered card. Things still work because the core will eventually

Re: [PATCH 1/3 V2] mmc:core: parse voltage from device-tree

2013-08-09 Thread Kumar Gala
On Jul 31, 2013, at 1:25 AM, Haijun Zhang wrote: Add function to support get voltage from device-tree. If there are voltage-range specified in device-tree node, this function will parse it and return the avail voltage mask. Signed-off-by: Haijun Zhang haijun.zh...@freescale.com ---

Re: [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing

2013-08-09 Thread Dinh Nguyen
On Fri, 2013-08-09 at 11:54 +0900, Jaehoon Chung wrote: Hi Dinh On 08/09/2013 07:55 AM, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Remove the samsung in samsung,dw-mshc-ciu-div, samsung,dw-mshc-sdr-timing, and samsung,dw-mshc-ddr-timing. These characteristics

RE: [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing

2013-08-09 Thread Dinh Nguyen
Hi Seungwon Jeon, On Fri, 2013-08-09 at 21:36 +0900, Seungwon Jeon wrote: On Fri, August 09, 2013, Jaehoon Chung wrote: Hi Dinh On 08/09/2013 07:55 AM, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Remove the samsung in samsung,dw-mshc-ciu-div,

Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Doug Anderson
Seungwon, On Fri, Aug 9, 2013 at 6:33 AM, Seungwon Jeon tgih@samsung.com wrote: On Wed, August 07, 2013, Doug Anderson wrote: If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact

Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-09 Thread Doug Anderson
Seungwon and Jaehoon, On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon tgih@samsung.com wrote: On Wed, August 07, 2013, Doug Anderson wrote: The dw_mmc driver keeps a cache of the current slot-clock in order to avoid doing a whole lot of work every time set_ios() is called. However, after

Re: [PATCH v4 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-08-09 Thread Doug Anderson
Seungwon, On Fri, Aug 9, 2013 at 6:35 AM, Seungwon Jeon tgih@samsung.com wrote: On Wed, August 07, 2013, Doug Anderson wrote: After suspend/resume all of the dw_mmc registers are reset to defaults. We restore most of them, but specifically don't setup the clock registers after resume

Re: dw_mmc: Does anyone use multiple slots?

2013-08-09 Thread Doug Anderson
Hi, On Thu, Aug 8, 2013 at 8:18 PM, Seungwon Jeon tgih@samsung.com wrote: On Fri, August 09, 2013, Chris Ball wrote: On Fri, Aug 09 2013, Olof Johansson wrote: On Thu, Aug 8, 2013 at 5:16 PM, Doug Anderson diand...@google.com wrote: I guess my overall question is: if there are no

[PATCH v5 0/4] mmc: dw_mmc: fixes for suspend/resume on exynos

2013-08-09 Thread Doug Anderson
This series of patches addresses some suspend/resume problems with dw_mmc on exynos platforms, espeically exynos5420. Since suspend/resume is not fully working on ToT Linux (v3.11-rc4) on exynos5250-snow, this series was tested against the current ToT ChromeOS 3.8 tree. I have confirmed basic

[PATCH v5 4/4] mmc: dw_mmc: Set timeout to max upon resume

2013-08-09 Thread Doug Anderson
The TMOUT register is initted to 0x at probe time but isn't initted after suspend/resume. Add an init of this value. No problems were observed without this (it will also get initted in __dw_mci_start_request if there is data to send), but it makes the register dump before and after

[PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Doug Anderson
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact that we haven't enabled any wakeup events due to a silicon errata. It is safe to do on all exynos variants. Signed-off-by: Doug

[PATCH v5 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-09 Thread Doug Anderson
The dw_mmc driver keeps a cache of the current slot-clock in order to avoid doing a whole lot of work every time set_ios() is called. However, after suspend/resume the register values are bogus so we need to ensure that the cached value is invalidated. Specifically I saw problems with the SD Card

[PATCH v5 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-08-09 Thread Doug Anderson
After suspend/resume all of the dw_mmc registers are reset to defaults. We restore most of them, but specifically don't setup the clock registers after resume unless we've got a powered card. Things still work because the core will eventually call set_ios() and we'll set things up. There

Re: [PATCH v2] tmio_mmc_dma: fix PIO fallback on SDHI

2013-08-09 Thread Sergei Shtylyov
Hello. On 08/03/2013 02:33 AM, Sergei Shtylyov wrote: I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA controller using The driver for this controller is using drivers/dma/sh/shdma-base.c framework. 'bonnie++' and getting DMA error And I suspect some bug/race in

Re: [PATCH v2] tmio_mmc_dma: fix PIO fallback on SDHI

2013-08-09 Thread Sergei Shtylyov
Hello. On 08/06/2013 02:37 AM, Sergei Shtylyov wrote: I'm testing SH-Mobile SDHI driver in DMA mode with a new DMA controller using 'bonnie++' and getting DMA error after which the tmio_mmc_dma.c code falls back to PIO but all commands time out after that. It turned out that the fallback

[PATCH] mmc: sdhci-pci : Remove logically dead code

2013-08-09 Thread Philippe De Swert
The amount of slots is calculated as follows: slots = PCI_SLOT_INFO_SLOTS(slots) + 1; Which means that just after it slots cannot be 0. Found with coverity: CID#744269 Signed-off-by: Philippe De Swert philippe.desw...@jollamobile.com --- drivers/mmc/host/sdhci-pci.c | 3 --- 1 file changed, 3

Re: [PATCHv2] ARM: socfpga: dts: Add support for SD/MMC

2013-08-09 Thread Stephen Warren
On 08/08/2013 05:10 PM, Dinh Nguyen wrote: On Thu, 2013-08-08 at 15:13 -0600, Stephen Warren wrote: ... Why is there a need to directly represent the divider anywhere? The driver can find the rate of the input clock, and I assume it knows what rate it wants the clock to run at, so can't it

Re: [PATCHv2] ARM: socfpga: dts: Add support for SD/MMC

2013-08-09 Thread Dinh Nguyen
On Fri, 2013-08-09 at 15:00 -0600, Stephen Warren wrote: On 08/08/2013 05:10 PM, Dinh Nguyen wrote: On Thu, 2013-08-08 at 15:13 -0600, Stephen Warren wrote: ... Why is there a need to directly represent the divider anywhere? The driver can find the rate of the input clock, and I assume it

Re: [PATCH 1/3 V3] mmc:core: parse voltage from device-tree

2013-08-09 Thread Anton Vorontsov
On Fri, Aug 09, 2013 at 11:11:01AM +0800, Haijun Zhang wrote: Add function to support get voltage from device-tree. If there are voltage-range specified in device-tree node, this function will parse it and return the available voltage mask. Signed-off-by: Haijun Zhang

Re: [PATCHv2] ARM: socfpga: dts: Add support for SD/MMC

2013-08-09 Thread Stephen Warren
On 08/09/2013 04:41 PM, Dinh Nguyen wrote: On Fri, 2013-08-09 at 15:00 -0600, Stephen Warren wrote: On 08/08/2013 05:10 PM, Dinh Nguyen wrote: On Thu, 2013-08-08 at 15:13 -0600, Stephen Warren wrote: ... Why is there a need to directly represent the divider anywhere? The driver can find the