Re: [PATCH] mmc: fix null pointer use in mmc_blk_remove_req

2013-10-10 Thread Greg KH
On Mon, Oct 07, 2013 at 11:54:11AM +0300, Adrian Hunter wrote: > On 25/08/13 06:22, Chris Ball wrote: > > Hi Franck, > > > > On Wed, Jul 24 2013, franck.jull...@gmail.com wrote: > >> From: Franck Jullien > >> > >> A previous commit (fdfa20c1631210d0) reordered the > >> shutdown sequence in mmc_bl

Re: [PATCH 2/2] mmc: core: Use autosuspend when applicable at runtime idle

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 01:21:53 PM Alan Stern wrote: > On Thu, 10 Oct 2013, Ulf Hansson wrote: > > > Hi Alan, > > > > Thanks for response! > > You're welcome. > > > > I would greatly prefer to see the core rpm_idle() routine changed > > > instead. Currently the last line says: > > > > >

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-10-10 Thread Zoran Markovic
I like the simplified approach taken in this patch. Shortening the awake time by trying to call __pm_relax() in all corner cases turned out to be too complex. Reviewed-by: Zoran Markovic Regards, Zoran On 1 October 2013 02:22, Ulf Hansson wrote: > Hi John, > >> So how does the notification don

Re: [PATCH 2/2] mmc: core: Use autosuspend when applicable at runtime idle

2013-10-10 Thread Alan Stern
On Thu, 10 Oct 2013, Ulf Hansson wrote: > Hi Alan, > > Thanks for response! You're welcome. > > I would greatly prefer to see the core rpm_idle() routine changed > > instead. Currently the last line says: > > > > return retval ? retval : rpm_suspend(dev, rpmflags); > > > > The second a

Re: [PATCH 2/2] mmc: core: Use autosuspend when applicable at runtime idle

2013-10-10 Thread Ulf Hansson
On 10 October 2013 16:45, Alan Stern wrote: > On Thu, 10 Oct 2013, Ulf Hansson wrote: > >> Typically the runtime idle function is triggered after resume and >> probe. Instead of immediately requesting the device to go into >> in-active state we make use of the autosuspend, if we have enabled >> it

Re: [PATCH 1/2] PM / Runtime: Add helper function to get value of use_autosuspend

2013-10-10 Thread Ulf Hansson
On 10 October 2013 15:03, Rafael J. Wysocki wrote: > On Thursday, October 10, 2013 12:01:46 PM Ulf Hansson wrote: >> In some cases it will be useful to know whether a device has the >> autosuspend mode enabled. Provide a helper function that returns the >> current setting. >> >> Cc: Len Brown >>

Re: [PATCH 2/2] mmc: core: Use autosuspend when applicable at runtime idle

2013-10-10 Thread Alan Stern
On Thu, 10 Oct 2013, Ulf Hansson wrote: > Typically the runtime idle function is triggered after resume and > probe. Instead of immediately requesting the device to go into > in-active state we make use of the autosuspend, if we have enabled > it earlier. > > Cc: Len Brown > Cc: Pavel Machek >

[PATCH 2/2] mmc: add dw-mmc-k3

2013-10-10 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao Tested-by: Zhigang Wang --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 66 drivers/mmc/host/Kconfig | 10 + drivers/mmc/host/Makefile |1 + drivers/mmc

[PATCH 0/2] add dw_mmc-k3.c

2013-10-10 Thread Zhangfei Gao
Support mmc for k3v2, base on dw_mmc.c Zhangfei Gao (2): mmc: dw_mmc: change definition of get_cd mmc: add dw-mmc-k3 .../devicetree/bindings/mmc/k3-dw-mshc.txt | 66 drivers/mmc/host/Kconfig | 10 + drivers/mmc/host/Makefile

[PATCH 1/2] mmc: dw_mmc: change definition of get_cd

2013-10-10 Thread Zhangfei Gao
int (*get_cd)(struct dw_mci *host, u32 slot_id) Add host info to pass priv, where contains cd pin Signed-off-by: Zhangfei Gao --- drivers/mmc/host/dw_mmc.c |2 +- include/linux/mmc/dw_mmc.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b

Re: [PATCH 14/27] mmc: omap_hsmmc: Move away from using deprecated APIs

2013-10-10 Thread Balaji T K
On Thursday 26 September 2013 08:24 PM, Ulf Hansson wrote: Suspend and resume of cards are being handled from the protocol layer and consequently the mmc_suspend|resume_host APIs are deprecated. This means we can simplify the suspend|resume callbacks by removing the use of the deprecated APIs. A

[PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-10-10 Thread Oskar Andero
From: Lars Svensson Some error bits in the status field of R1/R1b response are only set by the device in response to the command following the failing command. The status is only read and checked after a r/w command if an error is detected during the initial command or the following data transfer

[PATCH] mmc: Adding ftrace event logging to the mmc layer, extended

2013-10-10 Thread Månsson, Björn
From: Bjorn Mansson Adding ftrace to the mmc layer facilitates debugging, making it easier to debug commend sequences without rebuilding the kernel. Added support for CMD23 to my previous patch. It is also possible to parse the ftrace output into VCD format and visualize it in GTKWave. If I ge

Re: [PATCH 1/2] PM / Runtime: Add helper function to get value of use_autosuspend

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 12:01:46 PM Ulf Hansson wrote: > In some cases it will be useful to know whether a device has the > autosuspend mode enabled. Provide a helper function that returns the > current setting. > > Cc: Len Brown > Cc: Pavel Machek > Cc: Rafael J. Wysocki > Cc: Kevin Hilm

Re: help with 'discard' mount option on eMMC

2013-10-10 Thread Konstantin Dorfman
Hello, On 10/10/13 12:40, Prasanna NAVARATNA wrote: Hello, Could you please post kernel log of such failure? What hw are you using? I'm using sdhci controller. Hynix eMMC4.41. Linux Kernel 3.4.5 There are no kernel log failures as such. I need it to understand the flow. Also - how exactly reboo

Re: Re: [PATCH] mmc: dw_mmc: Add hardware lock error (HLE) to the CMD error flag

2013-10-10 Thread Alim Akhtar
Hi Jaeohoon, On Mon, Oct 7, 2013 at 2:00 AM, ALIM AKHTAR wrote: > Hi Jaeohoon, > Thanks for quick review. >>--- Original Message --- >>Sender : Jaehoon Chung S4/Engineer/System S/W >>Lab./Samsung Electronics >>Date : Oct 07, 2013 17:36 (GMT+09:00) >>Title : Re: [PATCH] mmc: dw_mmc: Add h

[PATCH 2/2] mmc: core: Use autosuspend when applicable at runtime idle

2013-10-10 Thread Ulf Hansson
Typically the runtime idle function is triggered after resume and probe. Instead of immediately requesting the device to go into in-active state we make use of the autosuspend, if we have enabled it earlier. Cc: Len Brown Cc: Pavel Machek Cc: Rafael J. Wysocki Cc: Kevin Hilman Cc: Alan Stern

[PATCH 1/2] PM / Runtime: Add helper function to get value of use_autosuspend

2013-10-10 Thread Ulf Hansson
In some cases it will be useful to know whether a device has the autosuspend mode enabled. Provide a helper function that returns the current setting. Cc: Len Brown Cc: Pavel Machek Cc: Rafael J. Wysocki Cc: Kevin Hilman Cc: Alan Stern Cc: Mika Westerberg Cc: linux...@vger.kernel.org Signed-

[PATCH 0/2] mmc: core: Favor autosuspend at runtime idle

2013-10-10 Thread Ulf Hansson
Runtime idle is typically triggered after resume and probe. In these cases we would like to make use of autosuspend if we have enabled it earlier, otherwise the device will more or less immediately be requested to go into in-active state. As a part of this patchset a new helper function has been a

Re: help with 'discard' mount option on eMMC

2013-10-10 Thread Prasanna NAVARATNA
> Hello, > Could you please post kernel log of such failure? > What hw are you using? I'm using sdhci controller. Hynix eMMC4.41. Linux Kernel 3.4.5 There are no kernel log failures as such. If i add print while sending CMD38 when 'discard' mount option is specified, then CMD38 with Arg 1 are con

mmc_rescan causes severe interrupt latency

2013-10-10 Thread Thomas Otvald Jensen
Hi, I am on an embedded system, and found that we had several ms interrupt delay (causing UART overrun). The problem was identified as part of the mmc_rescan. Our setup has enabled polling (MMC_CAP_NEEDS_POLL) to detect if an SD card is present. This will cause a periodic rescheduling of mmc_resc

Re: help with 'discard' mount option on eMMC

2013-10-10 Thread Konstantin Dorfman
Hello, Could you please post kernel log of such failure? What hw are you using? On 10/10/13 09:44, Prasanna NAVARATNA wrote: Hello, I'm using Hynix eMMC4.41 with Linux kernel 3.4.5. After mounting ext4 partition /userdata with 'discard' mount option enabled, fs triggers TRIM commands to eMMC a

Re: [PATCH] mmc: sh_mmcif: Get rid of MMC_BLOCK dependency

2013-10-10 Thread Simon Horman
On Thu, Oct 10, 2013 at 07:45:45AM +0900, Magnus Damm wrote: > From: Magnus Damm > > It seems like sh_mmcif.c now is the only MMC driver depending on MMC_BLOCK, > the hardware is not special in any way so rework the Kconfig dependency to > be less special. > > Signed-off-by: Magnus Damm Review