Re: [PATCHv2 3/3] mmc: dw_mmc-exynos: Remove Exynos' custom prepare_command function

2013-12-06 Thread Arnd Bergmann
On Saturday 07 December 2013, dingu...@altera.com wrote: > -static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) > -{ > - /* > -* Exynos4412 and Exynos5250 extends the use of CMD register with the > -* use of bit 29 (which is reserved on standard MSHC cont

[PATCHv2 1/3] mmc: dw_mmc: Enable the hold reg for certain speed modes

2013-12-06 Thread dinguyen
From: Dinh Nguyen This patch will enable the SDMMC_CMD_USE_HOLD_REG bit when the slot is operating all timing modes, except for SDR50, DDR50, SDR104, and MMC_HS200. According to the Synopsys databook :"To meet the relatively high Input Hold Time requirement for SDR12, SDR25, and other MMC speed

[PATCHv2 2/3] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread dinguyen
From: Dinh Nguyen Rockchip's implementation of the dw_mmc controller only requires the setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the patch to set the SDMMC_CMD_USE_HOLD_REG by checking the slot's speed mode, this Rockchip custom driver structure is no longer necessary. Signed-

[PATCHv2 0/3] mmc: dw_mmc: Make the use of the hold reg generic

2013-12-06 Thread dinguyen
From: Dinh Nguyen Hi, This is v2 of the patch series that makes the setting of the SDMMC_CMD_USE_HOLD_REG bit generic. v2 differences: * Another part of the spec on dw_mmc states, "Never set CMD.use_hold_reg = 1 and cclk_in_drv phase shift to 0 at the same time. This would add an extra one

[PATCHv2 3/3] mmc: dw_mmc-exynos: Remove Exynos' custom prepare_command function

2013-12-06 Thread dinguyen
From: Dinh Nguyen The Exynos prepare_command function is only checking when to set the SDMMC_CMD_USE_HOLD_REG bit. Now that there is a generic way to check on when to set SDMMC_CMD_USE_HOLD_REG bit. Signed-off-by: Dinh Nguyen --- v2: none --- drivers/mmc/host/dw_mmc-exynos.c | 14 ---

Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread Heiko Stübner
Am Samstag, 7. Dezember 2013, 00:27:01 schrieb Dinh Nguyen: > On 12/6/13 5:22 PM, Heiko Stübner wrote: > > Am Samstag, 7. Dezember 2013, 00:18:07 schrieb Dinh Nguyen: > >> On 12/6/13 5:14 PM, Heiko Stübner wrote: > >>> Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dingu...@altera.com:@@ > >>> -42,

Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread Heiko Stübner
Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dingu...@altera.com: > From: Dinh Nguyen > > Rockchip's implementation of the dw_mmc controller only requires the > setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the patch to > set the SDMMC_CMD_USE_HOLD_REG by checking the slot's spee

Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread Dinh Nguyen
On 12/6/13 5:14 PM, Heiko Stübner wrote: > Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dingu...@altera.com: >> From: Dinh Nguyen >> >> Rockchip's implementation of the dw_mmc controller only requires the >> setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the patch to >> set the SD

Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread Dinh Nguyen
On 12/6/13 5:22 PM, Heiko Stübner wrote: > Am Samstag, 7. Dezember 2013, 00:18:07 schrieb Dinh Nguyen: >> On 12/6/13 5:14 PM, Heiko Stübner wrote: >>> Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dingu...@altera.com:@@ -42,7 >>> +42,7 @@ >>> /* Common flag combinations */ >>> #define DW_MCI_D

Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread Heiko Stübner
Am Samstag, 7. Dezember 2013, 00:18:07 schrieb Dinh Nguyen: > On 12/6/13 5:14 PM, Heiko Stübner wrote: > > Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dingu...@altera.com: > >> From: Dinh Nguyen > >> > >> Rockchip's implementation of the dw_mmc controller only requires the > >> setting of the

Re: [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic

2013-12-06 Thread Dinh Nguyen
On 12/6/13 11:36 AM, Arnd Bergmann wrote: > On Friday 06 December 2013, dingu...@altera.com wrote: >> From: Dinh Nguyen >> >> Hi, >> >> This patch series makes the setting of the SDMMC_CMD_USE_HOLD_REG bit generic >> for all platforms that requires it. According the Synopsys spec on the >> dw_mm

Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2013-12-06 Thread Jarkko Nikula
On 12/06/2013 01:41 PM, Aaro Koskinen wrote: >> Set goes on top of v3.13-rc2-208-g8ecffd791448. > > Patch 5 had some fuzz with plain 3.13-rc2. Otherwise these look fine. > I tested these on 770 and N800, so for all patches: > > Tested-by: Aaro Koskinen > Yes, reason for your fuzz observation is

Re: [PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic

2013-12-06 Thread Arnd Bergmann
On Friday 06 December 2013, dingu...@altera.com wrote: > From: Dinh Nguyen > > Hi, > > This patch series makes the setting of the SDMMC_CMD_USE_HOLD_REG bit generic > for all platforms that requires it. According the Synopsys spec on the dw_mmc, > setting the SDMMC_CMD_USE_HOLD_REG should be don

[PATCH 0/2] mmc: dw_mmc: Make the use of the hold reg generic

2013-12-06 Thread dinguyen
From: Dinh Nguyen Hi, This patch series makes the setting of the SDMMC_CMD_USE_HOLD_REG bit generic for all platforms that requires it. According the Synopsys spec on the dw_mmc, setting the SDMMC_CMD_USE_HOLD_REG should be done for all speeds except for the following higher speed modes: SDR104,

[PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure

2013-12-06 Thread dinguyen
From: Dinh Nguyen Rockchip's implementation of the dw_mmc controller only requires the setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the patch to set the SDMMC_CMD_USE_HOLD_REG by checking the slot's speed mode, this Rockchip custom driver structure is no longer necessary. Signed-

[PATCH 1/2] mmc: dw_mmc: Enable the hold reg for certain speed modes

2013-12-06 Thread dinguyen
From: Dinh Nguyen This patch will enable the SDMMC_CMD_USE_HOLD_REG bit when the slot is operating all timing modes, except for SDR50, DDR50, SDR104, and MMC_HS200. According to the Synopsys databook :"To meet the relatively high Input Hold Time requirement for SDR12, SDR25, and other MMC speed

Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2013-12-06 Thread Aaro Koskinen
Hi, On Wed, Dec 04, 2013 at 09:14:07PM +, Jarkko Nikula wrote: > I've sent these patches earlier to linux-mmc list. This time set is one > patch smaller since commit 31ee9181eb92 > ("mmc: omap: Fix DMA configuration to not rely on device id") does > practically same what one of my patch did. >

Re: [PATCH v7 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

2013-12-06 Thread Georgi Djakov
On 12/05/2013 12:27 PM, Mark Rutland wrote: On Wed, Nov 06, 2013 at 03:56:45PM +, Georgi Djakov wrote: This platform driver adds the initial support of Secure Digital Host Controller Interface compliant controller found in Qualcomm MSM chipsets. Signed-off-by: Georgi Djakov --- drivers/m

Re: [PATCH v7 1/2] mmc: sdhci-msm: Initial SDHCI MSM driver documentation

2013-12-06 Thread Georgi Djakov
On 12/05/2013 11:52 AM, Mark Rutland wrote: Hi, Apologies for the late reply. Hi Mark, thanks for the review! On Wed, Nov 06, 2013 at 03:56:44PM +, Georgi Djakov wrote: This patch adds documentation for Qualcomm SDHCI MSM driver. It contains the differences between the core properties

Re: [PATCH] atmel-mci: fix transfers < 16 bytes problem in PDC mode

2013-12-06 Thread Ludovic Desroches
Hi Olivier, On Thu, Dec 05, 2013 at 10:45:16AM +0100, Olivier Sobrie wrote: [...] > > Hi Ludovic, > > With this patch I'm able to use the wlan sdio module wl1271. > When you've time, it would be nice to validate or fix this > patch. Thanks for your patch, before giving my ack I would like to

Re: [PATCH 1/6] mmc: Do not call get_cd for non removable cards

2013-12-06 Thread Ulf Hansson
On 5 December 2013 14:34, Sascha Hauer wrote: > Non removable cards are always present, so do not call get_cd for them. > > Signed-off-by: Sascha Hauer Acked-by: Ulf Hansson > --- > drivers/mmc/core/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/