RE: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-07 Thread Roger Tseng
Hi Dan, >> +int rtsx_usb_ep0_write_register(struct rtsx_ucr *ucr, u16 addr, >> + u8 mask, u8 data) >> +{ >> + u16 value = 0, index = 0; >> + >> + value |= (u16)(3 & 0x03) << 14; >> + value |= (u16)(addr & 0x3FFF); > >Don't do pointless things: > >value |= 0x03 << 14

Re: [PATCH] mmc: tmio: fixup compile error

2014-01-07 Thread Simon Horman
On Tue, Jan 07, 2014 at 05:33:51PM -0800, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch fixup below compile error > > ${LINUX}/drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_probe': > ${LINUX}/drivers/mmc/host/tmio_mmc.c:93:35: \ > error: 'res_ctl' undeclared (first

[PATCH 3/3] mmc: sdhci-pci: remove unnecessary pci_set_drvdata()

2014-01-07 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sd

[PATCH 2/3] mmc: mmc_spi: remove unnecessary spi_set_drvdata()

2014-01-07 Thread Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c |2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 1/3] mmc: mmc_spi: use spi_get_drvdata() and spi_set_drvdata()

2014-01-07 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we can directly pass a struct spi_device. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c |8 1 file changed,

[PATCH] mmc: tmio: fixup compile error

2014-01-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch fixup below compile error ${LINUX}/drivers/mmc/host/tmio_mmc.c: In function 'tmio_mmc_probe': ${LINUX}/drivers/mmc/host/tmio_mmc.c:93:35: \ error: 'res_ctl' undeclared (first use in this function) ${LINUX}/drivers/mmc/host/tmio_mmc.c:93:35: \ no

Re: [PATCHv4] mmc: dw_mmc: Enable the hold reg for certain speed modes

2014-01-07 Thread Jaehoon Chung
Hi, Dinh. Sorry for replying too late. ..[snip].. >>> +sdr_timing[1] = ddr_timing[1] = 1; >>> +of_property_read_u32_array(np, >>> +"samsung,dw-mshc-sdr-timing", sdr_timing, 2); >>> + >>> +of_property_read_u32_array(np, >>> +"samsung,dw-m

Re: [PATCHv4] mmc: dw_mmc: Enable the hold reg for certain speed modes

2014-01-07 Thread Dinh Nguyen
On Thu, 2013-12-26 at 11:26 -0600, Dinh Nguyen wrote: > Hi Jaehoon, > > On 12/25/13 8:57 PM, Jaehoon Chung wrote: > > On 12/17/2013 11:54 PM, zhangfei wrote: > >> > >> On 12/17/2013 10:03 PM, Dinh Nguyen wrote: > >>> Hi Zhangfei, > >>> > >>> On 12/17/13 2:11 AM, zhangfei wrote: > > On 12

Re: [RESEND PATCHv8 3/4] mmc: dw_mmc-socfpga: Remove the SOCFPGA specific platform for dw_mmc

2014-01-07 Thread Dinh Nguyen
Hi Gerhard, On Tue, 2014-01-07 at 21:17 +0100, Gerhard Sittig wrote: > On Mon, Jan 06, 2014 at 13:32 -0600, dingu...@altera.com wrote: > > > > --- > > drivers/mmc/host/Kconfig |8 --- > > drivers/mmc/host/dw_mmc-socfpga.c | 138 > > - > > 2 file

Re: [RESEND PATCHv8 3/4] mmc: dw_mmc-socfpga: Remove the SOCFPGA specific platform for dw_mmc

2014-01-07 Thread Gerhard Sittig
On Mon, Jan 06, 2014 at 13:32 -0600, dingu...@altera.com wrote: > > --- > drivers/mmc/host/Kconfig |8 --- > drivers/mmc/host/dw_mmc-socfpga.c | 138 > - > 2 files changed, 146 deletions(-) > delete mode 100644 drivers/mmc/host/dw_mmc-socfpga.c

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

2014-01-07 Thread Tim Kryger
On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt wrote: > On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger wrote: >> Enable the external clock needed by the host controller during the >> probe and disable it during the remove. >> >> Signed-off-by: Tim Kryger >> Reviewed-by: Markus Mayer >> Reviewed

[PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-01-07 Thread Franky Lin
For high clock frequency modes, ie. SDR104 and possibly SDR50, the data window on the CMD and DAT lines needs to be tuned. Once tuned to a sample clock rate, a re-tuning might required because of drifted signal on different lines. This re-tuning is needed and only necessary for commands using the D

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

2014-01-07 Thread Laurent Pinchart
On Tuesday 07 January 2014 15:50:45 Chris Ball wrote: > On Tue, Jan 07 2014, Laurent Pinchart wrote: > > On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote: > >> Hi Chris, > >> > >> Could you please pick this patch (and patch 08/15 in the same series) up > >> for v3.14 ? > > > > Ping ?

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

2014-01-07 Thread Chris Ball
Hi Laurent, On Tue, Jan 07 2014, Laurent Pinchart wrote: > Hi Chris, > > On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote: >> Hi Chris, >> >> Could you please pick this patch (and patch 08/15 in the same series) up for >> v3.14 ? > > Ping ? Thanks, both pushed to mmc-next for 3.14,

Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST

2014-01-07 Thread Laurent Pinchart
Hi Chris, On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote: > Hi Chris, > > Could you please pick this patch (and patch 08/15 in the same series) up for > v3.14 ? Ping ? > On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote: > > This helps increasing build testing coverag

Re: [PATCH 2/4] mmc: tmio: bus_shift become tmio_mmc_data member

2014-01-07 Thread Arnd Bergmann
On Wednesday 20 November 2013, Kuninori Morimoto wrote: > const struct mfd_cell *cell = mfd_get_cell(pdev); > struct tmio_mmc_data *pdata; > struct tmio_mmc_host *host; > + struct resource *res; > int ret = -EINVAL, irq; > > if (pdev->num_resources !=

Re: [PATCH v7 5/7] ARM: dts: add pbias dt node

2014-01-07 Thread Balaji T K
On Tuesday 07 January 2014 04:27 PM, Mark Rutland wrote: On Tue, Jan 07, 2014 at 10:18:15AM +, Balaji T K wrote: On Monday 06 January 2014 11:49 PM, Mark Rutland wrote: On Fri, Dec 20, 2013 at 05:35:53PM +, Balaji T K wrote: Add pbias regulator node as a child of system control module

Re: [PATCH v7 5/7] ARM: dts: add pbias dt node

2014-01-07 Thread Mark Rutland
On Tue, Jan 07, 2014 at 10:18:15AM +, Balaji T K wrote: > On Monday 06 January 2014 11:49 PM, Mark Rutland wrote: > > On Fri, Dec 20, 2013 at 05:35:53PM +, Balaji T K wrote: > >> Add pbias regulator node as a child of system control > >> module - syscon. > >> > >> Signed-off-by: Balaji T K

Re: [PATCH v7 5/7] ARM: dts: add pbias dt node

2014-01-07 Thread Balaji T K
On Monday 06 January 2014 11:49 PM, Mark Rutland wrote: On Fri, Dec 20, 2013 at 05:35:53PM +, Balaji T K wrote: Add pbias regulator node as a child of system control module - syscon. Signed-off-by: Balaji T K --- arch/arm/boot/dts/dra7.dtsi | 18 ++ arch/arm/boot/d

Re: [PATCH v7 3/7] regulator: add pbias regulator support

2014-01-07 Thread Balaji T K
On Monday 06 January 2014 11:46 PM, Mark Rutland wrote: On Fri, Dec 20, 2013 at 05:35:51PM +, Balaji T K wrote: pbias register controls internal power supply to sd card i/o pads in most OMAPs (OMAP2-5, DRA7). Control bits for selecting voltage level and enabling/disabling are in the same PBI