Re: [PATCH v2 4/7] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2014-04-14 Thread Jaehoon Chung
Hi, Seungwon. On 03/26/2014 08:31 PM, Seungwon Jeon wrote: ciu_div may not be common value for all speed mode. So, it needs to be attached to CLKSEL timing. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc-exynos.c | 75

Re: [PATCH v2 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available

2014-04-14 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 03/26/2014 08:31 PM, Seungwon Jeon wrote: Add checking whether the clock is valid. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc-exynos.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-)

Re: [PATCH v2 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC

2014-04-14 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 03/26/2014 08:30 PM, Seungwon Jeon wrote: Even though 1MB is reserved for descriptor table in IDMAC, the dw_mmc host driver is allowed to receive only maximum 128KB block length in one request. This is caused by setting improper max_blk_count.

Re: [PATCH v2 3/7] mmc: dw_mmc: exynos: move definitions to header file

2014-04-14 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 03/26/2014 08:31 PM, Seungwon Jeon wrote: Move some parts related to definition to header file. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc-exynos.c | 46 ---

Re: [PATCH] mmc: dw_mmc: fix status error for Kingston brand SD cards

2014-04-14 Thread Jaehoon Chung
Hi, Dinh. On 03/29/2014 12:53 AM, Dinh Nguyen wrote: On Fri, 2014-03-28 at 21:32 +0900, Seungwon Jeon wrote: Hi Dinh, On Fri, March 28, 2014, Dinh Nguyen wrote: From: Dinh Nguyen dingu...@altera.com commits [90c2143a8f mmc: dw_mmc: guarantee stop-abort cmd in data errors] and [e352c813110

Re: [RFC PATCH 1/1 v5 ]mmc: Support-FFU-for-eMMC-v5.0

2014-04-14 Thread Jaehoon Chung
Hi Avi. Could you fix the line wrap? Best Regards, Jaehoon Chung On 04/12/2014 03:39 AM, Avi Shchislowski wrote: Change the patch version number from V4 to v5 The Field Firmware Update (FFU) feature is new for eMMC 5.0 spec (Jedec: JESD84-B50.pdf)

Re: [PATCH RESEND] mmc: Delay the card_event callback into the mmc_rescan worker

2014-04-14 Thread Ulf Hansson
On 9 April 2014 00:19, Markus Mayer markus.ma...@linaro.org wrote: This change removes the callback from atomic context which it doesn't need to be in, and puts it in line with the debounced rescan. This code is based on these e-mail threads with Christian Daudt:

Re: [PATCH RESEND 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

2014-04-14 Thread Ulf Hansson
On 22 March 2014 09:52, Alexander Shiyan shc_w...@mail.ru wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru Acked-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/mxcmmc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

Re: [PATCH RESEND] mmc: sdhci-s3c: Remove unused define for NUM_GPIOS

2014-04-14 Thread Ulf Hansson
On 8 March 2014 08:03, Axel Lin axel@ingics.com wrote: NUM_GPIOS is not used after commit e19499ae mmc: sdhci-s3c: let device core setup the default pin configuration. Thus remove it. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Jaehoon Chung jh80.ch...@samsung.com Acked-by:

[GIT PULL] MMC updates for mmc-next for 3.16, take 1

2014-04-14 Thread Ulf Hansson
Hi Chris, Here are a collection of patches for which I have acked earlier. I have changed my ack to a signed-off-by for these patches, I suppose that makes sense!? Unless you have some additional review comments, please pull them into you mmc-next branch once you have re-based it towards an 3.15

Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

2014-04-14 Thread Mark Brown
On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote: The is_enabled implementation is wrong in some cases: e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26) However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits. So is_enabled callback will always return

[PATCH] mmc: sdhci-pci: Remove useless check for slots == 0

2014-04-14 Thread Bjorn Helgaas
Remove the check for slots == 0 because it can never be 0 here. Found by Coverity (CID 744269). Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/mmc/host/sdhci-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c

[PATCH 0/4] Tegra SD/MMC fixes

2014-04-14 Thread Andrew Bresticker
The following patches fix a couple of issues which prevented Venice2 boards from booting via eMMC and SD card reliably. Note that this includes disabling UHS support since SDR50 and above require a Tegra-specific tuning procedure which is not supported yet (and still seems to have issues even in

[PATCH 2/4] mmc: tegra: fix reporting of base clock frequency

2014-04-14 Thread Andrew Bresticker
Tegra SDHCI controllers, by default, report a base clock frequency of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the actual base clock frequency. While this can be overridden by setting BASE_CLK_FREQ in VENDOR_CLOCK_CTRL on Tegra30 and later SoCs, just set

[PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators

2014-04-14 Thread Andrew Bresticker
VDDIO_SDMMC3 is the VQMMC supply, not the VMMC supply, for the SD slot. Add 1.8V_VDDIO as the VQMMC supply for the eMMC. Signed-off-by: Andrew Bresticker abres...@chromium.org --- arch/arm/boot/dts/tegra124-venice2.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 1/4] mmc: tegra: disable UHS modes

2014-04-14 Thread Andrew Bresticker
Program TEGRA_SDHCI_VENDOR_MISC_CTRL so that UHS modes aren't advertised in SDHCI_CAPABILITIES_1. While the Tegra SDHCI controller does support these modes, they require Tegra-specific tuning and calibration routines which the driver does not support yet. Signed-off-by: Andrew Bresticker

[PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-14 Thread Andrew Bresticker
If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but the corresponding regulator may not have probed). Instead of continuing without the regulator, return EPROBE_DEFER from sdhci_add_host(). Also, fix regulator