Re: Help needed on an error during SD card enumeration

2013-01-21 Thread Kishore Kadiyala
Hi Shashidhar Hiremath, snip mmc0:host doesn't support card's voltages set_ios invoked Poweroff Done mmc0: error -22 whilst initializing SDIO card Could you check whether the MMC host controller regulator is configured properly. eventhough I have inserted a SD card Which SD card you

Re: [PATCH] omap_hsmmc - use threaded irq handler for card-detect.

2011-12-29 Thread Kishore Kadiyala
-by: Felipe Balbi ba...@ti.com Tested-by: Grazvydas Ignotas nota...@gmail.com Signed-off-by: NeilBrown ne...@suse.de I have done some thing similar but didn't pushed it :-( Anyways Acked-by: Kishore Kadiyala kishorek.kadiy...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc

Re: [PATCH 1/1] mmc: Check to disable IOCTL when card is mounted

2011-12-28 Thread Kishore Kadiyala
On Wed, Dec 28, 2011 at 5:46 AM, Shashidhar hiremath shashidh...@vayavyalabs.com wrote: From: Shashidhar Hiremath shashidh...@vayavyalabs.com The Patch adds a check to disable the IOCTL from running when the card is mounted or device is opened elsewhere. Signed-off-by: Shashidhar Hiremath

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-06 Thread Kishore Kadiyala
On Fri, Sep 2, 2011 at 12:35 AM, Venkatraman S svenk...@ti.com wrote: Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a single location in post_req function, to prevent double unmapping. Signed-off-by: Venkatraman S

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-07-22 Thread Kishore Kadiyala
on SDMMC1_VDDS whereas USBC1 is based on SIM_VDDS therefore they can operate independently. Signed-off-by: Bryan Buckley bryan.buck...@ti.com Good catch, Acked-by: Kishore Kadiyala kishore.kadiy...@ti.com ---  arch/arm/mach-omap2/hsmmc.c |   12  1 files changed, 4 insertions(+), 8

Re: [PATCH] mmc: enable background operations for emmc4.41 with HPI support

2011-07-18 Thread Kishore Kadiyala
snip How does BKOPS work with card power management ? On some controllers, regulators are switched off in between transactions after some delay. Wouldn't the card need power to do it's BKOPS ? AFAIK eMMC card has two voltages one for core rail and other for IO rail. Power Management is done

Re: [PATCH v6 11/11] mmc: add handling for two parallel block requests in issue_rw_rq

2011-06-21 Thread Kishore Kadiyala
Hi Per, snip --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -108,6 +108,7 @@ static DEFINE_MUTEX(open_lock);  enum mmc_blk_status {        MMC_BLK_SUCCESS = 0, +       MMC_BLK_PARTIAL,        MMC_BLK_RETRY,        MMC_BLK_DATA_ERR,        MMC_BLK_CMD_ERR, snip

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Kishore Kadiyala
Hi Per, On Tue, Jun 21, 2011 at 12:21 PM, Per Forlin per.for...@linaro.org wrote: On 21 June 2011 07:41, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: snip + +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request *mrq, +                              bool

Re: [PATCH v6 11/11] mmc: add handling for two parallel block requests in issue_rw_rq

2011-06-20 Thread Kishore Kadiyala
On Mon, Jun 20, 2011 at 2:47 AM, Per Forlin per.for...@linaro.org wrote: Change mmc_blk_issue_rw_rq() to become asynchronous. The execution flow looks like this: The mmc-queue calls issue_rw_rq(), which sends the request to the host and returns back to the mmc-queue. The mmc-queue calls

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-20 Thread Kishore Kadiyala
snip + +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request *mrq, +                              bool is_first_req) I don't see the usage of is_first_req below. Is it required? +{ +       struct omap_hsmmc_host *host = mmc_priv(mmc); + +       if

Re: Dynamic MMC device naming vs. bootloaders

2011-04-06 Thread Kishore Kadiyala
On Wed, Apr 6, 2011 at 2:58 AM, Stephen Warren swar...@nvidia.com wrote: Kishore Kadiyala wrote at Tuesday, April 05, 2011 12:38 AM: Hi Stephen, On Mon, Apr 4, 2011 at 11:09 PM, Stephen Warren swar...@nvidia.com wrote: Chris et. al., I'm working on an ARM system that contains at least

Re: Dynamic MMC device naming vs. bootloaders

2011-04-05 Thread Kishore Kadiyala
Hi Stephen, On Mon, Apr 4, 2011 at 11:09 PM, Stephen Warren swar...@nvidia.com wrote: Chris et. al., I'm working on an ARM system that contains at least two MMC/SD devices; specifically the board has an internal MMC device, and an SD card slot, although the SoC has four MMC/SD hosts IIRC.

Re: [patch 149/177] drivers/mmc/host/omap_hsmmc.c: use resource_size()

2011-03-23 Thread Kishore Kadiyala
Feel free to add Acked-by: Kishore Kadiyala kishore.kadiy...@ti.com ---  drivers/mmc/host/omap_hsmmc.c |    7 +++  1 file changed, 3 insertions(+), 4 deletions(-) diff -puN drivers/mmc/host/omap_hsmmc.c~drivers-mmc-host-omap_hsmmcc-use-resource_size drivers/mmc/host/omap_hsmmc.c

Re: [patch 148/177] drivers/mmc/host/omap.c: use resource_size()

2011-03-23 Thread Kishore Kadiyala
-foundation.org Acked-by: Kishore Kadiyala kishore.kadiy...@ti.com ---  drivers/mmc/host/omap.c |    6 +++---  1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/mmc/host/omap.c~drivers-mmc-host-omapc-use-resource_size drivers/mmc/host/omap.c --- a/drivers/mmc/host/omap.c

[PATCH v6 8/8] OMAP: hsmmc: Rename the device and driver

2011-02-28 Thread Kishore Kadiyala
Modifying the device driver name from mmci-omap-hs to omap_hsmmc. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/board-2430sdp.c |2 +- arch/arm/mach-omap2/board-3430sdp.c |6 +++--- arch/arm

[PATCH v6 5/8] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-28 Thread Kishore Kadiyala
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_44xx_data.c |8 arch/arm/plat-omap/include

[PATCH v6 1/8] omap: mmc: split out init for 2420

2011-02-28 Thread Kishore Kadiyala
. Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Chris Ball c...@laptop.org --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c

[PATCH v6 3/8] OMAP3: hwmod data: Add HSMMC

2011-02-28 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit

[PATCH v6 0/8] OMAP: HSMMC: hwmod adaptation

2011-02-28 Thread Kishore Kadiyala
Kishore Kadiyala (4): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: hsmmc: Move mux configuration to hsmmc.c OMAP: adapt hsmmc to hwmod framework OMAP: hsmmc: Rename the device and driver Paul Walmsley (2): OMAP2430: hwmod data: Add HSMMC OMAP3: hwmod data: Add HSMMC

[PATCH v6 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-28 Thread Kishore Kadiyala
controller supports dual volt cards Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Reviewed-by: Balaji T K balaj...@ti.com Cc: Benoit Cousson b-cous...@ti.com CC: Kevin Hilman khil...@deeprootsystems.com Cc: Tony Lindgren t...@atomide.com --- arch/arm

[PATCH v6 6/8] OMAP: hsmmc: Move mux configuration to hsmmc.c

2011-02-28 Thread Kishore Kadiyala
Moving the definition of mux setting API from devices.c to hsmmc.c and renaming it from omap2_mmc_mux to omap_hsmmc_mux. Also calling omap_hsmmc_mux from omap2_hsmmc_init. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Chris Ball c...@laptop.org Cc: Tony Lindgren t...@atomide.com

[PATCH v6 4/8] OMAP4: hwmod data: enable HSMMC

2011-02-28 Thread Kishore Kadiyala
From: Anand Gadiyar gadi...@ti.com Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5

[RESEND v5 PATCH 5/8] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-26 Thread Kishore Kadiyala
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_44xx_data.c |8 arch/arm/plat-omap/include

[RESEND v5 PATCH 2/8] OMAP2430: hwmod data: Add HSMMC

2011-02-26 Thread Kishore Kadiyala
https://patchwork.kernel.org/patch/538301/ Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit Cousson b-cous...@ti.com --- arch/arm/mach

[PATCH v5 0/8] OMAP: HSMMC: hwmod adaptation

2011-02-25 Thread Kishore Kadiyala
(2): omap: mmc: split out init for 2420 OMAP4: hwmod data: enable HSMMC Kishore Kadiyala (4): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: hsmmc: Move mux configuration to hsmmc.c OMAP: adapt hsmmc to hwmod framework OMAP: hsmmc: Rename the device and driver Paul

[PATCH v5 1/8] omap: mmc: split out init for 2420

2011-02-25 Thread Kishore Kadiyala
. Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Chris Ball c...@laptop.org --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c

[PATCH v5 8/8] OMAP: hsmmc: Rename the device and driver

2011-02-25 Thread Kishore Kadiyala
Modifying the device driver name from mmci-omap-hs to omap_hsmmc. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/board-2430sdp.c |2 +- arch/arm/mach-omap2/board-3430sdp.c |6 +++--- arch/arm

[PATCH v5 4/8] OMAP4: hwmod data: enable HSMMC

2011-02-25 Thread Kishore Kadiyala
From: Anand Gadiyar gadi...@ti.com Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5

[PATCH v5 6/8] OMAP: hsmmc: Move mux configuration to hsmmc.c

2011-02-25 Thread Kishore Kadiyala
Moving the definition of mux setting API from devices.c to hsmmc.c and renaming it from omap2_mmc_mux to omap_hsmmc_mux. Also calling omap_hsmmc_mux from omap2_hsmmc_init. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Chris Ball c...@laptop.org Cc: Tony Lindgren t...@atomide.com

[PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kishore Kadiyala
...@pwsan.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit Cousson b-cous...@ti.com CC: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2/devices.c | 168 arch/arm/mach-omap2/hsmmc.c | 343 ++-- arch

[PATCH v5 2/8] OMAP2430: hwmod data: Add HSMMC

2011-02-25 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc

[PATCH v5 3/8] OMAP3: hwmod data: Add HSMMC

2011-02-25 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit

[PATCH v4 3/6] OMAP4: hwmod data: enable HSMMC

2011-02-24 Thread Kishore Kadiyala
From: Anand Gadiyar gadi...@ti.com Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Benoit Coussonb-cous...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5

[PATCH v4 0/6] OMAP: HSMMC: hwmod adaptation

2011-02-24 Thread Kishore Kadiyala
Kishore Kadiyala (2): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: adapt hsmmc to hwmod framework OMAP: hsmmc: Rename the device and driver Paul Walmsley (2): OMAP2430: hwmod data: Add HSMMC OMAP3: hwmod data: Add HSMMC arch/arm/mach-omap2/board-2430sdp.c

[PATCH v4 4/6] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-24 Thread Kishore Kadiyala
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |6 ++ arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 ++ arch

[PATCH v4 1/6] OMAP2430: hwmod data: Add HSMMC

2011-02-24 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc

[PATCH v4 2/6] OMAP3: hwmod data: Add HSMMC

2011-02-24 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit

[PATCH v4 6/6] OMAP: hsmmc: Rename the device and driver

2011-02-24 Thread Kishore Kadiyala
Modifying the device driver name from mmci-omap-hs to omap_hsmmc. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Chris Ball c...@laptop.org Cc: Tony Lindgren t

[PATCH 1/6] omap: mmc: split out init for 2420

2011-02-23 Thread Kishore Kadiyala
. Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Chris Ball c...@laptop.org --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c

[PATCH] omap: mmc: split out init for 2420

2011-02-23 Thread Kishore Kadiyala
. Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Chris Ball c...@laptop.org --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c

[PATCH v3 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-23 Thread Kishore Kadiyala
/lists/linux-omap/msg45443.html V1: --- http://www.spinics.net/lists/linux-mmc/msg05689.html Anand Gadiyar (1): OMAP4: hwmod data: enable HSMMC Kishore Kadiyala (2): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: adapt hsmmc to hwmod framework Paul Walmsley (2): OMAP2430

[PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-23 Thread Kishore Kadiyala
number, Irq_number, device attribute. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit Cousson b-cous...@ti.com CC: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2/devices.c | 251

[PATCH v3 4/5] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-23 Thread Kishore Kadiyala
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c |9 + arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 12 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 16

[PATCH v3 2/5] OMAP3: hwmod data: Add HSMMC

2011-02-23 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit

[PATCH v3 3/5] OMAP4: hwmod data: enable HSMMC

2011-02-23 Thread Kishore Kadiyala
From: Anand Gadiyar gadi...@ti.com Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar gadi...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com CC: Kevin Hilman khil...@deeprootsystems.com --- arch/arm

[PATCH v3 1/5] OMAP2430: hwmod data: Add HSMMC

2011-02-23 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc

Re: [PATCH] omap: hsmmc: fix ocr mask usage

2011-02-21 Thread Kishore Kadiyala
this patch on OMAP4430SDP OMAP4 Blaze. Tested-by: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Kishore Kadiyala kishore.kadiy...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Chris Ball c...@laptop.org --- Tony, Chris, This is only a partial fix

[PATCH v2 2/5] OMAP2430: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155 1 files changed, 155 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c b/arch/arm/mach-omap2/omap_hwmod_2430_data.c index 8ecfbcd..166391d

[PATCH v2 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-08 Thread Kishore Kadiyala
attribute. 4) Update the driver to use dev_attr to find whether controller supports dual volt cards. 5) Moving omap_mmc_add api from plat-omap/devices.c to mach-omap1/devices.c Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH v2 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL VOLT cards. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 80

[PATCH v2 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH v2 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-08 Thread Kishore Kadiyala
, the patch series has dependency on https://patchwork.kernel.org/patch/538301/ Testing on N8x0 is pending due to unavailability of working ones. Will be thankful if some body test this series on N8x0. V1: --- http://www.spinics.net/lists/linux-mmc/msg05689.html Kishore Kadiyala (2): OMAP2420

[PATCH v2 4/5] OMAP4: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Benoit Cousson b-cous...@ti.com Update the omap4 hwmod data with the HSMMC info. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339 1 files changed, 339

[PATCH 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-02 Thread Kishore Kadiyala
. Currently omap2_hsmmc_init call is missing in the board files, but updating it is not helping though. Investigation is under progress and any pointers on working version of MMC/SD on OMAP2420/2430 SDP would be helpful. Kishore Kadiyala (2): OMAP2420: hwmod data: Add HSMMC OMAP: devices: Modify

[PATCH 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL VOLT cards. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 88

[PATCH 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH 4/5] OMAP4: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Benoit Cousson b-cous...@ti.com Update the omap4 hwmod data with the HSMMC info. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339 1 files changed, 339

[PATCH 2/5] OMAP2430: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155 1 files changed, 155 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c b/arch/arm/mach-omap2/omap_hwmod_2430_data.c index 8ecfbcd..1fbc5c4

[PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-01-18 Thread Kishore Kadiyala
on OMAP4430SDP OMAP3430SDP. Kishore Kadiyala (4): omap: hsmmc: Rename use_dma to xfer_type and define possible transfers omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup omap4: hsmmc: Adding ADMA support for MMC1 MMC2 controllers omap4: hsmmc: enable ADMA for MMC1 MMC2 arch/arm/mach

[PATCH 1/4] omap: hsmmc: Rename use_dma to xfer_type and define possible transfers

2011-01-18 Thread Kishore Kadiyala
OMAP4 introduces dedicated internal DMA which is ADMA for its MMC controllers HSMMC1 HSMMC2. Renaming use_dma member of the struct omap_hsmmc_host to xfer_type and defining the transfer modes PIO/SDMA/ADMA that can be used by the MMC controller. Signed-off-by: Kishore Kadiyala kishore.kadiy

[PATCH 2/4] omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup

2011-01-18 Thread Kishore Kadiyala
Renaming omap_hsmmc_dma_cleanup as omap_hsmmc_xfer_cleanup and doing some cleanup by handling the error success scenarios during a transfer for different xfer_type. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Reviewed-by: Sukumar Ghorai s-gho...@ti.com --- drivers/mmc/host

[PATCH 3/4] omap4: hsmmc: Adding ADMA support for MMC1 MMC2 controllers

2011-01-18 Thread Kishore Kadiyala
[based on attributes]. Base address of Descriptor table in stored in MMCHS_ADMASAL register. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Sukumar Ghorai s-gho...@ti.com

[PATCH 4/4] omap4: hsmmc: enable ADMA for MMC1 MMC2

2011-01-18 Thread Kishore Kadiyala
Enable ADMA support for MMC1 MMC2 controller on omap4 by updating features of struct omap_mmc_platform_data. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com Reviewed-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/hsmmc.c | 13

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-29 Thread Kishore Kadiyala
On Fri, Oct 29, 2010 at 2:21 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Thu, Oct 28, 2010 at 6:40 PM, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: On Thu, Oct 28, 2010 at 9:43 PM, Nicolas Pitre n...@fluxnic.net wrote: This is not clear that this is something that the core can

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-28 Thread Kishore Kadiyala
Nicolas, snip    2.a) Card sleep, Power cutoff to the card:      This should be handled in the core where based on block layer      activity, calling corresponding API's from bus layer:      mmc_power_save_host/ mmc_power_restore_host Same issue here.  Card power is for the core to

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-28 Thread Kishore Kadiyala
On Thu, Oct 28, 2010 at 9:43 PM, Nicolas Pitre n...@fluxnic.net wrote: On Thu, 28 Oct 2010, Ohad Ben-Cohen wrote: On Thu, Oct 28, 2010 at 5:39 PM, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote: Wouldn't adapting the host driver just to PM-Runtime will answer the above issues? It's

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-27 Thread Kishore Kadiyala
On Wed, Oct 27, 2010 at 8:02 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: 2. Ideally host-driver driver should not tell the core to shut down    the upper layers, instead the core should decide when to    disabled clock or cut the power. How will the core know ? I actually think you are

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
Ping !! On Wed, Sep 29, 2010 at 4:11 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Gentle Reminder ! Regards, Kishore On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Samuel, Could you please review this patch which touches mfd/twl6030

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
Samuel, Sorry , I will ensure to CC you for MFD related changes in future. Regards, Kishore On Fri, Oct 1, 2010 at 4:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Oct 01, 2010 at 12:29:48PM +0530, kishore kadiyala wrote: Ping !! Applied !! BTW, please add the full patch when you

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
On Fri, Oct 1, 2010 at 8:11 PM, Varadarajan, Charulatha ch...@ti.com wrote: snip diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h index 6de90bf..e64894c 100644 --- a/include/linux/i2c/twl.h +++ b/include/linux/i2c/twl.h @@ -141,6 +141,16 @@  #define

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-10-01 Thread kishore kadiyala
will be updated and used in the driver accordingly. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com ---  arch/arm/mach-omap2/devices.c         |    8 +++-  arch/arm/mach-omap2/hsmmc.c           |    4  arch/arm/plat-omap/include/plat/mmc.h |    3 +++  drivers/mmc/host

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-29 Thread kishore kadiyala
Gentle Reminder ! Regards, Kishore On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Samuel, Could you please review this patch which touches mfd/twl6030-irq.c for card detect support of MMC1 controller on OMAP4. Regards, Kishore On Mon, Sep 27

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Tony, On Sat, Sep 25, 2010 at 6:08 AM, Tony Lindgren t...@atomide.com wrote: * kishore kadiyala kishore.kadiy...@ti.com [100924 10:05]: Adding card detect callback function and card detect configuration function for MMC1 Controller on OMAP4. Card detect configuration function does initial

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Cc: Samuel Ortiz sa...@linux.intel.com On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala kishore.kadiy...@ti.com wrote: Adding card detect callback function and card detect configuration function for MMC1 Controller on OMAP4. Card detect configuration function does initial configuration

[PATCH v4 0/4] omap4 hsmmc: Card detect and Register offset handling

2010-09-24 Thread kishore kadiyala
-archive.com/linux-o...@vger.kernel.org/msg35135.html V1: http://www.mail-archive.com/linux-o...@vger.kernel.org/msg34040.html Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit

[PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-24 Thread kishore kadiyala
to the probe thus making it generic for both OMAP3 OMAP4. Cc: Tony Lindgren t...@atomide.com Cc: Andrew Morton a...@linux-foundation.org Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach

[PATCH v4 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-24 Thread kishore kadiyala
Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |1 + drivers/mmc/host/omap_hsmmc.c | 12 2 files changed, 13 insertions(+), 0 deletions(-) diff --git

[PATCH v4 3/4] omap4 hsmmc: Register offset handling

2010-09-24 Thread kishore kadiyala
in for current implementation as well as once the driver undergoes hwmod adaptation. Cc: Tony Lindgren t...@atomide.com Cc: Andrew Morton a...@linux-foundation.org Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore

[PATCH v3 0/4] omap4 hsmmc: Card detect and Register offset handling

2010-09-22 Thread kishore kadiyala
-archive.com/linux-o...@vger.kernel.org/msg34040.html Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit Cousson (1); omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

[PATCH v3 3/4] omap4 hsmmc: Register offset handling

2010-09-22 Thread kishore kadiyala
implementation as well as once the driver undergoes hwmod adaptation. Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c |8 +++- arch/arm/mach-omap2/hsmmc.c

[PATCH v3 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-22 Thread kishore kadiyala
register, eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr mask and same will be communicated to core which will set the regulator to always operate at 3V when ever turned ON. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board

Re: [PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
Hi Hari, On Thu, Sep 23, 2010 at 1:19 AM, Kanigeri, Hari h-kanige...@ti.com wrote: Kishore, +int twl6030_mmc_card_detect(struct device *dev, int slot) +{ +     int ret = -EIO; +     u8 read_reg = 0; +     struct platform_device *pdev = to_platform_device(dev); + +     switch (pdev-id) {

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-21 Thread kishore kadiyala
Hi Benoit, On Tue, Sep 21, 2010 at 2:26 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote: The offset handling implementation of omap4 mmc registers which was already present can't be reused once hwmod modifications are done for mmc

[PATCH v2 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-18 Thread kishore kadiyala
detect call back function provides card present/absent status by reading MMC Control register. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |7 +++- drivers/mfd/twl6030-irq.c | 76 +++ drivers/mmc/host

[PATCH v2 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-18 Thread kishore kadiyala
From: Benoit Cousson b-cous...@ti.com Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |8 +++- 1 files changed, 7 insertions(+), 1

[PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-18 Thread kishore kadiyala
should be updated in the hsmmc driver. The omap-mmc platform data is updated with a register offset which will be updated and used in the driver accordingly. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c |8 +++- arch/arm/mach-omap2

[PATCH v2 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-18 Thread kishore kadiyala
, eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr mask and same will be communicated to core which will set the regulator to always operate at 3V when turned ON. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |1

Re: [PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-09-06 Thread kishore kadiyala
Hi Benoit, On Fri, Sep 3, 2010 at 1:51 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Benoit snip +               while (!(omap_readl(base + reg_off)                          MMCHS_SYSSTATUS_RESETDONE))                         cpu_relax(); Why does that series not seems

Re: [PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-09-03 Thread kishore kadiyala
Hi Benoit snip +               while (!(omap_readl(base + reg_off)                          MMCHS_SYSSTATUS_RESETDONE))                         cpu_relax(); Why does that series not seems to be based on your hwmod migration? The reset is fully handle by the hwmod framework now. Agree. But

[PATCH 1/3] omap4 hsmmc : Adding card detect support for MMC1

2010-08-30 Thread kishore kadiyala
detect call back function provides card present/absent status by reading MMC Control register. Cc: Tony Lindgren t...@atomide.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Kishore Kadiyala kishore.kadiy

[PATCH 0/3] OMAP hsmmc : card detect and Register offset handling

2010-08-30 Thread kishore kadiyala
Hi, The patch series includes : adding carddetect feature for MMC1 controller on OMAP4 and register offset handling for OMAP3 OMAP4 and followed by a fix when CONFIG_MMC_OMAP_HS not selected for OMAP4. Patch series has been tested on OMAP3430SDP and OMAP4430SDP Kishore Kadiyala (2): omap4

[PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-08-30 Thread kishore kadiyala
. Cc: Tony Lindgren t...@atomide.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c | 30 +++-- arch/arm/mach-omap2

Re: [PATCH v3 9/9] omap: zoom: add mmc3/wl1271 device support

2010-08-11 Thread kishore kadiyala
Ohad, On Wed, Aug 11, 2010 at 9:08 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros roger.quad...@nokia.com wrote: +               .ocr_mask       = MMC_VDD_165_195, Do we really need to specify ocr_mask here? Since you specified the voltage source

Re: [PATCH v6] OMAP4 HSMMC: Adding Card detect support for MMC1 on OMAP4

2010-08-05 Thread kishore kadiyala
Madhu, On Thu, Aug 5, 2010 at 4:26 AM, Madhusudhan madhu...@ti.com wrote: snip  arch/arm/mach-omap2/board-4430sdp.c |    7 +++-  drivers/mfd/twl6030-irq.c           |   76 +++  drivers/mmc/host/omap_hsmmc.c       |    4 +-  include/linux/i2c/twl.h  

Re: [PATCH v6] OMAP4 HSMMC: Adding Card detect support for MMC1 on OMAP4

2010-08-02 Thread kishore kadiyala
Andrew, Can this patch be taken now as there are no comments. Regards, Kishore On Wed, Jul 7, 2010 at 7:42 PM, kishore kadiyala kishore.kadiy...@ti.com wrote: Adding card detect callback function and card detect configuration function for MMC1 Controller. Card detect configuration function

Re: [PATCH] omap: hsmmc funtionality breaks when CONFIG_PM not define

2010-07-20 Thread kishore kadiyala
Hi Adrian, Is there any use case or a valid scenario whether to use omap_hsmmc_ps_ops or omap_hsmmc_ops ? I meant using power_saving option and without power_saving option Ideally I feel having omap_hsmmc_ps_ops as default with or without CONFIG_PM would be better as it internally has a state

Re: [PATCH v5] OMAP: Fix for bus width which improves SD card's peformance.

2010-07-07 Thread kishore kadiyala
Tony, Could this patch be taken ? Thanks, kishore On Tue, Jun 15, 2010 at 1:37 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: From: Kishore Kadiyala kishore.kadiy...@ti.com This patch improves low speeds for SD cards. OMAP-MMC controller's can support maximum bus width of '8

Re: [PATCH v5] OMAP: Fix for bus width which improves SD card's peformance.

2010-06-30 Thread kishore kadiyala
Hi Andrew, If no further comments on this patch, can this be taken? Regards, Kishore On Tue, Jun 15, 2010 at 1:37 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: From: Kishore Kadiyala kishore.kadiy...@ti.com This patch improves low speeds for SD cards. OMAP-MMC controller's can

Re: [PATCH v5 2/2] OMAP4 HSMMC: Adding card detect support for MMC1 Controller

2010-06-29 Thread kishore kadiyala
On Tue, Jun 29, 2010 at 1:00 PM, Adrian Hunter adrian.hun...@nokia.com wrote: ext kishore kadiyala wrote: Adrian , Sorry for the late response snip As per my email 5/5/10, I would suggest the only change to omap_hsmmc is: Agreed  and followed the changes mostly but made some more

Re: [PATCH v5 2/2] OMAP4 HSMMC: Adding card detect support for MMC1 Controller

2010-06-29 Thread kishore kadiyala
On Tue, Jun 29, 2010 at 1:48 PM, Adrian Hunter adrian.hun...@nokia.com wrote: kishore kadiyala wrote: On Tue, Jun 29, 2010 at 1:00 PM, Adrian Hunter adrian.hun...@nokia.com wrote: ext kishore kadiyala wrote: Adrian , Sorry for the late response snip As per my email 5/5/10, I would

  1   2   >