Hi Shashidhar Hiremath,
snip
mmc0:host doesn't support card's voltages
set_ios invoked
Poweroff Done
mmc0: error -22 whilst initializing SDIO card
Could you check whether the MMC host controller regulator is
configured properly.
eventhough I have inserted a SD card
Which SD card you
-by: Felipe Balbi ba...@ti.com
Tested-by: Grazvydas Ignotas nota...@gmail.com
Signed-off-by: NeilBrown ne...@suse.de
I have done some thing similar but didn't pushed it :-(
Anyways
Acked-by: Kishore Kadiyala kishorek.kadiy...@gmail.com
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc
On Wed, Dec 28, 2011 at 5:46 AM, Shashidhar hiremath
shashidh...@vayavyalabs.com wrote:
From: Shashidhar Hiremath shashidh...@vayavyalabs.com
The Patch adds a check to disable the IOCTL from running when the card is
mounted
or device is opened elsewhere.
Signed-off-by: Shashidhar Hiremath
On Fri, Sep 2, 2011 at 12:35 AM, Venkatraman S svenk...@ti.com wrote:
Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in
omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a
single location in post_req function, to prevent double unmapping.
Signed-off-by: Venkatraman S
on SDMMC1_VDDS whereas USBC1 is based on SIM_VDDS therefore
they can operate independently.
Signed-off-by: Bryan Buckley bryan.buck...@ti.com
Good catch,
Acked-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/hsmmc.c | 12
1 files changed, 4 insertions(+), 8
snip
How does BKOPS work with card power management ? On some controllers,
regulators are switched off in between transactions after some delay.
Wouldn't the card need power to do it's BKOPS ?
AFAIK eMMC card has two voltages one for core rail and other for IO rail.
Power Management is done
Hi Per,
snip
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -108,6 +108,7 @@ static DEFINE_MUTEX(open_lock);
enum mmc_blk_status {
MMC_BLK_SUCCESS = 0,
+ MMC_BLK_PARTIAL,
MMC_BLK_RETRY,
MMC_BLK_DATA_ERR,
MMC_BLK_CMD_ERR,
snip
Hi Per,
On Tue, Jun 21, 2011 at 12:21 PM, Per Forlin per.for...@linaro.org wrote:
On 21 June 2011 07:41, Kishore Kadiyala kishorek.kadiy...@gmail.com wrote:
snip
+
+static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request
*mrq,
+ bool
On Mon, Jun 20, 2011 at 2:47 AM, Per Forlin per.for...@linaro.org wrote:
Change mmc_blk_issue_rw_rq() to become asynchronous.
The execution flow looks like this:
The mmc-queue calls issue_rw_rq(), which sends the request
to the host and returns back to the mmc-queue. The mmc-queue calls
snip
+
+static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request *mrq,
+ bool is_first_req)
I don't see the usage of is_first_req below.
Is it required?
+{
+ struct omap_hsmmc_host *host = mmc_priv(mmc);
+
+ if
On Wed, Apr 6, 2011 at 2:58 AM, Stephen Warren swar...@nvidia.com wrote:
Kishore Kadiyala wrote at Tuesday, April 05, 2011 12:38 AM:
Hi Stephen,
On Mon, Apr 4, 2011 at 11:09 PM, Stephen Warren swar...@nvidia.com wrote:
Chris et. al.,
I'm working on an ARM system that contains at least
Hi Stephen,
On Mon, Apr 4, 2011 at 11:09 PM, Stephen Warren swar...@nvidia.com wrote:
Chris et. al.,
I'm working on an ARM system that contains at least two MMC/SD devices;
specifically the board has an internal MMC device, and an SD card slot,
although the SoC has four MMC/SD hosts IIRC.
Feel free to add
Acked-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
drivers/mmc/host/omap_hsmmc.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff -puN
drivers/mmc/host/omap_hsmmc.c~drivers-mmc-host-omap_hsmmcc-use-resource_size
drivers/mmc/host/omap_hsmmc.c
-foundation.org
Acked-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
drivers/mmc/host/omap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/mmc/host/omap.c~drivers-mmc-host-omapc-use-resource_size
drivers/mmc/host/omap.c
--- a/drivers/mmc/host/omap.c
Modifying the device driver name from mmci-omap-hs to
omap_hsmmc.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/board-2430sdp.c |2 +-
arch/arm/mach-omap2/board-3430sdp.c |6 +++---
arch/arm
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |6 ++
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |8
arch/arm/plat-omap/include
.
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Chris Ball c...@laptop.org
---
arch/arm/mach-omap2/board-n8x0.c |2 +-
arch/arm/mach-omap2/devices.c
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit
Kishore Kadiyala (4):
OMAP: hwmod data: Add dev_attr and use in the host driver
OMAP: hsmmc: Move mux configuration to hsmmc.c
OMAP: adapt hsmmc to hwmod framework
OMAP: hsmmc: Rename the device and driver
Paul Walmsley (2):
OMAP2430: hwmod data: Add HSMMC
OMAP3: hwmod data: Add HSMMC
controller
supports dual volt cards
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Reviewed-by: Balaji T K balaj...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
CC: Kevin Hilman khil...@deeprootsystems.com
Cc: Tony Lindgren t...@atomide.com
---
arch/arm
Moving the definition of mux setting API from devices.c to hsmmc.c
and renaming it from omap2_mmc_mux to omap_hsmmc_mux.
Also calling omap_hsmmc_mux from omap2_hsmmc_init.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Chris Ball c...@laptop.org
Cc: Tony Lindgren t...@atomide.com
From: Anand Gadiyar gadi...@ti.com
Enabling hsmmc hwmod for OMAP4
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +-
1 files changed, 5
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |6 ++
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |8
arch/arm/plat-omap/include
https://patchwork.kernel.org/patch/538301/
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
---
arch/arm/mach
(2):
omap: mmc: split out init for 2420
OMAP4: hwmod data: enable HSMMC
Kishore Kadiyala (4):
OMAP: hwmod data: Add dev_attr and use in the host driver
OMAP: hsmmc: Move mux configuration to hsmmc.c
OMAP: adapt hsmmc to hwmod framework
OMAP: hsmmc: Rename the device and driver
Paul
.
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Chris Ball c...@laptop.org
---
arch/arm/mach-omap2/board-n8x0.c |2 +-
arch/arm/mach-omap2/devices.c
Modifying the device driver name from mmci-omap-hs to
omap_hsmmc.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/board-2430sdp.c |2 +-
arch/arm/mach-omap2/board-3430sdp.c |6 +++---
arch/arm
From: Anand Gadiyar gadi...@ti.com
Enabling hsmmc hwmod for OMAP4
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +-
1 files changed, 5
Moving the definition of mux setting API from devices.c to hsmmc.c
and renaming it from omap2_mmc_mux to omap_hsmmc_mux.
Also calling omap_hsmmc_mux from omap2_hsmmc_init.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Chris Ball c...@laptop.org
Cc: Tony Lindgren t...@atomide.com
...@pwsan.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
CC: Kevin Hilman khil...@deeprootsystems.com
---
arch/arm/mach-omap2/devices.c | 168
arch/arm/mach-omap2/hsmmc.c | 343 ++--
arch
From: Paul Walmsley p...@pwsan.com
Update the omap2430 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit
From: Anand Gadiyar gadi...@ti.com
Enabling hsmmc hwmod for OMAP4
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +-
1 files changed, 5
Kishore Kadiyala (2):
OMAP: hwmod data: Add dev_attr and use in the host driver
OMAP: adapt hsmmc to hwmod framework
OMAP: hsmmc: Rename the device and driver
Paul Walmsley (2):
OMAP2430: hwmod data: Add HSMMC
OMAP3: hwmod data: Add HSMMC
arch/arm/mach-omap2/board-2430sdp.c
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 ++
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |6 ++
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 ++
arch
From: Paul Walmsley p...@pwsan.com
Update the omap2430 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit
Modifying the device driver name from mmci-omap-hs to
omap_hsmmc.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
Cc: Chris Ball c...@laptop.org
Cc: Tony Lindgren t
.
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Chris Ball c...@laptop.org
---
arch/arm/mach-omap2/board-n8x0.c |2 +-
arch/arm/mach-omap2/devices.c
.
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Chris Ball c...@laptop.org
---
arch/arm/mach-omap2/board-n8x0.c |2 +-
arch/arm/mach-omap2/devices.c
/lists/linux-omap/msg45443.html
V1:
---
http://www.spinics.net/lists/linux-mmc/msg05689.html
Anand Gadiyar (1):
OMAP4: hwmod data: enable HSMMC
Kishore Kadiyala (2):
OMAP: hwmod data: Add dev_attr and use in the host driver
OMAP: adapt hsmmc to hwmod framework
Paul Walmsley (2):
OMAP2430
number, Irq_number,
device attribute.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
CC: Kevin Hilman khil...@deeprootsystems.com
---
arch/arm/mach-omap2/devices.c | 251
-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c |9 +
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 12
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 16
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit
From: Anand Gadiyar gadi...@ti.com
Enabling hsmmc hwmod for OMAP4
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
CC: Kevin Hilman khil...@deeprootsystems.com
---
arch/arm
From: Paul Walmsley p...@pwsan.com
Update the omap2430 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc
this patch on OMAP4430SDP OMAP4 Blaze.
Tested-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Chris Ball c...@laptop.org
---
Tony, Chris,
This is only a partial fix
-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155
1 files changed, 155 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
index 8ecfbcd..166391d
attribute.
4) Update the driver to use dev_attr to find whether controller
supports dual volt cards.
5) Moving omap_mmc_add api from plat-omap/devices.c to mach-omap1/devices.c
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch
Update the omap2420 hwmod data with the HSMMC info.
Add a device attribute structure which will be used
by the host driver to find whether the HSMMC controller
supports DUAL VOLT cards.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2420_data.c | 80
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch
, the patch series has dependency on
https://patchwork.kernel.org/patch/538301/
Testing on N8x0 is pending due to unavailability of working ones.
Will be thankful if some body test this series on N8x0.
V1:
---
http://www.spinics.net/lists/linux-mmc/msg05689.html
Kishore Kadiyala (2):
OMAP2420
From: Benoit Cousson b-cous...@ti.com
Update the omap4 hwmod data with the HSMMC info.
Signed-off-by: Benoit Cousson b-cous...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339
1 files changed, 339
. Currently omap2_hsmmc_init call is missing in the board files, but
updating it is not helping though.
Investigation is under progress and any pointers on working version of MMC/SD on
OMAP2420/2430 SDP would be helpful.
Kishore Kadiyala (2):
OMAP2420: hwmod data: Add HSMMC
OMAP: devices: Modify
Update the omap2420 hwmod data with the HSMMC info.
Add a device attribute structure which will be used
by the host driver to find whether the HSMMC controller
supports DUAL VOLT cards.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2420_data.c | 88
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch
From: Benoit Cousson b-cous...@ti.com
Update the omap4 hwmod data with the HSMMC info.
Signed-off-by: Benoit Cousson b-cous...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339
1 files changed, 339
-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155
1 files changed, 155 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
index 8ecfbcd..1fbc5c4
on OMAP4430SDP OMAP3430SDP.
Kishore Kadiyala (4):
omap: hsmmc: Rename use_dma to xfer_type and define possible
transfers
omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup
omap4: hsmmc: Adding ADMA support for MMC1 MMC2 controllers
omap4: hsmmc: enable ADMA for MMC1 MMC2
arch/arm/mach
OMAP4 introduces dedicated internal DMA which is ADMA for its MMC
controllers HSMMC1 HSMMC2.
Renaming use_dma member of the struct omap_hsmmc_host to xfer_type
and defining the transfer modes PIO/SDMA/ADMA that can be used by the
MMC controller.
Signed-off-by: Kishore Kadiyala kishore.kadiy
Renaming omap_hsmmc_dma_cleanup as omap_hsmmc_xfer_cleanup and doing some
cleanup by handling the error success scenarios during a transfer for
different xfer_type.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Reviewed-by: Sukumar Ghorai s-gho...@ti.com
---
drivers/mmc/host
[based on attributes].
Base address of Descriptor table in stored in MMCHS_ADMASAL register.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Signed-off-by: Venkatraman S svenk...@ti.com
Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
Reviewed-by: Sukumar Ghorai s-gho...@ti.com
Enable ADMA support for MMC1 MMC2 controller on omap4 by updating
features of struct omap_mmc_platform_data.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Signed-off-by: Venkatraman S svenk...@ti.com
Reviewed-by: Sukumar Ghorai s-gho...@ti.com
---
arch/arm/mach-omap2/hsmmc.c | 13
On Fri, Oct 29, 2010 at 2:21 AM, Ohad Ben-Cohen o...@wizery.com wrote:
On Thu, Oct 28, 2010 at 6:40 PM, Kishore Kadiyala
kishorek.kadiy...@gmail.com wrote:
On Thu, Oct 28, 2010 at 9:43 PM, Nicolas Pitre n...@fluxnic.net wrote:
This is not clear that this is something that the core can
Nicolas,
snip
2.a) Card sleep, Power cutoff to the card:
This should be handled in the core where based on block layer
activity, calling corresponding API's from bus layer:
mmc_power_save_host/ mmc_power_restore_host
Same issue here. Card power is for the core to
On Thu, Oct 28, 2010 at 9:43 PM, Nicolas Pitre n...@fluxnic.net wrote:
On Thu, 28 Oct 2010, Ohad Ben-Cohen wrote:
On Thu, Oct 28, 2010 at 5:39 PM, Kishore Kadiyala
kishorek.kadiy...@gmail.com wrote:
Wouldn't adapting the host driver just to PM-Runtime will answer the
above issues?
It's
On Wed, Oct 27, 2010 at 8:02 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote:
2. Ideally host-driver driver should not tell the core to shut down
the upper layers, instead the core should decide when to
disabled clock or cut the power.
How will the core know ?
I actually think you are
Ping !!
On Wed, Sep 29, 2010 at 4:11 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
Gentle Reminder !
Regards,
Kishore
On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
Hi Samuel,
Could you please review this patch which touches mfd/twl6030
Samuel,
Sorry , I will ensure to CC you for MFD related changes in future.
Regards,
Kishore
On Fri, Oct 1, 2010 at 4:59 PM, Samuel Ortiz sa...@linux.intel.com wrote:
On Fri, Oct 01, 2010 at 12:29:48PM +0530, kishore kadiyala wrote:
Ping !!
Applied !!
BTW, please add the full patch when you
On Fri, Oct 1, 2010 at 8:11 PM, Varadarajan, Charulatha ch...@ti.com wrote:
snip
diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
index 6de90bf..e64894c 100644
--- a/include/linux/i2c/twl.h
+++ b/include/linux/i2c/twl.h
@@ -141,6 +141,16 @@
#define
will be updated and used in the driver accordingly.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/devices.c | 8 +++-
arch/arm/mach-omap2/hsmmc.c | 4
arch/arm/plat-omap/include/plat/mmc.h | 3 +++
drivers/mmc/host
Gentle Reminder !
Regards,
Kishore
On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
Hi Samuel,
Could you please review this patch which touches mfd/twl6030-irq.c for
card detect support
of MMC1 controller on OMAP4.
Regards,
Kishore
On Mon, Sep 27
Hi Tony,
On Sat, Sep 25, 2010 at 6:08 AM, Tony Lindgren t...@atomide.com wrote:
* kishore kadiyala kishore.kadiy...@ti.com [100924 10:05]:
Adding card detect callback function and card detect configuration
function for MMC1 Controller on OMAP4.
Card detect configuration function does initial
Cc: Samuel Ortiz sa...@linux.intel.com
On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala
kishore.kadiy...@ti.com wrote:
Adding card detect callback function and card detect configuration
function for MMC1 Controller on OMAP4.
Card detect configuration function does initial configuration
-archive.com/linux-o...@vger.kernel.org/msg35135.html
V1:
http://www.mail-archive.com/linux-o...@vger.kernel.org/msg34040.html
Kishore Kadiyala (3):
omap4 hsmmc : Adding card detect support for MMC1
omap4 hsmmc: Register offset handling
omap4 hsmmc: Update ocr mask for MMC2 for regulator to use
Benoit
to the probe thus making it generic for both OMAP3 OMAP4.
Cc: Tony Lindgren t...@atomide.com
Cc: Andrew Morton a...@linux-foundation.org
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Adrian Hunter adrian.hun...@nokia.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach
Chikkature madhu...@ti.com
Cc: Adrian Hunter adrian.hun...@nokia.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/board-4430sdp.c |1 +
drivers/mmc/host/omap_hsmmc.c | 12
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git
in for current
implementation as well as once the driver undergoes hwmod adaptation.
Cc: Tony Lindgren t...@atomide.com
Cc: Andrew Morton a...@linux-foundation.org
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Adrian Hunter adrian.hun...@nokia.com
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Kishore
-archive.com/linux-o...@vger.kernel.org/msg34040.html
Kishore Kadiyala (3):
omap4 hsmmc : Adding card detect support for MMC1
omap4 hsmmc: Register offset handling
omap4 hsmmc: Update ocr mask for MMC2 for regulator to use
Benoit Cousson (1);
omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set
implementation as well as once the driver undergoes hwmod adaptation.
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Benoit Cousson b-cous...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/devices.c |8 +++-
arch/arm/mach-omap2/hsmmc.c
register,
eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr
mask and same will be communicated to core which will set the regulator to
always operate at 3V when ever turned ON.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/board
Hi Hari,
On Thu, Sep 23, 2010 at 1:19 AM, Kanigeri, Hari h-kanige...@ti.com wrote:
Kishore,
+int twl6030_mmc_card_detect(struct device *dev, int slot)
+{
+ int ret = -EIO;
+ u8 read_reg = 0;
+ struct platform_device *pdev = to_platform_device(dev);
+
+ switch (pdev-id) {
Hi Benoit,
On Tue, Sep 21, 2010 at 2:26 AM, Cousson, Benoit b-cous...@ti.com wrote:
Hi Kishore
On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote:
The offset handling implementation of omap4 mmc registers which
was already present can't be reused once hwmod modifications are done
for mmc
detect call back function provides card present/absent
status by reading MMC Control register.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/board-4430sdp.c |7 +++-
drivers/mfd/twl6030-irq.c | 76 +++
drivers/mmc/host
From: Benoit Cousson b-cous...@ti.com
Avoid possible crash if CONFIG_MMC_OMAP_HS is not set
Signed-off-by: Benoit Cousson b-cous...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/board-4430sdp.c |8 +++-
1 files changed, 7 insertions(+), 1
should be updated in the hsmmc driver.
The omap-mmc platform data is updated with a register offset which
will be updated and used in the driver accordingly.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/devices.c |8 +++-
arch/arm/mach-omap2
,
eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr
mask and same will be communicated to core which will set the regulator to
always operate at 3V when turned ON.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/board-4430sdp.c |1
Hi Benoit,
On Fri, Sep 3, 2010 at 1:51 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
Hi Benoit
snip
+ while (!(omap_readl(base + reg_off)
MMCHS_SYSSTATUS_RESETDONE))
cpu_relax();
Why does that series not seems
Hi Benoit
snip
+ while (!(omap_readl(base + reg_off)
MMCHS_SYSSTATUS_RESETDONE))
cpu_relax();
Why does that series not seems to be based on your hwmod migration? The
reset is fully handle by the hwmod framework now.
Agree. But
detect call back function provides card present/absent
status by reading MMC Control register.
Cc: Tony Lindgren t...@atomide.com
Cc: Adrian Hunter adrian.hun...@nokia.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Kishore Kadiyala kishore.kadiy
Hi,
The patch series includes :
adding carddetect feature for MMC1 controller on OMAP4 and register offset
handling
for OMAP3 OMAP4 and followed by a fix when CONFIG_MMC_OMAP_HS not selected
for OMAP4.
Patch series has been tested on OMAP3430SDP and OMAP4430SDP
Kishore Kadiyala (2):
omap4
.
Cc: Tony Lindgren t...@atomide.com
Cc: Adrian Hunter adrian.hun...@nokia.com
Cc: Madhusudhan Chikkature madhu...@ti.com
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
---
arch/arm/mach-omap2/devices.c | 30 +++--
arch/arm/mach-omap2
Ohad,
On Wed, Aug 11, 2010 at 9:08 PM, Ohad Ben-Cohen o...@wizery.com wrote:
On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros roger.quad...@nokia.com
wrote:
+ .ocr_mask = MMC_VDD_165_195,
Do we really need to specify ocr_mask here?
Since you specified the voltage source
Madhu,
On Thu, Aug 5, 2010 at 4:26 AM, Madhusudhan madhu...@ti.com wrote:
snip
arch/arm/mach-omap2/board-4430sdp.c | 7 +++-
drivers/mfd/twl6030-irq.c | 76
+++
drivers/mmc/host/omap_hsmmc.c | 4 +-
include/linux/i2c/twl.h
Andrew,
Can this patch be taken now as there are no comments.
Regards,
Kishore
On Wed, Jul 7, 2010 at 7:42 PM, kishore kadiyala
kishore.kadiy...@ti.com wrote:
Adding card detect callback function and card detect configuration
function for MMC1 Controller.
Card detect configuration function
Hi Adrian,
Is there any use case or a valid scenario whether to use
omap_hsmmc_ps_ops or omap_hsmmc_ops ?
I meant using power_saving option and without power_saving option
Ideally I feel having omap_hsmmc_ps_ops as default with or without
CONFIG_PM would be better as it internally has a state
Tony,
Could this patch be taken ?
Thanks,
kishore
On Tue, Jun 15, 2010 at 1:37 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
From: Kishore Kadiyala kishore.kadiy...@ti.com
This patch improves low speeds for SD cards.
OMAP-MMC controller's can support maximum bus width of '8
Hi Andrew,
If no further comments on this patch, can this be taken?
Regards,
Kishore
On Tue, Jun 15, 2010 at 1:37 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
From: Kishore Kadiyala kishore.kadiy...@ti.com
This patch improves low speeds for SD cards.
OMAP-MMC controller's can
On Tue, Jun 29, 2010 at 1:00 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
ext kishore kadiyala wrote:
Adrian ,
Sorry for the late response
snip
As per my email 5/5/10, I would suggest the only change to omap_hsmmc is:
Agreed and followed the changes mostly but made some more
On Tue, Jun 29, 2010 at 1:48 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
kishore kadiyala wrote:
On Tue, Jun 29, 2010 at 1:00 PM, Adrian Hunter adrian.hun...@nokia.com
wrote:
ext kishore kadiyala wrote:
Adrian ,
Sorry for the late response
snip
As per my email 5/5/10, I would
1 - 100 of 143 matches
Mail list logo