The Nomadik variant supports 8bit mode for (e)MMC cards.
Signed-off-by: Linus Walleij
---
drivers/mmc/host/mmci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index acece3299756..0d6ca4116f3d 100644
--- a/drivers/mmc/host/mmci.c
+++ b
f "ARM: 7378/1: mmci: add support for the Nomadik MMCI
variant"
Signed-off-by: Linus Walleij
---
drivers/mmc/host/mmci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index fb266745f824..acece3299756 100644
--- a/dr
On Wed, Nov 25, 2015 at 4:02 PM, Andrew Lunn wrote:
> On Wed, Nov 25, 2015 at 02:57:57PM +0100, Linus Walleij wrote:
>> There are no in-kernel users of the MVSDIO platform data method
>> (instantiating from a board file) so just delete this code and
>> make this a DT-only dr
: Linus Walleij
---
drivers/mmc/host/Kconfig | 1 +
drivers/mmc/host/mvsdio.c | 63 +++
2 files changed, 15 insertions(+), 49 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 1dee533634c9..1526b8a10b09 100644
--- a
This platform data struct is only used inside the MVSDIO driver,
nowhere else in the entire kernel. Move the struct into the
driver and delete the external header.
Cc: Nicolas Pitre
Cc: Andrew Lunn
Cc: Sebastian Hesselbarth
Signed-off-by: Linus Walleij
---
drivers/mmc/host/mvsdio.c
t.
>
> Probably, question for pinctrl maintainer. Looping Linus Walleji.
We have another pinctrl driver exposing the occasional fixed regulator
for exactly this purpose, see:
sh-pfc/pfc-sh73a0.c
So use the same mechanism for this driver.
Yours,
Linus Walleij
--
To unsubscribe from this list: send
crease maintenance efforts, this
> patch removes all code related to MMC_CLKGATE.
>
> Signed-off-by: Ulf Hansson
Runtime PM is the generic solution to the specific problem, good feat.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "uns
at we get if there is
no state is basically a dummy pinctrl that does nothing.
Do you wanna make a patch for this?
(Looping in Stephen Warren so he can tell if I miss something
obviously evident in the design that require stubs to
be present.)
Yours,
Linus Walleij
--
To unsubscribe from this l
be used from a pin control
point of view.
If you depended on CONFIG_PM you could use
pinctrl_pm_select_default_state() but for this simple scenario
this is fine.
Reviewed-by: Linus Walleij
>From a pinctrl point of view.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
a flag for pins that have configurable I/O voltage and SoC
> operations to get and set the nominal voltage. Implement the pinconf
> power-source parameter using these operations.
>
> Signed-off-by: Ben Hutchings
Patch applied with Laurent's ACK.
Yours,
Linus Walleij
--
To unsu
Makes things a little less confusing in this confusing boundary between
electronics and code...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
oblem,
i.e. do you run into it? Does the system lock up?
> If the reboot notifier gets invoked after the shutdown handler then we could
> be sure that restoring the initial line state of the pcf lines wouldn't
> affect the devices connected to it.
OK so does it?
ftrace is your friend.
On Mon, Mar 16, 2015 at 9:46 AM, Kishon Vijay Abraham I wrote:
> On Wednesday 14 January 2015 05:28 PM, Linus Walleij wrote:
>> #include
>>
>> static int foo_reboot_handler(struct notifier_block *this,
>>
ng it later.
This is now in my git and -next, I can take patches to pwrseq if Ulf
ACKs them to go through my GPIO tree.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo
rs/gpio/gpio-mxc.c.
>
> Signed-off-by: Yingjoe Chen
> Signed-off-by: Chaotian Jing
Patch applied on top of the rest of the mtk pinctrl support.
Adding Hongzhou's ACK on top.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body
rs/gpio/gpio-mxc.c.
>
> Signed-off-by: Yingjoe Chen
> Signed-off-by: Chaotian Jing
Hongzhu, if you're fine with this patch can you ACK it as maintainer
of the pinctrl driver so I can merge it immediately on top of your
drivern whenever we consider it finished (and if it applies still
isk depending on pin configuration.
>>>
>>> Assume we are doing a reset when the system is powered on, irrespective of
>>> the
>>> state of the system, we'll be forcing the pin level to the default state.
>>
>> Yes, I dont deny that system will be fine
e know if this also fixes it for you, and I'll send in a proper
> patch.
Argh how could I make this stupid mistake :(
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
r Martinez Canillas
Signed-off-by: Linus Walleij
---
ChangeLog v3->v4:
- Fix breakage in sdhci-acpi.c due to changed function
prototype.
ChangeLog v2->v3:
- Make it possible to pass NULL as pointer for the gpio_invert
variable, so we don't need dummy variables in callers
ChangeLog
r Martinez Canillas
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- Make it possible to pass NULL as pointer for the gpio_invert
variable, so we don't need dummy variables in callers
ChangeLog v1->v2:
- Always set override_active_level when getting CD GPIO
- Invert
On Tue, Sep 30, 2014 at 5:07 PM, Javier Martinez Canillas
wrote:
> On Tue, Sep 30, 2014 at 4:05 PM, Linus Walleij
> wrote:
>> @@ -316,6 +317,8 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const
>> char *con_id,
>>
r Martinez Canillas
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Always set override_active_level when getting CD GPIO
- Invert the return value from gpiod_is_active_low() to
follow the old semantics
---
drivers/mmc/core/host.c | 32
drivers/mmc/cor
the hopes that no-one was using double
inversion.
It turns out that the XOR:ing between the explicit
inversion was indeed in use, so we need to restore the
old semantics where both ways of inversion are checked
and the end result XOR:ed.
Reported-by: Javier Martinez Canillas
Signed-off-by: Lin
On Tue, Sep 30, 2014 at 1:30 PM, Javier Martinez Canillas
wrote:
> On Wed, Aug 27, 2014 at 1:00 PM, Linus Walleij
> wrote:
>> This switches the central MMC OF parser to use gpio descriptors
>> instead of grabbing GPIOs explicitly from the device tree.
>> This strips
On Wed, Sep 24, 2014 at 8:21 PM, Behan Webster
wrote:
> On 09/24/14 02:22, Arnd Bergmann wrote:
>> but the first one seems
>> easier to read for someone familiar with kernel code.
>
> No worries. Happy to post a v3.
>
> Linus Walleij: Would you like me to respin the
in the right spot.
>
> Signed-off-by: Behan Webster
> Reviewed-by: Mark Charlebois
> Acked-by: Arnd Bergmann
> Acked-by: Matt Porter
Patch applied.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to ma
gt; GPIO direction flags are not getting set because
> an 'if' statement is the wrong way around.
>
> Signed-off-by: Adrian Hunter
Oopps that's a bug, patch applied for fixes, so it'll work when
this hits upstream.
Alex: confirm?
Yours,
Linus Walleij
--
To unsubscribe from
On Wed, Aug 27, 2014 at 1:00 PM, Linus Walleij wrote:
> This switches the central MMC OF parser to use gpio descriptors
> instead of grabbing GPIOs explicitly from the device tree.
> This strips out an unecessary use of the integer-based GPIO
> API that we want to get rid of, cuts
t; I will drop the GPIO desc patches again from my mmc tree. We need
> another round to sort out the decencies to GPIOLIB.
Yeah this is due to the way the vararg hacks for the new flags-enabled
descriptor API is done only when GPIOLIB is compiled in.
Oh well, I'll funnel another fix.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
forms to be converted to
GPIO descritor tables.
Cc: Alexandre Courbot
Cc: Russell King
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Skip excess error/info/debug report prints.
---
drivers/mmc/host/mmci.c | 39 +--
1 file changed, 29 insertion
-by: Alexandre Courbot
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Restore error reporting as done in previous stand-alone
patch.
---
drivers/mmc/core/host.c | 68 +
1 file changed, 23 insertions(+), 45 deletions(-)
diff --git a/driv
forms to be converted to
GPIO descritor tables.
Cc: Alexandre Courbot
Cc: Russell King
Signed-off-by: Linus Walleij
---
drivers/mmc/host/mmci.c | 53 +++--
1 file changed, 43 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/mmci.c b/driver
future we will make the flags argument compulsory.
Reviewed-by: Alexandre Courbot
Signed-off-by: Linus Walleij
---
drivers/mmc/core/slot-gpio.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
index 5f89cb83d5f0
This makes it possible to get the write protect (read only)
GPIO line from a GPIO descriptor. Written to exactly mirror
the card detect function.
Acked-by: Alexandre Courbot
Signed-off-by: Linus Walleij
---
drivers/mmc/core/slot-gpio.c | 48 +++
include
hacked if need be. He was more worried about core kernel code
growing wild.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 19, 2014 at 2:19 AM, Ulf Hansson wrote:
> On 18 August 2014 19:13, Linus Walleij wrote:
>> Or maybe even do the second approach of putting stubs in slot-gpio.h
>> for !GPIOLIB...
>
> Hmm, that doesn't sound the proper solution either.
>
> Currently
specified (i.e. -ENOENT is returned) and if there
is some other error, report it with dev_err().
Reported-by: Simon Baatz
Cc: Simon Baatz
Signed-off-by: Linus Walleij
---
drivers/mmc/core/host.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc
On Mon, Aug 18, 2014 at 2:46 PM, Simon Baatz wrote:
> On Tue, Aug 12, 2014 at 07:25:54PM +0200, Linus Walleij wrote:
>> This switches the central MMC OF parser to use gpio descriptors
>> instead of grabbing GPIOs explicitly from the device tree.
>> This strips out an unecessa
On Thu, Aug 14, 2014 at 9:56 AM, Alexandre Courbot wrote:
> On Tue, Aug 12, 2014 at 10:25 AM, Linus Walleij
> wrote:
>> - /* If DT, cd/wp gpios must be supplied through it. */
>> - if (!np && gpio_is_valid(plat->gpio_cd)) {
>> -
l.
Grrr should I use "depends on GPIOLIB" for MMC instead?
Or maybe even do the second approach of putting stubs in slot-gpio.h
for !GPIOLIB...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
enable GPIOLIB,
so make CONFIG_MMC select CONFIG_GPIOLIB.
Signed-off-by: Linus Walleij
---
drivers/mmc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
index f2eeb38efa65..bf44002793c4 100644
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
FIG_GPIOLIB is not set and not compile slot-gpio.c if GPIOLIB
is not selected.
Which one would the MMC maintainers prefer?
I don't think we have a system using some legacy GPIO API without
GPIOLIB so we should enforce this somehow.
Yours,
Linus Walleij
--
To unsubscribe from this list:
on-2^n support the exception rather
than the rule and applies only to the variants relevant so the logic is right.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
&&
And this becomes just
if (variant->st_sdio)...
> (host->size < 8 ||
> (host->size <= 8 && host->mclk > 5000)))
> clk = host->clk_reg & ~variant->clkreg_e
s like Qualcomm which maps this
> bits to something else, so making this enable bit to come from variant
> data solves the issue.
>
> Originally the issue is detected while testing WLAN ath6kl on Qualcomm
> APQ8064.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus
is in no way a bug not to supply CD/WP GPIOs the messages
about them not being specified have been depromoted from
dev_err() to dev_dbg().
Cc: Alexandre Courbot
Signed-off-by: Linus Walleij
---
drivers/mmc/core/host.c | 68 +++--
1 file changed, 21
This makes it possible to get the write protect (read only)
GPIO line from a GPIO descriptor. Written to exactly mirror
the card detect function.
Cc: Alexandre Courbot
Signed-off-by: Linus Walleij
---
drivers/mmc/core/slot-gpio.c | 48 +++
include/linux
forms to be converted to
GPIO descritor tables.
Cc: Alexandre Courbot
Cc: Russell King
Signed-off-by: Linus Walleij
---
drivers/mmc/host/mmci.c | 53 +++--
1 file changed, 43 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/mmci.c b/driver
future we will make the flags argument compulsory.
Cc: Alexandre Courbot
Signed-off-by: Linus Walleij
---
drivers/mmc/core/slot-gpio.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
index 5f89cb83d5f0
nce RFC:
> - Moved qcom_dml.* to mmci_qcom_dml.* as suggested by Linus W.
> - added BAM DMA dependency in Kconfig as suggested by Linus W
I really like this v2 version.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsub
Why is that necessary? The interrupt
callback still isn't registered, so this isn't used for anything?
If it's still needed it would be a bug in the DMA engine I think.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jun 21, 2014 at 9:22 AM, Alexandre Courbot wrote:
>> I have added Linus Walleij and Alexandre Courbot, the maintainers of
>> gpio. Let's see if they can point us in a direction.
>
> I agree it would be nice if the debounce value could be handled by the
> GP
main SD
> controller driver for Qualcomm SOCs.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo in
gs. Based on qcom_fifo flag in
> variant data structure, the corresponding get_rx_fifocnt function is selected.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
r, and also
> adds explicit_mclk_control flag in variant structure giving more flexibility
> to the driver.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a m
ing it to
> mmc-core.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
usec delay to use mmci_reg_delay function which can provide
> correct delay depending on the cclk frequency.
>
> Without this patch the card is not detected.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: s
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tch in the series.
Anyway, this needs to be rebased and reposted anyway, I
just merged some base patches from Maxime for external
interrupts that will go in after the merge window, I need some
help to figure out what and how to merge here.
Yours,
Linus Walleij
--
To unsubscribe from this list: send t
ment with real BE hardware with this
PrimeCell to determine whether to do this, and until that is
done just don't try to outsmart the hardware by thinking ahead
and designing for the unknown, that will just fail.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "u
uld have helped but its not advised to be
> use as per the datasheet.
You are right. readsl() or ioread32_rep() isn't used for this reason.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 27, 2014 at 4:21 PM, Chen-Yu Tsai wrote:
> On Tue, May 27, 2014 at 10:11 PM, Linus Walleij
>> I tried to hack the sunxi driver to even use the gpiolib
>> irqchip helpers but exactly this complex map thing in
>> ->irq_array[] git me stuck. If any of you guy
On Fri, May 23, 2014 at 2:53 PM, wrote:
> + if (unlikely(bytes)) {
> + unsigned char buf[4];
(...)
Please think twice about this.
http://lwn.net/Articles/70473/
http://lwn.net/Articles/420019/
http://lwn.net/Articles/182369/
Yours,
Linus Walleij
--
To unsubscribe fro
ubtle difference between both the flags. Am happy to change it
> to qcom_clkdiv.
I think this was due to me wanting the variant variables to be more about
the actual technical difference they indicate rather than pointing to
a certain vendor or variant where that difference occurs.
It's a
>
>> Linus, will have to confirm this. I don't know if the u300 variant
>> support 8-bit.
>>
>
> Do you know if u300 supports 8BIT bus?
Yes it does actually.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
cant we just call
pinctrl_request_gpio() and pinctrl_free_gpio() here instead?
Or maybe pinctrl_gpio_direction_input() and have that set
up the muxing in the pinctrl driver side?
It looks slightly convoluted.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc&qu
k. If any of you guys could be so
nice to take a stab at this (compare to other commits
converting drivers to use gpiolibs irqchip helpers) then
I'd be very happy.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to
mments in mmci_pio_read() you will
see how this is handled. Are you sure this function cannot be
augmented to handle the qcom variant as well so you don't get this
problem further down the road?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
's a very minor issue, so:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to the
> driver.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
M_CLK_WIDEBUS_8,
Isn't this achieveing exactly the same thing without the extra fields?
You unconditionally do it at every enable anyway, don't you?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@v
t;
> Signed-off-by: Srinivas Kandagatla
Now it looks real elegant.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
patch other new SOCs like Qcom will have to add more code to
> special case them
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord..
ister is updated with wrong ddrmode mask on non
> ST SOCs, resulting in card detection failures.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a m
Qcom will have to add more code
> to special case them.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majo
writing to its SD Card
> Controller registers.
>
> Signed-off-by: Srinivas Kandagatla
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordo
ned-off-by: Srinivas Kandagatla
OK this is looking good.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 16, 2014 at 6:43 PM, Stephen Boyd wrote:
> On 05/16/14 09:24, Linus Walleij wrote:
>> On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd wrote:
>>
>>> Please add a note that this id is fake in the commit text or in
>>> the code as well.
>> You just
"fake" anymore...
This is a bit like device tree, it's defined by the kernel community as much
as by the hardware engineers and it's a little bit of back-and-forth.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc"
> remain);
> + else
> + len = mmci_pio_read(host, buffer, remain);
> + }
Use something like bool qcom_fifo; in vendor data instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2)
> +#define MCI_CSPM_QCOM_MCIABORT (1 << 13)
> +#define MCI_CSPM_QCOM_CCSENABLE(1 << 14)
> +#define MCI_CSPM_QCOM_CCSDISABLE (1 << 15)
> +#define MCI_CSPM_QCOM_AUTO_CMD19 (1 << 16)
> +#define MCI_CSPM_QCOM_AUTO_CMD21 (1
plat->f_max : min(host->mclk, plat->f_max);
So rewrite like that:
if (host->vendor->explicit_mclk_control)
mmc->f_max = plat->f_max;
else
mmc->f_max = min(host->mclk, plat->f_max);
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in latch data and command */
> +#define MCI_CLK_QCOM_SEL_IN_SHIFT (14)
> +#define MCI_CLK_QCOM_SEL_MASK (0x3)
> +#define MCI_CLK_QCOM_SEL_RISING_EDGE (1)
> +#define MCI_CLK_QCOM_SEL_FEEDBACK_CLK (2)
> +#define MCI_CLK_QCOM_SEL_DDR_MODE (3)
> +
>
ta variant_ux500v2 = {
.datactrl_ddrmode = MCI_ST_DPSM_DDRMODE,
(...)
Then end up like this:
>if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50)
> - datactrl |= MCI_ST_DPSM_DDRMODE;
> + datactrl |= host->vendor->datactrl_dd
.mclk_delayed_writes = true,
(...)
if (host->vendor->mclk_delayed_writes)
udelay(DIV_ROUND_UP((3 * USEC_PER_SEC), host->mclk));
You get the idea.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a mess
On Tue, Apr 29, 2014 at 10:20 AM, wrote:
> From: Srinivas Kandagatla
>
> This patch replaces a constant used in calculating timeout with a proper
> macro. This is make code more readable.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
This can be merged
nivas Kandagatla
This is probably something I got wrong when I attempted to use
this driver on the Dragon board. Now I see what I missed...
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majo
main SD
> controller driver for Qualcomm SOCs.
>
> Signed-off-by: Srinivas Kandagatla
Reviewed-by: Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
like 0x41 is "A" for ARM. You could as well mention
this in the commit message.
And you can probably just put this patch into Russell's patch tracker
already.
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mm
same idea came
> immediately after me.
Sometimes good ideas are just "in the air", like with Edison
and Sawyers fight over the lightbulb...
Can't you folks just add the other's Signed-off-by to either patch.
I guess Chris or Ulf will decide which one to take.
Yours,
Linus Walleij
On Wed, Apr 16, 2014 at 9:31 AM, Ulf Hansson wrote:
> On 15 April 2014 10:33, Linus Walleij wrote:
>> The next step in modernization of GPIO is to let drivers handle
>> descriptors rather than integer numbers representing GPIO pins,
>> akin to how clocks or regulators are
data if that
is not possible. After all platforms with MMCI have been
migrated to use descriptors, the platform data entries for
GPIO pins can be removed.
Cc: Alexandre Courbot
Cc: Ulf Hansson
Cc: Russell King
Signed-off-by: Linus Walleij
---
Hi Russell,Ulf: there is no hurry to do these changes
; otherwise the caller must also call mmc_gpiod_request_cd_irq().
>
> Signed-off-by: Adrian Hunter
This is very helpful.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...
tree or ACPI) and then use
devm_gpiod_get[_index]() in probe()?
This can certainly be step 2, but that is where we want to go with
the GPIO clean-up work in the long run.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a mess
ons of the PL18x, as it depends on exploiting properties
on an assumed pin controller.
Systems that don't have such wakeup features on their pins are
unlikely to support deepsleep in any capacity, and if they do they are
ill-designed from the top level as this needs to be taken into account
w
These four (so far unused) flags are only found in the ST Micro
versions of MMCI, so infix them properly with the _ST_ infix.
Signed-off-by: Linus Walleij
---
drivers/mmc/host/mmci.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/mmci.h b/drivers
em
> handle the resources accordingly, including the clock.
>
> Cc: Alessandro Rubini
> Cc: Linus Walleij
> Cc: Wolfram Sang
> Signed-off-by: Ulf Hansson
Hm do I read it right as patch 13 breaks runtime PM by leaving
the device active after probe() and this patch
14 fixes
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote:
> Use devm_* functions to simplify code and error handling.
>
> Cc: Alessandro Rubini
> Cc: Linus Walleij
> Cc: Wolfram Sang
> Signed-off-by: Ulf Hansson
Acked-by: Linus Walleij
However make sure this (and the rest) appl
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote:
> The driver core is now taking care of putting our pins into default
> state at probe. Thus we can remove the redundant call for it in probe.
>
> Cc: Mark Brown
> Signed-off-by: Ulf Hansson
Acked-by: Linus Walleij
Yours
depend on
> PM_RUNTIME for platforms like this.
Isn't the typical Android platform using PM_SLEEP without using
PM_RUNTIME?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordo
1 - 100 of 498 matches
Mail list logo
