Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width

2015-09-16 Thread Ray Jui
quot;, > - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N'); > + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N'); > The fix looks good to me. Thanks. Reviewed-by: Ray Jui Ray -- To unsubscribe fr

Re: [PATCH v2 5/7] mmc: sdhci-bcm-kona: kill the "external_clk" member in driver private struct

2015-02-27 Thread Ray Jui
Hi Kevin, On 2/26/2015 11:47 PM, Kevin Hao wrote: > Actually we can use the "clk" in the struct sdhci_pltfm_host. Also > change the "external clock" to "core clock" and kill two redundant > private functions in this driver as suggested by Ray Jui. &g

Re: [PATCH 5/7] mmc: sdhci-bcm-kona: kill the "external_clk" member in driver private struct

2015-02-05 Thread Ray Jui
On 2/5/2015 7:15 PM, Kevin Hao wrote: > Actually we can use the "clk" in the struct sdhci_pltfm_host. > > Signed-off-by: Kevin Hao > --- > drivers/mmc/host/sdhci-bcm-kona.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-bcm-kon

Re: [PATCH v2] mmc: fix host release issue after discard operation

2013-11-26 Thread Ray Jui
On 11/26/2013 2:06 PM, Chris Ball wrote: Hi Ray, On Sat, Oct 26 2013, Ray Jui wrote: Under function mmc_blk_issue_rq, after an MMC discard operation, the MMC request data structure may be freed in memory. Later in the same function, the check of req->cmd_flags & MMC_REQ_SPECIAL_