Re: [PATCH 3/3] mmc: block: Enable runtime pm for mmc blkdevice

2013-04-02 Thread Subhash Jadavani
On 4/2/2013 4:08 PM, Ulf Hansson wrote: On 1 April 2013 10:28, Asutosh Das asuto...@codeaurora.org wrote: On 3/6/2013 12:27 PM, Ulf Hansson wrote: On 6 March 2013 02:04, Asutosh Das asuto...@codeaurora.org wrote: On 3/5/2013 7:09 AM, Ulf Hansson wrote: On 4 March 2013 21:48, Asutosh Das

Re: [PATCH] Add method for triggering Sanitize command

2013-03-22 Thread Subhash Jadavani
On 3/20/2013 5:28 PM, Yaniv Gardi wrote: This patch adds a method to trigger Sanitize command to MMC. The Sanitize command is used for deleting the unmapped memory region of the MMC device. Signed-off-by: Yaniv Gardi yga...@codeaurora.org diff --git a/mmc.c b/mmc.c index a2de863..174d9a4

Re: [PATCH] Add method for triggering Sanitize command

2013-03-22 Thread Subhash Jadavani
On 3/22/2013 10:42 PM, Chris Ball wrote: Hi, On Fri, Mar 22 2013, Subhash Jadavani wrote: On 3/20/2013 5:28 PM, Yaniv Gardi wrote: This patch adds a method to trigger Sanitize command to MMC. The Sanitize command is used for deleting the unmapped memory region of the MMC device. Signed-off

Re: [PATCH 1/2] mmc: core: fix permanent sleep of mmcqd during card removal

2013-02-04 Thread Subhash Jadavani
On 1/30/2013 12:00 PM, Seungwon Jeon wrote: Hi Konstantin. Could you check this patch with [2/2]? [PATCH 2/2] mmc: block: don't start new request when the card is removed mmcqd is often sleeping with acquiring the claim(mmc_claim_host) when a card is removed. As a result, mmc_rescan can

Re: [PATCH 1/2] mmc: core: fix permanent sleep of mmcqd during card removal

2013-02-04 Thread Subhash Jadavani
-by: Subhash Jadavani subha...@codeaurora.org Best Regards, Jaehoon Chung On 02/05/2013 02:57 PM, Seungwon Jeon wrote: On Monday, February 04, 2013, Subhash Jadavani wrote: On 1/30/2013 12:00 PM, Seungwon Jeon wrote: Hi Konstantin. Could you check this patch with [2/2]? [PATCH 2/2] mmc: block

Re: [PATCH] mmc: core: fix the aysync mechanism when card removed

2013-01-31 Thread Subhash Jadavani
On 1/22/2013 5:48 PM, Jaehoon Chung wrote: When card removed, then didn't complete the previously data. (It didn't wakeup any interrupt.) If card is removed, then we can assume to complete the previously data. And wakeup the interrupt for wait_event of data. This problem is produced when

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread Subhash Jadavani
this patch? Yes, this patch also fixes the issue. You may add: Tested-by: Subhash Jadavani subha...@codeaurora.org . Regards, Subhash arch/arm/mm/dma-mapping.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-16 Thread Subhash Jadavani
On 1/16/2013 4:02 PM, James Bottomley wrote: On Wed, 2013-01-16 at 12:07 +0530, Subhash Jadavani wrote: Now consider this call stack from MMC block driver (this is on the ARmv7 based board): [ 98.918174] [c001b50c] (v7_dma_inv_range+0x30/0x48) from [c0017b8c] (dma_cache_maint_page

Re: [PATCH] mmc: core: disable the cache before suspend only after stopping BKOPS

2013-01-16 Thread Subhash Jadavani
As Maya is going to fix the commit text, Acked-by: Subhash Jadavani subha...@codeaurora.org On 1/17/2013 12:18 PM, Seungwon Jeon wrote: On Thursday, January 17, 2013 , Ulf Hansson wrote: On 13 January 2013 22:47, Maya Erez me...@codeaurora.org wrote: -Original Message- From: Subhash

Re: Query regarding ADMA descriptor allocation

2013-01-15 Thread Subhash Jadavani
Hi Chris, Can anyone from SDHCi confirm if the understanding below is correct or not? If it is than we can post a patch to fix it. Regards, Subhash On 1/13/2013 5:50 PM, Asutosh Das wrote: Hi Can you please let me know if my understanding in the below question is correct ? Thanks Asutosh

[PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-15 Thread Subhash Jadavani
-gather nodes. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- block/blk-merge.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 936a110..6eaef3d4 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -42,6

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-15 Thread Subhash Jadavani
On 1/15/2013 9:49 PM, James Bottomley wrote: On Tue, 2013-01-15 at 21:31 +0530, Subhash Jadavani wrote: blk_rq_map_sg() function merges the physically contiguous pages to use same scatter-gather node without checking if their page descriptors are contiguous or not. Now when dma_map_sg

[PATCH v1 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-11 Thread Subhash Jadavani
-gather nodes. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- block/blk-merge.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 936a110..623fca5 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -42,6

Re: [PATCH] mmc: core: disable the cache before suspend only after stopping BKOPS

2013-01-11 Thread Subhash Jadavani
On 1/12/2013 2:12 AM, Maya Erez wrote: mmc_cache_ctrl was called in runtime suspend before MMC interrupted BKOPS in case it is still running on the card. This caused the cache disable to timeout. I guess even if the idle time bkops polling is not implemented, this patch is good to have. cache

Re: FW: [PATCH v1 0/3] SDIO fixes

2012-12-11 Thread Subhash Jadavani
Jadavani subha...@codeaurora.org To: linux-mmc@vger.kernel.org CC: linux-arm-...@vger.kernel.org, Subhash Jadavani subha...@codeaurora.org This patch-series is having 1 fix for SDIO resume and 2 fixes related to SDIO3.0 card detection Subhash Jadavani (2): mmc: sdio: fix resume failure mmc

Re: [PATCH 3/3] mmc: core: Fixup signal voltage switch

2012-12-10 Thread Subhash Jadavani
On 12/10/2012 1:51 PM, Johan Rudholm wrote: Hi Subhash, 2012/12/8 Subhash Jadavani subha...@codeaurora.org: On 12/7/2012 9:49 PM, Johan Rudholm wrote: When switching SD and SDIO cards from 3.3V to 1.8V signal levels, the clock should be gated for 5 ms during the step. After enabling the clock

Re: [PATCH v1 1/3] mmc: sdio: fix resume failure

2012-12-07 Thread Subhash Jadavani
On 12/7/2012 3:40 AM, Ulf Hansson wrote: On 6 December 2012 16:25, Subhash Jadavani subha...@codeaurora.org wrote: On 12/6/2012 4:03 PM, Ulf Hansson wrote: On 4 December 2012 12:36, Subhash Jadavani subha...@codeaurora.org wrote: If SDIO keep power flag (MMC_PM_KEEP_POWER) is not set, card

Re: [PATCH v1 1/3] mmc: sdio: fix resume failure

2012-12-07 Thread Subhash Jadavani
On 12/7/2012 8:21 PM, Ulf Hansson wrote: On 7 December 2012 13:15, Subhash Jadavani subha...@codeaurora.org wrote: On 12/7/2012 3:40 AM, Ulf Hansson wrote: On 6 December 2012 16:25, Subhash Jadavani subha...@codeaurora.org wrote: On 12/6/2012 4:03 PM, Ulf Hansson wrote: On 4 December 2012 12

Re: [PATCH 3/3] mmc: core: Fixup signal voltage switch

2012-12-07 Thread Subhash Jadavani
On 12/7/2012 9:49 PM, Johan Rudholm wrote: When switching SD and SDIO cards from 3.3V to 1.8V signal levels, the clock should be gated for 5 ms during the step. After enabling the clock, the host should wait for at least 1 ms before checking for failure. Failure by the card to switch is

Re: [PATCH v1 1/3] mmc: sdio: fix resume failure

2012-12-06 Thread Subhash Jadavani
On 12/6/2012 4:03 PM, Ulf Hansson wrote: On 4 December 2012 12:36, Subhash Jadavani subha...@codeaurora.org wrote: If SDIO keep power flag (MMC_PM_KEEP_POWER) is not set, card would be reinitialized during resume but as we are not resetting (CMD52 reset) the SDIO card during

Re: [PATCH v1 2/3] mmc: sdio: Fix SDIO 3.0 UHS-I initialization sequence

2012-12-05 Thread Subhash Jadavani
: Bing Zhao [mailto:bz...@marvell.com] Sent: Thursday, December 06, 2012 3:14 AM To: Shen, Jackey; Subhash Jadavani; linux-mmc@vger.kernel.org Cc: linux-arm-...@vger.kernel.org; Sujit Reddy Thumma Subject: RE: [PATCH v1 2/3] mmc: sdio: Fix SDIO 3.0 UHS-I initialization sequence Hi Jackey, Hi Bing

[PATCH v1 0/3] SDIO fixes

2012-12-04 Thread Subhash Jadavani
This patch-series is having 1 fix for SDIO resume and 2 fixes related to SDIO3.0 card detection Subhash Jadavani (2): mmc: sdio: fix resume failure mmc: sdio: print correct UHS mode during card detection Sujit Reddy Thumma (1): mmc: sdio: Fix SDIO 3.0 UHS-I initialization sequence

[PATCH v1 1/3] mmc: sdio: fix resume failure

2012-12-04 Thread Subhash Jadavani
the reinitialization of card during resume. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/sdio.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c index 2273ce6..34ad4c8 100644 --- a/drivers/mmc/core

[PATCH v1 2/3] mmc: sdio: Fix SDIO 3.0 UHS-I initialization sequence

2012-12-04 Thread Subhash Jadavani
...@codeaurora.org Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/sdio.c | 22 +++--- include/linux/mmc/host.h |8 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c index 34ad4c8..9565d38

[PATCH v1 3/3] mmc: sdio: print correct UHS mode during card detection

2012-12-04 Thread Subhash Jadavani
When SDIO3.0 card is detected, incorrect bus speed mode is printed as part of card detection print in kernel logs. This change fixes it so that user won't be confused by looking at incorrect card detection message in logs. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc

Re: [PATCH v2] mmc: core: Add support for idle time BKOPS

2012-11-11 Thread Subhash Jadavani
Thanks Maya. Looks good to me. Reviewed-by: subha...@codeaurora.org Regards, Subhash On 10/5/2012 3:58 AM, Maya Erez wrote: Devices have various maintenance operations need to perform internally. In order to reduce latencies during time critical operations like read and write, it is better to

Re: [PATCH 1/1] mmc: debugfs: Set frequency to maximum possible on higher request

2012-09-03 Thread Subhash Jadavani
-by: Subhash Jadavani subha...@codeaurora.org mmc_claim_host(host); mmc_set_clock(host, (unsigned int) val); -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/1] mmc: debugfs: Set frequency to maximum possible on higher request

2012-09-03 Thread Subhash Jadavani
On 9/3/2012 6:00 PM, Andy Shevchenko wrote: On Mon, Sep 3, 2012 at 2:50 PM, Subhash Jadavani subha...@codeaurora.org wrote: As such this is ok if you want this behaviour. But i see other issue which is not related to your patch. Let's say if the host supports 400KHz, 25 MHz, 50MHz, 100MHz

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012-06-28 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Seungwon Jeon Sent: Thursday, June 28, 2012 3:13 PM To: 'Subhash Jadavani'; 'Saugata Das' Cc: 'Chris Ball'; 'Maya Erez'; linux-mmc@vger.kernel.org; linux- ker

RE: [PATCH v5] mmc: core: Fix the HPI execution sequence

2012-06-22 Thread Subhash Jadavani
Thanks Venkatraman. Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org Regards, Subhash -Original Message- From: Venkatraman S [mailto:svenk...@ti.com] Sent: Friday, June 22, 2012 11:43 AM To: c...@laptop.org Cc: linux-mmc@vger.kernel.org; linkinj...@gmail.com

RE: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-21 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of S, Venkatraman Sent: Thursday, June 21, 2012 12:55 PM To: Subhash Jadavani Cc: c...@laptop.org; linux-mmc@vger.kernel.org; linkinj...@gmail.com; jh80.ch...@samsung.com

RE: [PATCH v4] mmc: core: Fix the HPI execution sequence

2012-06-21 Thread Subhash Jadavani
One comment inline below: -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Venkatraman S Sent: Thursday, June 21, 2012 7:43 PM To: c...@laptop.org Cc: linux-mmc@vger.kernel.org; linkinj...@gmail.com;

RE: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-20 Thread Subhash Jadavani
Hi Venkatraman, -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Venkatraman S Sent: Wednesday, June 20, 2012 3:04 PM To: c...@laptop.org Cc: linux-mmc@vger.kernel.org; linkinj...@gmail.com; jh80.ch...@samsung.com;

RE: [PATCH RESEND v7 1/3] mmc: core: Add packed command feature of eMMC4.5

2012-06-18 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org -Original Message- From: Seungwon Jeon [mailto:tgih@samsung.com] Sent: Monday, June 18, 2012 11:13 AM To: linux-mmc@vger.kernel.org Cc: linux-ker...@vger.kernel.org; 'Chris Ball'; 'Maya Erez'; 'Subhash

RE: [PATCH v9] mmc: support BKOPS feature for eMMC

2012-06-15 Thread Subhash Jadavani
Hi Jaehoon, -Original Message- From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] Sent: Friday, June 15, 2012 9:50 AM To: Subhash Jadavani Cc: linux-mmc; Chris Ball; Kyungmin Park; Hanumath Prasad; Per FORLIN; Sebastian Rasmussen; Dong, Chuanxiao; svenk...@ti.com; Saugata Das

RE: power class selection fails on 3.5-rc1

2012-06-08 Thread Subhash Jadavani
-Original Message- From: Girish K S [mailto:girish.shivananja...@linaro.org] Sent: Friday, June 08, 2012 5:16 PM To: Subhash Jadavani Cc: Marc Dietrich; Ulf Hansson; saugata@linaro.org; linux- m...@vger.kernel.org Subject: Re: power class selection fails on 3.5-rc1 On 7

[PATCH v2 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-06-07 Thread Subhash Jadavani
requests normally have large transfer size and which means there are chances that while mmcq is executing blk_update_bidi_request(), it may get interrupted by interrupts or other high priority thread. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/card/block.c | 36

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-06-07 Thread Subhash Jadavani
-Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Wednesday, June 06, 2012 7:01 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; 'Namjae Jeon' Subject: Re: [PATCH v1 1/1] mmc: block: replace __blk_end_request

RE: power class selection fails on 3.5-rc1

2012-06-07 Thread Subhash Jadavani
-mmc- ow...@vger.kernel.org] On Behalf Of Marc Dietrich Sent: Thursday, June 07, 2012 3:05 PM To: Subhash Jadavani Cc: 'Ulf Hansson'; Girish K S; saugata@linaro.org; linux- m...@vger.kernel.org Subject: Re: power class selection fails on 3.5-rc1 On Wednesday 06 June 2012 15:14:48

Re: [PATCH v2 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-06-07 Thread Subhash Jadavani
On 6/7/2012 4:05 PM, Namjae Jeon wrote: This change is not meant for improving MMC throughput; it's basically about becoming fair to other threads/interrupts in the system. By holding spin lock and interrupts disabled for longer duration, we won't allow other threads/interrupts to run at

RE: power class selection fails on 3.5-rc1

2012-06-06 Thread Subhash Jadavani
Girish / Saugata needs to comment on one point Comments inline: -Original Message- From: Ulf Hansson [mailto:ulf.hans...@stericsson.com] Sent: Tuesday, June 05, 2012 6:06 PM To: Marc Dietrich; Subhash Jadavani Cc: linux-mmc@vger.kernel.org Subject: Re: power class selection fails

RE: [PATCH v6 1/3] mmc: core: Add packed command feature of eMMC4.5

2012-05-29 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of me...@codeaurora.org Sent: Tuesday, May 29, 2012 5:08 PM To: Seungwon Jeon Cc: linux-mmc@vger.kernel.org; 'Chris Ball'; me...@codeaurora.org; linux-

RE: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-28 Thread Subhash Jadavani
Hi Girish, Saugata, There is an issue with this patch during resume. Please find comments inline below: -Original Message- From: Girish K S [mailto:girish.shivananja...@linaro.org] Sent: Tuesday, May 22, 2012 5:15 PM To: linux-mmc@vger.kernel.org Cc: c...@laptop.org;

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-23 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org On 5/22/2012 5:15 PM, Girish K S wrote: From: Saugata Dassaugata@linaro.org This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage of POWER

Re: [PATCH v6 1/3] mmc: core: Add packed command feature of eMMC4.5

2012-05-21 Thread Subhash Jadavani
Hi Seungwon, Sorry for commenting on this late. I have one comment below. Please check if it makes sense or not. On 5/17/2012 3:10 PM, Seungwon Jeon wrote: This patch adds packed command feature of eMMC4.5. The maximum number for packing read(or write) is offered and exception event

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-05-19 Thread Subhash Jadavani
Hi Chris, Do you see any issues with this patch? Regards, Subhash -Original Message- From: Subhash Jadavani [mailto:subha...@codeaurora.org] Sent: Wednesday, April 18, 2012 1:07 PM To: 'Namjae Jeon' Cc: 'Chris Ball'; 'linux-mmc@vger.kernel.org'; 'linux-arm- m...@vger.kernel.org

Re: [PATCH v3] MMC-4.5 Power OFF Notify Rework

2012-05-18 Thread Subhash Jadavani
On 5/18/2012 3:16 PM, Girish K S wrote: From: Saugata Dassaugata@linaro.org This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage of POWER OFF NOTIFY together with SLEEP and misunderstanding on the usage of

RE: [RFC 3/3] mmc: Context support

2012-05-18 Thread Subhash Jadavani
Hi Sougata, Please find few comments inline below. Regards, Subhash -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Saugata Das Sent: Wednesday, May 16, 2012 9:01 PM To: linux-e...@vger.kernel.org;

RE: [PATCH 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-17 Thread Subhash Jadavani
Reviewed-by: Subhash Jadavani subha...@codeaurora.org Sougata, There are additional blank lines before and after the do_disable_512B_emulation() function. You may want to remove them. Regards, Subhash -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow

RE: [PATCH v2 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-17 Thread Subhash Jadavani
Thanks Saugata. Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org Regards, Subhash -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Saugata Das Sent: Thursday, May 17, 2012 4:32 PM To: linux-mmc

RE: [PATCH v2 1/2] [MMC-4.5] Disable emulation

2012-05-17 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org Regards, Subhash -Original Message- From: Saugata Das [mailto:saugata@stericsson.com] Sent: Thursday, May 17, 2012 4:32 PM To: linux-mmc@vger.kernel.org Cc: patc...@linaro.org; saugata@linaro.org; subha

Re: [RFC 1/2] [MMC-4.5] Disable emulation

2012-05-15 Thread Subhash Jadavani
On 5/14/2012 8:21 PM, Saugata Das wrote: On 14 May 2012 15:55, Subhash Jadavanisubha...@codeaurora.org wrote: On 5/9/2012 8:18 PM, Saugata Das wrote: From: Saugata Dassaugata@linaro.org This patch adds the support for large sector size of 4KB by disabling emulation. This patch passes

RE: [PATCH v8] mmc: support BKOPS feature for eMMC

2012-05-14 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Jaehoon Chung Sent: Monday, May 14, 2012 8:29 AM To: Subhash Jadavani Cc: Jaehoon Chung; linux-mmc; Chris Ball; Kyungmin Park; Hanumath Prasad; Per FORLIN; Sebastian

Re: [RFC 1/2] [MMC-4.5] Disable emulation

2012-05-14 Thread Subhash Jadavani
On 5/9/2012 8:18 PM, Saugata Das wrote: From: Saugata Dassaugata@linaro.org This patch adds the support for large sector size of 4KB by disabling emulation. This patch passes eMMC DATA_SECTOR_SIZE as the logical block size during mmc_blk_alloc_req. In order to use this patch for 4KB sector

Re: [RFC 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-14 Thread Subhash Jadavani
On 5/9/2012 8:18 PM, Saugata Das wrote: From: Saugata Dassaugata@linaro.org In this patch, we add utility to disable emulation mode in the eMMC-4.5. This is done to increase the data sector size to 4KB. Signed-off-by: Saugata Dassaugata@linaro.org --- mmc.c |6 ++ mmc.h

Re: [RFC 2/2] [MMC-4.5] [MMC UTIL] Disable emulation

2012-05-14 Thread Subhash Jadavani
On 5/9/2012 8:18 PM, Saugata Das wrote: From: Saugata Dassaugata@linaro.org In this patch, we add utility to disable emulation mode in the eMMC-4.5. This is done to increase the data sector size to 4KB. Signed-off-by: Saugata Dassaugata@linaro.org --- mmc.c |6 ++ mmc.h

Re: [PATCH v3 1/2] MMC-4.5 Power OFF Notify rework

2012-05-11 Thread Subhash Jadavani
Hi Girish, On 5/7/2012 7:11 PM, Girish K S wrote: This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage of POWER OFF NOTIFY together with SLEEP and misunderstanding on the usage of MMC_POWER_OFF power_mode from

Re: [PATCH v8] mmc: support BKOPS feature for eMMC

2012-05-11 Thread Subhash Jadavani
Hi Jaehoon, Please find comments inline below. On 5/10/2012 7:07 PM, Jaehoon Chung wrote: Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write

RE: [PATCH V2] MMC-4.5 Power OFF Notify rework

2012-05-01 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Saugata Das Sent: Monday, April 30, 2012 11:17 PM To: Ulf Hansson Cc: Girish K S; linux-mmc@vger.kernel.org; patc...@linaro.org Subject: Re: [PATCH V2] MMC-4.5 Power OFF

Re: [PATCH V2] MMC-4.5 Power OFF Notify rework

2012-04-30 Thread Subhash Jadavani
On 4/30/2012 11:44 AM, Girish K S wrote: This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage of POWER OFF NOTIFY together with SLEEP and misunderstanding on the usage of MMC_POWER_OFF power_mode from mmc_set_ios in

RE: [PATCH 1/2] mmc: core: fix the decision of mmc card-type

2012-04-25 Thread Subhash Jadavani
+ if (caps MMC_CAP_MMC_HIGHSPEED + card_type EXT_CSD_CARD_TYPE_52) Just from code readability point of view, can we add parenthesis for each conditions within if? if ( (xxx) (xxx)) Right but '' is higher than '' in priority, so how about keeping on?

RE: [PATCH 2/2] mmc: core: fix the signaling 1.8V for HS200

2012-04-25 Thread Subhash Jadavani
-Original Message- From: Seungwon Jeon [mailto:tgih@samsung.com] Sent: Wednesday, April 25, 2012 10:46 AM To: 'Subhash Jadavani' Cc: linux-mmc@vger.kernel.org; 'Chris Ball'; 'Girish K S' Subject: RE: [PATCH 2/2] mmc: core: fix the signaling 1.8V for HS200 Subhash Jadavani

RE: [PATCH v2 1/2] mmc: core: fix the decision of mmc card-type

2012-04-25 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org Regards, Subhash -Original Message- From: Seungwon Jeon [mailto:tgih@samsung.com] Sent: Wednesday, April 25, 2012 12:48 PM To: linux-mmc@vger.kernel.org Cc: 'Chris Ball'; 'Subhash Jadavani'; 'Girish K S

RE: [PATCH v2 2/2] mmc: core: fix the signaling 1.8V for HS200

2012-04-25 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org Regards, Subhash -Original Message- From: Seungwon Jeon [mailto:tgih@samsung.com] Sent: Wednesday, April 25, 2012 12:48 PM To: linux-mmc@vger.kernel.org Cc: 'Chris Ball'; 'Subhash Jadavani'; 'Girish K S

RE: [PATCH v3 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-25 Thread Subhash Jadavani
Hi Chris, Is this patch looks ok? Regards, Subhash -Original Message- From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Namjae Jeon Sent: Friday, April 13, 2012 8:12 PM To: Subhash Jadavani; Chris Ball Cc: linux-mmc

Re: [PATCH 1/2] mmc: core: fix the decision of mmc card-type

2012-04-24 Thread Subhash Jadavani
Hi Seungwon, On 4/23/2012 2:41 PM, Seungwon Jeon wrote: Current implementation decides the card type exclusively. Even though eMMC device can support both HS200 and DDR mode, card type will be set only for HS200. If the host doesn't support HS200 but has DDR capability, then DDR mode can't be

Re: [PATCH 2/2] mmc: core: fix the signaling 1.8V for HS200

2012-04-24 Thread Subhash Jadavani
Hi Seungwon, On 4/23/2012 2:41 PM, Seungwon Jeon wrote: Currently only 1.2V is treated for HS200 mode. If the host has only 1.8V I/O capability not 1.2V, mmc_set_signal_voltage can't be called for 1.8V HS200. EXT_CSD_CARD_TYPE_SDR_1_8V needs to be considered. Commit text looks confusing to me.

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-18 Thread Subhash Jadavani
Hi Namjae, -Original Message- From: Namjae Jeon [mailto:linkinj...@gmail.com] Sent: Wednesday, April 18, 2012 11:12 AM To: Subhash Jadavani Cc: Chris Ball; linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org Subject: Re: [PATCH v1 1/1] mmc: block: replace __blk_end_request

RE: [PATCH] mmc: sdhci-spear: Add clk_{un}prepare() support

2012-04-17 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Viresh Kumar Sent: Tuesday, April 17, 2012 3:14 PM To: c...@laptop.org Cc: linux-mmc@vger.kernel.org; spear-de...@list.st.com; viresh.li...@gmail.com; Viresh Kumar

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-17 Thread Subhash Jadavani
Hi Chris, -Original Message- From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Subhash Jadavani Sent: Wednesday, April 11, 2012 12:22 AM To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org Subject: RE

[PATCH v3 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-12 Thread Subhash Jadavani
With current implementation of power class selection, mmc_select_powerclass() should never fail. So treat any error returned by this function as serious enough to skip the card initialization. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/mmc.c | 18

[PATCH v2 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-11 Thread Subhash Jadavani
With current implementation of power class selection, mmc_select_powerclass() should never fail. So treat any error returned by this function as serious enough to skip the card initialization. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/mmc.c | 26

RE: [PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-10 Thread Subhash Jadavani
-Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Tuesday, April 10, 2012 7:46 PM To: Namjae Jeon Cc: Subhash Jadavani; linux-mmc@vger.kernel.org; saugata@linaro.org Subject: Re: [PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

[PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-10 Thread Subhash Jadavani
this test for almost a day on multicore system and no errors observed. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/card/block.c | 36 +--- 1 files changed, 9 insertions(+), 27 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers

RE: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request()

2012-04-10 Thread Subhash Jadavani
-Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Wednesday, April 11, 2012 12:08 AM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org Subject: Re: [PATCH v1 1/1] mmc: block: replace __blk_end_request() with blk_end_request() Hi

RE: [PATCH v1 1/1] mmc: core: fix power class selection

2012-04-09 Thread Subhash Jadavani
Hi Porzio, -Original Message- From: Luca Porzio (lporzio) [mailto:lpor...@micron.com] Sent: Tuesday, April 03, 2012 10:36 PM To: Subhash Jadavani; 'Saugata Das' Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; girish.shivananja...@linaro.org; Danilo Caraccio (dcaracci

[PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-09 Thread Subhash Jadavani
With current implementation of power class selection, mmc_select_powerclass() should never fail. So treat any error returned by this function as serious enough to skip the card initialization. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/mmc.c | 34

RE: Changing the way MMC block request ends

2012-04-06 Thread Subhash Jadavani
Hi Chris, Any thoughts or suggestions on this? Regards, Subhash -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Subhash Jadavani Sent: Thursday, April 05, 2012 11:16 AM To: linux-mmc@vger.kernel.org Cc: linux-arm

RE: Changing the way MMC block request ends

2012-04-06 Thread Subhash Jadavani
Hi Chris, -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Chris Ball Sent: Friday, April 06, 2012 7:24 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org Subject: Re: Changing the way

[PATCH v1 1/1] mmc: core: fix power class selection

2012-04-03 Thread Subhash Jadavani
the power class shouldn't be treated as fatal error because even if setting the power class fails, card can still work in default power class. If mmc_select_powerclass() returns error, just print the warning message and go ahead with rest of the card initialization. Signed-off-by: Subhash Jadavani subha

RE: [PATCH v1 1/1] mmc: core: fix power class selection

2012-04-03 Thread Subhash Jadavani
-Original Message- From: Saugata Das [mailto:saugata@linaro.org] Sent: Tuesday, April 03, 2012 8:55 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; girish.shivananja...@linaro.org Subject: Re: [PATCH v1 1/1] mmc: core: fix power class

RE: [PATCH v1 1/1] mmc: core: fix power class selection

2012-04-03 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Saugata Das Sent: Tuesday, April 03, 2012 9:48 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; girish.shivananja...@linaro.org

RE: [PATCH V2] mmc: core: Add host capability check for power class

2012-04-02 Thread Subhash Jadavani
-Original Message- From: Saugata Das [mailto:saugata@linaro.org] Sent: Monday, April 02, 2012 1:20 PM To: Subhash Jadavani Cc: Girish K S; linux-mmc@vger.kernel.org; patc...@linaro.org; linux- samsung-...@vger.kernel.org; Chris Ball Subject: Re: [PATCH V2] mmc: core: Add host

[PATCH v2 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-30 Thread Subhash Jadavani
When UHS-I card is detected also print the bus speed mode in which UHS-I card will be running. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/bus.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/bus.c b

RE: [PATCH V2] mmc: core: Add host capability check for power class

2012-03-29 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Girish K S Sent: Friday, March 30, 2012 10:29 AM To: Subhash Jadavani Cc: Saugata Das; linux-mmc@vger.kernel.org; patc...@linaro.org; linux- samsung-...@vger.kernel.org

RE: [PATCH V2] mmc: core: Add host capability check for power class

2012-03-28 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Saugata Das Sent: Thursday, December 15, 2011 6:35 PM To: Girish K S Cc: linux-mmc@vger.kernel.org; patc...@linaro.org; linux-samsung- s...@vger.kernel.org;

RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-26 Thread Subhash Jadavani
-Original Message- From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Aaron Lu Sent: Monday, March 26, 2012 8:47 AM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; arindam.n...@amd.com Subject

RE: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-26 Thread Subhash Jadavani
...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Subhash Jadavani Sent: Monday, March 26, 2012 11:46 AM To: 'Aaron Lu' Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; arindam.n...@amd.com Subject: RE: [PATCH v1 1/1] mmc: bus: print bus speed mode

RE: [PATCH] mmc: block: Remove use of mmc_blk_set_blksize

2012-03-23 Thread Subhash Jadavani
Reviewed-by: Subhash Jadavani subha...@codeauora.org -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Ulf Hansson Sent: Thursday, March 22, 2012 4:17 PM To: linux-mmc@vger.kernel.org; Chris Ball Cc: Subhash Jadavani

[PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card

2012-03-22 Thread Subhash Jadavani
When UHS-I card is detected also print the bus speed mode in which UHS-I card will be running. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/bus.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/core

RE: [PATCH v1 1/1] mmc: core: hs200 fixes

2012-03-06 Thread Subhash Jadavani
Hi Girish, -Original Message- From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm- ow...@vger.kernel.org] On Behalf Of Girish K S Sent: Tuesday, March 06, 2012 3:30 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; c...@laptop.org

RE: [PATCH v1 1/1] mmc: core: hs200 fixes

2012-03-06 Thread Subhash Jadavani
-Original Message- From: Girish K S [mailto:girish.shivananja...@linaro.org] Sent: Tuesday, March 06, 2012 5:39 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; linux-arm-...@vger.kernel.org; c...@laptop.org Subject: Re: [PATCH v1 1/1] mmc: core: hs200 fixes On 6 March

[PATCH v2 1/1] mmc: core: hs200 fixes

2012-03-06 Thread Subhash Jadavani
() is called. So this patch moves this operation after execute_tuning() is completed. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/mmc.c | 38 +- 1 files changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/mmc/core/mmc.c

[PATCH v1 1/1] mmc: core: hs200 fixes

2012-03-05 Thread Subhash Jadavani
() is called. So this patch moves this operation after execute_tuning() is completed. Signed-off-by: Subhash Jadavani subha...@codeaurora.org --- drivers/mmc/core/mmc.c | 37 - 1 files changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/mmc/core/mmc.c b

Re: [PATCH] mmc: core: Fixup suspend/resume issues for UHS-I cards

2012-03-02 Thread Subhash Jadavani
Tested-by: Subhash Jadavani subha...@codeaurora.org On 3/2/2012 12:27 AM, Philip Rakity wrote: acked-by: Philip Rakityprak...@marvell.com On Mar 1, 2012, at 4:18 AM, Ulf Hansson wrote: Even if cards supports 1.8V I/O voltage those should anyway be initialized at 3.3V I/O according to (e)MMC

Re: [PATCH V2 1/1] mmc: start removing enable / disable API

2012-03-01 Thread Subhash Jadavani
On 3/1/2012 1:51 PM, Adrian Hunter wrote: On 01/03/12 10:08, Subhash Jadavani wrote: On 2/29/2012 12:47 PM, Adrian Hunter wrote: Most parts of the enable / disable API are no longer used and can be removed. Cc: Rajendra Nayakrna...@ti.com Cc: Venkatraman Ssvenk...@ti.com Cc: Kukjin Kimkgene

RE: [PATCH V7 1/2] mmc: core: HS200 mode support for eMMC 4.5

2011-12-20 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Girish K S Sent: Wednesday, December 21, 2011 9:43 AM To: linux-mmc@vger.kernel.org Cc: patc...@linaro.org; linux-samsung-...@vger.kernel.org; Girish K S; Chris Ball

RE: [PATCH V6 1/2] mmc: core: HS200 mode support for eMMC 4.5

2011-12-19 Thread Subhash Jadavani
-Original Message- From: Girish K S [mailto:girish.shivananja...@linaro.org] Sent: Monday, December 19, 2011 4:20 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; patc...@linaro.org; linux-samsung- s...@vger.kernel.org; Chris Ball Subject: Re: [PATCH V6 1/2] mmc: core: HS200

Re: [PATCH V2] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Subhash Jadavani
On 12/19/2011 4:42 PM, Ulf Hansson wrote: Subhash Jadavani wrote: -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Ulf Hansson Sent: Thursday, December 15, 2011 3:06 PM To: linux-mmc@vger.kernel.org; Chris Ball Cc: Per

RE: [PATCH V2] mmc: core: Add option to prevent eMMC sleep command

2011-12-19 Thread Subhash Jadavani
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Ulf Hansson Sent: Monday, December 19, 2011 5:28 PM To: Subhash Jadavani Cc: linux-mmc@vger.kernel.org; 'Chris Ball'; Per FORLIN; Johan RUDHOLM; 'Lee Jones' Subject: Re

  1   2   >