Re: [PATCH] mmc: tegra: don't enable UHS modes on Tegra210

2016-01-05 Thread Ulf Hansson
On 30 December 2015 at 16:49, Lucas Stach wrote: > Tegra210 needs a different tuning sequence than Tegra30+. Disable > UHS modes until support for this is properly added. > > Signed-off-by: Lucas Stach > --- > Ulf, > this is a follow on patch to my Tegra UHS-I

Re: [PATCH] mmc: core: Optimize boot time by detecting cards simultaneously

2015-12-28 Thread Ulf Hansson
On 18 December 2015 at 04:05, Shawn Lin <shawn@rock-chips.com> wrote: > On 2015/12/18 9:28, Jaehoon Chung wrote: >> >> Hi, >> >> On 12/18/2015 06:49 AM, Ulf Hansson wrote: >>> >>> On 17 December 2015 at 20:47, Alan Cooper <alcoop...@gmail

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

2015-12-28 Thread Ulf Hansson
On 18 December 2015 at 23:31, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151218 14:20]: >> On 18 December 2015 at 17:14, Tony Lindgren <t...@atomide.com> wrote: >> > * Ulf Hansson <ulf.hans...@linaro.org> [151207 16:2

Re: [v4, 5/6] mmc: kconfig: select FSL_GUTS for MMC_SDHCI_OF_ESDHC

2015-12-28 Thread Ulf Hansson
On 28 December 2015 at 11:26, Yangbo Lu <yangbo...@nxp.com> wrote: >> -Original Message----- >> From: Ulf Hansson [mailto:ulf.hans...@linaro.org] >> Sent: Thursday, December 17, 2015 7:31 PM >> To: Scott Wood >> Cc: Lu Yangbo-B47093; linux-mmc; Xie Xiaobo-R

Re: 1217:8520 [Dell Latitude E7450] O2 Micro, SD/MMC Card Reader doesn't work

2015-12-28 Thread Ulf Hansson
On 23 December 2015 at 12:13, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > On Tue, Dec 22, 2015 at 09:30:00AM +0100, Ulf Hansson wrote: >> This quirk seems a bit strange. It looks like a generic problem being >> solved by the wrong approach. Although, my

Re: [PATCH 05/10] mmc: cb710: use to_platform_device()

2015-12-28 Thread Ulf Hansson
On 27 December 2015 at 14:15, Geliang Tang wrote: > Use to_platform_device() instead of open-coding it. > > Signed-off-by: Geliang Tang Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/cb710-mmc.h | 3 +-- > 1 file changed, 1

Re: [PATCH v2 0/5] Tegra SDHCI UHS-I support

2015-12-28 Thread Ulf Hansson
On 22 December 2015 at 19:40, Lucas Stach wrote: > Hi all, > > this series implements UHS-I signaling for the Tegra SDHCI host, > which mainly means putting a proper tuning sequence in place. > > I've tested this on Jetson TK1 and got the following speed results, > where mmcblk0

Re: [PATCH 4/9] mmc: sdhci-pci: use to_pci_dev()

2015-12-28 Thread Ulf Hansson
On 27 December 2015 at 11:46, Geliang Tang wrote: > Use to_pci_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/sdhci-pci-core.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] mmc: dw_mmc: remove the unused quirks

2015-12-28 Thread Ulf Hansson
On 24 December 2015 at 10:41, Jaehoon Chung wrote: > Removed the unused quirks. These quirks don't used anywhere. > > Signed-off-by: Jaehoon Chung As I don't expect any additional PR for dw_mmc for 4.5, I decided to pick this one up myself.

Re: [RFC 0/6] mmc: Field Firmware Update

2015-12-22 Thread Ulf Hansson
+ Olof (forgot to add him last time) On 22 December 2015 at 09:55, Ulf Hansson <ulf.hans...@linaro.org> wrote: > + Gwendal, Grant, Olof, Seshagiri, Jon > > On 22 December 2015 at 09:15, Holger Schurig <holgerschu...@gmail.com> wrote: >> >>> Sorry for the

Re: BUG 4.4rc-4: wrong eMMC signaling voltage reported

2015-12-22 Thread Ulf Hansson
On 22 December 2015 at 10:39, Fabio Estevam <feste...@gmail.com> wrote: > Hi Ulf and Holger, > > On Thu, Dec 17, 2015 at 2:10 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: > >> The no-1-8-v is a somewhat broken DT binding. I advise people to not >> use any mor

Re: [PATCH v2 00/24] MMC/SDHCI fixes

2015-12-22 Thread Ulf Hansson
On 21 December 2015 at 14:59, Ulf Hansson <ulf.hans...@linaro.org> wrote: > On 21 December 2015 at 14:41, Russell King - ARM Linux > <li...@arm.linux.org.uk> wrote: >> On Mon, Dec 21, 2015 at 02:23:17PM +0100, Ulf Hansson wrote: >>> On 21 December 2015 at 13:51,

Re: 1217:8520 [Dell Latitude E7450] O2 Micro, SD/MMC Card Reader doesn't work

2015-12-22 Thread Ulf Hansson
+ Adrian, Russell On 22 December 2015 at 04:24, Peter Guo wrote: > Hi Ulf & Alex, > > Below is the complete analysis of this issue. > > The basic flow of send command is as below: > (1) Upper layer prepare the command parameter; > (2) Call sdhci_send_command, and

Re: [RFC 0/6] mmc: Field Firmware Update

2015-12-22 Thread Ulf Hansson
+ Gwendal, Grant, Olof, Seshagiri, Jon On 22 December 2015 at 09:15, Holger Schurig wrote: > >> Sorry for the delay. > > No problem, I was busy with many other projects as well. > >> My advise right now is to try this out via the mmc ioctl in userspace, >> yes. Although,

Re: BUG 4.4rc-4: wrong eMMC signaling voltage reported

2015-12-22 Thread Ulf Hansson
On 22 December 2015 at 09:33, Holger Schurig wrote: > >> The no-1-8-v is a somewhat broken DT binding. I advise people to not >> use any more. >> Depending on the sdhci variant it have different meanings. >> >> I guess you are using the sdhci-esdhc-imx variant, which

Re: [PATCH 07/17] mmc: sdhci: avoid unnecessary mapping/unmapping of align buffer

2015-12-21 Thread Ulf Hansson
On 19 December 2015 at 21:30, Russell King wrote: > Unnecessarily mapping and unmapping the align buffer for SD cards is > expensive: performance measurements on iMX6 show that this gives a hit > of 10% on hdparm buffered disk reads. > > MMC/SD card IO comes from the

Re: [PATCH v2 00/24] MMC/SDHCI fixes

2015-12-21 Thread Ulf Hansson
On 21 December 2015 at 13:51, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > On Mon, Dec 21, 2015 at 01:35:36PM +0100, Ulf Hansson wrote: >> I decided to try to apply it for my next branch, to get some good test >> coverage. Although, it failed when reaching pa

Re: [PATCH v2 00/24] MMC/SDHCI fixes

2015-12-21 Thread Ulf Hansson
On 21 December 2015 at 14:41, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > On Mon, Dec 21, 2015 at 02:23:17PM +0100, Ulf Hansson wrote: >> On 21 December 2015 at 13:51, Russell King - ARM Linux >> <li...@arm.linux.org.uk> wrote: >> > On Mon, D

Re: [PATCH 01/17] mmc: core: shut up "voltage-ranges unspecified" pr_info()

2015-12-21 Thread Ulf Hansson
On 19 December 2015 at 21:29, Russell King wrote: > Each time a driver such as sdhci-esdhc-imx is probed, we get a info > printk complaining that the DT voltage-ranges property has not been > specified. > > However, the DT binding specifically says that the

Re: [PATCH 00/17] MMC/SDHCI fixes

2015-12-21 Thread Ulf Hansson
On 19 December 2015 at 21:28, Russell King - ARM Linux wrote: > This all started with a report from an iMX6 Hummingboard user that > they were seeing regular "mmc0: Got data interrupt 0x0002 even > though no data operation was in progress." messages with 4.4-rc and >

Re: [PATCH v2 00/24] MMC/SDHCI fixes

2015-12-21 Thread Ulf Hansson
On 21 December 2015 at 12:39, Russell King - ARM Linux wrote: > This all started with a report from an iMX6 Hummingboard user that > they were seeing regular "mmc0: Got data interrupt 0x0002 even > though no data operation was in progress." messages with 4.4-rc and >

Re: [PATCH 4/5] mmc: tegra: enable UHS-I modes

2015-12-21 Thread Ulf Hansson
On 19 December 2015 at 20:16, Lucas Stach wrote: > Keep the quirk bits, as Tegra30 and Tegra114 host have different levels > of support for UHS-I modes and so need different spare bits to be set, > but change the logic to be positive. > > Signed-off-by: Lucas Stach

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

2015-12-18 Thread Ulf Hansson
On 18 December 2015 at 09:11, Ludovic Desroches <ludovic.desroc...@atmel.com> wrote: > Hi Ulf, Jisheng, > > On Fri, Dec 11, 2015 at 03:48:04PM +0100, Ulf Hansson wrote: >> + Ludovic (We had some discussions around this code recently as well) >> >> On 11 December 2

Re: [bug] kernel panic if writting data to mmc after suspendding

2015-12-18 Thread Ulf Hansson
On 18 December 2015 at 10:33, Geert Uytterhoeven wrote: > Hi Dung-san, > > CC Ulf > > On Mon, Dec 14, 2015 at 3:34 AM, Nguyen Viet Dung wrote: >> While is testting LTSI-v4.1.13-rc1, we have found the following the failure >> of mmcif. >> 1. mount mmc

Re: 1217:8520 [Dell Latitude E7450] O2 Micro, SD/MMC Card Reader doesn't work

2015-12-18 Thread Ulf Hansson
On 18 December 2015 at 04:14, Peter Guo wrote: > Hi Alex & Adam, > > I have send the patch. Please check it. > Attachment is the patch file. Thanks Peter for helping out! Although I would appreciate if you don't send patches as attachments. Moreover, even if the patch

Re: [PATCH] mmc: It is not an error for the card to be removed while suspended

2015-12-18 Thread Ulf Hansson
On 14 December 2015 at 14:51, Adrian Hunter wrote: > A card can be removed while it is runtime suspended. > Do not print an error message. > > Signed-off-by: Adrian Hunter Thanks, applied for next! Kind regards Uffe > --- >

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

2015-12-18 Thread Ulf Hansson
On 18 December 2015 at 17:14, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151207 16:20]: >> +Linus >> >> On 7 December 2015 at 23:54, Tony Lindgren <t...@atomide.com> wrote: >> > Commit ce037275861e (&qu

Re: SDHCI long sleep with interrupts off

2015-12-17 Thread Ulf Hansson
[...] >> If/when you decide to fix this issue. Please keep in mind the following >> things. >> >> - Try to convert the SDHCI into a pure library. No more quirks or callbacks. >> - I assume we can simplify lots of code if we convert SDHCI into using >> a threaded IRQ in favour of the tasklet. >>

Re: BUG 4.4rc-4: wrong eMMC signaling voltage reported

2015-12-17 Thread Ulf Hansson
On 9 December 2015 at 15:53, Holger Schurig wrote: > Hi, > > I have an i.MX6Q based system that cannot provide 1.8V voltage towards > the eMMC. But Linux 4.4-rc4 reports 1.8V for the eMMC, but this is > impossible. Neither my hardware allows this, nor does the DT say it.

Re: [PATCH] mmc: core: Optimize boot time by detecting cards simultaneously

2015-12-17 Thread Ulf Hansson
On 17 December 2015 at 20:47, Alan Cooper <alcoop...@gmail.com> wrote: > On Wed, Dec 16, 2015 at 4:07 AM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> To find the improved card detection times, I just used the kernel boot >> log and checked the time stamps for when th

Re: [v4, 5/6] mmc: kconfig: select FSL_GUTS for MMC_SDHCI_OF_ESDHC

2015-12-17 Thread Ulf Hansson
[...] >> >> And I think stubs for reading SVR is quite a bad idea. It'll make the driver >> build but it will silently not be able to apply SVR-based workarounds. > > It doesn't have to be "silent", the driver can return an error (and > print error messages) from its ->probe() method, if the

Re: SDHCI long sleep with interrupts off

2015-12-17 Thread Ulf Hansson
On 17 December 2015 at 12:27, Lucas Stach wrote: > Am Donnerstag, den 17.12.2015, 12:20 +0100 schrieb David Jander: >> Hi Lucas, >> >> Thanks for reacting. >> >> On Thu, 17 Dec 2015 12:03:10 +0100 >> Lucas Stach wrote: >> >> > Am Donnerstag, den

Re: [v4, 5/6] mmc: kconfig: select FSL_GUTS for MMC_SDHCI_OF_ESDHC

2015-12-17 Thread Ulf Hansson
On 16 December 2015 at 23:48, Scott Wood <scottw...@freescale.com> wrote: > On Tue, 2015-12-15 at 10:46 +0100, Ulf Hansson wrote: >> [...] >> > > > --- a/drivers/mmc/host/Kconfig >> > > > +++ b/drivers/mmc/host/Kconfig >> > > > @@ -142,6

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

2015-12-16 Thread Ulf Hansson
On 16 December 2015 at 12:44, Ivan T. Ivanov <ivan.iva...@linaro.org> wrote: > >> On Dec 16, 2015, at 12:18 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> >> [...] >> >>>> It seems like a reasonable assumption that the controller can't cope &

Re: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

2015-12-16 Thread Ulf Hansson
[...] > +static int pic32_sdhci_probe(struct platform_device *pdev) > +{ > + struct device *dev = >dev; > + struct sdhci_host *host; > + struct resource *iomem; > + struct pic32_sdhci_pdata *sdhci_pdata; > + struct pic32_sdhci_platform_data *plat_data; > +

Re: [PATCH] mmc: core: Optimize boot time by detecting cards simultaneously

2015-12-16 Thread Ulf Hansson
On 16 December 2015 at 00:22, Jaehoon Chung <jh80.ch...@samsung.com> wrote: > On 12/15/2015 12:50 AM, Ulf Hansson wrote: >> On 1 December 2015 at 16:15, Ulf Hansson <ulf.hans...@linaro.org> wrote: >>> The mmc workqueue is an ordered workqueue, allowing only one work

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

2015-12-16 Thread Ulf Hansson
[...] >> It seems like a reasonable assumption that the controller can't cope >> with a higher clock rate than 100 MHz as "input" clock. That would >> then mean that there are different versions of the controller, as it >> seems like for some version it's fine with 200MHz and for some 100MHz. >>

Re: [RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-12-15 Thread Ulf Hansson
Hi Shawn, Sorry for the delay. [...] >> >> I think your are in right track, but unfortunate you still have some >> work to do. :-) >> >> You can't call sdhci_suspend_host() with a runtime suspended host. You >> will for example access sdhci internal registers, even-though the >> clock to the

Re: [v4, 5/6] mmc: kconfig: select FSL_GUTS for MMC_SDHCI_OF_ESDHC

2015-12-15 Thread Ulf Hansson
[...] >> > --- a/drivers/mmc/host/Kconfig >> > +++ b/drivers/mmc/host/Kconfig >> > @@ -142,6 +142,8 @@ config MMC_SDHCI_OF_ESDHC >> > depends on MMC_SDHCI_PLTFM >> > depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE >> > select MMC_SDHCI_IO_ACCESSORS >> > + select SOC_FSL

Re: 4.3 kernel panics when MMC/SDHC card is inserted on thinkpad

2015-12-15 Thread Ulf Hansson
+Adrian On 8 November 2015 at 23:05, Denis Bychkov wrote: > The only started in 4.3 kernel (at least RC-5), 4.2.x does not have > this problem. The kernel panic happens immediately after the SDHC card > is inserted, reproducibility is 100%. If the system boots up with the >

Re: [RFC][PATCH v2] mmc_block: Allow more than 8 partitions per card

2015-12-15 Thread Ulf Hansson
devidx > from md->disk. md->disk->first_minor is always initialized > from devidx and can always be used to recover it. > > Thoughts or feedback would be greatly appreciated. > > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: Adrian Hunter <adrian.hun...@int

Re: [RFC 0/6] mmc: Field Firmware Update

2015-12-15 Thread Ulf Hansson
+Chris, Baolin On 25 November 2015 at 09:56, Holger Schurig wrote: > We had to modify the last patch a bit and was able to update a Kingston > device from Firmware 0xba to 0xbd. But when doing this in user-space only is > now the way to go, I should probably not submit

Re: [v4, 0/6] eSDHC patches introduction

2015-12-14 Thread Ulf Hansson
On 14 December 2015 at 05:24, Yangbo Lu wrote: > This patchset is used to fix host version in eSDHC_HOSTVER for > T4240-R1.0-R2.0. > To get the SoC version and revision, it's needed to add the GUTS driver to > access > the global utilities registers. > > So, the first

Re: [v4, 5/6] mmc: kconfig: select FSL_GUTS for MMC_SDHCI_OF_ESDHC

2015-12-14 Thread Ulf Hansson
On 14 December 2015 at 05:24, Yangbo Lu wrote: > The sdhci-of-esdhc driver needs the GUTS driver support > to access the global utilities registers for SVR value. > So we select FSL_GUTS for MMC_SDHCI_OF_ESDHC here. > > Signed-off-by: Yangbo Lu >

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

2015-12-11 Thread Ulf Hansson
+ Ludovic (We had some discussions around this code recently as well) On 11 December 2015 at 14:36, Jisheng Zhang wrote: > After commit 52221610dd84 ("mmc: sdhci: Improve external VDD regulator > support"), for the VDD is supplied via external regulators, we ignore > the

Re: [v3, 4/5] powerpc: dts: t4240: add syscon support for DCFG node

2015-12-11 Thread Ulf Hansson
[...] >> > > The fsl_get_svr() you suggested is also an idea for this. >> > > Then, may I know is there a guts driver in kernel? >> > > Thanks a lot. >> > >> > There isn't, but there should be. >> > >> > -Scott >> >> [Lu Yangbo-B47093] Ok, I'd like to try. But can you suggest where we should >>

Re: Update dw-mmc controller

2015-12-11 Thread Ulf Hansson
On 11 December 2015 at 05:57, Jaehoon Chung wrote: > Dear, Ulf > > Could you pull this patch on your repository? Sorry for late. > Also I will send the some patches at mailing on this weekend.. Thanks! Pulled into my next branch. Kind regards Uffe > > Best Regards, >

Re: [BUG] mfd: rtsx_usb data corruption with SDCX microsd

2015-12-10 Thread Ulf Hansson
On 8 December 2015 at 17:34, Daniel Lenski <dlen...@gmail.com> wrote: > On Dec 8, 2015 6:11 AM, "Ulf Hansson" <ulf.hans...@linaro.org> wrote: >> >> On 4 December 2015 at 21:34, Daniel Lenski <dlen...@gmail.com> wrote: >> > In conclusio

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

2015-12-08 Thread Ulf Hansson
On 8 December 2015 at 01:32, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151207 16:20]: >> +Linus >> >> On 7 December 2015 at 23:54, Tony Lindgren <t...@atomide.com> wrote: >> > Commit ce037275861e (&qu

Re: [v3, 3/5] mmc: kconfig: select MFD_SYSCON for MMC_SDHCI_OF_ESDHC

2015-12-08 Thread Ulf Hansson
On 27 November 2015 at 04:20, Yangbo Lu wrote: > The sdhci-of-esdhc driver needs the syscon support to do > regmap and access the global utilities registers. So we > select MFD_SYSCON for MMC_SDHCI_OF_ESDHC here. > > Signed-off-by: Yangbo Lu >

Re: [PATCH v4] mmc: meson: Add driver for the SD/MMC host found on Amlogic MesonX SoCs

2015-12-08 Thread Ulf Hansson
On 1 December 2015 at 17:41, Carlo Caione wrote: > From: Carlo Caione > > Add a driver for the SD/MMC host found on the Amlogic MesonX SoCs. This > is an MMC controller which provides an interface between the application > processor and various memory cards.

Re: [v3, 1/5] powerpc/fsl: move mpc85xx.h to include/linux

2015-12-08 Thread Ulf Hansson
+Lee Jones On 27 November 2015 at 04:20, Yangbo Lu wrote: > Move mpc85xx.h to include/linux and rename it to fsl-svr.h as > a common header file. It has been used for mpc85xx and it will > be used for ARM-based SoC as well. > > Signed-off-by: Yangbo Lu

Re: [BUG] mfd: rtsx_usb data corruption with SDCX microsd

2015-12-08 Thread Ulf Hansson
On 4 December 2015 at 21:34, Daniel Lenski <dlen...@gmail.com> wrote: > On Fri, Dec 4, 2015 at 11:21 AM, Daniel Lenski <dlen...@gmail.com> wrote: >> On 21 October 2015 at 12:02, Ulf Hansson linaro.org> wrote: >>> As I don't know the HW, I can just provide some g

Re: [PATCH v4] mmc: meson: Add driver for the SD/MMC host found on Amlogic MesonX SoCs

2015-12-08 Thread Ulf Hansson
[...] > > I have actually a problem and a question related to this value. On the > boards I'm currently using to test this driver I have no CD GPIO. In > this case do I have to specify the MMC as "non-removable"? Also if I "non-removable" is intended to be used for eMMC or other cards (SD/SDIO)

Re: [PATCH] mmc: fix racy probe cleanup

2015-12-07 Thread Ulf Hansson
On 7 December 2015 at 12:15, Russell King wrote: > MMC probe cleanup is racy: consider the following sequence: > > - mmc_alloc_host() > - mmc_gpio_request_cd() > - some failure > - mmc_free_host() > > mmc_gpio_request_cd() registers a handler for the card detect GPIO

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

2015-12-07 Thread Ulf Hansson
+Linus On 7 December 2015 at 23:54, Tony Lindgren wrote: > Commit ce037275861e ("mmc: pwrseq_simple: use GPIO descriptors array API") > changed the handling MMC power sequence so GPIOs no longer are optional. > > This broke SDIO WLAN at least for omap5 that can't yet use the

Re: [PATCH] mmc: enable MMC/SD/SDIO device to suspend/resume asynchronously

2015-12-04 Thread Ulf Hansson
On 4 December 2015 at 14:05, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures > all power

Re: [PATCH v4] mmc: core: fix __mmc_switch timeout caused by preempt

2015-12-04 Thread Ulf Hansson
On 30 November 2015 at 02:27, Chaotian Jing wrote: > there is a time window between __mmc_send_status() and time_afer(), > on some eMMC chip, the timeout_ms is only 10ms, if this thread was > scheduled out during this period, then, even card has already changes > to

Re: [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags

2015-12-04 Thread Ulf Hansson
On 25 November 2015 at 19:26, Saurabh Sengar wrote: > If no primary handler is specified for threaded_irq then a > default one is assigned which always returns IRQ_WAKE_THREAD. > This handler requires the IRQF_ONESHOT, because the source of > interrupt is not disabled > >

Re: eMMC tuning fail issue

2015-12-02 Thread Ulf Hansson
[...] > > Do you receive any similar issue report on other eMMC vendor? > No. Although, that may be to that people don't report them. [...] > > > This code is active on all Chromebooks with eMMC without an issue, and the > eMMC spec doesn't require a delay here. So I don't think it can be a

[PATCH] mmc: core: Optimize boot time by detecting cards simultaneously

2015-12-01 Thread Ulf Hansson
the system_wq, is because we need card detection mechanism to be disabled once userspace are frozen during system PM. Currently the mmc core deal with this via PM notifiers, but following patches may utilize the behaviour of the system_freezable_wq, to simplify the use of the PM notifiers. Signed-off-by: Ulf

Re: [PATCH v3] mmc: core: fix __mmc_switch timeout caused by preempt

2015-11-27 Thread Ulf Hansson
On 27 November 2015 at 02:41, Chaotian Jing wrote: > there is a time window between __mmc_send_status() and time_afer(), > on some eMMC chip, the timeout_ms is only 10ms, if this thread was > scheduled out during this period, then, even card has already changes > to

Re: [PATCH 0/7] mmc: Some fixes

2015-11-27 Thread Ulf Hansson
On 26 November 2015 at 13:00, Adrian Hunter wrote: > Hi > > Here are some fixes. The important ones have cc: stable. > It doesn't matter to me whether you queue them as fixes > or for v4.5. > > > Adrian Hunter (6): > mmc: sdhci-pci: Do not default to 33 Ohm driver

Re: [PATCH 5/7] mmc: sdhc: Fix DMA descriptor with zero data length

2015-11-27 Thread Ulf Hansson
On 26 November 2015 at 13:00, Adrian Hunter wrote: > SDHCI has built-in DMA called ADMA2. ADMA2 uses a descriptor > table to define DMA scatter-gather. Each desciptor can specify > a data length up to 65536 bytes, however the length field is > only 16-bits so zero means

Re: [PATCH 3/7] mmc: sdhci: Do not BUG on invalid vdd

2015-11-27 Thread Ulf Hansson
On 27 November 2015 at 06:08, Venu Byravarasu <vbyravar...@nvidia.com> wrote: > > >> -Original Message- >> From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- >> ow...@vger.kernel.org] On Behalf Of Adrian Hunter >> Sent: Thursday, November 26, 2

Re: [PATCH] mmc: sdhci-of-at91: controller is suspended too early

2015-11-27 Thread Ulf Hansson
On 26 November 2015 at 17:41, Ludovic Desroches wrote: > When calling sdhci_add_host(), the controller is already suspended. It > causes to read 0 in registers. > Increment the device's usage counter before calling sdhci_add_host(), > decrement it after and put it in

Re: [PATCH v2] mmc: core: fix __mmc_switch timeout caused by preempt

2015-11-26 Thread Ulf Hansson
On 26 November 2015 at 13:36, Chaotian Jing wrote: > there is a time window between __mmc_send_status() and time_afer(), > on some eMMC chip, the timeout_ms is only 10ms, if this thread was > scheduled out during this period, then, even card has already changes > to

Re: [PATCH v2] mmc: core: Introduce MMC_CAP2_NO_SDIO cap

2015-11-26 Thread Ulf Hansson
On 25 November 2015 at 18:16, Carlo Caione <ca...@endlessm.com> wrote: > On Wed, Nov 25, 2015 at 5:34 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> On 25 November 2015 at 15:39, Carlo Caione <ca...@caione.org> wrote: >>> From: Carlo Caione <ca...@end

Re: [PATCH] mmc: core: fix __mmc_switch timeout caused by preempt

2015-11-26 Thread Ulf Hansson
On 26 November 2015 at 03:51, Chaotian Jing wrote: > there is a time window between __mmc_send_status() and time_afer(), > on some eMMC chip, the timeout_ms is only 10ms, if this thread was > scheduled out during this period, then, even card has already changes > to

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-26 Thread Ulf Hansson
On 26 November 2015 at 17:07, Ludovic Desroches <ludovic.desroc...@atmel.com> wrote: > On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: >> On 10 November 2015 at 11:36, Ludovic Desroches >> <ludovic.desroc...@atmel.com> wrote: >> > Add runtime PM s

Re: [PATCH v3] MMC/SDIO: enable SDIO device to suspend/resume asynchronously

2015-11-26 Thread Ulf Hansson
[...] >> >> Depending if you have SD/(e)MMC card slot(s), the below patch might >> affect your results. So it might be a good idea to re-run your test to >> get some fresh data. >> >> [PATCH 1/2] mmc: core: Make runtime resume default behavior for MMC/SD [3] > I didn't find this patch in mainline

Re: [PATCH 1/2] mmc: mvsdio: delete platform data header

2015-11-25 Thread Ulf Hansson
On 25 November 2015 at 14:57, Linus Walleij wrote: > This platform data struct is only used inside the MVSDIO driver, > nowhere else in the entire kernel. Move the struct into the > driver and delete the external header. > > Cc: Nicolas Pitre > Cc:

Re: [PATCH 2/2] mmc: mvsdio: delete platform data code path

2015-11-25 Thread Ulf Hansson
On 25 November 2015 at 14:57, Linus Walleij wrote: > There are no in-kernel users of the MVSDIO platform data method > (instantiating from a board file) so just delete this code and > make this a DT-only driver. We depend on OF and check that we have > an OF node in

Re: [PATCH] mmc: sdhci-of-esdhc: add/remove some quirks according to vendor version

2015-11-25 Thread Ulf Hansson
On 25 November 2015 at 03:05, Yangbo Lu wrote: > A previous patch had removed esdhc_of_platform_init() by mistake. > static void esdhc_of_platform_init(struct sdhci_host *host) > { > u32 vvn; > > vvn = in_be32(host->ioaddr + SDHCI_SLOT_INT_STATUS); >

Re: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

2015-11-25 Thread Ulf Hansson
[...] >> +sdhci_pic32_probe_dts(struct platform_device *pdev, >> + struct pic32_sdhci_pdata *boarddata) >> +{ >> + struct device_node *np = pdev->dev.of_node; >> + >> + if (!np) >> + return -ENODEV; >> + >> + if (of_find_property(np, "no-1-8-v",

Re: [PATCH 1/3] mmc: atmel-mci: move atmel-mci-regs.h content in atmel-mci.c

2015-11-25 Thread Ulf Hansson
On 23 November 2015 at 16:27, Ludovic Desroches wrote: > atmel-mci-regs.h is only included in atmel-mci.c so move its content in > the driver and do some cleanup in these definitions to remove checkpatch > errors. > > Signed-off-by: Ludovic Desroches

Re: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

2015-11-25 Thread Ulf Hansson
On 21 November 2015 at 01:17, Joshua Henderson wrote: > From: Andrei Pistirica > > This driver supports the SDHCI host controller found on the PIC32 in DMA > or PIO mode. > > Signed-off-by: Andrei Pistirica

Re: [PATCH 3/3] mmc: atmel-mci: atmci_convert_chksize depends on controller version

2015-11-25 Thread Ulf Hansson
On 23 November 2015 at 16:27, Ludovic Desroches wrote: > The atmci_convert_chksize() function is no more valid for controller > version 0x600 due to the introduction of '2 data' chunk size. > > Signed-off-by: Ludovic Desroches Thanks,

Re: [PATCH v2] mmc: core: Introduce MMC_CAP2_NO_SDIO cap

2015-11-25 Thread Ulf Hansson
On 25 November 2015 at 15:39, Carlo Caione wrote: > From: Carlo Caione > > This patch introduce a new MMC_CAP2_NO_SDIO cap used to tell the mmc > core to not send SDIO specific commands. I guess there are two reasons to why such capability is useful. 1) The

Re: [PATCH 2/3] MAINTAINERS: remove atmel-mci-regs.h file

2015-11-25 Thread Ulf Hansson
On 23 November 2015 at 16:27, Ludovic Desroches wrote: > Remove atmel-mci-regs.h file since it has been merged in atmel-mci.c. > > Signed-off-by: Ludovic Desroches Thanks, applied for next! Kind regards Uffe > --- > MAINTAINERS | 1 -

Re: [PATCH 3/3] mmc: core: Introduce MMC_CAP2_NO_SDIO cap

2015-11-25 Thread Ulf Hansson
On 25 November 2015 at 12:28, Carlo Caione wrote: > From: Carlo Caione > > This patch introduce a new MMC_CAP2_NO_SDIO cap used to tell the mmc > core to not send SDIO specific commands. > > Signed-off-by: Carlo Caione > --- >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
On 24 November 2015 at 10:23, Ludovic Desroches <ludovic.desroc...@atmel.com> wrote: > Hi Ulf, > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: >> On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > > [...] > >> > Now, this d

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
[...] >> > This one to not write an invalid voltage in the power control register >> > even if we have an external regulator for vmmc. >> > >> >> As I stated earlier, according to the SDHCI spec in the section for >> the Power Control Register. Bit 0 needs to be set when communicating >> with the

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
On 24 November 2015 at 14:12, Ludovic Desroches <ludovic.desroc...@atmel.com> wrote: > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: >> On 24 November 2015 at 10:23, Ludovic Desroches >> <ludovic.desroc...@atmel.com> wrote: >> > Hi Ulf, >>

Re: mmc card suspension problem

2015-11-20 Thread Ulf Hansson
On 19 November 2015 at 22:57, Renju Liu wrote: > Hi All, > > I'm currently studying the suspension behavior of MMC. However, I > don't quite understand the rationale why the kernel needs to wait > until timeout in the following code: That's because the eMMC spec states

Re: [PATCH 2/2] mmc: sdhci-esdhc-imx: correct the tuning-step setting

2015-11-20 Thread Ulf Hansson
On 19 November 2015 at 17:34, Dong Aisheng <donga...@gmail.com> wrote: > Hi Ulf, > > On Thu, Nov 19, 2015 at 7:20 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> On 10 November 2015 at 10:43, Haibo Chen <haibo.c...@freescale.com> wrote: >>> Here we u

Re: [PATCH] mmc: fix mmc_{un,}register_pm_notifier prototypes

2015-11-20 Thread Ulf Hansson
On 20 November 2015 at 11:28, Arnd Bergmann wrote: > The mmc pm notifiers were recently reworked, but the new > code produces a lot of warnings when CONFIG_PM_SLEEP is disabled: > > In file included from ../drivers/mmc/core/sdio_bus.c:27:0: > drivers/mmc/core/core.h:97:13: warning:

[GIT PULL] MMC fixes for v.4.4 rc2

2015-11-19 Thread Ulf Hansson
Hi Linus, Here are some mmc fixes intended for v4.4 rc2. It's based on a commit prior rc1 as I wanted to get them a bit more tested in next before sending you the pull request. Details are as usual found in the signed tag. Please pull this in! Kind regards Ulf Hansson The following changes

Re: [PATCH 1/2] mmc: sdhci-esdhc-imx: move the setting of watermark level out of probe

2015-11-19 Thread Ulf Hansson
On 10 November 2015 at 10:43, Haibo Chen wrote: > Currently, we config the watermark_level register only in probe. > This will cause the mmc write operation timeout issue after system > resume back in LPSR mode. Because in LPSR mode, after system resume > back, the

Re: [PATCH 2/2] mmc: sdhci-esdhc-imx: correct the tuning-step setting

2015-11-19 Thread Ulf Hansson
On 10 November 2015 at 10:43, Haibo Chen wrote: > Here we use '|=' to set the tuning-step, but before that, we should > clear the tuning-step, otherwise we could got the wrong setting. > > Signed-off-by: Haibo Chen > --- >

Re: [PATCH] mmc: sh_mmcif: Document r8a7793 DT bindings

2015-11-19 Thread Ulf Hansson
On 27 October 2015 at 17:56, Geert Uytterhoeven wrote: > From: Ulrich Hecht > > Signed-off-by: Ulrich Hecht > Acked-by: Simon Horman > [geert: Rebased] > Signed-off-by: Geert

Re: [PATCH V2] mmc: change to use kmalloc

2015-11-19 Thread Ulf Hansson
On 12 November 2015 at 12:27, yalin wang wrote: > Use kmalloc instead of kzalloc, zero the memory is not needed. > > Signed-off-by: yalin wang Thanks, applied for next! I took liberty to update the change log and the commit message header to

Re: [PATCH] mmc: pwrseq: constify mmc_pwrseq_ops structures

2015-11-19 Thread Ulf Hansson
On 14 November 2015 at 18:05, Julia Lawall wrote: > The mmc_pwrseq_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, applied for next! Kind regards Uffe > > ---

Re: [PATCH 05/19] mmc: core/host: enable support for the standard "wakeup-source" property

2015-11-19 Thread Ulf Hansson
d property "wakeup-source". > > This patch adds support for "wakeup-source" property in addition to the > existing "enable-sdio-wakeup" property. > > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: linux-m

Re: [PATCH 2/2] mmc: tegra: Add Tegra210 support

2015-11-19 Thread Ulf Hansson
On 16 November 2015 at 10:27, Thierry Reding wrote: > From: Thierry Reding > > Signed-off-by: Thierry Reding Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/sdhci-tegra.c | 17 + > 1 file

Re: [PATCH v2] mmc: kconfig: replace FAULT_INJECTION with FAULT_INJECTION_DEBUG_FS

2015-11-19 Thread Ulf Hansson
On 10 November 2015 at 20:12, Adrien Schildknecht wrote: > Fault-injection capability for MMC IO uses debugfs entries to configure > the attributes. > FAULT_INJECTION_DEBUG_FS must be enabled to use FAIL_MMC_REQUEST. > > Replace FAULT_INJECTION with

Re: [PATCH] mmc: core: set regulator not found message as debug

2015-11-19 Thread Ulf Hansson
On 9 November 2015 at 15:03, Ludovic Desroches wrote: > Turn the informative message about no vmmc/vqmmc regulator found in > debug one. There is no need to indicate that something optional is > missing. Moreover, it can bring confusion, people who doesn't know > it

Re: [PATCH v4] mmc: sdhci at91: add PM support

2015-11-19 Thread Ulf Hansson
On 11 November 2015 at 19:11, Ludovic Desroches wrote: > Add runtime PM support and use runtime_force_suspend|resume() for system > PM. > > Signed-off-by: Ludovic Desroches Thanks, applied for next! Kind regards Uffe > --- > > Changes:

Re: [PATCH] mmc: omap_hsmmc: No need to check DMA channel validity at module remove

2015-11-19 Thread Ulf Hansson
On 3 November 2015 at 12:37, Peter Ujfalusi <peter.ujfal...@ti.com> wrote: > The driver will not probe without valid DMA channels so no need to check > if they are valid when the module is removed. > > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> > CC: Ulf Hans

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

2015-11-18 Thread Ulf Hansson
On 18 November 2015 at 02:38, Stephen Boyd <sb...@codeaurora.org> wrote: > On 11/16, Ulf Hansson wrote: >> [...] >> >> >> > >> > In case you're wondering, the max frequency for sdc1 on 8974ac is >> > 400MHz. If it's just a plain 8974pro then t

  1   2   3   4   5   6   7   8   9   10   >