Re: [PATCH V2 16/16] mmc: omap_hsmmc: add a hardware reset before initialization

2011-05-06 Thread Varadarajan, Charulatha
Hi, On Fri, May 6, 2011 at 14:44, Adrian Hunter wrote: > After a warm restart, an eMMC which cannot be powered off is > in an unknown state, so reset it to be sure it will initialize. > > Signed-off-by: Adrian Hunter > --- >  drivers/mmc/host/omap_hsmmc.c |   38 +

Re: [PATCH V2 04/16] mmc: omap_hsmmc: reduce a bit the error handlers in probe()

2011-05-06 Thread Varadarajan, Charulatha
On Fri, May 6, 2011 at 14:44, Adrian Hunter wrote: > From: Andy Shevchenko > Add patch description here. > Signed-off-by: Andy Shevchenko > Signed-off-by: Adrian Hunter > --- >  drivers/mmc/host/omap_hsmmc.c |   17 ++--- >  1 files changed, 6 insertions(+), 11 deletions(-) > <> -

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-23 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala wrote: > Changes involves: > 1) Remove controller reset in devices.c which is taken care of >   by hwmod framework. > 2) Removing all base address macro defines except keeping one for OMAP2420. why? > 3) Using omap-device layer to registe

Re: [PATCH v3 4/5] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-23 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala wrote: > Add a device attribute to hwmod data of omap2430, omap3, omap4. > Currently the device attribute holds information regarding dual volt MMC card > support by the controller which will be later passed to the host driver via > platfor

Re: [PATCH v2 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-08 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 9, 2011 at 01:23, Kishore Kadiyala wrote: > Changes involves: > 1) Remove controller reset in devices.c which is taken care >   by hwmod framework. > 2) Removing all base address macro defines. > 3) Using omap-device layer to register device and utilizing data from >   hwmod

RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Varadarajan, Charulatha
> -Original Message- > From: kishore kadiyala [mailto:kishorek.kadiy...@gmail.com] > Sent: Friday, October 01, 2010 8:15 PM > To: Varadarajan, Charulatha > Cc: Samuel Ortiz; linux-mmc@vger.kernel.org; linux-o...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; t

RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Varadarajan, Charulatha
Kishore, <> A minor comment > +int twl6030_mmc_card_detect(struct device *dev, int slot) > +{ > + int ret = -EIO; > + u8 read_reg = 0; > + struct platform_device *pdev = to_platform_device(dev); > + > + if (pdev->id) { > + /* TWL6030 provide's Card detect support for

RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Varadarajan, Charulatha
<> > >> diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h > >> index 6de90bf..e64894c 100644 > >> --- a/include/linux/i2c/twl.h > >> +++ b/include/linux/i2c/twl.h > >> @@ -141,6 +141,16 @@ > >>  #define TWL6030_CHARGER_CTRL_INT_MASK  0x10 > >>  #de