s(-)
For all patches:
Acked-by: Viresh Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20 February 2014 16:29, Russell King - ARM Linux
wrote:
> I'll send a few patches in a moment. First through, I've just found this
> gem:
Yeah, 'gem' is the real word for this precious code :)
> static int sdhci_probe(struct platform_device *pdev)
> {
> ...
> sdhci = devm_kzalloc(&pd
Thanks for removing my ST email id from this mail, I was about to do that
this time :)
On 19 February 2014 16:20, Russell King - ARM Linux
wrote:
> On Wed, Feb 19, 2014 at 03:39:35PM +0530, Viresh Kumar wrote:
>> I didn't get that completely here.. sorry completely out of to
On 19 February 2014 15:22, Russell King - ARM Linux
wrote:
> Are you aware that power control to the card is part of the MMC/SD/SDIO
> spec - and part of the protocol talking to the card? Hence why the
> mmc layer has support for its control built-in.
Yeah, almost everything is part of the proto
On 19 February 2014 15:13, Russell King - ARM Linux
wrote:
> On Wed, Feb 19, 2014 at 11:43:19AM +0530, Viresh Kumar wrote:
>> Adding ST people as well who have access to boards and are working on SPEAr.
>>
>> On 18 February 2014 23:27, Russell King - ARM Linux
>
Adding ST people as well who have access to boards and are working on SPEAr.
On 18 February 2014 23:27, Russell King - ARM Linux
wrote:
> On Tue, Feb 18, 2014 at 03:09:38PM +, Russell King wrote:
>> There's no requirement to have the card tasklet separate now that we
>> have a threaded interr
rtion(+), 2 deletions(-)
Acked-by: Viresh Kumar
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12 September 2013 14:34, Sachin Kamat wrote:
> pdata could be NULL if cd_gpio = -1. Dereference pdata only
> if it is not NULL.
>
> Signed-off-by: Sachin Kamat
> Cc: Viresh Kumar
> ---
> Compile tested.
> Changes since v1:
> * Moved the pdata assignment inside if
On 12 September 2013 13:52, Sachin Kamat wrote:
> sdhci_probe only checks for IS_ERR. We would need to change it to
> IS_ERR_OR_NULL (which I do not prefer personally as there is some
> discussion for its removal). In that case we would need to return as I
> mentioned in my earlier email. Let me k
On 12 September 2013 13:48, Sachin Kamat wrote:
>>> 96 return ERR_PTR(-ENODATA);
>
> Wouldn't this be unconditional error return whether pdata is null or not?
Stupid me... I meant return pdata from this place..
Necessary checks are done in sdhci_probe()
--
To unsubscribe from this list: se
On 12 September 2013 13:41, Sachin Kamat wrote:
> Yes. That was my second option. If we do that we would get something as below:
>
> 84 /* If pdata is required */
> 85 if (cd_gpio != -1) {
> 86pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata),
> GFP_KERNEL);
> 87
On 12 September 2013 12:13, Sachin Kamat wrote:
> pdata could be NULL if cd_gpio = -1. Hence move the NULL check
> outside the if condition.
>
> Signed-off-by: Sachin Kamat
> Cc: Viresh Kumar
> ---
> Only compile tested.
> ---
> drivers/mmc/host/sdhci-spear.c
On Sat, Aug 31, 2013 at 12:11 PM, Axel Lin wrote:
> This patch refactors the code to use sdhci_pltfm_* APIs instead of open-coded.
>
> Signed-off-by: Axel Lin
> ---
> Hi Viresh,
> Looks like this driver can be converted to use sdhci_pltfm_* APIs instead of
> open-coded. I don't have this hardware
oaddr + SDHCI_INT_STATUS);
> if (scratch == (u32)-1)
> dead = 1;
Acked-by: Viresh Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
o Han
> ---
> drivers/mmc/host/sdhci-spear.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Viresh Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22 March 2013 22:56, Chris Ball wrote:
> On Mon, Mar 18 2013, Viresh Kumar wrote:
>
> /home/cjb/git/mmc/drivers/mmc/core/core.c: In function
> ‘mmc_schedule_delayed_work’:
> /home/cjb/git/mmc/drivers/mmc/core/core.c:88:2: error: implicit declaration
) non-idle cpu
(non-idle from schedulers perspective). If the current cpu is not idle or all
cpus are idle, work will be scheduled on local cpu.
Cc: Chris Ball
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Viresh Kumar
---
drivers/mmc/core/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
On 26 November 2012 20:39, Chris Ball wrote:
> On Thu, Nov 08 2012, Viresh Kumar wrote:
>> + ret = clk_set_rate(sdhci->clk, 5000);
>> + if (ret)
>> + dev_dbg(&pdev->dev, "Error setting desired clk, clk=%lu\n",
>> +
On 20 November 2012 12:11, Viresh Kumar wrote:
> On 8 November 2012 20:39, Viresh Kumar wrote:
>> From: Vipul Kumar Samar
>>
>> SPEAr sdhci driver expects the clock to be set to 50 MHz for proper
>> functioning.
>> This patch sets clk to 50 MHz in probe.
>&
On 8 November 2012 20:39, Viresh Kumar wrote:
> From: Vipul Kumar Samar
>
> SPEAr sdhci driver expects the clock to be set to 50 MHz for proper
> functioning.
> This patch sets clk to 50 MHz in probe.
>
> Signed-off-by: Vipul Kumar Samar
> Signed-off-by: Viresh Kumar
"
> Cc: Jarkko Lavinen
> Cc: Venkatraman S
> Cc: Viresh Kumar
> Cc: Guennadi Liakhovetski
> Cc: Ian Molton
> Cc: Bruce Chang
> Cc: Harald Welte
> Cc: Pierre Ossman
> Cc: linux-mmc@vger.kernel.org
> Cc: uclinux-dist-de...@blackfin.uclinux.org
> Cc: linux-o...@vger.k
On Mon, Nov 19, 2012 at 11:50 PM, Bill Pemberton wrote:
> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
> needed.
>
> Signed-off-by: Bill Pemberton
> Cc: Chris Ball
> Cc: "Michał Mirosław"
> Cc: Jarkko Lavinen
> Cc: Venkatraman S
clk_{un}prepare is mandatory for platforms using common clock framework. Because
for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones
in probe/remove.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
From: Vipul Kumar Samar
SPEAr sdhci driver expects the clock to be set to 50 MHz for proper functioning.
This patch sets clk to 50 MHz in probe.
Signed-off-by: Vipul Kumar Samar
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 5 +
1 file changed, 5 insertions(+)
diff
This adds simple DT bindings for SDHCI SPEAr controller. It uses cd-gpios from
common mmc bindings.
This also fixes spear300-evb.dts with correct name for card detect binding.
Signed-off-by: Viresh Kumar
---
V1->V2:
- Use cd-gpios instead of int-gpio as binding for card detect gpio.
-
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 10 +-
1 file changed, 5
On Fri, Sep 28, 2012 at 3:43 PM, Chris Ball wrote:
> I think now is a good time to get the DT bindings right instead of
> propagating previous hacks into the DT, and this should be a pretty
> simple change -- it's not even a code change, since the code for
> automatically handling a vmmc-supply ex
ead of underscores
Hi Chris,
I have fixed above two for now, please apply below if it looks fine to you:
From: Viresh Kumar
Date: Mon, 26 Mar 2012 15:05:14 +0530
Subject: [PATCH V2 1/2] mmc: sdhci-spear: add device tree bindings
This adds simple DT bindings for SDHCI SPEAr controller. It uses cd-
On Fri, Sep 28, 2012 at 2:33 PM, Chris Ball wrote:
> On Fri, Sep 28 2012, Viresh Kumar wrote:
>> +- reg : Address range of the sdhci
>> +- interrupt-parent: Should be the phandle for the interrupt controller
>> + that services interrupts for this device
>> +- interrup
This adds simple DT bindings for SDHCI SPEAr controller. It uses cd-gpios from
common mmc bindings.
This also fixes spear300-evb.dts with correct name for card detect binding.
Signed-off-by: Viresh Kumar
---
V1->resend:
- Use cd-gpios instead of int-gpio as binding for card detect gpio.
-
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 10 +-
1 file changed, 5
On 4/10/2012 3:06 PM, Viresh KUMAR wrote:
> On 3/27/2012 8:40 AM, Viresh KUMAR wrote:
>> > pdev is guaranteed to be valid in probe. And so check is not required to
>> > check
>> > if it is non-NULL. Remove it.
>> >
>> > Signed-off-by: Viresh Kum
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.
Signed-off-by: Viresh Kumar
---
V1->V2:
- Use clk_prepare_enable and clk_disable_unprepare
driv
On 4/17/2012 4:32 PM, Subhash Jadavani wrote:
> It's better to use clk_prepare_enable() helper function if you are doing
> enable immediately after prepare.
Sure. Will fix it.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 22 --
1
On 3/27/2012 8:40 AM, Viresh KUMAR wrote:
> pdev is guaranteed to be valid in probe. And so check is not required to check
> if it is non-NULL. Remove it.
>
> Signed-off-by: Viresh Kumar
Hi Chris,
Can you atleast apply first two patches of this set. Will rework patch 3/3 after
D
_UP(host->clkrate, 64);
> mmc->f_max = (mmc_has_26MHz()) ? 2600 : host->clkrate;
>
> pxamci_init_ocr(host);
Reviewed-by: Viresh Kumar
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/27/2012 9:49 PM, Arnd Bergmann wrote:
> These bindings came up in a discussion IRC today. I think it's rather bad that
> we can't agree on a common way to name the properties for mmc. We have
> bindings being proposed or already included from Anton, Stephen, Shawn,
> Rajendra, Viresh, Lee and
This patch replaces normal calls to resource allocation routines with devm_*()
derivative of those routines. This removes the need to free those resources
inside the driver.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 80 ++--
1 file
This adds simple DT bindings for SDHCI SPEAr controller.
Signed-off-by: Viresh Kumar
---
.../devicetree/bindings/mmc/sdhci-spear.txt| 29
drivers/mmc/host/sdhci-spear.c | 71 +++-
2 files changed, 98 insertions(+), 2 deletions(-)
create
pdev is guaranteed to be valid in probe. And so check is not required to check
if it is non-NULL. Remove it.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
From: Shiraz Hashim
Signed-off-by: Shiraz Hashim
---
drivers/mmc/host/sdhci-spear.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index b7f8b33..6dfa82e 100644
--- a/drivers/mmc/host/sdhci-spear.c
From: Rajeev KUMAR
The suspend and resume implementation is through dev_pm_ops in dmac. So
in order to support hibernation, freeze, thaw, restore and poweroff
features are required.
Signed-off-by: Rajeev Kumar
Acked-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |4
1 files changed, 4
.device_fc is added in struct dma_slave_config recently. All user drivers, which
want DMA to be the flow controller must pass this field as false. As earlier
driver don't look to use this feature, mark it false for now.
Signed-off-by: Viresh Kumar
Acked-by: Linus Walleij
---
drivers/mmc
There are few existing user drivers of dw_dmac. They will break as soon as we
remove unused fields from struct dw_dma_slave. This patch focuses to fix these
user drivers to use dma_slave_config() routine.
Signed-off-by: Viresh Kumar
---
arch/avr32/mach-at32ap/at32ap700x.c | 13
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac_regs.h | 12
include/linux/dw_dmac.h| 38 --
2 files changed, 12 insertions(+), 38 deletions(-)
diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h
index 2005d30
these drivers.
Perhaps, this should be a part of struct dma_slave_config. This patch adds
another field device_fc to this structure. User drivers must pass this as true
if they want to be flow controller of certain transfers.
Signed-off-by: Viresh Kumar
Acked-by: Linus Walleij
---
include
-by: Viresh Kumar
---
drivers/dma/dw_dmac.c | 49 +++--
1 files changed, 31 insertions(+), 18 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 5d7b199..49d477c 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
Use already defined function dev_get_platdata() instead of accessing
pdev->dev.data.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 1577394..f3aecb3 100644
--
64 bit transfers are possible on both sides in slave transfers (memory as well
as peripherals). This patch adds support for it memory side 64 bit transfers.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c | 20
1 files changed, 16 insertions(+), 4 deletions(-)
diff
Block interrupts give interrupt on completion of every LLI, which is actually
too much interrupts. This is just not required for current functioning of
dw_dmac.
So, just don't handle them at all.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |
This patch adds support for DMA_SLAVE_CONFIG in dwc DMAC controller. Fields in
struct dw_dma_slave for passing similar data are preserved in this patch untill
all existing users are fixed.
That will be handled later in this patchset.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c
Total number of channels is passed in pdata->nr_channels variable, thus we must
not use magic number '7' for total number of channels.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dw_dma
Flow controller information is passed now from DMA_SLAVE_CONFIG option. This
patch makes changes in pl08x driver to use device_fc from it instead of platform
data.
Signed-off-by: Viresh Kumar
Acked-by: Linus Walleij
---
drivers/dma/amba-pl08x.c |4 +++-
include/linux/amba/pl08x.h |8
:
commit
3506c0d507144d9b0f19efd5a56d289f70611179
Author: Tushar Behera
Date: Tue Dec 6 16:15:54 2011 +0530
DMA: PL330: Remove pm_runtime_xxx
calls from pl330 probe/remove
Rajeev KUMAR (1):
dmaengine/dw_dmac: Hibernation support in dw_dmac
Viresh Kumar (11):
dmaengine
xx_uart_device = {
> - .dev = {
> - .init_name = "uart",
> - },
> - .res = {
> - .start = SPEAR3XX_ICM1_UART_BASE,
> - .end = SPEAR3XX_ICM1_UART_BASE + SZ_4K - 1,
> - .flags = IORESOURCE_MEM,
> - },
> - .irq =
RESOURCE_MEM,
> },
> - .irq = {IRQ_BASIC_GPIO, NO_IRQ},
> + .irq = {IRQ_BASIC_GPIO},
> }, {
> .dev = {
> .init_name = "gpio2",
> @@ -95,7 +95,7 @@ struct amba_device gpio_device[] = {
>
From: Rajeev KUMAR
The suspend and resume implementation is through dev_pm_ops in dmac. So
in order to support hibernation, freeze, thaw, restore and poweroff
features are required.
Signed-off-by: Rajeev Kumar
Acked-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |4
1 files changed, 4
.device_fc is added in struct dma_slave_config recently. All user drivers, which
want DMA to be the flow controller must pass this field as false. As earlier
driver don't look to use this feature, mark it false for now.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/mmci.c |
Flow controller information is passed now from DMA_SLAVE_CONFIG option. This
patch makes changes in pl08x driver to use device_fc from it instead of platform
data.
Signed-off-by: Viresh Kumar
---
drivers/dma/amba-pl08x.c |4 +++-
include/linux/amba/pl08x.h |8
2 files changed
2011 +0530
DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove
Rajeev KUMAR (1):
dmaengine/dw_dmac: Hibernation support in dw_dmac
Viresh Kumar (11):
dmaengine: Add flow controller information to dma_slave_config
dmaengine: Pass dma_slave_config .device_fc = NULL for
Block interrupts give interrupt on completion of every LLI, which is actually
too much interrupts. This is just not required for current functioning of
dw_dmac.
So, just don't handle them at all.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |
these drivers.
Perhaps, this should be a part of struct dma_slave_config. This patch adds
another field device_fc to this structure. User drivers must pass this as true
if they want to be flow controller of certain transfers.
Signed-off-by: Viresh Kumar
---
include/linux/dmaengine.h |5
individual descriptors will
contain their individual lengths. Finally, we will call unmap for all
descriptors.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c | 49 +++--
1 files changed, 31 insertions(+), 18 deletions(-)
diff --git a/drivers/dma
This patch adds support for DMA_SLAVE_CONFIG in dwc DMAC controller. Fields in
struct dw_dma_slave for passing similar data are preserved in this patch untill
all existing users are fixed.
That will be handled later in this patchset.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c
Total number of channels is passed in pdata->nr_channels variable, thus we must
not use magic number '7' for total number of channels.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dw_dma
There are few existing user drivers of dw_dmac. They will break as soon as we
remove unused fields from struct dw_dma_slave. This patch focuses to fix these
user drivers to use dma_slave_config() routine.
Signed-off-by: Viresh Kumar
---
arch/avr32/mach-at32ap/at32ap700x.c | 13
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac_regs.h | 12
include/linux/dw_dmac.h| 38 --
2 files changed, 12 insertions(+), 38 deletions(-)
diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h
index 2005d30
64 bit transfers are possible on both sides in slave transfers (memory as well
as peripherals). This patch adds support for it memory side 64 bit transfers.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c | 20
1 files changed, 16 insertions(+), 4 deletions(-)
diff
Use already defined function dev_get_platdata() instead of accessing
pdev->dev.data.
Signed-off-by: Viresh Kumar
---
drivers/dma/dw_dmac.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 1577394..f3aecb3 100644
--
With the inclusion of following patch:
"mmc: sdhci: remove "state" argument from sdhci_suspend_host"
we get a compilation error for sdhci-spear:
drivers/mmc/host/sdhci-spear.c:283:2: error: too many arguments to function
‘sdhci_suspend_host’
This patch fixes this error.
S
On Sat, Nov 26, 2011 at 10:25 AM, Axel Lin wrote:
> This patch converts the drivers in drivers/mmc/host/* to use the
> module_platform_driver() macro which makes the code smaller and a bit
> simpler.
>
> Cc: "Michał Mirosław"
> Cc: David Brown
> Cc: Ben Dooks
>
Suspend/Resume is missing from sdhci-spear driver. This patch adds support for
suspend/resume for this driver.
Signed-off-by: Viresh Kumar
---
Changes in V2:
- support for clk enable/disable is added in suspend/resume
drivers/mmc/host/sdhci-spear.c | 40
On 11/15/2011 2:06 PM, Viresh KUMAR wrote:
> +#ifdef CONFIG_PM
> +static int sdhci_suspend(struct device *dev)
> +{
> + struct sdhci_host *host = dev_get_drvdata(dev);
> + pm_message_t state = {.event = 0};
> +
> + return sdhci_suspend_host(host, state);
Chris,
Suspend/Resume is missing from sdhci-spear driver. This patch adds support for
suspend/resume for this driver.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci
On 11/15/2011 12:27 PM, Dong, Chuanxiao wrote:
> Hi Viresh,
> I also meet the hang issue when suspending a system with a mounted SD card.
> Actually it caused by a dead lock of mmc_claim_host. Maybe we faced the same
> issue.
> So may be the two mails in the attachment can help you.
Hi Dong,
Yo
On 11/12/2011 8:54 AM, Chris Ball wrote:
> On Fri, Nov 11 2011, Viresh Kumar wrote:
>> > Controller specific suspend/resume are still not called, so i think it
>> > might
>> > be related to core code. I am using 2.6.37 kernel version.
>> >
>> > An
Hi,
I am working with sdhci-spear.c driver on SPEAr SoC.
When i suspend the system, with card inserted, the system hangs, and after
2 minutes i get following log:
root@10.199.15.17:~# rtcwake -s 5 -m standby
rtcwake: wakeup from "standby" using /dev/rtc0 at Sat Nov 12 12:14:13 2011
PM: Syncing
Currently if card_power_gpio is passed from platform data, it is acquired and
its value is either set or reset. After that its value is written 1, which is
not required.
So, this patch removes this extra line while sets its value.
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c
m bit new to LKML and i don't know if i should send the patch again
with signed-off or simply send a signed-off: in a similar way as we send
Acked-by:. Please tell me if i need to resend patch.
> From: Viresh Kumar
> Date: Tue, 4 Jan 2011 12:55:14 -0500
> Subject: [PATCH] mmc: regis
Hello,
I am using mmc_test.c driver present in drivers/mmc/test.c
Whenever i insert my card after booting linux i get this error:
"mmc_test mmc0:0001: Can't create file. Perhaps debugfs is disabled"
I debugged a bit and found something strange. In file drivers/mmc/core/bus.c
following code is pr
Hello,
I am using sdhci & sdhci-spear drivers for arasan SDIO controller
present on ST SPEAr platform.
When i use MMC card, everything works fine and i am able to read/write
from card.
But when i use SD or MicroSD cards, then during initialization, CMD51
fails, read scr, i get error. (Data CRC).
Hello,
We have ARASAN SDHCI controller in SPEAr1300, and using sdhci.c
and sdhci-spear.c drivers.
When we insert MMC card then it works fine, we are able to run
mmc_test on it. But when we insert SD or MicroSD card then we get
-84 error and it was due to DATA CRC Error Interrupt.
I have also trie
This patch is a incremental patch over V1 of sdhci-spear patch.
It contains following changes from V1:
- dev_get_platdata is used to get dev->platform_data
Signed-off-by: Viresh Kumar
---
drivers/mmc/host/sdhci-spear.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
d
On Thu, May 20, 2010 at 4:42 PM, Andrew Morton
wrote:
> On Thu, 20 May 2010 11:03:28 +0530 Viresh KUMAR wrote:
>
>> On 5/20/2010 2:40 AM, Andrew Morton wrote:
>> > On Wed, 5 May 2010 15:05:18 +0530
>> > Viresh KUMAR wrote:
>> >
>> >> This patc
On 5/20/2010 2:40 AM, Andrew Morton wrote:
> On Wed, 5 May 2010 15:05:18 +0530
> Viresh KUMAR wrote:
>
>> This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
>>
>
> Looks OK to my untrained eye. A few very minor things:
Andrew,
Should
On 5/20/2010 2:40 AM, Andrew Morton wrote:
> On Wed, 5 May 2010 15:05:18 +0530
> Viresh KUMAR wrote:
>
>> This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
>>
>
> Looks OK to my untrained eye. A few very minor things:
>
>&
On 5/5/2010 3:05 PM, Viresh KUMAR wrote:
> This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
>
> Signed-off-by: Viresh Kumar
> ---
> MAINTAINERS |6 +
> drivers/mmc/host/Kconfig| 12 ++
> drivers/mmc/host/
On 5/12/2010 10:58 AM, Viresh KUMAR wrote:
> On 5/10/2010 8:57 AM, Viresh KUMAR wrote:
>> On 5/5/2010 3:05 PM, Viresh KUMAR wrote:
>>> This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
>>>
>>> Signed-off-by: Vi
On 5/10/2010 8:57 AM, Viresh KUMAR wrote:
> On 5/5/2010 3:05 PM, Viresh KUMAR wrote:
>> This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
>>
>> Signed-off-by: Viresh Kumar
>> ---
>> MAINTAINERS |6 +
>>
On 5/5/2010 3:05 PM, Viresh KUMAR wrote:
> This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
>
> Signed-off-by: Viresh Kumar
> ---
> MAINTAINERS |6 +
> drivers/mmc/host/Kconfig| 12 ++
> drivers/mmc/host/
This patch adds glue layer for support of sdhci driver on ST SPEAr platform.
Signed-off-by: Viresh Kumar
---
MAINTAINERS |6 +
drivers/mmc/host/Kconfig| 12 ++
drivers/mmc/host/Makefile |1 +
drivers/mmc/host/sdhci-spear.c | 300
92 matches
Mail list logo
