Re: Help needed on an error during SD card enumeration

2013-01-21 Thread Kishore Kadiyala
Hi Shashidhar Hiremath, > > mmc0:host doesn't support card's voltages > set_ios invoked > Poweroff Done > > mmc0: error -22 whilst initializing SDIO card Could you check whether the MMC host controller regulator is configured properly. > eventhough I have inserted a SD card Which SD card you

Re: [PATCH] omap_hsmmc - use threaded irq handler for card-detect.

2011-12-29 Thread Kishore Kadiyala
k. > > Reviewed-by: Felipe Balbi > Tested-by: Grazvydas Ignotas > Signed-off-by: NeilBrown I have done some thing similar but didn't pushed it :-( Anyways Acked-by: Kishore Kadiyala > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index

Re: [PATCH 1/1] mmc: Check to disable IOCTL when card is mounted

2011-12-28 Thread Kishore Kadiyala
On Wed, Dec 28, 2011 at 5:46 AM, Shashidhar hiremath wrote: > From: Shashidhar Hiremath > > The Patch adds a check to disable the IOCTL from running when the card is > mounted > or device is opened elsewhere. > > Signed-off-by: Shashidhar Hiremath > --- >  drivers/mmc/card/block.c |    6 ++

Re: [PATCH] ARM: OMAP: hsmmc: add max_freq field

2011-12-22 Thread Kishore Kadiyala
On Wed, Dec 14, 2011 at 6:52 PM, Daniel Mack wrote: > External circuitry like level shifters may limit the maximum operation > speed of the hsmmc controller. Add a field to struct omap2_hsmmc_info > so boards can adjust the setting on demand. > > Signed-off-by: Daniel Mack > Cc: Tony Lindgren >

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-06 Thread Kishore Kadiyala
On Fri, Sep 2, 2011 at 12:35 AM, Venkatraman S wrote: > Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in > omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a > single location in post_req function, to prevent double unmapping. > > Signed-off-by: Venkatraman S > --- >  

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-07-22 Thread Kishore Kadiyala
> MMC1 is based on SDMMC1_VDDS whereas USBC1 is based on SIM_VDDS therefore > they can operate independently. > > Signed-off-by: Bryan Buckley Good catch, Acked-by: Kishore Kadiyala > --- >  arch/arm/mach-omap2/hsmmc.c |   12 >  1 files changed, 4 insertions(+),

Re: [PATCH] mmc: enable background operations for emmc4.41 with HPI support

2011-07-18 Thread Kishore Kadiyala
> How does BKOPS work with card power management ? On some controllers, > regulators are switched off in between transactions after some delay. > Wouldn't the card need power to do it's BKOPS ? AFAIK eMMC card has two voltages one for core rail and other for IO rail. Power Management is done wit

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Kishore Kadiyala
Hi Per, On Tue, Jun 21, 2011 at 12:21 PM, Per Forlin wrote: > On 21 June 2011 07:41, Kishore Kadiyala wrote: >> >> >>> + >>> +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request >>> *mrq, >>> +                            

Re: [PATCH v6 11/11] mmc: add handling for two parallel block requests in issue_rw_rq

2011-06-21 Thread Kishore Kadiyala
Hi Per, --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -108,6 +108,7 @@ static DEFINE_MUTEX(open_lock);  enum mmc_blk_status {        MMC_BLK_SUCCESS = 0, +       MMC_BLK_PARTIAL,        MMC_BLK_RETRY,        MMC_BLK_DATA_ERR,  

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-20 Thread Kishore Kadiyala
> + > +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request *mrq, > +                              bool is_first_req) I don't see the usage of "is_first_req" below. Is it required? > +{ > +       struct omap_hsmmc_host *host = mmc_priv(mmc); > + > +       if (mrq->data->host_

Re: [PATCH v6 11/11] mmc: add handling for two parallel block requests in issue_rw_rq

2011-06-20 Thread Kishore Kadiyala
On Mon, Jun 20, 2011 at 2:47 AM, Per Forlin wrote: > Change mmc_blk_issue_rw_rq() to become asynchronous. > The execution flow looks like this: > The mmc-queue calls issue_rw_rq(), which sends the request > to the host and returns back to the mmc-queue. The mmc-queue calls > issue_rw_rq() again wi

Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC

2011-05-31 Thread Kishore Kadiyala
tialising MMC card > > Signed-off-by: Balaji T K Tested-by: Kishore Kadiyala Acked-by: Kishore Kadiyala > --- >  arch/arm/mach-omap2/board-4430sdp.c   |    1 + >  arch/arm/mach-omap2/hsmmc.c           |    3 +++ >  arch/arm/mach-omap2/hsmmc.h           |    1 + >  arch/

Re: [PATCH 1/2] ARM: OMAP4: MMC: increase delay for pbias

2011-05-31 Thread Kishore Kadiyala
ias Voltage is not same as LDO" > > Signed-off-by: Balaji T K Acked-by: Kishore Kadiyala -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Dynamic MMC device naming vs. bootloaders

2011-04-06 Thread Kishore Kadiyala
On Wed, Apr 6, 2011 at 2:58 AM, Stephen Warren wrote: > Kishore Kadiyala wrote at Tuesday, April 05, 2011 12:38 AM: >> >> Hi Stephen, >> >> On Mon, Apr 4, 2011 at 11:09 PM, Stephen Warren wrote: >> > Chris et. al., >> > >> > I'm working

Re: Dynamic MMC device naming vs. bootloaders

2011-04-04 Thread Kishore Kadiyala
Hi Stephen, On Mon, Apr 4, 2011 at 11:09 PM, Stephen Warren wrote: > Chris et. al., > > I'm working on an ARM system that contains at least two MMC/SD devices; > specifically the board has an internal MMC device, and an SD card slot, > although the SoC has four MMC/SD hosts IIRC. > > The kernel's

Re: [patch 148/177] drivers/mmc/host/omap.c: use resource_size()

2011-03-23 Thread Kishore Kadiyala
On Wed, Mar 23, 2011 at 5:04 AM, wrote: > From: Chris Ball > > Signed-off-by: Chris Ball > Cc: Jarkko Lavinen > Cc: Tony Lindgren > Cc: > Signed-off-by: Andrew Morton Acked-by: Kishore Kadiyala > --- > >  drivers/mmc/host/omap.c |    6 +++--- >  1

Re: [patch 149/177] drivers/mmc/host/omap_hsmmc.c: use resource_size()

2011-03-23 Thread Kishore Kadiyala
On Wed, Mar 23, 2011 at 5:04 AM, wrote: > From: Chris Ball > > Use resource_size(). > > Signed-off-by: Chris Ball > Cc: Madhusudhan Chikkature > Cc: > Signed-off-by: Andrew Morton Feel free to add Acked-by: Kishore Kadiyala > --- > >  drivers/mmc/host

[PATCH v6 4/8] OMAP4: hwmod data: enable HSMMC

2011-02-28 Thread Kishore Kadiyala
From: Anand Gadiyar Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar Signed-off-by: Kishore Kadiyala Acked-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v6 2/8] OMAP2430: hwmod data: Add HSMMC

2011-02-28 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 148 1 files changed, 148 insertio

[PATCH v6 6/8] OMAP: hsmmc: Move mux configuration to hsmmc.c

2011-02-28 Thread Kishore Kadiyala
Moving the definition of mux setting API from devices.c to hsmmc.c and renaming it from "omap2_mmc_mux" to "omap_hsmmc_mux". Also calling "omap_hsmmc_mux" from omap2_hsmmc_init. Signed-off-by: Kishore Kadiyala Cc: Chris Ball slots[0].switch_pin > 0) && \

[PATCH v6 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-28 Thread Kishore Kadiyala
controller supports dual volt cards Signed-off-by: Paul Walmsley Signed-off-by: Kishore Kadiyala Reviewed-by: Balaji T K Cc: Benoit Cousson CC: Kevin Hilman Cc: Tony Lindgren --- arch/arm/mach-omap2/devices.c | 168 arch/arm/mach-omap2/hsmmc.c | 346

[PATCH v6 3/8] OMAP3: hwmod data: Add HSMMC

2011-02-28 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 209

[PATCH v6 0/8] OMAP: HSMMC: hwmod adaptation

2011-02-28 Thread Kishore Kadiyala
le HSMMC Kishore Kadiyala (4): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: hsmmc: Move mux configuration to hsmmc.c OMAP: adapt hsmmc to hwmod framework OMAP: hsmmc: Rename the device and driver Paul Walmsley (2): OMAP2430: hwmod data: Add HSMMC OMAP3: hwmod data: A

[PATCH v6 1/8] omap: mmc: split out init for 2420

2011-02-28 Thread Kishore Kadiyala
: Anand Gadiyar Signed-off-by: Kishore Kadiyala Cc: Tony Lindgren Cc: Madhusudhan Chikkature Cc: Chris Ball --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c | 88 + arch/arm/plat-omap/include/plat/mmc.h |4 ++ 3

[PATCH v6 5/8] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-28 Thread Kishore Kadiyala
Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller which will be later passed to the host driver via platform data. Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala

[PATCH v6 8/8] OMAP: hsmmc: Rename the device and driver

2011-02-28 Thread Kishore Kadiyala
Modifying the device & driver name from "mmci-omap-hs" to "omap_hsmmc". Signed-off-by: Kishore Kadiyala Acked-by: Benoit Cousson --- arch/arm/mach-omap2/board-2430sdp.c |2 +- arch/arm/mach-omap2/board-3430sdp.c |6 +++--- arch/arm/ma

[RESEND v5 PATCH 2/8] OMAP2430: hwmod data: Add HSMMC

2011-02-26 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. For testing OMAP2430SDP with hsmmc hwmod adaptation has dependency on 1) Pauls clock domain fix patch for hsmmc2 http://www.spinics.net/lists/linux-omap/msg47088.html 2) Balaji's regulator patch https://patchwork.k

[RESEND v5 PATCH 5/8] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-26 Thread Kishore Kadiyala
Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller which will be later passed to the host driver via platform data. Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala

[PATCH v5 3/8] OMAP3: hwmod data: Add HSMMC

2011-02-25 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 209

[PATCH v5 2/8] OMAP2430: hwmod data: Add HSMMC

2011-02-25 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 146 1 files changed, 146 insertio

[PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kishore Kadiyala
Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson CC: Kevin Hilman --- arch/arm/mach-omap2/devices.c | 168 arch/arm/mach-omap2/hsmmc.c | 343 ++-- arch/arm/plat-omap/include/plat/mmc.h | 20 +-- drivers/mmc/host/omap_hsmmc.c

[PATCH v5 6/8] OMAP: hsmmc: Move mux configuration to hsmmc.c

2011-02-25 Thread Kishore Kadiyala
Moving the definition of mux setting API from devices.c to hsmmc.c and renaming it from "omap2_mmc_mux" to "omap_hsmmc_mux". Also calling "omap_hsmmc_mux" from omap2_hsmmc_init. Signed-off-by: Kishore Kadiyala Cc: Chris Ball slots[0].switch_pin > 0) && \

[PATCH v5 4/8] OMAP4: hwmod data: enable HSMMC

2011-02-25 Thread Kishore Kadiyala
From: Anand Gadiyar Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar Signed-off-by: Kishore Kadiyala Acked-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v5 8/8] OMAP: hsmmc: Rename the device and driver

2011-02-25 Thread Kishore Kadiyala
Modifying the device & driver name from "mmci-omap-hs" to "omap_hsmmc". Signed-off-by: Kishore Kadiyala Acked-by: Benoit Cousson --- arch/arm/mach-omap2/board-2430sdp.c |2 +- arch/arm/mach-omap2/board-3430sdp.c |6 +++--- arch/arm/ma

[PATCH v5 5/8] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-25 Thread Kishore Kadiyala
Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller which will be later passed to the host driver via platform data. Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala

[PATCH v5 1/8] omap: mmc: split out init for 2420

2011-02-25 Thread Kishore Kadiyala
: Anand Gadiyar Signed-off-by: Kishore Kadiyala Cc: Tony Lindgren Cc: Madhusudhan Chikkature Cc: Chris Ball --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c | 88 + arch/arm/plat-omap/include/plat/mmc.h |4 ++ 3

[PATCH v5 0/8] OMAP: HSMMC: hwmod adaptation

2011-02-25 Thread Kishore Kadiyala
l Anand Gadiyar (2): omap: mmc: split out init for 2420 OMAP4: hwmod data: enable HSMMC Kishore Kadiyala (4): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: hsmmc: Move mux configuration to hsmmc.c OMAP: adapt hsmmc to hwmod framework OMAP: hsmmc: Rename the device and driv

[PATCH v4 6/6] OMAP: hsmmc: Rename the device and driver

2011-02-24 Thread Kishore Kadiyala
Modifying the device & driver name from "mmci-omap-hs" to "omap_hsmmc". Signed-off-by: Kishore Kadiyala Cc: Kevin Hilman Cc: Benoit Cousson Cc: Paul Walmsley Cc: Chris Ball --- arch/arm/mach-omap2/board-2430sdp.c |2 +- arch/arm/mach-omap2/board-3

[PATCH v4 2/6] OMAP3: hwmod data: Add HSMMC

2011-02-24 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 209

[PATCH v4 1/6] OMAP2430: hwmod data: Add HSMMC

2011-02-24 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 146 1 files changed, 146 insertio

[PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Kishore Kadiyala
Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson CC: Kevin Hilman --- arch/arm/mach-omap2/devices.c | 251 arch/arm/mach-omap2/hsmmc.c | 417 + arch/arm/plat-omap/include/plat/mmc.h | 20 +-- drivers/mmc/host/omap_hsmmc.c

[PATCH v4 4/6] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-24 Thread Kishore Kadiyala
Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller which will be later passed to the host driver via platform data. Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala Cc

[PATCH v4 0/6] OMAP: HSMMC: hwmod adaptation

2011-02-24 Thread Kishore Kadiyala
: enable HSMMC Kishore Kadiyala (2): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: adapt hsmmc to hwmod framework OMAP: hsmmc: Rename the device and driver Paul Walmsley (2): OMAP2430: hwmod data: Add HSMMC OMAP3: hwmod data: Add HSMMC arch/arm/mach-omap2/board-2

[PATCH v4 3/6] OMAP4: hwmod data: enable HSMMC

2011-02-24 Thread Kishore Kadiyala
From: Anand Gadiyar Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar Signed-off-by: Kishore Kadiyala Acked-by: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v3 1/5] OMAP2430: hwmod data: Add HSMMC

2011-02-23 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 146 1 files changed, 146 insertio

[PATCH v3 3/5] OMAP4: hwmod data: enable HSMMC

2011-02-23 Thread Kishore Kadiyala
From: Anand Gadiyar Enabling hsmmc hwmod for OMAP4 Signed-off-by: Anand Gadiyar Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson Cc: Paul Walmsley CC: Kevin Hilman --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v3 2/5] OMAP3: hwmod data: Add HSMMC

2011-02-23 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 209

[PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-23 Thread Kishore Kadiyala
number, Irq_number, device attribute. Signed-off-by: Paul Walmsley Signed-off-by: Kishore Kadiyala Cc: Benoit Cousson CC: Kevin Hilman --- arch/arm/mach-omap2/devices.c | 251 - arch/arm/mach-omap2/hsmmc.c | 153 ++-- arch

[PATCH v3 4/5] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-23 Thread Kishore Kadiyala
Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller which will be later passed to the host driver via platform data. Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala Cc

[PATCH v3 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-23 Thread Kishore Kadiyala
.net/lists/linux-omap/msg45443.html V1: --- http://www.spinics.net/lists/linux-mmc/msg05689.html Anand Gadiyar (1): OMAP4: hwmod data: enable HSMMC Kishore Kadiyala (2): OMAP: hwmod data: Add dev_attr and use in the host driver OMAP: adapt hsmmc to hwmod framework Paul Walmsley (2): OMAP

[PATCH] omap: mmc: split out init for 2420

2011-02-23 Thread Kishore Kadiyala
: Anand Gadiyar Signed-off-by: Kishore Kadiyala Cc: Tony Lindgren Cc: Madhusudhan Chikkature Cc: Chris Ball --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c | 88 + arch/arm/plat-omap/include/plat/mmc.h |4 ++ 3

[PATCH 1/6] omap: mmc: split out init for 2420

2011-02-23 Thread Kishore Kadiyala
: Anand Gadiyar Signed-off-by: Kishore Kadiyala Cc: Tony Lindgren Cc: Madhusudhan Chikkature Cc: Chris Ball --- arch/arm/mach-omap2/board-n8x0.c |2 +- arch/arm/mach-omap2/devices.c | 88 + arch/arm/plat-omap/include/plat/mmc.h |4 ++ 3

Re: [PATCH] omap: hsmmc: fix ocr mask usage

2011-02-21 Thread Kishore Kadiyala
esumes). > > Signed-off-by: Anand Gadiyar Tested this patch on OMAP4430SDP & OMAP4 Blaze. Tested-by: Kishore Kadiyala > Cc: Kishore Kadiyala > Cc: Tony Lindgren > Cc: Madhusudhan Chikkature > Cc: Chris Ball > --- > Tony, Chris, > > This is only a partia

[PATCH v2 4/5] OMAP4: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Benoit Cousson Update the omap4 hwmod data with the HSMMC info. Signed-off-by: Benoit Cousson Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339 1 files changed, 339 insertions(+), 0 deletions(-) diff --git a/arch/arm

[PATCH v2 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-08 Thread Kishore Kadiyala
P2430SDP validation, the patch series has dependency on https://patchwork.kernel.org/patch/538301/ Testing on N8x0 is pending due to unavailability of working ones. Will be thankful if some body test this series on N8x0. V1: --- http://www.spinics.net/lists/linux-mmc/msg05689.html Kishore Kadiyala (2):

[PATCH v2 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 221 arch/arm/mach

[PATCH v2 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL VOLT cards. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 80

[PATCH v2 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-08 Thread Kishore Kadiyala
attribute. 4) Update the driver to use dev_attr to find whether controller supports dual volt cards. 5) Moving "omap_mmc_add" api from plat-omap/devices.c to mach-omap1/devices.c Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap1/devices.c

[PATCH v2 2/5] OMAP2430: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. Also update the device attribute structure. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155 1 fil

[PATCH 2/5] OMAP2430: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap2430 hwmod data with the HSMMC info. Also update the device attribute structure. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155 1 fil

[PATCH 4/5] OMAP4: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Benoit Cousson Update the omap4 hwmod data with the HSMMC info. Signed-off-by: Benoit Cousson Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339 1 files changed, 339 insertions(+), 0 deletions(-) diff --git a/arch/arm

[PATCH 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Paul Walmsley Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley Signed-off-by: Kevin Hilman Signed-off-by: Rajendra Nayak Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 221 arch/arm/mach

[PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-02 Thread Kishore Kadiyala
attribute. 4) Update the driver to use dev_attr to find whether controller supports dual volt cards. 5) Moving "omap_mmc_add" api from plat-omap/devices.c to mach-omap1/devices.c Signed-off-by: Kevin Hilman Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap1/devices.c

[PATCH 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL VOLT cards. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 88

[PATCH 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-02 Thread Kishore Kadiyala
detected. Currently omap2_hsmmc_init call is missing in the board files, but updating it is not helping though. Investigation is under progress and any pointers on working version of MMC/SD on OMAP2420/2430 SDP would be helpful. Kishore Kadiyala (2): OMAP2420: hwmod data: Add HSMMC OMAP: devices

[PATCH 4/4] omap4: hsmmc: enable ADMA for MMC1 & MMC2

2011-01-18 Thread Kishore Kadiyala
Enable ADMA support for MMC1 & MMC2 controller on omap4 by updating "features" of struct omap_mmc_platform_data. Signed-off-by: Kishore Kadiyala Signed-off-by: Venkatraman S Reviewed-by: Sukumar Ghorai --- arch/arm/mach-omap2/hsmmc.c | 13 +++-- 1 files changed, 11 in

[PATCH 3/4] omap4: hsmmc: Adding ADMA support for MMC1 & MMC2 controllers

2011-01-18 Thread Kishore Kadiyala
tion [based on attributes]. Base address of Descriptor table in stored in MMCHS_ADMASAL register. Signed-off-by: Kishore Kadiyala Signed-off-by: Venkatraman S Signed-off-by: Santosh Shilimkar Reviewed-by: Sukumar Ghorai --- arch/arm/plat-omap/include/plat/mmc.h |1 + drivers/mmc/host/omap_hsm

[PATCH 1/4] omap: hsmmc: Rename use_dma to xfer_type and define possible transfers

2011-01-18 Thread Kishore Kadiyala
OMAP4 introduces dedicated internal DMA which is ADMA for its MMC controllers HSMMC1 & HSMMC2. Renaming "use_dma" member of the struct omap_hsmmc_host to "xfer_type" and defining the transfer modes PIO/SDMA/ADMA that can be used by the MMC controller. Signed-off-by: Kisho

[PATCH 2/4] omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup

2011-01-18 Thread Kishore Kadiyala
Renaming omap_hsmmc_dma_cleanup as omap_hsmmc_xfer_cleanup and doing some cleanup by handling the error & success scenarios during a transfer for different xfer_type. Signed-off-by: Kishore Kadiyala Reviewed-by: Sukumar Ghorai --- drivers/mmc/host/omap_hsmmc.c |

[PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-01-18 Thread Kishore Kadiyala
d on OMAP4430SDP & OMAP3430SDP. Kishore Kadiyala (4): omap: hsmmc: Rename use_dma to xfer_type and define possible transfers omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup omap4: hsmmc: Adding ADMA support for MMC1 & MMC2 controllers omap4: hsmmc: enable ADMA for MMC1 &

omap4: hsmmc: Fix improper card detection while booting

2010-11-15 Thread kishore kadiyala
the issue. Signed-off-by: Kishore Kadiyala Acked-by: Felipie Balbi Cc: Tony Lindgren Cc: Chris Ball Cc: Madhusudhan Chikkature --- drivers/mmc/host/omap_hsmmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-29 Thread Kishore Kadiyala
On Fri, Oct 29, 2010 at 2:21 AM, Ohad Ben-Cohen wrote: > On Thu, Oct 28, 2010 at 6:40 PM, Kishore Kadiyala > wrote: >> On Thu, Oct 28, 2010 at 9:43 PM, Nicolas Pitre wrote: >>> This is not clear that this is something that the core can effectively >>> help with.

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-28 Thread Kishore Kadiyala
On Thu, Oct 28, 2010 at 9:43 PM, Nicolas Pitre wrote: > On Thu, 28 Oct 2010, Ohad Ben-Cohen wrote: > >> On Thu, Oct 28, 2010 at 5:39 PM, Kishore Kadiyala >> wrote: >> > Wouldn't adapting the host driver just to PM-Runtime will answer the >> > above issu

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-28 Thread Kishore Kadiyala
On Thu, Oct 28, 2010 at 8:41 PM, Kishore Kadiyala wrote: > Nicolas, > > >> >>>    2.a) Card sleep, Power cutoff to the card: >>>      This should be handled in the core where based on block layer >>>      activity, calling corresponding API'

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-28 Thread Kishore Kadiyala
Nicolas, > >>    2.a) Card sleep, Power cutoff to the card: >>      This should be handled in the core where based on block layer >>      activity, calling corresponding API's from bus layer: >>      mmc_power_save_host/ mmc_power_restore_host > > Same issue here.  Card power is for the core to d

Re: [RFC] MMC: Proposals on reworking clock and power management

2010-10-27 Thread Kishore Kadiyala
On Wed, Oct 27, 2010 at 8:02 PM, Alan Cox wrote: >> 2. Ideally host-driver driver should not tell the core to shut down >>    the upper layers, instead the core should decide when to >>    "disabled clock or cut the power". > > How will the core know ? > > I actually think you are simply perpetuat

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-10-01 Thread kishore kadiyala
deviation of registers should be updated in the hsmmc driver. >> The omap-mmc platform data is updated with a register offset >> which will be updated and used in the driver accordingly. >> >> Signed-off-by: Kishore Kadiyala >> --- >>  arch/arm/mach-omap2/device

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
On Fri, Oct 1, 2010 at 8:11 PM, Varadarajan, Charulatha wrote: > > <> > >> >> diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h >> >> index 6de90bf..e64894c 100644 >> >> --- a/include/linux/i2c/twl.h >> >> +++ b/include/linux/i2c/twl.h >> >> @@ -141,6 +141,16

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
Samuel, Sorry , I will ensure to CC you for MFD related changes in future. Regards, Kishore On Fri, Oct 1, 2010 at 4:59 PM, Samuel Ortiz wrote: > On Fri, Oct 01, 2010 at 12:29:48PM +0530, kishore kadiyala wrote: >> Ping !! > Applied !! > > BTW, please add the full patch when

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-30 Thread kishore kadiyala
Ping !! On Wed, Sep 29, 2010 at 4:11 PM, kishore kadiyala wrote: > Gentle Reminder ! > > Regards, > Kishore > > On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala > wrote: >> Hi Samuel, >> >> Could you please review this patch which touches mfd/twl6030

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-29 Thread kishore kadiyala
Gentle Reminder ! Regards, Kishore On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala wrote: > Hi Samuel, > > Could you please review this patch which touches mfd/twl6030-irq.c for > card detect support > of MMC1 controller on OMAP4. > > Regards, > Kishore > > O

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Samuel, Could you please review this patch which touches mfd/twl6030-irq.c for card detect support of MMC1 controller on OMAP4. Regards, Kishore On Mon, Sep 27, 2010 at 1:25 PM, kishore kadiyala wrote: > Cc: Samuel Ortiz > > On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Cc: Samuel Ortiz On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala wrote: > Adding card detect callback function and card detect configuration > function for MMC1 Controller on OMAP4. > > Card detect configuration function does initial configuration of the > MMC Control &a

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Tony, On Sat, Sep 25, 2010 at 6:08 AM, Tony Lindgren wrote: > * kishore kadiyala [100924 10:05]: >> Adding card detect callback function and card detect configuration >> function for MMC1 Controller on OMAP4. >> >> Card detect configuration function does initial

[PATCH v4 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-24 Thread kishore kadiyala
-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |1 + drivers/mmc/host/omap_hsmmc.c | 12 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index 7978a79..8b0e71a 100644

[PATCH v4 3/4] omap4 hsmmc: Register offset handling

2010-09-24 Thread kishore kadiyala
n for current implementation as well as once the driver undergoes hwmod adaptation. Cc: Tony Lindgren Cc: Andrew Morton Cc: Madhusudhan Chikkature Cc: Adrian Hunter Cc: Benoit Cousson Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/devices.c |8 +++- arch/arm/mach-omap2/hs

[PATCH v4 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-24 Thread kishore kadiyala
From: Benoit Cousson Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Cc: Tony Lindgren Cc: Andrew Morton Cc: Madhusudhan Chikkature Cc: Adrian Hunter Signed-off-by: Benoit Cousson Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |8 +++- 1 files

[PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-24 Thread kishore kadiyala
is moved to the probe thus making it generic for both OMAP3 & OMAP4. Cc: Tony Lindgren Cc: Andrew Morton Cc: Madhusudhan Chikkature Cc: Adrian Hunter Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |7 +++- drivers/mfd/twl6030-irq.c

[PATCH v4 0/4] omap4 hsmmc: Card detect and Register offset handling

2010-09-24 Thread kishore kadiyala
-archive.com/linux-o...@vger.kernel.org/msg35135.html V1: http://www.mail-archive.com/linux-o...@vger.kernel.org/msg34040.html Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit

Re: [PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-24 Thread kishore kadiyala
Hi Hari, On Thu, Sep 23, 2010 at 11:22 AM, kishore kadiyala wrote: > Hi Hari, > > On Thu, Sep 23, 2010 at 1:19 AM, Kanigeri, Hari wrote: >> Kishore, >> >>> +int twl6030_mmc_card_detect(struct device *dev, int slot) >>> +{ >>> +     int ret = -

Re: [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-24 Thread kishore kadiyala
On Wed, Sep 22, 2010 at 11:35 PM, Sergei Shtylyov wrote: > Hello. > > kishore kadiyala wrote: > >> From: Benoit Cousson > >> Avoid possible crash if CONFIG_MMC_OMAP_HS is not set > >> Signed-off-by: Benoit Cousson >> Signed-off-by: Kishore Kadi

Re: [PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
Hi Hari, On Thu, Sep 23, 2010 at 1:19 AM, Kanigeri, Hari wrote: > Kishore, > >> +int twl6030_mmc_card_detect(struct device *dev, int slot) >> +{ >> +     int ret = -EIO; >> +     u8 read_reg = 0; >> +     struct platform_device *pdev = to_platform_device(dev); >> + >> +     switch (pdev->id) { >>

[PATCH v3 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-22 Thread kishore kadiyala
register, eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr mask and same will be communicated to core which will set the regulator to always operate at 3V when ever turned ON. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |1 + drivers

[PATCH v3 3/4] omap4 hsmmc: Register offset handling

2010-09-22 Thread kishore kadiyala
rrent implementation as well as once the driver undergoes hwmod adaptation. Cc: Kevin Hilman Cc: Benoit Cousson Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/devices.c |8 +++- arch/arm/mach-omap2/hsmmc.c |4 arch/arm/plat-omap/include/plat/mmc.h |

[PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
is moved to the probe thus making it generic for both OMAP3 & OMAP4. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |7 +++- drivers/mfd/twl6030-irq.c | 72 +++ drivers/mmc/host/omap_hsmmc.c |4 +- include/li

[PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-22 Thread kishore kadiyala
From: Benoit Cousson Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Signed-off-by: Benoit Cousson Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp.c

[PATCH v3 0/4] omap4 hsmmc: Card detect and Register offset handling

2010-09-22 Thread kishore kadiyala
-archive.com/linux-o...@vger.kernel.org/msg34040.html Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit Cousson (1); omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

Re: [PATCH v2 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
Hi balbi, On Wed, Sep 22, 2010 at 2:21 PM, Felipe Balbi wrote: > Hi, > > On Sat, Sep 18, 2010 at 11:33:56AM -0500, kishore kadiyala wrote: >> >> @@ -223,6 +224,81 @@ int twl6030_interrupt_mask(u8 bit_mask, u8 offset) >> } >> EXPORT_SYMBOL(tw

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-21 Thread kishore kadiyala
Hi Benoit, On Tue, Sep 21, 2010 at 2:26 AM, Cousson, Benoit wrote: > Hi Kishore > > On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote: >> >> The offset handling implementation of omap4 mmc registers which >> was already present can't be reused once hwmod modifications are done >> for mmc driver. >> S

[PATCH v2 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-18 Thread kishore kadiyala
, eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr mask and same will be communicated to core which will set the regulator to always operate at 3V when turned ON. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |1 + drivers/mmc/host

  1   2   >