Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
At Thu, 21 Apr 2011 13:36:03 -0400, Chris Ball wrote: > > Hi Takashi, > > On Thu, Apr 21 2011, Takashi Iwai wrote: > >> I don't like overwriting ops here -- it's too magical, and now we have > >> to maintain the ops table in two places. A quirk seems justified here, > >> even though we're trying

Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Chris Ball
Hi Takashi, On Thu, Apr 21 2011, Takashi Iwai wrote: >> I don't like overwriting ops here -- it's too magical, and now we have >> to maintain the ops table in two places. A quirk seems justified here, >> even though we're trying to reduce them in general. > > Well, I also used quirk bit in my ver

Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
At Thu, 21 Apr 2011 12:40:26 -0400, Chris Ball wrote: > > Hi Takashi, > > On Thu, Apr 21 2011, Takashi Iwai wrote: > > On HP laptops with JMicron 388 chip, the write-locked SD card isn't > > detected correctly as read-only in many cases. This is because the > > PRESENT_STATE register becomes uns

Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Chris Ball
Hi Takashi, On Thu, Apr 21 2011, Takashi Iwai wrote: > On HP laptops with JMicron 388 chip, the write-locked SD card isn't > detected correctly as read-only in many cases. This is because the > PRESENT_STATE register becomes unsable just after plugging, and it > returns the WRITE_PROTECT bit wron

[PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
On HP laptops with JMicron 388 chip, the write-locked SD card isn't detected correctly as read-only in many cases. This is because the PRESENT_STATE register becomes unsable just after plugging, and it returns the WRITE_PROTECT bit wrongly at the first read. This patch fixes the read-only detecti