Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-04-19 Thread Arnd Bergmann
On Tuesday 19 April 2011, Tony Olech wrote: > What is wrong in wanting to support non-technical users? > Especially since there are no backward compatible issues > involved at all. It's good to support non-technical users. Things that are bad about your patch are: * Have interfaces that work only

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-04-19 Thread Tony Olech
On Tue, 2011-04-19 at 14:10 +0200, Arnd Bergmann wrote: > On Tuesday 19 April 2011, Tony Olech wrote: > > The purpose of this read-only interface is for VUB300 support > > staff to obtain information from our customers. Our customers > > are not like the people on this list. If you have ever tried

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-04-19 Thread Arnd Bergmann
On Tuesday 19 April 2011, Tony Olech wrote: > The purpose of this read-only interface is for VUB300 support > staff to obtain information from our customers. Our customers > are not like the people on this list. If you have ever tried > to do telephone support you would appreciate the difficulty >

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-04-19 Thread Tony Olech
On Tue, 2011-03-15 at 17:23 +0100, Arnd Bergmann wrote: > On Thursday 10 March 2011, Tony Olech wrote: ... > > +static ssize_t __show_operating_mode(struct vub300_mmc_host *vub300, > > + struct mmc_host *mmc, char *buf) > > +{ > > + int usb_packet_size = vub3

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Tony Olech
see embedded answers:- On Tue, 2011-03-15 at 17:23 +0100, Arnd Bergmann wrote: > On Thursday 10 March 2011, Tony Olech wrote: > > Add a driver for Elan Digital System's VUB300 chip > > which is a USB connected SDIO/SDmem/MMC host controller. > > A VUB300 chip enables a USB 2.0 or USB 1.1 connect

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Arnd Bergmann
On Thursday 10 March 2011, Tony Olech wrote: > Add a driver for Elan Digital System's VUB300 chip > which is a USB connected SDIO/SDmem/MMC host controller. > A VUB300 chip enables a USB 2.0 or USB 1.1 connected host > computer to use SDIO/SD/MMC cards without the need for > a directly connected,

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Arnd Bergmann
On Tuesday 15 March 2011, Chris Ball wrote: > I thought about it, but I think staging drivers generally have a much > larger TODO list than this one would. > > Perhaps a good plan is: I'll push it to mmc-next after the 2.6.39 merge, > then I'll try to work on style changes a bit (I'll send each p

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Chris Ball
Hi Wolfram, On Tue, Mar 15 2011, Wolfram Sang wrote: >> I'm leaning towards merging it as-is and then >> working on incremental fixes; please yell if that sounds like a bad idea. > > What about staging? From my all overall impression, the driver would fit > there. > Also, there are more people lu

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-15 Thread Wolfram Sang
Hi, > linux-mmc@ folks, any strong opinions on this driver? My impression is > that it looks reasonable, but has some areas of being pretty far from > standard CodingStyle. I totally agree (sadly it is hard to review because of its size) and I am still not convinced of the sysfs-entry. Then agai

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission

2011-03-14 Thread Chris Ball
Hi, On Thu, Mar 10 2011, Tony Olech wrote: > Add a driver for Elan Digital System's VUB300 chip > which is a USB connected SDIO/SDmem/MMC host controller. > A VUB300 chip enables a USB 2.0 or USB 1.1 connected host > computer to use SDIO/SD/MMC cards without the need for > a directly connected, fo