Re: [PATCH] mmc: core: remove issue_fn indirect function call

2013-09-27 Thread Ulf Hansson
On 27 September 2013 00:16, Grant Grundler grund...@chromium.org wrote: On Thu, Sep 26, 2013 at 2:56 PM, Grant Grundler grund...@chromium.org wrote: On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball c...@laptop.org wrote: Hi, On Wed, Sep 25 2013, Chris Ball wrote: Hi, On Fri, Sep 20 2013, Ulf

Re: [PATCH] mmc: core: remove issue_fn indirect function call

2013-09-26 Thread Grant Grundler
On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball c...@laptop.org wrote: Hi, On Wed, Sep 25 2013, Chris Ball wrote: Hi, On Fri, Sep 20 2013, Ulf Hansson wrote: On 19 September 2013 19:20, Grant Grundler grund...@chromium.org wrote: struct mmc_queue defines issue_fn as an indirect function call.

Re: [PATCH] mmc: core: remove issue_fn indirect function call

2013-09-26 Thread Grant Grundler
On Thu, Sep 26, 2013 at 2:56 PM, Grant Grundler grund...@chromium.org wrote: On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball c...@laptop.org wrote: Hi, On Wed, Sep 25 2013, Chris Ball wrote: Hi, On Fri, Sep 20 2013, Ulf Hansson wrote: On 19 September 2013 19:20, Grant Grundler

Re: [PATCH] mmc: core: remove issue_fn indirect function call

2013-09-25 Thread Chris Ball
Hi, On Fri, Sep 20 2013, Ulf Hansson wrote: On 19 September 2013 19:20, Grant Grundler grund...@chromium.org wrote: struct mmc_queue defines issue_fn as an indirect function call. issue_fn field only gets set to mmc_blk_issue_rq and only gets invoked immediately after calling

Re: [PATCH] mmc: core: remove issue_fn indirect function call

2013-09-25 Thread Chris Ball
Hi, On Wed, Sep 25 2013, Chris Ball wrote: Hi, On Fri, Sep 20 2013, Ulf Hansson wrote: On 19 September 2013 19:20, Grant Grundler grund...@chromium.org wrote: struct mmc_queue defines issue_fn as an indirect function call. issue_fn field only gets set to mmc_blk_issue_rq and only gets

Re: [PATCH] mmc: core: remove issue_fn indirect function call

2013-09-20 Thread Ulf Hansson
On 19 September 2013 19:20, Grant Grundler grund...@chromium.org wrote: struct mmc_queue defines issue_fn as an indirect function call. issue_fn field only gets set to mmc_blk_issue_rq and only gets invoked immediately after calling blk_fetch_request(). Don't bother with indirect function call

[PATCH] mmc: core: remove issue_fn indirect function call

2013-09-19 Thread Grant Grundler
struct mmc_queue defines issue_fn as an indirect function call. issue_fn field only gets set to mmc_blk_issue_rq and only gets invoked immediately after calling blk_fetch_request(). Don't bother with indirect function call - it's pointless and just obfuscates the code. Signed-off-by: Grant