Re: [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL

2013-11-27 Thread Shawn Guo
On Wed, Nov 27, 2013 at 07:47:39AM +0100, Dirk Behme wrote: > >>>I'm wondering if it fixes any issue in real life? > > I wasn't aware that this questions blocks applying that patch. I > think I've answered Shawn's question in a private mail: Using RST_N > doesn't work if the controller's IPP_RST_N

Re: [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL

2013-11-26 Thread Dirk Behme
On 26.11.2013 22:22, Chris Ball wrote: Hi Dirk, On Fri, Nov 01 2013, Dirk Behme wrote: On 16.07.2013 09:38, Shawn Guo wrote: Hi Dirk, On Tue, Jul 16, 2013 at 08:36:11AM +0200, Dirk Behme wrote: In case of SDHCI_TIMEOUT_CONTROL write only 4 bits and not the whole byte to avoid touching other

Re: [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL

2013-11-26 Thread Chris Ball
Hi Dirk, On Fri, Nov 01 2013, Dirk Behme wrote: > On 16.07.2013 09:38, Shawn Guo wrote: >> Hi Dirk, >> >> On Tue, Jul 16, 2013 at 08:36:11AM +0200, Dirk Behme wrote: >>> In case of SDHCI_TIMEOUT_CONTROL write only 4 bits and not the >>> whole byte to avoid touching other unrelated bits in the i.MX

Re: [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL

2013-10-31 Thread Dirk Behme
On 16.07.2013 09:38, Shawn Guo wrote: Hi Dirk, On Tue, Jul 16, 2013 at 08:36:11AM +0200, Dirk Behme wrote: In case of SDHCI_TIMEOUT_CONTROL write only 4 bits and not the whole byte to avoid touching other unrelated bits in the i.MX6 SYS_CTRL register. E.g. IPP_RST_N shouldn't be touched acciden

Re: [PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL

2013-07-16 Thread Shawn Guo
Hi Dirk, On Tue, Jul 16, 2013 at 08:36:11AM +0200, Dirk Behme wrote: > In case of SDHCI_TIMEOUT_CONTROL write only 4 bits and not the > whole byte to avoid touching other unrelated bits in the i.MX6 > SYS_CTRL register. E.g. IPP_RST_N shouldn't be touched accidently. > > Signed-off-by: Dirk Behme

[PATCH] mmc: sdhci-esdhc-imx: Write only 4 bit in case of TIMEOUT_CONTROL

2013-07-15 Thread Dirk Behme
In case of SDHCI_TIMEOUT_CONTROL write only 4 bits and not the whole byte to avoid touching other unrelated bits in the i.MX6 SYS_CTRL register. E.g. IPP_RST_N shouldn't be touched accidently. Signed-off-by: Dirk Behme --- drivers/mmc/host/sdhci-esdhc-imx.c | 12 1 file changed, 12