Re: [PATCH 0/2] Race fixes in sdhci

2011-04-27 Thread Chris Ball
Hi Mark, On Wed, Apr 27 2011, Mark Brown wrote: > Ben Dooks (1): > MMC: SDHCI: Check mrq->cmd in sdhci_tasklet_finish > > Dimitris Papastamos (1): > MMC: SDHCI: Check mrq != NULL in sdhci_tasklet_finish Thanks. I've merged Ben's patch for .39, and also: From: Chris Ball Subject: [P

Re: [PATCH 0/2] Race fixes in sdhci

2011-04-27 Thread Mark Brown
On Wed, Apr 27, 2011 at 04:41:27PM -0400, Chris Ball wrote: > No, I think Mark's saying there's a race of: > * the successful completion interrupt fires, and > * the host timer fires to signify timeout due to *lack* of an interrupt > (via sdhci_timeout_timer()). i.e., the completion interrupt

Re: [PATCH 0/2] Race fixes in sdhci

2011-04-27 Thread Chris Ball
Hi, On Wed, Apr 27 2011, Andrei Warkentin wrote: > On Wed, Apr 27, 2011 at 8:23 AM, Mark Brown > wrote: >> I've had this pair of patches sitting in my tree for a while now (I >> believe they were previously posted) providing stability improvements in >> sdhci on my systems. Having looked through

Re: [PATCH 0/2] Race fixes in sdhci

2011-04-27 Thread Andrei Warkentin
On Wed, Apr 27, 2011 at 8:23 AM, Mark Brown wrote: > I've had this pair of patches sitting in my tree for a while now (I > believe they were previously posted) providing stability improvements in > sdhci on my systems.  Having looked through the code I believe but have > not confirmed that the iss

[PATCH 0/2] Race fixes in sdhci

2011-04-27 Thread Mark Brown
I've had this pair of patches sitting in my tree for a while now (I believe they were previously posted) providing stability improvements in sdhci on my systems. Having looked through the code I believe but have not confirmed that the issue is that the timeout is racing with an actual completion o