Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2012-04-11 Thread Shashidhar Hiremath
Hi Chris, Any updates on when this patch can be pushed ? On Thu, Jan 19, 2012 at 3:59 PM, Will Newton wrote: > On Tue, Jan 17, 2012 at 1:46 PM, Shashidhar Hiremath > wrote: >> Hi , >>  Any update on this patch ? > > I'm happy to see it merged based on those numbers. It might be worth > adding

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2012-01-19 Thread Shashidhar Hiremath
thanks James. Will add the Numbers to Commit Message On Thu, Jan 19, 2012 at 3:59 PM, Will Newton wrote: > On Tue, Jan 17, 2012 at 1:46 PM, Shashidhar Hiremath > wrote: >> Hi , >>  Any update on this patch ? > > I'm happy to see it merged based on those numbers. It might be worth > adding the

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2012-01-19 Thread Will Newton
On Tue, Jan 17, 2012 at 1:46 PM, Shashidhar Hiremath wrote: > Hi , >  Any update on this patch ? I'm happy to see it merged based on those numbers. It might be worth adding the numbers to the commit message for future reference though? Acked-by: Will Newton -- To unsubscribe from this list: sen

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2012-01-17 Thread Shashidhar Hiremath
Hi , Any update on this patch ? On Wed, Jan 11, 2012 at 4:57 PM, Shashidhar Hiremath wrote: > Hi James, >   Sorry for delay in getting the performance numbers since there was > some issue with the Hardware. > Even though the Dual Buffer Patch does not improve the performance > considerably for

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2012-01-11 Thread Shashidhar Hiremath
Hi James,   Sorry for delay in getting the performance numbers since there was some issue with the Hardware. Even though the Dual Buffer Patch does not improve the performance considerably for Read operations, but for the write operations, I found the improvement in speed of upto 200 KiB/s. Please

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-18 Thread James Hogan
Hi Shashidhar, On Mon, Nov 14, 2011 at 09:32:25PM +0530, Shashidhar Hiremath wrote: > Hi Will, > > Just following up since i did not see any response from you on my > earlier mail.. In previous mail, im not sure whether i gave you enough > context/background.. So here it goes (apologies in advanc

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-14 Thread Shashidhar Hiremath
Hi Will, Just following up since i did not see any response from you on my earlier mail.. In previous mail, im not sure whether i gave you enough context/background.. So here it goes (apologies in advance if this turns out to be a lengthy mail...): 1>At Vayavya Labs, our work is to make sure tha

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-04 Thread Shashidhar Hiremath
Hi Will, I agree with you that it should not be merged unless it improves the performance. But I still feel that there might be some reason for which the IP Vendor has provided an additional feature. So will this not be a good feature to have as it will help in IP Validation for different modes

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-03 Thread Jaehoon Chung
On 11/04/2011 12:18 AM, Will Newton wrote: > On Thu, Nov 3, 2011 at 12:35 PM, Chris Ball wrote: >> Hi, >> >> On Thu, Nov 03 2011, Shashidhar Hiremath wrote: >>> Hi Chris, >>> Can this patch be accepted by criteria that its an additional >>> feature supported by the hardware and hence good to ha

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-03 Thread Will Newton
On Thu, Nov 3, 2011 at 12:35 PM, Chris Ball wrote: > Hi, > > On Thu, Nov 03 2011, Shashidhar Hiremath wrote: >> Hi Chris, >>   Can this patch be accepted by criteria that its an additional >> feature supported by the hardware and hence good to have the support >> in the driver.Also note the patch

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-03 Thread Chris Ball
Hi, On Thu, Nov 03 2011, Shashidhar Hiremath wrote: > Hi Chris, > Can this patch be accepted by criteria that its an additional > feature supported by the hardware and hence good to have the support > in the driver.Also note the patch has been tested. I think Will and James should make the call

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-11-03 Thread Shashidhar Hiremath
Hi Chris, Can this patch be accepted by criteria that its an additional feature supported by the hardware and hence good to have the support in the driver.Also note the patch has been tested. On Wed, Oct 5, 2011 at 7:44 AM, Jaehoon Chung wrote: > Hi Shashidhar. > > I tested dual-buffer descript

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-10-04 Thread Jaehoon Chung
Hi Shashidhar. Ok..that's dependence with Hardware feature..right? no problem..it's working fine.. On 10/05/2011 01:54 PM, Shashidhar Hiremath wrote: > Hi Jaehoon, > First of all, thanks a lot for testing the patch. > I think you are right in saying that the patch does not increase the > perfo

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-10-04 Thread Shashidhar Hiremath
Hi Jaehoon, First of all, thanks a lot for testing the patch. I think you are right in saying that the patch does not increase the performance considerably. The reason I have added the patch is that this dual descriptor mode of operation can be validated by this and its a Hardware feature support

Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-10-04 Thread Jaehoon Chung
Hi Shashidhar. I tested dual-buffer descriptor with applied your patch. Actually, i didn't see to improve the performance. Dose it relate with the performance? i didn't sure.. And you used #ifdef CHAIN_DESC and #ifdef DUAL_BUFFER_DESC. I think if you use CHAIN_DESC by default, need not #ifdef CHA

[PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc

2011-09-27 Thread Shashidhar Hiremath
This Patch adds the support for Dual Buffer Descriptor mode of Operation for the dw_mmc driver.The patch also provides the configurability Option for choosing DUAL_BUFFER mode or the chained modes through menuconfig. The Menuconfig option for selecting Dual Buffer mode or chained mode is selected o