Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-05-11 Thread S, Venkatraman
On Wed, May 9, 2012 at 8:20 PM, Philip Rakity prak...@marvell.com wrote: On Apr 13, 2012, at 7:39 AM, Namjae Jeon wrote: Hi. Venkatraman. You fixed 10 times. why is it 10 times ? and checking err from mmc_send_status is not needed ? is it  also infinite case ? Thanks. 2012/4/13

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-05-09 Thread kdorfman
Hi, I see 2 fixes for existing mmc_interrupt_hpi() function: - [PATCH 4/4] mmc: core: Send HPI only till it is successful - [PATCH v2] mmc: core: Fix the HPI execution sequence They are exclusive. Can you explain how final solution will look like? Thanks, Kostya Try to send HPI only a fixed

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-05-09 Thread S, Venkatraman
On Wed, May 9, 2012 at 6:52 PM, kdorf...@codeaurora.org wrote: Hi, I see 2 fixes for existing mmc_interrupt_hpi() function: -  [PATCH 4/4] mmc: core: Send HPI only till it is successful -  [PATCH v2] mmc: core: Fix the HPI execution sequence They are exclusive. Can you explain how final

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-05-09 Thread Philip Rakity
On Apr 13, 2012, at 7:39 AM, Namjae Jeon wrote: Hi. Venkatraman. You fixed 10 times. why is it 10 times ? and checking err from mmc_send_status is not needed ? is it also infinite case ? Thanks. 2012/4/13 Venkatraman S svenk...@ti.com: Try to send HPI only a fixed number of times

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-18 Thread Chris Ball
Hi, On Fri, Apr 13 2012, Venkatraman S wrote: Try to send HPI only a fixed number of times till it is successful. One successful transfer is enough - but wait till the card comes out of transfer state. Return an error if the card was not in programming state to begin with - so that the

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-18 Thread S, Venkatraman
On Thu, Apr 19, 2012 at 9:59 AM, Chris Ball c...@laptop.org wrote: Hi, On Fri, Apr 13 2012, Venkatraman S wrote: Try to send HPI only a fixed number of times till it is successful. One successful transfer is enough - but wait till the card comes out of transfer state. Return an error if the

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-17 Thread S, Venkatraman
On Sun, Apr 15, 2012 at 8:40 PM, Jae hoon Chung jh80.ch...@gmail.com wrote: Hi Venkatraman 2012/4/14 Namjae Jeon linkinj...@gmail.com: 2012/4/14 S, Venkatraman svenk...@ti.com: On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon linkinj...@gmail.com wrote: Hi. Venkatraman. You fixed 10 times. why

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-15 Thread Jae hoon Chung
Hi Venkatraman 2012/4/14 Namjae Jeon linkinj...@gmail.com: 2012/4/14 S, Venkatraman svenk...@ti.com: On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon linkinj...@gmail.com wrote: Hi. Venkatraman. You fixed 10 times. why is it 10 times ? There's no right number - I haven't seen it fail much in my

[PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-13 Thread Venkatraman S
Try to send HPI only a fixed number of times till it is successful. One successful transfer is enough - but wait till the card comes out of transfer state. Return an error if the card was not in programming state to begin with - so that the caller knows that HPI was not sent. Reported-by: Alex

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-13 Thread Namjae Jeon
Hi. Venkatraman. You fixed 10 times. why is it 10 times ? and checking err from mmc_send_status is not needed ? is it also infinite case ? Thanks. 2012/4/13 Venkatraman S svenk...@ti.com: Try to send HPI only a fixed number of times till it is successful. One successful transfer is enough -

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-13 Thread S, Venkatraman
On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon linkinj...@gmail.com wrote: Hi. Venkatraman. You fixed 10 times. why is it 10 times ? There's no right number - I haven't seen it fail much in my tests but should allow a few retries. and checking err from mmc_send_status is not needed ? is it  

Re: [PATCH 4/4] mmc: core: Send HPI only till it is successful

2012-04-13 Thread Namjae Jeon
2012/4/14 S, Venkatraman svenk...@ti.com: On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon linkinj...@gmail.com wrote: Hi. Venkatraman. You fixed 10 times. why is it 10 times ? There's no right number - I haven't seen it fail much in my tests but should allow a few retries. Is there the reason