Re: [RESEND PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-23 Thread merez
Hi Jaehoon, I don't have additional comments. Thanks, Maya On Sun, July 22, 2012 6:28 pm, Jaehoon Chung wrote: > Hi Maya, > > On 07/20/2012 08:58 PM, me...@codeaurora.org wrote: >> >> On Thu, July 19, 2012 8:12 am, Jaehoon Chung wrote: >>> +void mmc_start_bkops(struct mmc_card *card, bool from_ex

Re: [RESEND PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-22 Thread Jaehoon Chung
Hi Maya, On 07/20/2012 08:58 PM, me...@codeaurora.org wrote: > > On Thu, July 19, 2012 8:12 am, Jaehoon Chung wrote: >> +void mmc_start_bkops(struct mmc_card *card, bool from_exception) >> +{ >> +int err; >> +int timeout; >> +bool use_busy_signal; >> + >> +BUG_ON(!

Re: [RESEND PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-20 Thread Adrian Hunter
On 20/07/12 14:58, me...@codeaurora.org wrote: > > On Thu, July 19, 2012 8:12 am, Jaehoon Chung wrote: >> +void mmc_start_bkops(struct mmc_card *card, bool from_exception) >> +{ >> +int err; >> +int timeout; >> +bool use_busy_signal; >> + >> +BUG_ON(!card); >> + >>

Re: [RESEND PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-20 Thread merez
On Thu, July 19, 2012 8:12 am, Jaehoon Chung wrote: > +void mmc_start_bkops(struct mmc_card *card, bool from_exception) > +{ > +int err; > +int timeout; > +bool use_busy_signal; > + > +BUG_ON(!card); > + > +if (!card->ext_csd.bkops_en || mmc_card_doing_bkops

[RESEND PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-19 Thread Jaehoon Chung
Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. Immediately run BKOPS if required. read/write operations should be requested during BKOPS(LEVEL-1), then issue HPI to interrupt the ongoing BKOPS and service the foreground op

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-18 Thread merez
>>> +void mmc_start_bkops(struct mmc_card *card) >>> +{ >>> + int err; >>> + int timeout; >>> + u8 use_busy_signal; >>> + >>> + BUG_ON(!card); >>> + if (!card->ext_csd.bkops_en || !(card->host->caps2 & MMC_CAP2_BKOPS)) >> >> Can you please explain why we need to have MMC_CAP2_BKOPS in ad

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Jaehoon Chung
On 07/18/2012 04:34 AM, me...@codeaurora.org wrote: > See my comments below. > >> +/** >> + * mmc_start_bkops - start BKOPS for supported cards >> + * @card: MMC card to start BKOPS >> + * >> + * Start background operations whenever requested. >> + * when the urgent BKOPS bit is set in a R1 co

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread merez
On Tue, July 17, 2012 11:16 pm, Adrian Hunter wrote: > On 17/07/12 15:58, Jaehoon Chung wrote: >> On 07/17/2012 09:30 PM, Adrian Hunter wrote: >>> On 17/07/12 05:44, Jaehoon Chung wrote: >>> >>> >>> +/** + *mmc_start_bkops - start BKOPS for supported cards + *@card:

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Adrian Hunter
On 17/07/12 15:58, Jaehoon Chung wrote: > On 07/17/2012 09:30 PM, Adrian Hunter wrote: >> On 17/07/12 05:44, Jaehoon Chung wrote: >> >> >> >>> +/** >>> + * mmc_start_bkops - start BKOPS for supported cards >>> + * @card: MMC card to start BKOPS >>> + * >>> + * Start background operations whenever

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread merez
See my comments below. > +/** > + * mmc_start_bkops - start BKOPS for supported cards > + * @card: MMC card to start BKOPS > + * > + * Start background operations whenever requested. > + * when the urgent BKOPS bit is set in a R1 command response > + * then background operations should b

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Jaehoon Chung
On 07/17/2012 09:30 PM, Adrian Hunter wrote: > On 17/07/12 05:44, Jaehoon Chung wrote: > > > >> +/** >> + * mmc_start_bkops - start BKOPS for supported cards >> + * @card: MMC card to start BKOPS >> + * >> + * Start background operations whenever requested. >> + * when the urgent BKOPS bit i

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Adrian Hunter
On 17/07/12 05:44, Jaehoon Chung wrote: > +/** > + * mmc_start_bkops - start BKOPS for supported cards > + * @card: MMC card to start BKOPS > + * > + * Start background operations whenever requested. > + * when the urgent BKOPS bit is set in a R1 command response > + * then background

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread Jaehoon Chung
Hi I will fix your comment and resend the patch. Thank you. Best Regards, Jaehoon Chung On 07/17/2012 06:25 PM, S, Venkatraman wrote: > Some minor nits.. > > On Tue, Jul 17, 2012 at 8:14 AM, Jaehoon Chung wrote: >> Enable eMMC background operations (BKOPS) feature. >> >> If URGENT_BKOPS is set

Re: [PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-17 Thread S, Venkatraman
Some minor nits.. On Tue, Jul 17, 2012 at 8:14 AM, Jaehoon Chung wrote: > Enable eMMC background operations (BKOPS) feature. > > If URGENT_BKOPS is set after a response, note that BKOPS > are required. After all I/O requests are finished, run > BKOPS if required. Should read/write operations be r

[PATCH v10] mmc: support BKOPS feature for eMMC

2012-07-16 Thread Jaehoon Chung
Enable eMMC background operations (BKOPS) feature. If URGENT_BKOPS is set after a response, note that BKOPS are required. After all I/O requests are finished, run BKOPS if required. Should read/write operations be requested during BKOPS, first issue HPI to interrupt the ongoing BKOPS and then serv