Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-05-10 Thread kdorfman
Hello, 2 comments (see inside): 1. About card state before sending HPI 2. About waiting after sending HPI On Wed, May 9, 2012 at 7:36 PM, kdorf...@codeaurora.org wrote: On Wed, May 9, 2012 at 6:47 PM,  kdorf...@codeaurora.org wrote: @@ -403,6 +403,7 @@ int mmc_interrupt_hpi(struct mmc_card

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-05-09 Thread kdorfman
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-05-09 Thread S, Venkatraman
On Wed, May 9, 2012 at 6:47 PM, kdorf...@codeaurora.org wrote: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-05-09 Thread kdorfman
On Wed, May 9, 2012 at 6:47 PM, kdorf...@codeaurora.org wrote: @@ -403,6 +403,7 @@ int mmc_interrupt_hpi(struct mmc_card *card)  {       int err;       u32 status; +     unsigned long starttime;       BUG_ON(!card); @@ -421,27 +422,31 @@ int mmc_interrupt_hpi(struct mmc_card *card)    

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-05-09 Thread S, Venkatraman
On Wed, May 9, 2012 at 7:36 PM, kdorf...@codeaurora.org wrote: On Wed, May 9, 2012 at 6:47 PM,  kdorf...@codeaurora.org wrote: @@ -403,6 +403,7 @@ int mmc_interrupt_hpi(struct mmc_card *card)  {       int err;       u32 status; +     unsigned long starttime;       BUG_ON(!card); @@

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-19 Thread Chris Ball
Hi, On Thu, Apr 19 2012, Venkatraman S wrote: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-19 Thread S, Venkatraman
On Thu, Apr 19, 2012 at 7:05 PM, Chris Ball c...@laptop.org wrote: Hi, On Thu, Apr 19 2012, Venkatraman S wrote: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on

[PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-19 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the end

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread S, Venkatraman
On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon linkinj...@gmail.com wrote: 2012/4/18 Jaehoon Chung jh80.ch...@samsung.com: On 04/18/2012 09:20 AM, Namjae Jeon wrote: 2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Jaehoon Chung
On 04/18/2012 05:42 PM, S, Venkatraman wrote: On Wed, Apr 18, 2012 at 1:53 PM, Namjae Jeon linkinj...@gmail.com wrote: 2012/4/18 S, Venkatraman svenk...@ti.com: On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon linkinj...@gmail.com wrote: 2012/4/18 Jaehoon Chung jh80.ch...@samsung.com: On

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread S, Venkatraman
On Wed, Apr 18, 2012 at 6:24 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 04/18/2012 05:42 PM, S, Venkatraman wrote: On Wed, Apr 18, 2012 at 1:53 PM, Namjae Jeon linkinj...@gmail.com wrote: 2012/4/18 S, Venkatraman svenk...@ti.com: On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon

[PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-18 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the end

[PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the end

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Namjae Jeon
2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Jaehoon Chung
On 04/18/2012 09:20 AM, Namjae Jeon wrote: 2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition

Re: [PATCH v2] mmc: core: Fix the HPI execution sequence

2012-04-17 Thread Namjae Jeon
2012/4/18 Jaehoon Chung jh80.ch...@samsung.com: On 04/18/2012 09:20 AM, Namjae Jeon wrote: 2012/4/17 Venkatraman S svenk...@ti.com: mmc_execute_hpi should send the HPI command only once, only if the card is in PRG state. According to eMMC spec, the command's completion time is not