Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-24 Thread Alim Akhtar
Hi Ulf, On Mon, Dec 22, 2014 at 8:11 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 20 December 2014 at 14:18, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-23 Thread Jaehoon Chung
Hi. Ulf. Your patch has bug.. If last sample value is failed, then it's returned with error. I will recommend this. how about? drivers/mmc/host/dw_mmc-exynos.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-23 Thread Jaehoon Chung
Hi. Ulf. change from success to error or other..:) sorry. And dw-mmc controller doesn't need to send stop command. it's not spec. I believe this changing is fixed tuning sequence's problem for dw-mmc. Best Regards, Jaehoon Chung On 12/23/2014 06:49 PM, Jaehoon Chung wrote: Hi. Ulf. Your

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-23 Thread Ulf Hansson
On 23 December 2014 at 10:49, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi. Ulf. Your patch has bug.. If last sample value is failed, then it's returned with error. I will recommend this. how about? drivers/mmc/host/dw_mmc-exynos.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-23 Thread Jaehoon Chung
Hi, Ulf. On 12/22/2014 11:41 PM, Ulf Hansson wrote: On 20 December 2014 at 14:18, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-22 Thread Ulf Hansson
On 20 December 2014 at 14:18, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-21 Thread Jaehoon Chung
Hi, Alim. On 12/20/2014 10:34 PM, Alim Akhtar wrote: Hi Jaehoon On Mon, Dec 15, 2014 at 10:18 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Alim. On 12/13/2014 12:13 AM, Jaehoon Chung wrote: Hi. On 12/10/2014 06:30 AM, Alim Akhtar wrote: Hi Ulf On Mon, Dec 8, 2014 at 3:40 PM,

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-20 Thread Alim Akhtar
Hi Ulf, On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Instead of having a local hack taking care of sending the

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-20 Thread Alim Akhtar
Hi Jaehoon On Mon, Dec 15, 2014 at 10:18 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Alim. On 12/13/2014 12:13 AM, Jaehoon Chung wrote: Hi. On 12/10/2014 06:30 AM, Alim Akhtar wrote: Hi Ulf On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-14 Thread Jaehoon Chung
Hi, Alim. On 12/13/2014 12:13 AM, Jaehoon Chung wrote: Hi. On 12/10/2014 06:30 AM, Alim Akhtar wrote: Hi Ulf On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Fri, Dec 5, 2014 at

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-12 Thread Jaehoon Chung
Hi. On 12/10/2014 06:30 AM, Alim Akhtar wrote: Hi Ulf On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Instead

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-09 Thread Alim Akhtar
Hi Ulf On Mon, Dec 8, 2014 at 3:40 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Instead of having a local hack taking care of sending the

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-08 Thread Ulf Hansson
On 6 December 2014 at 13:43, Alim Akhtar alim.akh...@gmail.com wrote: Hi Ulf, On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Instead of having a local hack taking care of sending the tuning command and as well to verify the response pattern, let's convert to the

Re: [PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-06 Thread Alim Akhtar
Hi Ulf, On Fri, Dec 5, 2014 at 5:29 PM, Ulf Hansson ulf.hans...@linaro.org wrote: Instead of having a local hack taking care of sending the tuning command and as well to verify the response pattern, let's convert to the common mmc_send_tuning() API. This change affects the Exynos variant,

[PATCH v2 3/4] mmc: dw_mmc: Convert to mmc_send_tuning()

2014-12-05 Thread Ulf Hansson
Instead of having a local hack taking care of sending the tuning command and as well to verify the response pattern, let's convert to the common mmc_send_tuning() API. This change affects the Exynos variant, since it's the only one which support the dw_mmc's -execute_tuning() callback.