Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-18 Thread John Calixto
On Mon, 18 Apr 2011, Arnd Bergmann wrote: > In v6, it seems you have implemented the full CMD passthrough, if I > read it correctly. Is there anything still missing? > Hi Arnd, As far as I have tested, the v6 patch does indeed have full CMD passthrough. John -- To unsubscribe from this list: se

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-18 Thread John Calixto
On Mon, 18 Apr 2011, Arnd Bergmann wrote: > On Wednesday 13 April 2011, John Calixto wrote: > > Gah! OK, so much for the v5 I just sent then. What do you think about > > the compat_ioctl that I sent in v2? It means having the extra 32-bit > > compat structure, but at least all the compat overhea

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-18 Thread Arnd Bergmann
On Wednesday 13 April 2011, John Calixto wrote: > > Since the code is limited to ACMD and cannot do arbitrary commands, it's > > actually > > not possible to use this for the passthrough scenario, so you should not > > mention > > it in the changelog. > > > > I would also still advocate somethin

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-18 Thread Arnd Bergmann
On Wednesday 13 April 2011, John Calixto wrote: > Gah! OK, so much for the v5 I just sent then. What do you think about > the compat_ioctl that I sent in v2? It means having the extra 32-bit > compat structure, but at least all the compat overhead is conditional > upon CONFIG_COMPAT. If you're

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-12 Thread John Calixto
Hi Arnd, On Wed, 13 Apr 2011, Arnd Bergmann wrote: > On Monday 11 April 2011, John Calixto wrote: > > Sending ACMDs from userspace is useful for such things as: > > > > - The security application of an SD card (SD Specification, Part 3, > > Security) > > > > - SD passthrough for vi

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-12 Thread Arnd Bergmann
On Monday 11 April 2011, John Calixto wrote: > Sending ACMDs from userspace is useful for such things as: > > - The security application of an SD card (SD Specification, Part 3, > Security) > > - SD passthrough for virtual machines > > Tested on TI PCIxx12 (SDHCI), Sigma Designs SM

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-12 Thread John Calixto
On Wed, 13 Apr 2011, Arnd Bergmann wrote: > On Tuesday 12 April 2011, Michał Mirosław wrote: > > > + unsigned int cmd_timeout_ms; > > > + __u64 data_ptr; /* DAT buffer */ > > > > This will be more natural if you have an anonymous union here: > > union { > > __u64 data_ptr_ > > void

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-12 Thread Arnd Bergmann
On Tuesday 12 April 2011, Michał Mirosław wrote: > > + unsigned int cmd_timeout_ms; > > + __u64 data_ptr; /* DAT buffer */ > > This will be more natural if you have an anonymous union here: > union { > __u64 data_ptr_ > void *data_ptr; > }; No, that really does not work. It's impo

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-12 Thread John Calixto
On Tue, 12 Apr 2011, Michał Mirosław wrote: > 2011/4/11 John Calixto : > [...] > > --- /dev/null > > +++ b/include/linux/mmc/ioctl.h > > @@ -0,0 +1,32 @@ > > +#ifndef _MMC_IOCTL_H > > +#define _MMC_IOCTL_H > > +struct mmc_ioc_cmd { > > +       /* implies direction of data.  true = write, false = re

Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-12 Thread Michał Mirosław
2011/4/11 John Calixto : [...] > --- /dev/null > +++ b/include/linux/mmc/ioctl.h > @@ -0,0 +1,32 @@ > +#ifndef _MMC_IOCTL_H > +#define _MMC_IOCTL_H > +struct mmc_ioc_cmd { > +       /* implies direction of data.  true = write, false = read */ > +       int write_flag; > + > +       __u32 opcode; >

[PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs

2011-04-11 Thread John Calixto
Sending ACMDs from userspace is useful for such things as: - The security application of an SD card (SD Specification, Part 3, Security) - SD passthrough for virtual machines Tested on TI PCIxx12 (SDHCI), Sigma Designs SMP8652 SoC, TI OMAP3621 SoC, TI OMAP3630 SoC, Samsung S5PC110