Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-23 Thread Peppe CAVALLARO
On 09/23/2010 11:51 AM, Wolfram Sang wrote: > >> static int mmc_pad_resources(struct sdhci_host *sdhci) >> { >> if (!devm_stm_pad_claim(sdhci->mmc->parent, >> &stx7108_mmc_pad_config, >> dev_name(sdhci->mmc->parent))) >>

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-23 Thread Wolfram Sang
> static int mmc_pad_resources(struct sdhci_host *sdhci) > { > if (!devm_stm_pad_claim(sdhci->mmc->parent, > &stx7108_mmc_pad_config, > dev_name(sdhci->mmc->parent))) > return -ENODEV; > > return 0; >

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-23 Thread Peppe CAVALLARO
On 09/23/2010 10:48 AM, Wolfram Sang wrote: > I think it will be better to give init() access to all information > needed than to implement another hook. I tried with this patch > > https://patchwork.kernel.org/patch/196992/ > > I am still not sure what kind of information you need from the pdev.

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-23 Thread Wolfram Sang
> >> 3) In the end, another hook could be added in the sdhci_pltfm_data to > >>invoke specific own functions for claiming resources etc. > >>For example, I need an extra callback to invoke the STM pad manager > >>that's used for managing clocks, PIO lines and syscfg registers. > >> > >>

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-22 Thread Peppe CAVALLARO
On 09/22/2010 04:35 PM, Peppe CAVALLARO wrote: > No it's not late but I need the dev structure from the platform_device. > We could add the "struct device dev;" in the sdhci_host structure > instead of. > In this case the sdhci_host should be moved within the new > include/linux/mmc/sdhci.h file. >

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-22 Thread Peppe CAVALLARO
On 09/22/2010 04:12 PM, Wolfram Sang wrote: > Hi Peppe, > >> 1) I've already a patch to add the suspend/resume in the sdhci_pltfm >>driver. Please note this is mandatory for me. > > Great, improvements to the generic pltfm-driver are most welcome! Good! I'm happy to contribute on it. I'll st

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-22 Thread Wolfram Sang
Hi Peppe, > 1) I've already a patch to add the suspend/resume in the sdhci_pltfm >driver. Please note this is mandatory for me. Great, improvements to the generic pltfm-driver are most welcome! >Note: I'd like to look at the wake-up on card that should be nice to >have in the future.

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-22 Thread Peppe CAVALLARO
On 09/21/2010 11:44 AM, Wolfram Sang wrote: > On Tue, Sep 21, 2010 at 11:21:48AM +0200, Peppe CAVALLARO wrote: >> On 09/20/2010 10:38 AM, Wolfram Sang wrote: >>> On Mon, Sep 20, 2010 at 10:20:17AM +0200, Giuseppe CAVALLARO wrote: This patch adds the Arasan MMC/SD/SDIO driver for the STM S

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-21 Thread Wolfram Sang
On Tue, Sep 21, 2010 at 11:21:48AM +0200, Peppe CAVALLARO wrote: > On 09/20/2010 10:38 AM, Wolfram Sang wrote: > > On Mon, Sep 20, 2010 at 10:20:17AM +0200, Giuseppe CAVALLARO wrote: > >> This patch adds the Arasan MMC/SD/SDIO driver > >> for the STM ST40 platforms. It is based on the > >> SDHCI dr

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-21 Thread Peppe CAVALLARO
On 09/20/2010 10:38 AM, Wolfram Sang wrote: > On Mon, Sep 20, 2010 at 10:20:17AM +0200, Giuseppe CAVALLARO wrote: >> This patch adds the Arasan MMC/SD/SDIO driver >> for the STM ST40 platforms. It is based on the >> SDHCI driver. >> It has been tested on the STx7106/STx7108/STx5289 >> platforms. >>

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-20 Thread Wolfram Sang
On Mon, Sep 20, 2010 at 10:20:17AM +0200, Giuseppe CAVALLARO wrote: > This patch adds the Arasan MMC/SD/SDIO driver > for the STM ST40 platforms. It is based on the > SDHCI driver. > It has been tested on the STx7106/STx7108/STx5289 > platforms. > > Signed-off-by: Giuseppe Cavallaro Looks to me

Re: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-09-20 Thread Peppe CAVALLARO
On 08/04/2010 10:03 AM, Matt Fleming wrote: > On Wed, Aug 04, 2010 at 07:47:21AM +0200, Peppe CAVALLARO wrote: > > > > Yes, we can do it. The driver will be merged next. It is not a problem > > for me ;-). > > Fantastic! > Hello Matt, Andrew, I've just reworked the driver removing the invocat

Re: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-04 Thread Matt Fleming
On Wed, Aug 04, 2010 at 07:47:21AM +0200, Peppe CAVALLARO wrote: > > Yes, we can do it. The driver will be merged next. It is not a problem > for me ;-). Fantastic! -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More m

RE: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-03 Thread Peppe CAVALLARO
Hi Andrew, > -Original Message- > From: Andrew Morton [mailto:a...@linux-foundation.org] > Sent: Wednesday, August 04, 2010 7:44 AM > To: Peppe CAVALLARO > Cc: Matt Fleming; linux-mmc@vger.kernel.org > Subject: Re: [PATCH] mmc: add SDHCI driver for STM platforms. >

Re: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-03 Thread Andrew Morton
inux-mmc@vger.kernel.org > > Subject: Re: [PATCH] mmc: add SDHCI driver for STM platforms. > > > > On Mon, 2 Aug 2010 15:36:31 +0100 > > Matt Fleming wrote: > > > > > > > What is devm_stm_pad_claim()? I can't find this function in linus' &g

RE: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-03 Thread Peppe CAVALLARO
Hi Andrew, > -Original Message- > From: Andrew Morton [mailto:a...@linux-foundation.org] > Sent: Wednesday, August 04, 2010 12:21 AM > To: Matt Fleming > Cc: Peppe CAVALLARO; linux-mmc@vger.kernel.org > Subject: Re: [PATCH] mmc: add SDHCI driver for STM platforms. >

Re: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-03 Thread Andrew Morton
On Mon, 2 Aug 2010 15:36:31 +0100 Matt Fleming wrote: > > > What is devm_stm_pad_claim()? I can't find this function in linus' > > > tree, or in -next, or in Andrew's -mm series. Where is this function > > > from? > > > > This comes from our STMicroelectronics platform pad management > > infrast

RE: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-02 Thread Peppe CAVALLARO
Hi Matt, > -Original Message- > From: Matt Fleming [mailto:m...@console-pimps.org] > Sent: Monday, August 02, 2010 4:37 PM > To: Peppe CAVALLARO > Cc: Andrew Morton; linux-mmc@vger.kernel.org > Subject: Re: [PATCH] mmc: add SDHCI driver for STM platforms. > > On

Re: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-08-02 Thread Matt Fleming
On Mon, Aug 02, 2010 at 04:03:30PM +0200, Peppe CAVALLARO wrote: > Hi Matt, > > > -Original Message- > > From: Matt Fleming [mailto:m...@console-pimps.org] > > Sent: Monday, August 02, 2010 3:41 PM > > To: Peppe CAVALLARO > > Cc: Andrew Morton >

RE: [PATCH] mmc: add SDHCI driver for STM platforms.

2010-07-30 Thread Peppe CAVALLARO
Hello! I wonder if somebody's had some spare moment to review this patch. Welcome advice and feedback as usual Many thanks in advance. Best Regards, Giuseppe > -Original Message- > From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com] > Sent: Thursday, July 29, 2010 10:31 AM > To: lin