RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-20 Thread DebBarma, Tarun Kanti
..@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; t...@atomide.com; a...@linux- > foundation.org; Chikkature Rajashekar, Madhusudhan; > adrian.hun...@nokia.com > Subject: Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for > MMC1 > > On Fri, Oct 1, 2010 at 8:

RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Varadarajan, Charulatha
...@atomide.com; a...@linux- > foundation.org; Chikkature Rajashekar, Madhusudhan; > adrian.hun...@nokia.com > Subject: Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for > MMC1 > > On Fri, Oct 1, 2010 at 8:11 PM, Varadarajan, Charulatha > wrote: > > >

RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Varadarajan, Charulatha
Kishore, <> A minor comment > +int twl6030_mmc_card_detect(struct device *dev, int slot) > +{ > + int ret = -EIO; > + u8 read_reg = 0; > + struct platform_device *pdev = to_platform_device(dev); > + > + if (pdev->id) { > + /* TWL6030 provide's Card detect support for

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
On Fri, Oct 1, 2010 at 8:11 PM, Varadarajan, Charulatha wrote: > > <> > >> >> diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h >> >> index 6de90bf..e64894c 100644 >> >> --- a/include/linux/i2c/twl.h >> >> +++ b/include/linux/i2c/twl.h >> >> @@ -141,6 +141,16

RE: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Varadarajan, Charulatha
<> > >> diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h > >> index 6de90bf..e64894c 100644 > >> --- a/include/linux/i2c/twl.h > >> +++ b/include/linux/i2c/twl.h > >> @@ -141,6 +141,16 @@ > >>  #define TWL6030_CHARGER_CTRL_INT_MASK  0x10 > >>  #de

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
Samuel, Sorry , I will ensure to CC you for MFD related changes in future. Regards, Kishore On Fri, Oct 1, 2010 at 4:59 PM, Samuel Ortiz wrote: > On Fri, Oct 01, 2010 at 12:29:48PM +0530, kishore kadiyala wrote: >> Ping !! > Applied !! > > BTW, please add the full patch when you cc me, so that

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread Samuel Ortiz
On Fri, Oct 01, 2010 at 12:29:48PM +0530, kishore kadiyala wrote: > Ping !! Applied !! BTW, please add the full patch when you cc me, so that I don't have to dig through patchwork to grab something I can git-am. Cheers, Samuel. > On Wed, Sep 29, 2010 at 4:11 PM, kishore kadiyala > wrote: > >

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-30 Thread kishore kadiyala
Ping !! On Wed, Sep 29, 2010 at 4:11 PM, kishore kadiyala wrote: > Gentle Reminder ! > > Regards, > Kishore > > On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala > wrote: >> Hi Samuel, >> >> Could you please review this patch which touches mfd/twl6030-irq.c for >> card detect support >> of MMC1

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-29 Thread kishore kadiyala
Gentle Reminder ! Regards, Kishore On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala wrote: > Hi Samuel, > > Could you please review this patch which touches mfd/twl6030-irq.c for > card detect support > of MMC1 controller on OMAP4. > > Regards, > Kishore > > On Mon, Sep 27, 2010 at 1:25 PM, ki

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Samuel, Could you please review this patch which touches mfd/twl6030-irq.c for card detect support of MMC1 controller on OMAP4. Regards, Kishore On Mon, Sep 27, 2010 at 1:25 PM, kishore kadiyala wrote: > Cc: Samuel Ortiz > > On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala > wrote: >> Ad

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Cc: Samuel Ortiz On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala wrote: > Adding card detect callback function and card detect configuration > function for MMC1 Controller on OMAP4. > > Card detect configuration function does initial configuration of the > MMC Control & PullUp-PullDown regist

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Tony, On Sat, Sep 25, 2010 at 6:08 AM, Tony Lindgren wrote: > * kishore kadiyala [100924 10:05]: >> Adding card detect callback function and card detect configuration >> function for MMC1 Controller on OMAP4. >> >> Card detect configuration function does initial configuration of the >> MMC Co

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-24 Thread Tony Lindgren
* kishore kadiyala [100924 10:05]: > Adding card detect callback function and card detect configuration > function for MMC1 Controller on OMAP4. > > Card detect configuration function does initial configuration of the > MMC Control & PullUp-PullDown registers of Phoenix. > > For MMC1 Controller,