Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-13 Thread Daniel Mack
Hi Grant, On 13.10.2012 02:05, Grant Likely wrote: Balaji T K balaj...@ti.com wrote: On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: On 12.10.2012 16:56, Balaji T K wrote: On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: diff --git

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-13 Thread Grant Likely
On Sat, Oct 13, 2012 at 9:05 AM, Daniel Mack zon...@gmail.com wrote: Hi Grant, On 13.10.2012 02:05, Grant Likely wrote: Balaji T K balaj...@ti.com wrote: On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: On 12.10.2012 16:56, Balaji T K wrote: On Friday 12 October 2012 07:59 PM,

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-13 Thread Daniel Mack
On 13.10.2012 10:48, Grant Likely wrote: On Sat, Oct 13, 2012 at 9:05 AM, Daniel Mack zon...@gmail.com wrote: Hi Grant, On 13.10.2012 02:05, Grant Likely wrote: Balaji T K balaj...@ti.com wrote: On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: On 12.10.2012 16:56, Balaji T K wrote:

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-13 Thread Grant Likely
Daniel Mack zon...@gmail.com wrote: On 13.10.2012 10:48, Grant Likely wrote: somedriver_probe(struct platform_device *pdev) { struct somedriver_private *somedriver; somedriver = devm_kzalloc(sizeof (*somedriver), GFP_KERNEL); somedriver-pdata = pdev-platform_data;

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Daniel Mack
On 12.10.2012 12:58, Daniel Mack wrote: When probed from DT, the self-allocated platform data has to be attached to the actual device. Otherwise a NULL pointer will be dereferenced from omap_hsmmc_card_detect if a gpio handle for card-detect has been passed. Signed-off-by: Daniel Mack

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Balaji T K
On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: When probed from DT, the self-allocated platform data has to be attached to the actual device. Otherwise a NULL pointer will be dereferenced from omap_hsmmc_card_detect if a gpio handle for

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Daniel Mack
On 12.10.2012 16:56, Balaji T K wrote: On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: When probed from DT, the self-allocated platform data has to be attached to the actual device. Otherwise a NULL pointer will be dereferenced from

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Balaji T K
On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: On 12.10.2012 16:56, Balaji T K wrote: On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 19ccb59..4b70823 100644

Re: [PATCH 1/4] MMC: omap_hsmmc: set platform data after probe from DT node

2012-10-12 Thread Grant Likely
Balaji T K balaj...@ti.com wrote: On Friday 12 October 2012 08:44 PM, Daniel Mack wrote: On 12.10.2012 16:56, Balaji T K wrote: On Friday 12 October 2012 07:59 PM, Daniel Mack wrote: On 12.10.2012 12:58, Daniel Mack wrote: diff --git a/drivers/mmc/host/omap_hsmmc.c