Re: Re: [v4,1/6] mmc: dt: add DT binding for big endian controller

2015-08-28 Thread Ulf Hansson
On 27 August 2015 at 20:39, Li Leo wrote: >> > Or Maybe there is another method, use conditional compilation. The previous >> method would delete the MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER to >> use accessors defined in sdhci-esdhc.h, and add dependency of ARM. This >> method could use 'select i

Re: Re: [v4,1/6] mmc: dt: add DT binding for big endian controller

2015-08-27 Thread Ulf Hansson
On 27 August 2015 at 15:34, Ulf Hansson wrote: > [...] > >> >> What I had in mind is replacing in_be32() with a esdhc_ops->readl() in this >> function. And the esdhc_ops->readl() would be assigned at the beginning >> according endian. >> >> static u32 esdhc_readl(struct sdhci_host *host, int reg

Re: Re: [v4,1/6] mmc: dt: add DT binding for big endian controller

2015-08-27 Thread Ulf Hansson
[...] > > What I had in mind is replacing in_be32() with a esdhc_ops->readl() in this > function. And the esdhc_ops->readl() would be assigned at the beginning > according endian. > > static u32 esdhc_readl(struct sdhci_host *host, int reg) > { > u32 ret; > > ret = in_be32(host->

Re: Re: [v4,1/6] mmc: dt: add DT binding for big endian controller

2015-08-25 Thread Ulf Hansson
o.org; >> devicet...@vger.kernel.org >> Subject: Re: [v4,1/6] mmc: dt: add DT binding for big endian controller >> >> > Add specification of 'big-endian' property. if the controller is big >> > endian mode, specify this property in device tree node. >> >