Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-18 Thread Ryusuke Konishi
On Thu, 18 Sep 2014 12:17:08 -0700, Andrew Morton wrote: > On Thu, 18 Sep 2014 23:56:25 +0900 Ryusuke Konishi > wrote: > >> From: Andreas Rohner >> >> This bug leads to reproducible silent data loss, despite the use of >> msync(), sync() and a clean unmount of the file system. It is easily >>

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-18 Thread Andrew Morton
On Thu, 18 Sep 2014 23:56:25 +0900 Ryusuke Konishi wrote: > From: Andreas Rohner > > This bug leads to reproducible silent data loss, despite the use of > msync(), sync() and a clean unmount of the file system. It is easily > reproducible with the following script: > > ... > > --- a/fs/nilfs2

[PATCH] nilfs2: fix data loss with mmap()

2014-09-18 Thread Ryusuke Konishi
From: Andreas Rohner This bug leads to reproducible silent data loss, despite the use of msync(), sync() and a clean unmount of the file system. It is easily reproducible with the following script: [BEGIN SCRIPT] mkfs.nilfs2 -f /dev/sdb mount /dev/sdb /mnt dd

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-18 Thread Andreas Rohner
On 2014-09-18 09:24, Ryusuke Konishi wrote: > On Wed, 17 Sep 2014 21:34:39 +0900 (JST), Ryusuke Konishi wrote: >> On Wed, 17 Sep 2014 10:16:46 +0200, Andreas Rohner wrote: >>> On 2014-09-16 15:57, Ryusuke Konishi wrote: On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote: >> I'd appre

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-18 Thread Ryusuke Konishi
On Wed, 17 Sep 2014 21:34:39 +0900 (JST), Ryusuke Konishi wrote: > On Wed, 17 Sep 2014 10:16:46 +0200, Andreas Rohner wrote: >> On 2014-09-16 15:57, Ryusuke Konishi wrote: >>> On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote: > I'd appreciate your help on testing the patch for some old

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-17 Thread Ryusuke Konishi
On Wed, 17 Sep 2014 10:16:46 +0200, Andreas Rohner wrote: > On 2014-09-16 15:57, Ryusuke Konishi wrote: >> On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote: I'd appreciate your help on testing the patch for some old kernels. (And, please declare a "Tested-by" tag in the reply mail

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-17 Thread Andreas Rohner
On 2014-09-16 15:57, Ryusuke Konishi wrote: > On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote: >>> I'd appreciate your help on testing the patch for some old kernels. >>> (And, please declare a "Tested-by" tag in the reply mail, if the test >>> is ok). >> >> Sure I have everything set up.

[PATCH] nilfs2: fix data loss with mmap()

2014-09-16 Thread Andreas Rohner
This bug leads to reproducible silent data loss, despite the use of msync(), sync() and a clean unmount of the file system. It is easily reproducible with the following script: [BEGIN SCRIPT] mkfs.nilfs2 -f /dev/sdb mount /dev/sdb /mnt # create 30MB testfile dd

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-16 Thread Ryusuke Konishi
On Tue, 16 Sep 2014 10:38:29 +0200, Andreas Rohner wrote: >> I'd appreciate your help on testing the patch for some old kernels. >> (And, please declare a "Tested-by" tag in the reply mail, if the test >> is ok). > > Sure I have everything set up. Which kernels do I have to test? Was > commit 136e

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-16 Thread Andreas Rohner
On 2014-09-16 06:42, Ryusuke Konishi wrote: > On Tue, 16 Sep 2014 00:24:05 +0200, Andreas Rohner wrote: >> On 2014-09-16 00:01, Ryusuke Konishi wrote: >>> Hi Andreas, >>> On Mon, 15 Sep 2014 21:47:30 +0200, Andreas Rohner wrote: This bug leads to reproducible silent data loss, despite the use

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-15 Thread Ryusuke Konishi
On Tue, 16 Sep 2014 00:24:05 +0200, Andreas Rohner wrote: > On 2014-09-16 00:01, Ryusuke Konishi wrote: >> Hi Andreas, >> On Mon, 15 Sep 2014 21:47:30 +0200, Andreas Rohner wrote: >>> This bug leads to reproducible silent data loss, despite the use of >>> msync(), sync() and a clean unmount of the

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-15 Thread Andreas Rohner
On 2014-09-16 00:01, Ryusuke Konishi wrote: > Hi Andreas, > On Mon, 15 Sep 2014 21:47:30 +0200, Andreas Rohner wrote: >> This bug leads to reproducible silent data loss, despite the use of >> msync(), sync() and a clean unmount of the file system. It is easily >> reproducible with the following scr

Re: [PATCH] nilfs2: fix data loss with mmap()

2014-09-15 Thread Ryusuke Konishi
Hi Andreas, On Mon, 15 Sep 2014 21:47:30 +0200, Andreas Rohner wrote: > This bug leads to reproducible silent data loss, despite the use of > msync(), sync() and a clean unmount of the file system. It is easily > reproducible with the following script: > > [BEGIN SCRIPT]---

[PATCH] nilfs2: fix data loss with mmap()

2014-09-15 Thread Andreas Rohner
This bug leads to reproducible silent data loss, despite the use of msync(), sync() and a clean unmount of the file system. It is easily reproducible with the following script: [BEGIN SCRIPT] mkfs.nilfs2 -f /dev/sdb mount /dev/sdb /mnt # create 30MB testfile dd