Re: [PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 04:46:00PM -0800, Dan Williams wrote: > In the case of filesystem-dax (xfs or ext4) a punch hole operation is > effective for clearing a media error. Which at best is a third order side effect of what it actually does: release allocated space. Which is something we can do

Re: [PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 04:30:47PM -0700, Dave Jiang wrote: > Adding fallocate support to device-dax. This implements FALLOC_FL_PUNCH_HOLE > in order to allow clearing of badblocks/poison list. How exactly does that map to hole punch semantics? ___

Re: DAX mapping detection (was: Re: [PATCH] Fix region lost in /proc/self/smaps)

2016-12-19 Thread Dan Williams
On Mon, Dec 19, 2016 at 5:09 PM, Darrick J. Wong wrote: > On Mon, Dec 19, 2016 at 02:11:49PM -0700, Ross Zwisler wrote: >> On Fri, Sep 16, 2016 at 03:54:05PM +1000, Nicholas Piggin wrote: >> <> >> > Definitely the first step would be your simple preallocated per >> >

Re: DAX mapping detection (was: Re: [PATCH] Fix region lost in /proc/self/smaps)

2016-12-19 Thread Darrick J. Wong
On Mon, Dec 19, 2016 at 02:11:49PM -0700, Ross Zwisler wrote: > On Fri, Sep 16, 2016 at 03:54:05PM +1000, Nicholas Piggin wrote: > <> > > Definitely the first step would be your simple preallocated per > > inode approach until it is shown to be insufficient. > > Reviving this thread a few months

Re: [PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Dan Williams
[ adding fsdevel for fs/open.c change ] On Mon, Dec 19, 2016 at 3:30 PM, Dave Jiang wrote: > Adding fallocate support to device-dax. This implements FALLOC_FL_PUNCH_HOLE > in order to allow clearing of badblocks/poison list. I think we need to say more about the rationale

[PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Dave Jiang
Adding fallocate support to device-dax. This implements FALLOC_FL_PUNCH_HOLE in order to allow clearing of badblocks/poison list. Signed-off-by: Dave Jiang --- drivers/dax/dax-private.h |1 + drivers/dax/dax.c | 24 +++- drivers/dax/dax.h

Re: [PATCH 0/6 v3] dax: Page invalidation fixes

2016-12-19 Thread Dan Williams
On Mon, Dec 19, 2016 at 1:56 AM, Jan Kara wrote: > On Fri 16-12-16 17:35:35, Dan Williams wrote: >> On Tue, Dec 13, 2016 at 10:57 AM, Dan Williams >> wrote: >> > On Tue, Dec 13, 2016 at 3:52 AM, Jan Kara wrote: >> >> On Mon 12-12-16

Re: [PATCH v4 1/3] dax: masking off __GFP_FS in fs DAX handlers

2016-12-19 Thread Dave Chinner
On Mon, Dec 19, 2016 at 08:53:02PM +0100, Jan Kara wrote: > On Sat 17-12-16 09:04:50, Dave Chinner wrote: > > On Fri, Dec 16, 2016 at 09:19:16AM -0700, Ross Zwisler wrote: > > > On Fri, Dec 16, 2016 at 12:07:30PM +1100, Dave Chinner wrote: > > > > On Thu, Dec 15, 2016 at 04:40:41PM -0700, Dave

Re: DAX mapping detection (was: Re: [PATCH] Fix region lost in /proc/self/smaps)

2016-12-19 Thread Ross Zwisler
On Fri, Sep 16, 2016 at 03:54:05PM +1000, Nicholas Piggin wrote: <> > Definitely the first step would be your simple preallocated per > inode approach until it is shown to be insufficient. Reviving this thread a few months later... Dave, we're interested in taking a serious look at what it would

Re: [PATCH v4 1/3] dax: masking off __GFP_FS in fs DAX handlers

2016-12-19 Thread Jan Kara
On Sat 17-12-16 09:04:50, Dave Chinner wrote: > On Fri, Dec 16, 2016 at 09:19:16AM -0700, Ross Zwisler wrote: > > On Fri, Dec 16, 2016 at 12:07:30PM +1100, Dave Chinner wrote: > > > On Thu, Dec 15, 2016 at 04:40:41PM -0700, Dave Jiang wrote: > > > > The caller into dax needs to clear __GFP_FS mask

[PATCH v5 2/2] mm, dax: move pmd_fault() to take only vmf parameter

2016-12-19 Thread Dave Jiang
pmd_fault() and related functions really only need the vmf parameter since the additional parameters are all included in the vmf struct. Removing additional parameter and simplify pmd_fault() and friends. Signed-off-by: Dave Jiang Reviewed-by: Ross Zwisler

[PATCH v5 1/2] mm, dax: make pmd_fault() and friends to be the same as fault()

2016-12-19 Thread Dave Jiang
Instead of passing in multiple parameters in the pmd_fault() handler, a vmf can be passed in just like a fault() handler. This will simplify code and remove the need for the actual pmd fault handlers to allocate a vmf. Related functions are also modified to do the same. Signed-off-by: Dave Jiang

Re: [PATCH v4 1/3] dax: masking off __GFP_FS in fs DAX handlers

2016-12-19 Thread Jiang, Dave
On Sat, 2016-12-17 at 09:04 +1100, Dave Chinner wrote: > On Fri, Dec 16, 2016 at 09:19:16AM -0700, Ross Zwisler wrote: > > > > On Fri, Dec 16, 2016 at 12:07:30PM +1100, Dave Chinner wrote: > > > > > > On Thu, Dec 15, 2016 at 04:40:41PM -0700, Dave Jiang wrote: > > > > > > > > The caller into

Re: [PATCH v3 0/5] introduce DAX tracepoint support

2016-12-19 Thread Ross Zwisler
On Thu, Dec 01, 2016 at 09:37:46AM -0700, Ross Zwisler wrote: > Tracepoints are the standard way to capture debugging and tracing > information in many parts of the kernel, including the XFS and ext4 > filesystems. This series creates a tracepoint header for FS DAX and add > the first few DAX