Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread Paolo Bonzini
On 13/11/2018 17:21, Barret Rhoden wrote: > On 2018-11-12 at 20:31 Paolo Bonzini wrote: >> Looks good. What's the plan for removing PageReserved from DAX pages? > > I hear that's going on in this thread: > >

Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread Barret Rhoden
On 2018-11-12 at 20:31 Paolo Bonzini wrote: > Looks good. What's the plan for removing PageReserved from DAX pages? I hear that's going on in this thread: https://lore.kernel.org/lkml/154145268025.30046.11742652345962594283.st...@ahduyck-desk1.jf.intel.com/ Though it looks like it's speeding

Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread Barret Rhoden
On 2018-11-13 at 05:02 Pankaj Gupta wrote: > As this patch is dependent on PageReserved patch(which is in progress), just > wondering if we are able to test the code path for hugepage with DAX. For testing, I used the following patch. It's not 100%, since it intercepts at

Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread Barret Rhoden
On 2018-11-13 at 10:36 David Hildenbrand wrote: > > Note that KVM already faulted in the page (or huge page) in the host's > > page table, and we hold the KVM mmu spinlock (grabbed before checking > > the mmu seq). > > I wonder if the KVM mmu spinlock is enough for walking (not KVM >

Re: fsdax memory error handling regression

2018-11-13 Thread Matthew Wilcox
On Sat, Nov 10, 2018 at 09:08:10AM -0800, Dan Williams wrote: > On Sat, Nov 10, 2018 at 12:29 AM Matthew Wilcox wrote: > > On Wed, Nov 07, 2018 at 06:01:19AM +, Williams, Dan J wrote: > > > On Tue, 2018-11-06 at 06:48 -0800, Matthew Wilcox wrote: > > > > On Tue, Nov 06, 2018 at 03:44:47AM

Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread Paolo Bonzini
On 13/11/2018 11:02, Pankaj Gupta wrote: > >> >> On 09.11.18 21:39, Barret Rhoden wrote: >>> This change allows KVM to map DAX-backed files made of huge pages with >>> huge mappings in the EPT/TDP. >>> >>> DAX pages are not PageTransCompound. The existing check is trying to >>> determine if the

Re: [RFC v2 00/14] kunit: introduce KUnit, the Linux kernel unit testing framework

2018-11-13 Thread Brendan Higgins
On Wed, Nov 7, 2018 at 9:46 AM Frank Rowand wrote: > > On 11/6/18 5:17 PM, Brendan Higgins wrote: > > On Fri, Nov 2, 2018 at 11:23 AM Shuah Khan wrote: > >> > >> Hi Brendan, > > > >> Framework looks good. I think it would be helpful to include a real test > > > > Great to hear! > > > >> in the

Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread Pankaj Gupta
> > On 09.11.18 21:39, Barret Rhoden wrote: > > This change allows KVM to map DAX-backed files made of huge pages with > > huge mappings in the EPT/TDP. > > > > DAX pages are not PageTransCompound. The existing check is trying to > > determine if the mapping for the pfn is a huge mapping or

Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files

2018-11-13 Thread David Hildenbrand
On 09.11.18 21:39, Barret Rhoden wrote: > This change allows KVM to map DAX-backed files made of huge pages with > huge mappings in the EPT/TDP. > > DAX pages are not PageTransCompound. The existing check is trying to > determine if the mapping for the pfn is a huge mapping or not. For >

Re: [PATCH 1/2] mm: make dev_pagemap_mapping_shift() externally visible

2018-11-13 Thread David Hildenbrand
On 09.11.18 21:39, Barret Rhoden wrote: > KVM has a use case for determining the size of a dax mapping. The KVM > code has easy access to the address and the mm; hence the change in > parameters. > > Signed-off-by: Barret Rhoden > --- > include/linux/mm.h | 3 +++ > mm/memory-failure.c | 38