Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-12-05 Thread Jan Kara
On Tue 04-12-18 22:11:10, Dan Williams wrote: > On Tue, Dec 4, 2018 at 5:35 PM Matthew Wilcox wrote: > > > > On Mon, Dec 03, 2018 at 07:33:43PM -0800, Dan Williams wrote: > > > On Fri, Nov 30, 2018 at 12:05 PM Dan Williams > > > wrote: > > > > > -void dax_unlock_mapping_entry(struct page *page)

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 5:35 PM Matthew Wilcox wrote: > > On Mon, Dec 03, 2018 at 07:33:43PM -0800, Dan Williams wrote: > > On Fri, Nov 30, 2018 at 12:05 PM Dan Williams > > wrote: > > > > -void dax_unlock_mapping_entry(struct page *page) > > > > +void dax_unlock_mapping_entry(struct page *page,

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-12-04 Thread Matthew Wilcox
On Mon, Dec 03, 2018 at 07:33:43PM -0800, Dan Williams wrote: > On Fri, Nov 30, 2018 at 12:05 PM Dan Williams > wrote: > > > -void dax_unlock_mapping_entry(struct page *page) > > > +void dax_unlock_mapping_entry(struct page *page, dax_entry_t entry) > > > > Let's not require the page to be passed

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-12-03 Thread Dan Williams
On Fri, Nov 30, 2018 at 12:05 PM Dan Williams wrote: > > On Fri, Nov 30, 2018 at 11:50 AM Matthew Wilcox wrote: > > > > On Fri, Nov 30, 2018 at 09:01:07AM -0800, Dan Williams wrote: > > > On Fri, Nov 30, 2018 at 8:33 AM Dan Williams > > > wrote: > > > > > > > > On Fri, Nov 30, 2018 at 8:24 AM M

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Dan Williams
On Fri, Nov 30, 2018 at 11:50 AM Matthew Wilcox wrote: > > On Fri, Nov 30, 2018 at 09:01:07AM -0800, Dan Williams wrote: > > On Fri, Nov 30, 2018 at 8:33 AM Dan Williams > > wrote: > > > > > > On Fri, Nov 30, 2018 at 8:24 AM Matthew Wilcox > > > wrote: > > > > > > > > On Fri, Nov 30, 2018 at 0

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Matthew Wilcox
On Fri, Nov 30, 2018 at 09:01:07AM -0800, Dan Williams wrote: > On Fri, Nov 30, 2018 at 8:33 AM Dan Williams wrote: > > > > On Fri, Nov 30, 2018 at 8:24 AM Matthew Wilcox wrote: > > > > > > On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote: > > > > Looks good to me, although can we mak

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Dan Williams
On Fri, Nov 30, 2018 at 8:33 AM Dan Williams wrote: > > On Fri, Nov 30, 2018 at 8:24 AM Matthew Wilcox wrote: > > > > On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote: > > > Looks good to me, although can we make that cookie an actual type? I > > > think it's mostly ok to pass around

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Dan Williams
On Fri, Nov 30, 2018 at 8:24 AM Matthew Wilcox wrote: > > On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote: > > Looks good to me, although can we make that cookie an actual type? I > > think it's mostly ok to pass around (void *) for 'entry' inside of > > fs/dax.c, but once an entry le

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Matthew Wilcox
On Fri, Nov 30, 2018 at 07:54:49AM -0800, Dan Williams wrote: > Looks good to me, although can we make that cookie an actual type? I > think it's mostly ok to pass around (void *) for 'entry' inside of > fs/dax.c, but once an entry leaves that file I'd like it to have an > explicit type to catch pe

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Dan Williams
On Fri, Nov 30, 2018 at 7:49 AM Matthew Wilcox wrote: > > On Thu, Nov 29, 2018 at 04:13:46PM -0800, Dan Williams wrote: > > Internal to dax_unlock_mapping_entry(), dax_unlock_entry() is used to > > store a replacement entry in the Xarray at the given xas-index with the > > DAX_LOCKED bit clear. Wh

Re: [PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-30 Thread Matthew Wilcox
On Thu, Nov 29, 2018 at 04:13:46PM -0800, Dan Williams wrote: > Internal to dax_unlock_mapping_entry(), dax_unlock_entry() is used to > store a replacement entry in the Xarray at the given xas-index with the > DAX_LOCKED bit clear. When called, dax_unlock_entry() expects the unlocked > value of the

[PATCH] dax: Fix Xarray conversion of dax_unlock_mapping_entry()

2018-11-29 Thread Dan Williams
Internal to dax_unlock_mapping_entry(), dax_unlock_entry() is used to store a replacement entry in the Xarray at the given xas-index with the DAX_LOCKED bit clear. When called, dax_unlock_entry() expects the unlocked value of the entry relative to the current Xarray state to be specified. In most