Re: [PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 04:46:00PM -0800, Dan Williams wrote: > In the case of filesystem-dax (xfs or ext4) a punch hole operation is > effective for clearing a media error. Which at best is a third order side effect of what it actually does: release allocated space. Which is something we can do

Re: [PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 04:30:47PM -0700, Dave Jiang wrote: > Adding fallocate support to device-dax. This implements FALLOC_FL_PUNCH_HOLE > in order to allow clearing of badblocks/poison list. How exactly does that map to hole punch semantics? ___ Linux

Re: [PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Dan Williams
[ adding fsdevel for fs/open.c change ] On Mon, Dec 19, 2016 at 3:30 PM, Dave Jiang wrote: > Adding fallocate support to device-dax. This implements FALLOC_FL_PUNCH_HOLE > in order to allow clearing of badblocks/poison list. I think we need to say more about the rationale for picking fallocate

[PATCH v2 3/3] dev-dax: add fallocate support to clear poison

2016-12-19 Thread Dave Jiang
Adding fallocate support to device-dax. This implements FALLOC_FL_PUNCH_HOLE in order to allow clearing of badblocks/poison list. Signed-off-by: Dave Jiang --- drivers/dax/dax-private.h |1 + drivers/dax/dax.c | 24 +++- drivers/dax/dax.h |4 ++- drivers/dax