RE: [PATCHv4 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread ext-Eero.Nurkkala
> + > +static const struct snd_kcontrol_new omap_mcbsp2_st_controls[] = { > + SOC_SINGLE_EXT("McBSP2 Sidetone Switch", 1, 0, 1, 0, > + omap_mcbsp_st_get_mode, omap_mcbsp_st_put_mode), > + OMAP_MCBSP_SOC_SINGLE_S16_EXT("McBSP2 Sidetone Channel 0 Volume", > +

RE: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Nayak, Rajendra
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: Thursday, February 18, 2010 5:13 PM > To: Nayak, Rajendra > Cc: linux-omap@vger.kernel.org; Liam Girdwood; Samuel Ortiz > Subject: Re: [PATCH 1/2] twl6030: regulator: Fix vsel > calculations in

RE: [PATCH 1/9] omap3/4: uart: fix full-fifo write abort

2010-02-18 Thread Shilimkar, Santosh
Bye the way just to add bit more clarity, this patch addresses TX hardware restriction in the new UART IP used on omap3630 and omap4430. First part of the fix for RX is already in mainline, Commit: "ce13d4716a276f4331d78ba28a5093a63822ab95" More details on this thread are here. http://www.mail-arc

RE: [PATCH 2/9] omap2/3/4: ioremap omap_globals module

2010-02-18 Thread Shilimkar, Santosh
> -Original Message- > From: Kevin Hilman [mailto:khil...@deeprootsystems.com] > Sent: Friday, February 19, 2010 3:55 AM > To: Shilimkar, Santosh > Cc: t...@atomide.com; linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH 2/9] omap2/3/4: ioremap omap_gl

RE: [PATCH 7/9] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Shilimkar, Santosh
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, February 18, 2010 10:53 PM > To: Shilimkar, Santosh > Cc: t...@atomide.com; linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, > Benoit > Subject: Re: [PATCH 7/9] omap4: Add auto-

[PATCH] arm: Allow mounting root on omaps with CPU_V6 and CPU_V7

2010-02-18 Thread Tony Lindgren
Hi all, Here's one more patch for booting CPU_V6 and CPU_V7 omaps with the same kernel binary. This is needed to boot to user space, earlier I was just checking for "Mounted root". Now I'm wondering if some of these should be done as default y if CPU_V7 && !CPU_32v6K or default y if CPU_V7 &&

Re: [PATCH 2/2] dspbridge: proc: fix a double-free on 2 error paths

2010-02-18 Thread Omar Ramirez Luna
On 2/12/2010 10:26 AM, Phil Carmody wrote: From: Phil Carmody We free in the tail cleanup, so don't free before jumping there. Signed-off-by: Phil Carmody --- drivers/dsp/bridge/rmgr/proc.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) Removed NULL assignment as agreed

Re: [PATCH 1/2] dspbridge: proc: it's a pointer, not a handle

2010-02-18 Thread Omar Ramirez Luna
On 2/12/2010 10:26 AM, Phil Carmody wrote: From: Phil Carmody If there's one thing worse than systems hungarian notation, it's misleading systems hungarian notation. And you don't need 2 copies of the pointer. Signed-off-by: Phil Carmody --- drivers/dsp/bridge/rmgr/proc.c | 25 +++--

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Nicolas Pitre
On Thu, 18 Feb 2010, Steve Sakoman wrote: > On Thu, Feb 18, 2010 at 12:21 PM, Paul Walmsley wrote: > > > (cc'ing Steve, Richard, Anand) > > > There appear to be least seven SDIO card drivers in 2.6.34-rc7. At least > > one of these is for a TI chip - the wl1251.  I think some of the > > Gumstix

RE: [PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-18 Thread Guzman Lugo, Fernando
Hi, >-Original Message- >From: Ameya Palande [mailto:ameya.pala...@nokia.com] >Sent: Thursday, February 18, 2010 8:41 AM >To: linux-omap@vger.kernel.org >Cc: felipe.contre...@nokia.com; Menon, Nishanth; Chitriki Rudramuni, >Deepak; Guzman Lugo, Fernando; Ramirez Luna, Omar >Subject: [PATC

Re: [PATCH 2/9] omap2/3/4: ioremap omap_globals module

2010-02-18 Thread Kevin Hilman
Santosh Shilimkar writes: > This is a clean-up patch towards dynamic allocation of IO space > instead of using harcoded macros to calculate virtual addresses. > > Also update the sdrc, prcm, tap and control module to > allocate iospace dynamically You should drop the referenece to the TAP here s

[RFC][PATCH 1/2] DSPBRIDGE: add checking 128 byte alignment for dsp cache line size

2010-02-18 Thread Omar Ramirez Luna
A buffer shared with MPU and DSP has to be aligned on both cache line size to avoid memory corrupton with some DSP cache operations. Since there's no way for dspbridge to know how the shared buffer will be used like: "read-only", "write-only", "rw" through its life span, any shared buffer passed to

[RFC][PATCH 0/2] DSPBRIDGE: 128 bytes alignment check

2010-02-18 Thread Omar Ramirez Luna
Technical info: https://omapzoom.org/gf/download/docmanfileversion/52/985/DSP_cache.pdf This set of patches introduces the 128 byte alignment check, needed to avoid corruption if the dsp is meant to write to boundary portions of an unaligned chunk of memory. The second patch uses a field composed

[RFC][PATCH 2/2] DSPBRIDGE: Distinguish between read or write buffers

2010-02-18 Thread Omar Ramirez Luna
This patch introduces the check to differentiate the buffers coming to the dsp through bridgedriver. So far they can be input (read) or output (write) or rw (which are treated the same way as an output buffer), this distinctions are made from dsp perspective. Since this needs to be checked on map

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Steve Sakoman
On Thu, Feb 18, 2010 at 12:21 PM, Paul Walmsley wrote: > (cc'ing Steve, Richard, Anand) > There appear to be least seven SDIO card drivers in 2.6.34-rc7. At least > one of these is for a TI chip - the wl1251.  I think some of the > Gumstix Overo OMAP3 boards are using an SDIO-connected Marvell L

[PATCH 1/2] DSPBRIDGE: logic error fix for SleepDSP timeout value

2010-02-18 Thread Omar Ramirez Luna
When leaving the loop waiting for the dsp to transition from its power state, timeout value will be negative, therefore a print for "timeout waiting for the dsp" won't be displayed, as the condition to check for is !timeout. Reported-by: Berenice Herrera Signed-off-by: Omar Ramirez Luna --- dri

[PATCH 0/2] DSPBRIDGE: unrelated fixes

2010-02-18 Thread Omar Ramirez Luna
A couple of unrelated fixes. Omar Ramirez Luna (2): DSPBRIDGE: logic error fix for SleepDSP timeout value DSPBRIDGE: check pointer before dereference drivers/dsp/bridge/pmgr/msg.c | 16 drivers/dsp/bridge/wmd/tiomap3430_pwr.c |2 +- 2 files changed, 9 inserti

[PATCH 2/2] DSPBRIDGE: check pointer before dereference

2010-02-18 Thread Omar Ramirez Luna
Change the check for valid handle to detect a possible error, and now use it before dereferencing the pointer. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/pmgr/msg.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/msg.c

[PATCH 03/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in wmd

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/wmd/chnl_sm.c|4 +- drivers/dsp/bridge/wmd/io_sm.c | 106 +++-- drivers/dsp/bridge/wmd/mmu_fault.c |9 +- drivers/dsp/bridge/wmd/

[PATCH 08/12] DSPBRIDGE: Remove GT_trace variables for pmgr

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/pmgr/chnl.c | 10 -- drivers/dsp/bridge/pmgr/cmm.c |9 - drivers/dsp/bridge/pmgr/cod.c |9 - drivers/

[PATCH 09/12] DSPBRIDGE: Remove GT_trace variables for services

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/services/cfg.c |6 -- drivers/dsp/bridge/services/clk.c |6 -- drivers/dsp/bridge/services/dbg.c |9 +-

[PATCH 12/12] DSPBRIDGE: Remove unused instances of CONFIG_BRIDGE_DEBUG

2010-02-18 Thread Omar Ramirez Luna
Remove unused instances of CONFIG_BRIDGE_DEBUG. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/drv_interface.c |2 -- drivers/dsp/bridge/rmgr/nldr.c |2 -- drivers/dsp/bridge/rmgr/node.c | 10 -- drivers/dsp/bridge/rmgr/proc.c | 23 +++

[PATCH 02/12] DSPBRIDGE: Change custom GT_trace for dev_dbg

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/dbdcd.c | 29 - drivers/dsp/bridge/rmgr/disp.c | 58 ++ drivers/dsp/bridge/rmgr/drv.c | 91 ---

[PATCH 10/12] DSPBRIDGE: Remove custom debugging implementation

2010-02-18 Thread Omar Ramirez Luna
Replace custom debug implementation with a friendly set of pr_err, pr_info and dev_dbg messages. Signed-off-by: Omar Ramirez Luna --- arch/arm/plat-omap/include/dspbridge/dbg.h | 65 -- arch/arm/plat-omap/include/dspbridge/gt.h | 271 -- drivers/dsp/bridge/Makefile

[PATCH 04/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in pmgr

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/pmgr/cmm.c |9 +++--- drivers/dsp/bridge/pmgr/cod.c |5 +-- drivers/dsp/bridge/pmgr/dbll.c | 59 +++- drivers/dsp/bridge/pmgr/dmm.c

[PATCH 05/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in services

2010-02-18 Thread Omar Ramirez Luna
Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/services/cfg.c|3 +-- drivers/dsp/bridge/services/clk.c|5 ++--- drivers/dsp/bridge/services/regsup.c | 21 + 3 files changed, 12 insertions(+

[PATCH 06/12] DSPBRIDGE: Remove GT_trace variables for rmgr

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/dbdcd.c |2 -- drivers/dsp/bridge/rmgr/disp.c | 10 -- drivers/dsp/bridge/rmgr/drv.c |4

[PATCH 07/12] DSPBRIDGE: Remove GT_trace variables for wmd

2010-02-18 Thread Omar Ramirez Luna
This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/wmd/io_sm.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/br

[PATCH 01/12] DSPBRIDGE: global bridge device

2010-02-18 Thread Omar Ramirez Luna
This patch declares and externs a pointer to a bridge device to be used with dev_dbg. Signed-off-by: Omar Ramirez Luna --- arch/arm/plat-omap/include/dspbridge/host_os.h |1 + drivers/dsp/bridge/rmgr/drv_interface.c|4 2 files changed, 5 insertions(+), 0 deletions(-) diff -

[PATCH 00/12] Custom debug removal

2010-02-18 Thread Omar Ramirez Luna
Step 2 to remove custom debug tracing. This set of patches gets rid of GT_* and DBG_* functionality, and replaces them to use dev_dbg instead. This is meant to be a follow up of previous debug removal patches. More info on dynamic_debug: http://lwn.net/Articles/286191/ Omar Ramirez Luna (12):

[PATCH 11/12] DSPBRIDGE: Remove debug header files

2010-02-18 Thread Omar Ramirez Luna
This patch removes header files used in bridge debug implementation. Signed-off-by: Omar Ramirez Luna --- arch/arm/plat-omap/include/dspbridge/dbc.h |2 - arch/arm/plat-omap/include/dspbridge/dbg.h | 24 -- arch/arm/plat-omap/include/dspbridge/gt.h | 37 -

[PATCH 5/5] omap2/3/4: mailbox: retries in case of FIFO full

2010-02-18 Thread Anna, Suman
>From f2e895f74544876572adbe3328aa27d20aa1aec4 Mon Sep 17 00:00:00 2001 From: Hari Kanigeri Date: Fri, 4 Dec 2009 15:52:42 -0600 Subject: [PATCH 5/5] omap2/3/4: mailbox: retries in case of FIFO full This patch enables check for the mailbox fifo full Without this check in some extreme stress test

[PATCH 4/5] omap2/3/4: mailbox: use dedicated work queue for handling mailbox rx interrupt

2010-02-18 Thread Anna, Suman
>From 7410bf2d5c569c83a594b99a62d03b939e4f10b8 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 4 Jan 2010 19:22:03 +0530 Subject: [PATCH 4/5] omap2/3/4: mailbox: use dedicated work queue for handling mailbox rx interrupt keventd_wq is a shared work-queue, and should not be used when we need

[PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic

2010-02-18 Thread Anna, Suman
>From 18beb1784db07e4eb2b9d10783a309b5caccb979 Mon Sep 17 00:00:00 2001 From: Suman Anna Date: Fri, 5 Feb 2010 17:20:26 -0600 Subject: [PATCH 3/5] omap: mailbox: correct OMAP4 SIDLEMODE logic OMAP4 mailbox has a different MAILBOX_SYSCONFIG register. There is now no AutoIdle. The SIDLEMODE bits ha

[PATCH 2/5] omap: mailbox: correct OMAP4 reset logic

2010-02-18 Thread Anna, Suman
>From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 From: Suman Anna Date: Tue, 26 Jan 2010 16:55:29 -0600 Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic OMAP4 mailbox has a different register set. There is no MAILBOX_SYSSTATUS register. The reset is indicated w

[PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

2010-02-18 Thread Anna, Suman
>From 78d00b562548e1d95ad12a4d8121be67950daf68 Mon Sep 17 00:00:00 2001 From: Suman Anna Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox module. Signed-off-by: Suman Anna --- arch/arm/ma

[PATCH 0/5] Mailbox: Fix issues for OMAP4

2010-02-18 Thread Anna, Suman
>From f2e895f74544876572adbe3328aa27d20aa1aec4 Mon Sep 17 00:00:00 2001 From: Suman Anna Date: Thu, 18 Feb 2010 14:34:39 -0600 Subject: [PATCH 0/5] Mailbox: Fix issues for OMAP4 This patchset has fixes for OMAP4 mailbox SYSCONFIG register. Also included are patches for improving mailbox performa

Re: [PATCH] OMAP: HWMOD: Bug fixes in hwmod structure definitions

2010-02-18 Thread Paul Walmsley
Hello Thara, some comments. On Thu, 18 Feb 2010, Thara Gopinath wrote: > This patch corrects the width of some variables in hwmod structures > where the values to be stored in these variables exceed the current > field width. > > Signed-off-by: Thara Gopinath > Cc: Paul Walmsley > --- > arch

RE: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-18 Thread Menon, Nishanth
> -Original Message- > From: Ramirez Luna, Omar > Sent: Thursday, February 18, 2010 8:27 PM > To: Menon, Nishanth > Cc: Ameya Palande; Chitriki Rudramuni, Deepak; linux-omap; Guzman Lugo, > Fernando > Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking > > On 2/17/2

[GIT PULL] omap fix for 2.6.33-rc8

2010-02-18 Thread Tony Lindgren
Hi Linus, Please pull one more omap fix from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-fixes-for-linus Regards, Tony The following changes since commit 724e6d3fe8003c3f60bf404bf22e4e331327c596: Linus Torvalds (1): Linux 2.6.33-rc8 are available

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Menon, Nishanth
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Thursday, February 18, 2010 10:18 PM > To: Hebbar, Shivananda > Cc: Menon, Nishanth; linux-omap > Subject: Re: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup > > On Thu, Feb 18, 2010 at 10:10 PM, Hebbar,

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Paul Walmsley
Hi, (cc'ing Steve, Richard, Anand) On Thu, 18 Feb 2010, Madhusudhan wrote: > Not to add further confusion but as far as I understand SDIO should be > able to asynchronously wakeup OMAP regardless of MMC clocks being OFF . > As per the SDIO spec DAT1 line is used for signaling the card interrup

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
> -Original Message- > From: Nicolas Pitre [mailto:n...@fluxnic.net] > Sent: Thursday, February 18, 2010 1:27 PM > To: Madhusudhan > Cc: 'Paul Walmsley'; 'David Vrabel'; linux-...@vger.kernel.org; linux- > o...@vger.kernel.org > Subject: RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card i

Re: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Andy Shevchenko
On Thu, Feb 18, 2010 at 10:10 PM, Hebbar, Shivananda wrote: >> What is the motivation of this change? > Sometime back ,there was comment on excessive u32ypes used in bridge. > http://marc.info/?l=linux-omap&m=123998339213416&w=2 I respect Artem for his work, but his personal hate of u* types not a

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 20:42:27 +0200 Ilkka Koskinen wrote: > The first patch implements McBSP sidetone feature on OMAP3 while the second > one provides ALSA interface for using it. > > The patch set is based on the patch Eduardo Valentin sent to alsa-devel > mailing list in October 2009. Channel g

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Hebbar, Shivananda
Hi, > -Original Message- > From: Menon, Nishanth > Sent: Thursday, February 18, 2010 1:47 PM > To: Hebbar, Shivananda; linux-omap > Subject: RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup > > > -Original Message- > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- >

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Menon, Nishanth
> -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Hebbar, Shivananda > Sent: Thursday, February 18, 2010 9:24 PM > To: linux-omap > Subject: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup > > These patches remove excessive

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Nicolas Pitre
On Thu, 18 Feb 2010, Madhusudhan wrote: > If I look in the mainline kernel today there is only one SDIO card driver " > sdio_uart.c". And at least I don't see a way I can test any of these > features myself. There are many other SDIO drivers in the kernel today: - The libertas wireless driver s

Patch [2/2]: DSPBRIDGE: Execessive u32 Cleanup(u32->int)

2010-02-18 Thread Hebbar, Shivananda
>From 8884e6d372daa1ab2e5d3822ec6aa450ebcd0c47 Mon Sep 17 00:00:00 2001 From: Shivananda Hebbar Date: Mon, 1 Feb 2010 15:27:42 -0600 Subject: [PATCH] DSPBRIDGE: Execessive u32 Cleanup(u32->int) This patch removes execessive u32 types and replaces it with normal int type. Signed-off-by: Shivanand

Patch [1/2] DSPBRIDGE: Execessive u32 Cleanup(u32->short int)

2010-02-18 Thread Hebbar, Shivananda
>From 9c472382f598ed86fa2fe3f83dd064323918ff5e Mon Sep 17 00:00:00 2001 From: Shivananda Hebbar Date: Thu, 28 Jan 2010 18:22:56 -0600 Subject: [PATCH] DSPBRIDGE: Execessive u32 Cleanup(u32->short int) This patch removes execessive u32's used in bridge. As part of this, u32 types is changed to sh

Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Hebbar, Shivananda
These patches remove excessive u32 type and replaces it with the Normal C types. Shivananda Hebbar (2) DSPBRIDGE: Excessive u32 Cleanup (u32->short int) DSPBRIDGE: Excessive u32 Cleanup (u32->int) arch/arm/plat-omap/include/dspbridge/_chnl_sm.h | 10 arch/arm/plat-omap/include/dspbri

[PATCHv4 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen --- sound/soc/omap/omap-mcbsp.c | 138 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 140 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/omap-mc

[PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA interfa

[PATCHv4 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
From: Eero Nurkkala Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 60 + arch/arm/plat-omap/mcbsp.c | 402 +

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, February 18, 2010 11:44 AM > To: David Vrabel > Cc: Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org > Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts > > On Thu,

Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-18 Thread Omar Ramirez Luna
On 2/17/2010 10:09 AM, Menon, Nishanth wrote: Hi, From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Friday, February 12, 2010 12:21 AM To: Chitriki Rudramuni, Deepak Cc: linux-omap; Ramirez Luna, Omar; Menon, Nishanth Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive l

Re: [PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-18 Thread Felipe Contreras
On Thu, Feb 18, 2010 at 03:40:49PM +0100, Ameya Palande wrote: > This patch series splits DMM_RES_OBJECT into DMM_MAP_OBJECT and DMM_RSV_OBJECT > which are used independently for mapped and reserved memory resources > accounting. This will help in cleanup of reserved memory resources which was > no

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-18 Thread David Vrabel
Mike Rapoport wrote: > > Reverting this hunk and reverting/adjusting changes to IRQ handler makes > SD card recognizable again. No luck with SDIO interrupts though... Your card might need CLKEXTFREE enabled in MMCHSi_CON if it cannot generate card interrupts asynchronously. If that doesn't help

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Paul Walmsley
On Thu, 18 Feb 2010, David Vrabel wrote: > Paul Walmsley wrote: > > > > Perhaps I'm misunderstanding what you're referring to, but it seems there > > is some confusion as to what target smart-idle mode does. > > The TI OMAP 34xx TRM is the one of the most obtuse document I've had to > read. An

Re: Problem specifying which gpio_126 to use on omap353x

2010-02-18 Thread Tony Lindgren
* Peter Barada [100218 08:36]: > On my board I have an isp1760 hooked up using gpio_126 (pin P27 - > MMC1_DAT4/SIM_IO/GPIO_126). From the schematics (and TRM), there is a > 2nd gpio_126 on pin D25 (CAM_STROBE/GPIO_126). > > I tried to use: > > #define ISP1760_IRQ 126 > > omap_mux_init_gpio(ISP

RE: [PATCH 0/9] omap4 updates for 2.6.34

2010-02-18 Thread Shilimkar, Santosh
Thanks Paul !! > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, February 18, 2010 11:06 PM > To: Shilimkar, Santosh > Cc: Tony Lindgren; linux-omap@vger.kernel.org; linux-arm-kernel > Subject: Re: [PATCH 0/9] omap4 updates for 2.6.34 > > Hi Santosh, > >

Re: [PATCH 0/9] omap4 updates for 2.6.34

2010-02-18 Thread Paul Walmsley
Hi Santosh, On Thu, 18 Feb 2010, Shilimkar, Santosh wrote: > This series have few omap4 updates and is based on Tony's > 'omap-for-linus' branch. This series patches are part of the > below series posted on linux-omap for review earlier this week. > > http://www.mail-archive.com/linux-omap@vger

Re: [PATCH 2/9] omap2/3/4: ioremap omap_globals module

2010-02-18 Thread Paul Walmsley
One nitpicky comment on this one also: On Thu, 18 Feb 2010, Santosh Shilimkar wrote: > This is a clean-up patch towards dynamic allocation of IO space > instead of using harcoded macros to calculate virtual addresses. > > Also update the sdrc, prcm, tap and control module to > allocate iospace d

RE: [PATCH 7/9] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Shilimkar, Santosh
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, February 18, 2010 10:53 PM > To: Shilimkar, Santosh > Cc: t...@atomide.com; linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Cousson, > Benoit > Subject: Re: [PATCH 7/9] omap4: Add auto-

Re: PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Grant Likely
On Thu, Feb 18, 2010 at 10:09 AM, Tony Lindgren wrote: > * Grant Likely [100218 08:26]: >> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren wrote: >> > * Hemanth V [100203 02:19]: >> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 >> >> From: Hemanth V >> >> Date: Fri, 2

Re: [PATCH 7/9] omap4: Add auto-generated irq and dma headers

2010-02-18 Thread Paul Walmsley
Hello Santosh, thanks for sending these in. One minor comment: On Thu, 18 Feb 2010, Santosh Shilimkar wrote: > These files are generated along with the HWMOD and will eventually be > in the existing header files as soon as all drivers will be migrate to > omap_hwmod / omap_device. > > The dma-

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Tony Lindgren
* Mark Brown [100218 02:58]: > On Thu, Feb 18, 2010 at 12:58:55PM +0200, Ilkka Koskinen wrote: > > > Is that easiest way to do that? I mean, I'm afraid that the ALSA > > tree doesn't have Janusz Krzysztofik's McBSP register cache patches > > nor does it have your "omap3: Replace ARCH_OMAP34XX wit

Re: [alsa-devel] [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
On Thu, 18 Feb 2010, Ujfalusi Peter (Nokia-D/Tampere) wrote: On Thursday 18 February 2010 14:37:15 Koskinen Ilkka (Nokia-D/Tampere) wrote: ... +static int omap_mcbsp_set_st_channel_vol(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol, +

Re: [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Tony Lindgren
* Ilkka Koskinen [100218 02:54]: > > Hi, > > On Thu, 18 Feb 2010, ext Tony Lindgren wrote: > >* Ilkka Koskinen [100217 06:41]: > >>From: Eero Nurkkala > >> > >>Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. > >> > >>Signed-off-by: Ilkka Koskinen > > > >This one looks

Re: PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Tony Lindgren
* Grant Likely [100218 08:26]: > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren wrote: > > * Hemanth V [100203 02:19]: > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 > >> From: Hemanth V > >> Date: Fri, 27 Nov 2009 14:22:30 +0530 > >> Subject: [PATCH] Update platform

RE: [PATCH] twl6030: add base addr for ID0, ID1, ID2

2010-02-18 Thread Krishnamoorthy, Balaji T
Sending this as a separate patch which was earlier combined with the series http://marc.info/?l=linux-omap&m=126633460408606&w=2 > -Original Message- > From: Krishnamoorthy, Balaji T > Sent: Thursday, February 18, 2010 10:30 PM > To: linux-omap@vger.kernel.org; sa...@linux.intel.com > Cc:

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
> -Original Message- > From: David Vrabel [mailto:david.vra...@csr.com] > Sent: Thursday, February 18, 2010 6:16 AM > To: Madhusudhan > Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org > Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts > > Madhusudhan wrote:

[PATCH] twl6030: add base addr for ID0, ID1, ID2

2010-02-18 Thread balajitk
From: Balaji T K Add base address for generic slave ID0, ID1, ID2 and introduced one more entry to align RTC module number between twl4030 and twl6030 Signed-off-by: Balaji T K --- drivers/mfd/twl-core.c |7 +-- include/linux/i2c/twl.h |5 + 2 files changed, 10 insertions(+),

RE: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-18 Thread Madhusudhan
> > > >> Also, keep in mind that the buffers for transfers must begin and end on > >> a word boundary. The OMAP's DMA controller can only transfer whole > >> words to the MMC FIFO. > > I've slightly modified your patch "mmc: omap_hsmmc: use packet sync'd DMA" > and it > seems to work now, at lea

Problem specifying which gpio_126 to use on omap353x

2010-02-18 Thread Peter Barada
On my board I have an isp1760 hooked up using gpio_126 (pin P27 - MMC1_DAT4/SIM_IO/GPIO_126). From the schematics (and TRM), there is a 2nd gpio_126 on pin D25 (CAM_STROBE/GPIO_126). I tried to use: #define ISP1760_IRQ 126 omap_mux_init_gpio(ISP1760_IRQ, OMAP_PIN_INPUT_PULLUP); if (gpio_request

Re: PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Grant Likely
On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren wrote: > * Hemanth V [100203 02:19]: >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 >> From: Hemanth V >> Date: Fri, 27 Nov 2009 14:22:30 +0530 >> Subject: [PATCH] Update platform files >> >> This patch updates platform fil

Re: [alsa-devel] [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 15:56:03 +0200 Peter Ujfalusi wrote: > > Are you sure about these ids? Same comment to the patch 2 as well. > > Worth to check. > > They are correct. > mcbsp->id is 1 based (1 -> McBSP1, 2 -> McBSP2, etc) > While the exported functions expect the id to > be 0 based (0 -> McBS

Re: [PATCH] PM-WIP-OPP: Fixing wrong target level being passed during Core DVFS.

2010-02-18 Thread Menon, Nishanth
Gopinath, Thara said the following on 02/18/2010 10:31 AM: As per the current implementaion (u8*)&target_level is being passed to freq_to_opp in set_opp. This would result in updating just the first 8 bits of a u32 variable. Later target_level is passed to resource_set_opp_level as a u32 paramete

[PATCH v6] OMAP UART: Add omap-serial driver support.

2010-02-18 Thread Govindraj.R
>From 81fe9a08684830e84e64bed57c7f90e7461a5375 Mon Sep 17 00:00:00 2001 From: Govindraj R Date: Thu, 18 Feb 2010 19:34:04 +0530 Subject: [PATCH] OMAP UART: Add omap-serial driver support. This patch adds support for OMAP-HIGH SPEED UART Controller. It adds support for the following features: 1. I

RE: [PATCHv4 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-18 Thread Ameya Palande
Hi Fernando, On Thu, 2010-02-18 at 02:40 +0100, ext Guzman Lugo, Fernando wrote: > Hi, > > >-Original Message- > >From: Ameya Palande [mailto:ameya.pala...@nokia.com] > >Sent: Wednesday, February 17, 2010 12:06 PM > >To: linux-omap@vger.kernel.org > >Cc: felipe.contre...@nokia.com; Menon,

Re: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
Hi Felipe, On Thu, 2010-02-18 at 15:27 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: > On Thu, Feb 18, 2010 at 01:15:55PM +0100, Ameya Palande wrote: > > On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: > > > What do you think about it? > > > Instead of removing DRV_InsertDM

[PATCH 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
This patch improves current mapped memory cleanup mechanism by using linux native list implementation. As a side effect we also get following benefits: 1. Unnecessary data members in DMM_MAP_OBJECT are removed which results in memory saving. 2. Following functions are removed as they are not n

[PATCH 3/4] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

2010-02-18 Thread Ameya Palande
This patch fixes following issues: 1. pDMMRes was dereferenced and modified when it was already freed by PROC_Ummap(). This results in memory corruption. 2. Instead of passing ulDSPAddr, ulDSPResAddr was passed to PROC_UnMap() which will not retrieve correct DMMRes element. Signed-off-by:

[PATCH 1/4] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

2010-02-18 Thread Ameya Palande
In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup. Signed-off-by: Ameya Palande Reviewed-by: Felip

[PATCH 2/4] DSPBRIDGE: New reserved memory accounting framework

2010-02-18 Thread Ameya Palande
DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palande --- arch/arm/plat-omap/include/dspbridge/drv.h | 10 arch/arm/plat-omap/include/dspbridge/pro

[PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

2010-02-18 Thread Ameya Palande
This patch series splits DMM_RES_OBJECT into DMM_MAP_OBJECT and DMM_RSV_OBJECT which are used independently for mapped and reserved memory resources accounting. This will help in cleanup of reserved memory resources which was not handled properly before. With these patches resource cleanup mechanis

Re: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Felipe Contreras
On Thu, Feb 18, 2010 at 01:15:55PM +0100, Ameya Palande wrote: > On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: > > What do you think about it? > > Instead of removing DRV_InsertDMMResElement make it an inline function with > > your code inside: > > Making DRV_InsertDMMResEle

Re: [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Peter Ujfalusi
On Thursday 18 February 2010 14:37:15 Koskinen Ilkka (Nokia-D/Tampere) wrote: ... > +static int omap_mcbsp_set_st_channel_vol(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol, > + int id, int channel) >

Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Peter Ujfalusi
On Thursday 18 February 2010 15:06:21 ext Jarkko Nikula wrote: > On Wed, 17 Feb 2010 16:45:58 +0200 > > Ilkka Koskinen wrote: > > The first patch implements McBSP sidetone feature on OMAP3 while the > > second one provides ALSA interface for using it. > > Do I have something wrong since I cannot

Re: [alsa-devel] [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Peter Ujfalusi
Hello, On Thursday 18 February 2010 15:24:13 ext Jarkko Nikula wrote: > On Thu, 18 Feb 2010 14:37:14 +0200 > > Ilkka Koskinen wrote: > > static inline void __devexit omap34xx_device_exit(struct omap_mcbsp > > *mcbsp) { > > > > - if (cpu_is_omap34xx()) > > + if (cpu_is_omap34xx()) { > > >

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread David Vrabel
Paul Walmsley wrote: > > Perhaps I'm misunderstanding what you're referring to, but it seems there > is some confusion as to what target smart-idle mode does. The TI OMAP 34xx TRM is the one of the most obtuse document I've had to read. An even after multiple reads of relevant sections it still

Re: [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 14:37:14 +0200 Ilkka Koskinen wrote: > static inline void __devexit omap34xx_device_exit(struct omap_mcbsp *mcbsp) > { > - if (cpu_is_omap34xx()) > + if (cpu_is_omap34xx()) { > omap_additional_remove(mcbsp->dev); > + > + if (mcbsp->id == 2 |

Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Wed, 17 Feb 2010 16:45:58 +0200 Ilkka Koskinen wrote: > The first patch implements McBSP sidetone feature on OMAP3 while the second > one > provides ALSA interface for using it. > Do I have something wrong since I cannot adjust the controls? Both "McBSP2 Sidetone Channel [0|1]" show 50%. I

[PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone

2010-02-18 Thread Ilkka Koskinen
Add ASoC interface for OMAP McBSP2 and McBSP3 sidetones. Signed-off-by: Ilkka Koskinen --- sound/soc/omap/omap-mcbsp.c | 157 +++ sound/soc/omap/omap-mcbsp.h |2 + 2 files changed, 159 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/omap-mc

[PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
From: Eero Nurkkala Add sidetone feature to McBSP instances 2 and 3 on OMAP3 based devices. Signed-off-by: Ilkka Koskinen Acked-by: Tony Lindgren --- arch/arm/mach-omap2/mcbsp.c |2 + arch/arm/plat-omap/include/plat/mcbsp.h | 63 + arch/arm/plat-omap/mcbsp.c

[PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA interfa

Re: [PATCH 2/2] twl6030: regulator: Configure STATE register instead of REMAP

2010-02-18 Thread Liam Girdwood
On Wed, 2010-02-17 at 20:54 +0530, Rajendra Nayak wrote: > This is no REMAP register on twl6030, instead there is a STATE register > to drive a resource to a given state. > The state register can be used to specify what state the resource should > enter when its associated with a GRP. > Register Bi

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread David Vrabel
Madhusudhan wrote: > > My question was more related to the idle path. In a scenario where > you start using the SDIO functionality and after some time you leave > the SDIO card idle, does the FCLK still remain enabled? Or do you see > that sdio_irq_thread exits and disables the FCLK? What do you

RE: [PATCHv4 4/4] DSPBRIDGE: Improved mapped memory cleanup

2010-02-18 Thread Ameya Palande
Hi Fernando, On Thu, 2010-02-18 at 02:52 +0100, ext Guzman Lugo, Fernando wrote: > Hi, > > >-Original Message- > >From: Ameya Palande [mailto:ameya.pala...@nokia.com] > >Sent: Wednesday, February 17, 2010 12:06 PM > >To: linux-omap@vger.kernel.org > >Cc: felipe.contre...@nokia.com; Menon,

Re: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

2010-02-18 Thread Mark Brown
On Thu, Feb 18, 2010 at 05:09:53PM +0530, Nayak, Rajendra wrote: > Mark, I get your point. The table values were derived from what the spec > suggests, but I agree that its confusing that in theory the formula > suggests there could be more selectors than whats present in the table. > I will chec

  1   2   >