Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-21 Thread Ohad Ben-Cohen
[removed that bouncing email address we had all along :] On Thu, Oct 21, 2010 at 1:58 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Why would we need platform-specific function pointers here ? I'm not sure I'm following this one. So that board code (built-in) does not call the

Unknown symbol errors when insmod wl1271_sdio.ko and wl1271.ko

2010-10-21 Thread Elvis Dowson
Hi, I'm using the following wl127xx.git branch, and trying to bringup my board using the kernel drivers for wl1271 wlan module with a beagleboard design. I haven't yet applied luca's patches, and thought I'd try with seeing if the built drivers are loading properly. I get the

Re: Unknown symbol errors when insmod wl1271_sdio.ko and wl1271.ko

2010-10-21 Thread Luciano Coelho
On Thu, 2010-10-21 at 08:30 +0200, ext Elvis Dowson wrote: Hi, I'm using the following wl127xx.git branch, and trying to bringup my board using the kernel drivers for wl1271 wlan module with a beagleboard design. I haven't yet applied luca's patches, and thought I'd try with

RE: [PATCH 3/3] omap: add hwspinlock device

2010-10-21 Thread Kamoolkar, Mugdha
khil...@deeprootsystems.com wrote: Let's take the i2c-omap for example. It sounds like it must have a predefined hwspinlock, but what if: 1. It will use omap_hwspinlock_request() to dynamically allocate a hwspinlock 2. Obviously, the hwspinlock id number must be communicated to the

Re: [PATCH V3] OMAP: DSS2: don't power off a panel twice

2010-10-21 Thread Grazvydas Ignotas
Tomi can you queue this? This has been tested by multiple people now, also see here: http://marc.info/?l=linux-omapm=128759415821646w=2 On Fri, Sep 3, 2010 at 6:03 AM, Stanley.Miao stanley.m...@windriver.com wrote: If we blank the panel by echo 1 /sys/devices/platform/omapfb/graphics/fb0/blank

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-21 Thread Arnd Bergmann
On Thursday 21 October 2010, Ohad Ben-Cohen wrote: This sounds like adding a set of API that resembles spin_{unlock,lock}_irq. My gut feeling here is that while this may be useful and simple at certain places, it is somewhat error prone; a driver which would erroneously use this at the wrong

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Contreras
On Wed, Oct 20, 2010 at 8:54 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 20, 2010 at 11:22:17AM -0500, Felipe Contreras wrote: Users would not need to care... if they enable USB and USB_GADGET, it will be selected automatically for OMAP3, which is what users would expect. wouldn't a

Re: [PATCH 3/3] omap: add hwspinlock device

2010-10-21 Thread Ohad Ben-Cohen
On Thu, Oct 21, 2010 at 10:36 AM, Kamoolkar, Mugdha mug...@ti.com wrote: khil...@deeprootsystems.com wrote: Yes, that would indeed simplify things. Balaji, Nishant, are you OK with this ? The problem with this approach is that the i2c driver would have to sync up on the shared memory

RE: [PATCH V3] OMAP: DSS2: don't power off a panel twice

2010-10-21 Thread Guruswamy, Senthilvadivu
-Original Message- From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev- ow...@vger.kernel.org] On Behalf Of Grazvydas Ignotas Sent: Thursday, October 21, 2010 2:32 PM To: tomi.valkei...@nokia.com Cc: Stanley.Miao; linux-omap@vger.kernel.org; bryan...@canonical.com;

[PATCH] omap: am3517: fix build break

2010-10-21 Thread Anand Gadiyar
: Tony Lindgren t...@atomide.com Cc: Ajay Kumar Gupta ajay.gu...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@suse.de --- Build break observed with linux-next as of 20101021. Greg, okay with me to fold this into the original patch if the others in copy agree. It's a trivial

RE: [PATCH] OMAP: hmwod: Update the sysc_cache in case module context is lost

2010-10-21 Thread Nayak, Rajendra
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, October 15, 2010 9:10 PM To: Shilimkar, Santosh Cc: Nayak, Rajendra; linux-omap@vger.kernel.org; Paul Walmsley; Cousson, Benoit Subject: Re: [PATCH] OMAP: hmwod: Update the sysc_cache in case

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-21 Thread Ohad Ben-Cohen
On Thu, Oct 21, 2010 at 11:04 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 21 October 2010, Ohad Ben-Cohen wrote: This sounds like adding a set of API that resembles spin_{unlock,lock}_irq. My gut feeling here is that while this may be useful and simple at certain places, it is somewhat

Re: [PATCH] smsc95xx: generate random MAC address once, not every ifup

2010-10-21 Thread David Miller
From: Bernard Blackham bern...@largestprime.net Date: Tue, 19 Oct 2010 10:16:39 +1100 The smsc95xx driver currently generates a new random MAC address every time the interface is brought up. This makes it impossible to override using the standard `ifconfig hw ether` approach. Past patches

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Balbi
hi, On Thu, Oct 21, 2010 at 04:04:27AM -0500, Felipe Contreras wrote: wouldn't a user expect USB to be enabled if the board _has_ a USB connector ? Not if it's not going to be used. and how would you know before hand if it's going to be used or not ? 1) Do you think all the OMAP3 boards

Re: [PATCH] omap: am3517: fix build break

2010-10-21 Thread Felipe Balbi
On Thu, Oct 21, 2010 at 04:20:06AM -0500, Gadiyar, Anand wrote: Patch usb-am35x-add-musb-support.patch in greg's USB queue adds backan include of plat/control.h. This file was renamed by another commit in the omap tree and the file was already fixed to reflect this. Remove this include to fix

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Contreras
Hi, On Thu, Oct 21, 2010 at 1:24 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Oct 21, 2010 at 04:04:27AM -0500, Felipe Contreras wrote: wouldn't a user expect USB to be enabled if the board _has_ a USB connector ? Not if it's not going to be used. and how would you know before hand if

Re: [PATCH 1/3] drivers: misc: add omap_hwspinlock driver

2010-10-21 Thread Arnd Bergmann
On Thursday 21 October 2010, Ohad Ben-Cohen wrote: The change is also pretty trivial: * move the internal locking implementation to raw_ methods * the raw_ methods would save the current interrupt state only if given a placeholder * wrap those raw_ methods with the desired API (but only

RE: [PATCH 3/3] omap: add hwspinlock device

2010-10-21 Thread Kanigeri, Hari
Mugdha, This does not require any smart IPC and it will allow us to get rid of the omap_hwspinlock_request_specific() API and its early-callers requirement. Yes, that would indeed simplify things. Balaji, Nishant, are you OK with this ? The problem with this approach is

[PATCH v2] OMAP: DSS2: Add NEC NL8048HL11-01B display panel

2010-10-21 Thread Samreen
From: Erik Gilling konk...@android.com NEC WVGA LCD NL8048HL11-01B panel support has been added. This panel is being used in zoom2/zoom3/3630 sdp boards. Signed-off-by: Mukund Mittal mmit...@ti.com Signed-off-by: Rajkumar N rajkumar.nagara...@ti.com Signed-off-by: Samreen samr...@ti.com CC:

Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice

2010-10-21 Thread Tomi Valkeinen
Hi, On Fri, 2010-09-03 at 04:52 +0200, ext stanley.miao wrote: Hi, Tomi, Tomi Valkeinen wrote: snip Otherwise this looks fine, except that panel-taal.c does not need modifications, as it already handles this case. I will send a V3 to remove the panel-taal.c part. Also, at

Re: [PATCH V3] OMAP: DSS2: don't power off a panel twice

2010-10-21 Thread Tomi Valkeinen
On Thu, 2010-10-21 at 11:02 +0200, ext Grazvydas Ignotas wrote: Tomi can you queue this? This has been tested by multiple people now, also see here: http://marc.info/?l=linux-omapm=128759415821646w=2 Yes, I seem to have missed/forgotten this. I'll add it to my tree. Tomi -- To unsubscribe

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Roger Quadros
Hi, On 10/20/2010 05:38 PM, ext Felipe Contreras wrote: On Wed, Oct 20, 2010 at 3:33 PM, Roger Quadrosroger.quad...@nokia.com wrote: On 10/20/2010 12:23 PM, ext Felipe Contreras wrote: On Wed, Oct 20, 2010 at 12:14 PM, Roger Quadrosroger.quad...@nokia.com wrote: USB_G_NOKIA just needs a

Re: [PATCH] OMAP: hmwod: Update the sysc_cache in case module context is lost

2010-10-21 Thread Cousson, Benoit
On 10/21/2010 12:13 PM, Nayak, Rajendra wrote: snip Hi Kevin, What the patch does is reprogram's the sysc value (from the cache) whenever its lost. So its infact saved in the cache and restored when needed. Otherwise, all this patch does is refresh the _sysc_cache with completely unknown

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Felipe Balbi
Hi, On Thu, Oct 21, 2010 at 09:07:59AM -0500, Roger Quadros wrote: But I'm not sure that omap_udc is used only for OMAP1 architecture. Dave/Tony should confirm this. Maybe the old omap2420_h4 board still uses it, but from 2430 I think the ip isn't even there anymore. -- balbi -- To

Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

2010-10-21 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [101021 08:32]: Hi, On Thu, Oct 21, 2010 at 09:07:59AM -0500, Roger Quadros wrote: But I'm not sure that omap_udc is used only for OMAP1 architecture. Dave/Tony should confirm this. Maybe the old omap2420_h4 board still uses it, but from 2430 I think the ip

Re: linux-next - multi-omap image fails to boot on omap3/4

2010-10-21 Thread Tony Lindgren
* Gadiyar, Anand gadi...@ti.com [101019 23:21]: On Wed, Oct 20, 2010 at 5:16 AM, Gadiyar, Anand gadi...@ti.com wrote: On Wed, Oct 20, 2010 at 5:02 AM, Tony Lindgren t...@atomide.com wrote: * Tony Lindgren t...@atomide.com [101019 15:48]: * Gadiyar, Anand gadi...@ti.com [101019 11:26]: On

Re: [PATCH] OMAP: hmwod: Update the sysc_cache in case module context is lost

2010-10-21 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, October 15, 2010 9:10 PM To: Shilimkar, Santosh Cc: Nayak, Rajendra; linux-omap@vger.kernel.org; Paul Walmsley; Cousson, Benoit Subject: Re: [PATCH] OMAP:

Re: [RFC/PATCH 2/2] OMAP3: CPUidle: trigger early idle notification call chain

2010-10-21 Thread Kevin Hilman
Sripathy, Vishwanath vishwanath...@ti.com writes: During the early part of the CPUidle path (state selection by the governer, checking for device activity, etc.) there is no (good) reason to have interrupts disabled. Therefore, enable interrupts early in the CPUidle path and then trigger

Re: [RFC/PATCH 2/2] OMAP3: CPUidle: trigger early idle notification call chain

2010-10-21 Thread Kevin Hilman
[updated version of the patch, fixing issues raised by Vishwa] From 1661b0f7ad614d221f90eed590040f2cca01c265 Mon Sep 17 00:00:00 2001 From: Kevin Hilman khil...@deeprootsystems.com Date: Thu, 23 Sep 2010 09:54:41 -0700 Subject: [PATCH] OMAP3: CPUidle: trigger early idle notification call chain

Re: [PATCH 2/5] arm: omap: counter-32k: convert to pm_runtime API

2010-10-21 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Trivial patch removing clock framework and adding pm_runtime API. Signed-off-by: Felipe Balbi ba...@ti.com Minor nit: the runtime PM 'put' calls do not need to be the _sync versions. You can easily get by using the normal (async) versions here. Kevin

Re: [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4

2010-10-21 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Add 32k timer hwmod to the database. Signed-off-by: Felipe Balbi ba...@ti.com Not sure how this is working correctly on OMAP2 and OMAP3. All the hwmods are mising the oh-prcm.omap2.module_offs field. Without this, _wait_target_ready *should* fail, and the

Re: [PATCH 0/5] 32k sync timer meets hwmod

2010-10-21 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Converted 32k-sync timer to platform_driver and now using pm_runtime and hwmod. Tested on 3430 by me and 4430 by Tarun If someone could test on 2430 and 2420, I would be really glad. Hey, don't you have a 2420 device. There were some cool 2420-based

Re: [PATCH] omap: am3517: fix build break

2010-10-21 Thread Greg KH
to fix up a build break. Signed-off-by: Anand Gadiyar gadi...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Ajay Kumar Gupta ajay.gu...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@suse.de --- Build break observed with linux-next as of 20101021. Greg, okay with me

RE: [PATCH 4/7] omap:mailbox-send message in process context

2010-10-21 Thread Sapiens, Rene
Hi Hari, On Thursday, October 14, 2010 9:13 PM Kanigeri, Hari wrote: Schedule the Tasklet to send only when mailbox fifo is full, else send the message in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri

Re: [PATCH 2/5] arm: omap: counter-32k: convert to pm_runtime API

2010-10-21 Thread Felipe Balbi
On Thu, Oct 21, 2010 at 12:46:11PM -0500, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Trivial patch removing clock framework and adding pm_runtime API. Signed-off-by: Felipe Balbi ba...@ti.com Minor nit: the runtime PM 'put' calls do not need to be the _sync versions. You can

[PATCH] ARM: OMAP: Modified omap_mux_init_signal() to take in const char *

2010-10-21 Thread Tim Nordell
If one does the following line twice with the old code: omap_mux_init_signal(uart3_rts_sd.gpio_164, OMAP_PIN_INPUT); omap_mux_init_signal(uart3_rts_sd.gpio_164, OMAP_PIN_INPUT); the compiler optimizes the two const strings into one string internally in the compiler. The old code would modify

Re: [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4

2010-10-21 Thread Felipe Balbi
On Thu, Oct 21, 2010 at 12:57:41PM -0500, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Add 32k timer hwmod to the database. Signed-off-by: Felipe Balbi ba...@ti.com Not sure how this is working correctly on OMAP2 and OMAP3. All the hwmods are mising the oh-prcm.omap2.module_offs

Re: [PATCH 0/5] 32k sync timer meets hwmod

2010-10-21 Thread Felipe Balbi
On Thu, Oct 21, 2010 at 01:00:19PM -0500, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Converted 32k-sync timer to platform_driver and now using pm_runtime and hwmod. Tested on 3430 by me and 4430 by Tarun If someone could test on 2430 and 2420, I would be really glad. Hey, don't

Re: [PATCH] ARM: OMAP: Modified omap_mux_init_signal() to take in const char *

2010-10-21 Thread Tim Nordell
On 10/21/10 13:50, Tim Nordell wrote: If one does the following line twice with the old code: omap_mux_init_signal(uart3_rts_sd.gpio_164, OMAP_PIN_INPUT); omap_mux_init_signal(uart3_rts_sd.gpio_164, OMAP_PIN_INPUT); the compiler optimizes the two const strings into one string internally in

Re: [PATCH 2/5] arm: omap: counter-32k: convert to pm_runtime API

2010-10-21 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: On Thu, Oct 21, 2010 at 12:46:11PM -0500, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Trivial patch removing clock framework and adding pm_runtime API. Signed-off-by: Felipe Balbi ba...@ti.com Minor nit: the runtime PM 'put' calls do not need to

Re: [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4

2010-10-21 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: On Thu, Oct 21, 2010 at 12:57:41PM -0500, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Add 32k timer hwmod to the database. Signed-off-by: Felipe Balbi ba...@ti.com Not sure how this is working correctly on OMAP2 and OMAP3. All the hwmods are

Re: [PATCH 4/5] arm: omap: introduce 32k timer hwmod for omap2/3/4

2010-10-21 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Add 32k timer hwmod to the database. Signed-off-by: Felipe Balbi ba...@ti.com --- Looking closer at this patch, there are some other problems... [...] +static struct omap_hwmod omap2420_counter_32k_hwmod = { + .name = counter_32k, +

Re: [PATCH 4/7] omap:mailbox-send message in process context

2010-10-21 Thread Hari Kanigeri
Rene, Thanks for your comment. @@ -92,20 +92,25 @@ int omap_mbox_msg_send(struct omap_mbox *mbox,       mbox_msg_t msg) struct omap_mbox_queue *mq = mbox-txq;       int ret = 0, len; -     spin_lock(mq-lock); +     spin_lock_bh(mq-lock); Please check if this scenario looks valid to

RE: [PATCH 4/7] omap:mailbox-send message in process context

2010-10-21 Thread Sapiens, Rene
Hari, On Thursday, October 21, 2010 3:49 PM Hari Kanigeri wrote: Rene, Thanks for your comment. @@ -92,20 +92,25 @@ int omap_mbox_msg_send(struct omap_mbox *mbox,       mbox_msg_t msg) struct omap_mbox_queue *mq = mbox-txq;       int ret = 0, len; -     spin_lock(mq-lock); +    

RE: [PATCH v2] OMAP: DSS2: Add NEC NL8048HL11-01B display panel

2010-10-21 Thread Nilofer, Samreen
Grazvydas Ignotas wrote: On Thu, Oct 21, 2010 at 3:25 PM, Samreen samr...@ti.com wrote: From: Erik Gilling konk...@android.com NEC WVGA LCD NL8048HL11-01B panel support has been added. This panel is being used in zoom2/zoom3/3630 sdp boards. snip diff --git