Re: [PATCH 6/6] omap: iommu: code reorganization and cleanup

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Since omap-iommu is now using hwmod, there are structures and arrays that can be cleaned up to increase the readability of the code. This patch should be merged with the previous one as well. I do not see the need to split in 3 patches these chan

Re: [PATCH 5/6] omap: iommu: hwmod device enable/disable routines

2010-11-06 Thread Cousson, Benoit
You should use runtime PM directly. That omap_device step is useless. Moreover, this patch should be merged with the previous one. Benoit On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Use omap device enable/disable routines. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/omap-io

Re: [PATCH 4/6] omap: iommu: intial hwmod support

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Use the defined hwmod data according to the devices present on omap3 and omap4. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/omap-iommu.c| 77 --- arch/arm/plat-omap/include/plat/iommu.h |2 +

Re: [PATCH 3/6] OMAP4: hwmod data: add mmu hwmod for ducati and tesla

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Add mmu hwmod data for ducati and tesla. s/ducati/ipu/ s/tesla/dsp/ Please do not use internal codename. Here again, you completely changed the omap4 existing data for (almost) nothing. I agree, the original code was not considering the mmu a

Re: [PATCH 2/6] OMAP3: hwmod data: Add mmu for iva2 and isp

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Add mmu hwmod data for iva2 and isp. s/iva2/iva/ If you do need the version information, you should use the rev field in the hwmod class. All the comments about the structure fields order I did on your mailbox series will apply here as well.

Re: [PATCH 1/6] omap: iommu: remove redundant clock usage

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: iommu driver is meant to provide control of mmu hardware blocks A dot is missing here, and a capital letter should follow. its current users (MMUs) are part of larger subsystems and do not have a dedicated clock as the one they use is shared wit

RE: Mistral AM37x (with AM3715) devel board networking broken

2010-11-06 Thread Premi, Sanjeev
> From: linux-omap-ow...@vger.kernel.org [linux-omap-ow...@vger.kernel.org] On > Behalf Of Rick Bronson [r...@efn.org] > Sent: Saturday, November 06, 2010 8:50 PM > To: linux-omap@vger.kernel.org > Cc: srin...@mistralsolutions.com > Subject: Mistral AM37x (with AM3715) devel board networking broke

Re: [PATCH 0/6] omap: iommu: hwmod support and code reorganization

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Boot tested on omap 3430 and 3630, functionality on iva2 only. Introduced hwmod data and support for omap3 (iva2 mmu& isp mmu) and omap4 (ducati mmu& tesla mmu). Minor cleanup due to this changes. There is an issue (present without patches too)

Re: [PATCH v2 0/7] omap: mailbox: hwmod support and dependent cleanup patches

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: hwmod support for omap2 and omap3 chips, plus cleanups. Tested on 3430 and 3630 ** v2 ** - Added omap4 hwmod support. - Moved "mailbox_ick" from hwmod to hwmod_if (omap 2/3) - Declared sysc classes for omap 2/3 ** v1 ** 1. omap: mailbox: initial

Re: [PATCH 0/6] omap: iommu: hwmod support and code reorganization

2010-11-06 Thread Cousson, Benoit
s/ducati/ipu/ s/tesla/dsp/ Please do not use internal codename for the changelog or even for the code. On 11/5/2010 9:19 PM, Ramirez Luna, Omar wrote: Boot tested on omap 3430 and 3630, functionality on iva2 only. Introduced hwmod data and support for omap3 (iva2 mmu& isp mmu) and omap4 (duca

Re: [PATCH v2 08/12] staging: tidspbridge: convert rmgr to list_head

2010-11-06 Thread Greg KH
On Sat, Nov 06, 2010 at 08:18:27PM +0200, Ionut Nicu wrote: > Hi Rene, > > On Fri, 2010-11-05 at 18:07 -0600, Sapiens, Rene wrote: > > Hi Ionut, > > > > On Fri, Nov 5, 2010 at 9:13 AM, Ionut Nicu wrote: > > > Convert the rmgr module of the tidspbridge driver > > > to use struct list_head instead

Re: [PATCH v2 7/7] omap: mailbox: remove unreachable return

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: Remove unreachable return statement. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/mailbox.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c index

Re: [PATCH v2 08/12] staging: tidspbridge: convert rmgr to list_head

2010-11-06 Thread Ionut Nicu
Hi Rene, On Fri, 2010-11-05 at 18:07 -0600, Sapiens, Rene wrote: > Hi Ionut, > > On Fri, Nov 5, 2010 at 9:13 AM, Ionut Nicu wrote: > > Convert the rmgr module of the tidspbridge driver > > to use struct list_head instead of struct lst_list. > > > > Signed-off-by: Ionut Nicu > > > > > diff --

Re: [PATCH v2 6/7] omap: mailbox: fix detection for previously supported chips

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: Fix the mailbox detection for OMAP3630 and 2430, also minor cleanup on conditional ifdef's that could affect it. Given that 2430 has an iva too include it, as the same steps for omap3 apply. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-oma

Re: [PATCH v2 5/7] omap: mailbox: add omap_device latency information

2010-11-06 Thread Cousson, Benoit
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: From: Felipe Contreras So that we can enable the main clock. Why not going directly to the runtime PM interface? It will save you some effort, because most of this code is useless with runtime PM. Moreover, even without runtime PM, you should

Re: [PATCH v2 4/7] omap: mailbox: initial hwmod support

2010-11-06 Thread Cousson, Benoit
Hi Felipe, On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: From: Felipe Contreras hwmod support for omap mailbox module. Signed-off-by: Felipe Contreras Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/devices.c | 100 ++-- 1 files changed, 15 in

Re: [PATCH v2 06/12] staging: tidspbridge: convert core to list_head

2010-11-06 Thread Ionut Nicu
Hi Rene, On Fri, 2010-11-05 at 16:12 -0600, Sapiens, Rene wrote: > Hi Ionut, > > On Fri, Nov 5, 2010 at 9:13 AM, Ionut Nicu wrote: > > Convert the core module of the tidspbridge driver > > to use struct list_head instead of struct lst_list. > > > > Signed-off-by: Ionut Nicu > > > > > diff --

Re: [PATCH v2 06/12] staging: tidspbridge: convert core to list_head

2010-11-06 Thread Ionut Nicu
Hi Rene, On Fri, 2010-11-05 at 15:07 -0600, Sapiens, Rene wrote: > Hi Ionut, > > On Fri, Nov 5, 2010 at 9:13 AM, Ionut Nicu wrote: > > Convert the core module of the tidspbridge driver > > to use struct list_head instead of struct lst_list. > > > > > > >if (!status) { > >

Re: [PATCH v2 3/7] OMAP4: hwmod data: add mailbox data

2010-11-06 Thread Cousson, Benoit
I don't know why, but this patch has nothing to do with my original one. Can you stick to the original code? Of course, if you have valid comments or need to add extra data, you can, but in this case, I do not see any needed change. On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: From: Benoit

Re: [PATCH v2 1/7] OMAP2: hwmod data: add mailbox data

2010-11-06 Thread Cousson, Benoit
Hi Omar, On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote: hwmod data for omap2430 and 2420. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 67 arch/arm/mach-omap2/omap_hwmod_2430_data.c | 66 +++ 2 fi

Mistral AM37x (with AM3715) devel board networking broken

2010-11-06 Thread Rick Bronson
Hi, Should I be able to use the latest omap-linux-2.6 on this board? I tried: git clone git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git cd linux-omap-2.6; make omap2plus_defconfig ARCH=arm; make I get some warnings when it boots but it fails to setup the networking

[PATCH] arm: fix compilation warning during compilation

2010-11-06 Thread Marco Stornelli
From: Marco Stornelli During compilation of 2.6.36 for Beagle board, there a are a couple of warnings. This patch fix them. Signed-off-by: Marco Stornelli --- --- linux-2.6.36-orig/arch/arm/plat-omap/include/plat/usb.h 2010-10-20 22:30:22.0 +0200 +++ linux-2.6.36/arch/arm/plat-om

Re: [PATCH 6/6] omap: iommu: code reorganization and cleanup

2010-11-06 Thread Felipe Contreras
On Sat, Nov 6, 2010 at 3:19 AM, Omar Ramirez Luna wrote: > Since omap-iommu is now using hwmod, there are structures and > arrays that can be cleaned up to increase the readability of > the code. > > Signed-off-by: Omar Ramirez Luna NAK. > --- >  arch/arm/mach-omap2/omap-iommu.c        |   95