Re: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-03 Thread Marc Kleine-Budde
On 08/20/2012 01:20 PM, AnilKumar Ch wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned off. Signed-off-by: AnilKumar Ch anilku...@ti.com --- This patch has

Re: [PATCH v2 09/23] OMAPDSS: Create links between managers, outputs and devices

2012-09-03 Thread Archit Taneja
On Friday 31 August 2012 08:38 PM, Tomi Valkeinen wrote: On Fri, 2012-08-31 at 17:45 +0300, Tomi Valkeinen wrote: So I'm not really against having the enum. It just would've been neat to have the output type and instance number encoded into this enum, so that it'd be easy to extract either

Re: [PATCH v2 09/23] OMAPDSS: Create links between managers, outputs and devices

2012-09-03 Thread Tomi Valkeinen
On Mon, 2012-09-03 at 14:56 +0530, Archit Taneja wrote: On Friday 31 August 2012 08:38 PM, Tomi Valkeinen wrote: On Fri, 2012-08-31 at 17:45 +0300, Tomi Valkeinen wrote: So I'm not really against having the enum. It just would've been neat to have the output type and instance number

[PATCH] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

2012-09-03 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn pdata and pdata-regs have been allocated in this function and should be freed before leaving it, and in the other error handling cases too. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by:

RE: [PATCH 6/9] ARM: OMAP: Move gpio.h to include/linux/platform_data

2012-09-03 Thread Mohammed, Afzal
Hi, On Fri, Aug 31, 2012 at 06:22:34, Tony Lindgren wrote: This way we can remove includes of plat/gpio.h which won't work with the single zImage support. Note that we also remove the cpu_class_is_omap2() check in gpio-omap.c as the drivers should not call it as we need to make it local to

RE: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-03 Thread AnilKumar, Chimata
Marc, On Mon, Sep 03, 2012 at 14:22:22, Marc Kleine-Budde wrote: On 08/20/2012 01:20 PM, AnilKumar Ch wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned

Re: [PATCH] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

2012-09-03 Thread Russell King - ARM Linux
On Mon, Sep 03, 2012 at 06:13:33PM +0800, Wei Yongjun wrote: @@ -130,6 +132,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) pdev = omap_device_build(name, id - 1, oh, pdata, sizeof(*pdata), NULL, 0, false); +

[PATCH 3/4] ARM: AM33XX: board-generic: Add of_dev_auxdata to pass d_can raminit

2012-09-03 Thread AnilKumar Ch
Add of_dev_auxdata to pass d_can raminit callback APIs to initialize d_can RAM. D_CAN RAM initialization bits are present in CONTROL module address space, which can be accessed by platform specific code. So callback functions are added to serve this purpose, this can done by using of_dev_auxdata.

[PATCH 1/4] can: c_can: Adopt pinctrl support

2012-09-03 Thread AnilKumar Ch
Adopt pinctrl support to c_can driver based on c_can device pointer, pinctrl driver configure SoC pins to d_can mode according to definitions provided in .dts file. In device specific device tree file 'pinctrl-names = default;' and 'pinctrl-0 = d_can1_pins;' needs to add to configure pins from

[PATCH 2/4] can: c_can: Add d_can raminit support

2012-09-03 Thread AnilKumar Ch
Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM. DCAN RAM holds all the message objects during transmission or receiving of data. This initialization/de-initialization should be done in synchronous with D_CAN clock. Signed-off-by: AnilKumar Ch anilku...@ti.com ---

[PATCH 0/4] can: c_can: Add suspend/resume and pinctrl support

2012-09-03 Thread AnilKumar Ch
Adds suspend/resume functionality of d_can driver along with d_can raminit support which is required to initialize RAM while data transmission. This patch series also adds pinctrl support to c_can driver. These patches were tested on AM335x-EVM. This patch-series is based ontop of runtimePM

[PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-03 Thread AnilKumar Ch
Adds suspend resume support to DCAN driver which enables DCAN power down mode bit (PDR). Then DCAN will ack the local power-down mode by setting PDA bit in STATUS register. Also adds a status flag to know the status of DCAN module, whether it is opened or not. Signed-off-by: AnilKumar Ch

RE: [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone

2012-09-03 Thread AnilKumar, Chimata
Hi Koen, On Sat, Sep 01, 2012 at 18:21:10, AnilKumar, Chimata wrote: Hi Koen, On Sat, Sep 01, 2012 at 16:17:35, Koen Kooi wrote: Op 1 sep. 2012 om 09:01 heeft AnilKumar, Chimata anilku...@ti.com het volgende geschreven: Hi Koen, On Fri, Aug 31, 2012 at 21:23:18, Koen

Re: [PATCH] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

2012-09-03 Thread Wei Yongjun
On 09/03/2012 07:11 PM, Russell King - ARM Linux wrote: On Mon, Sep 03, 2012 at 06:13:33PM +0800, Wei Yongjun wrote: @@ -130,6 +132,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) pdev = omap_device_build(name, id - 1, oh, pdata,

Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-03 Thread Sean Young
On Sun, Sep 02, 2012 at 11:08:20PM +0300, Timo Kokkonen wrote: On 09/02/12 22:41, Sakari Ailus wrote: On Sun, Sep 02, 2012 at 06:20:27PM +0300, Timo Kokkonen wrote: On 09.02 2012 18:06:34, Sakari Ailus wrote: Heippa, Timo Kokkonen wrote: Terve, On 09/01/12 20:14, Sakari Ailus

RE: [PATCH] ARM: OMAP2+: select PINCTRL in Kconfig

2012-09-03 Thread AnilKumar, Chimata
Hi Tony, On Mon, Aug 27, 2012 at 11:30:44, AnilKumar, Chimata wrote: Select PINCTRL in Kconfig under Typical OMAP configuration, this is required to add pinctrl driver to omap2+ family of devices. Signed-off-by: AnilKumar Ch anilku...@ti.com --- arch/arm/mach-omap2/Kconfig |1 + 1

[PATCH v2] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

2012-09-03 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn pdata and pdata-regs have been allocated in this function and should be freed before leaving it, and in the other error handling cases too. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by:

[PATCH 2/3] gpio-twl4030: new dt properties for BeagleBoard and omap3-EVM

2012-09-03 Thread Florian Vaussard
Add device tree properties for twl4030/gpio, according to the platform data of corresponding boards. This enables the led connected to LEDB output for both boards, as well as pullups/pulldowns on GPIO for the BeagleBoard. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch ---

[PATCH 3/3] gpio-twl4030: updates the bindings for new dt properties

2012-09-03 Thread Florian Vaussard
Add the new properties to the documentation of bindings. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- .../devicetree/bindings/gpio/gpio-twl4030.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti D
Currently in omap2_mcspi_txrx_dma has the rx and the rx support interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call functions. While at it also remove the braces in the if statements which has only one line. Also fix [foo * bar to foo

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti D
Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call the functions. While at it remove the braces in the if statements which has only one line. Also fix [foo * bar to foo

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti
On Monday 03 September 2012 07:32 PM, Shubhrajyoti D wrote: Currently in omap2_mcspi_txrx_dma has the rx I meant tx here will resend. please ignore this patch and the rx support interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call

Re: [PATCH 0/3] gpio-twl4030: add new device tree properties

2012-09-03 Thread Benoit Cousson
+ Vaibhav for the omap3-evm Hi Florian, On 09/03/2012 03:54 PM, Florian Vaussard wrote: A number of platform data are missing when using twl4030/gpio from a device tree. Yeah, I know, I was too lazy when I did the DT conversion at that time :-) Many thanks for completing the work. This

Re: [PATCH 0/2] OMAP: hwmod: fix hardreset handling

2012-09-03 Thread Omar Ramirez Luna
On 22 August 2012 00:42, Omar Ramirez Luna omar.l...@linaro.org wrote: From: Omar Ramirez Luna omar.rami...@ti.com The patch to expose hwmod assert/deassert functions through omap_device has been accepted and queued for 3.7[1], however these two patches are needed to make the API functional.

Re: [PATCH v2 1/8] ARM/dts: OMAP2: Add McBSP entries for OMAP2420 and OMAP2430 SoC

2012-09-03 Thread Benoit Cousson
Hi Peter, The overall series looks good to me, but I do have a couple of comments. On 08/29/2012 03:31 PM, Peter Ujfalusi wrote: The McBSP IP within OMAP2420 and 2430 is different we need to create separate dtsi files for them. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

Re: [PATCH v2 0/8] ARM/dts: OMAP audio related updates for OMAP2/3/4/5

2012-09-03 Thread Benoit Cousson
Hi Peter, On 08/29/2012 03:30 PM, Peter Ujfalusi wrote: Hello, I have extended and rebased the previous set: 'ARM/dts: omap McBSP and audio support for BeagleBoard' Changes since v1: - Rebased on current l-o:devel-dt branch - Two new patch, one for OMAP4 to add reg-names for the mem

Re: [PATCH 0/5] ARM: OMAP: Few device tree patches for 3.7

2012-09-03 Thread Benoit Cousson
Hi Santosh, Sorry for the delay, I missed that email :-( On 08/23/2012 09:32 AM, Santosh Shilimkar wrote: Benoit, On Monday 13 August 2012 04:30 PM, Santosh Shilimkar wrote: These are the few device tree related patches which has been posted and reviewed on the list. They are intended for

[PATCH] ARM: dts: OMAP4: Cleanup and move GIC outside of the OCP node

2012-09-03 Thread Benoit Cousson
Remove a useless comment and move GIC controller outside of the OCP node since it does use the MPU internal bus and not the OCP. This will not change the functionality but will reflect the reality more accurately. Signed-off-by: Benoit Cousson b-cous...@ti.com --- Hi Tony This is a minor

[RFC 0/3] Initial stab at converting OMAP ASoC support to DMA engine

2012-09-03 Thread Russell King - ARM Linux
The following series of three patches is an attempt to convert the OMAP ASoC backend to use the DMA engine support. I'll bring your attention to the comments in patch 3 which highlight some of the features lost in this process. Some questions need answering there (in particular the one

[RFC 1/3] ASoC: dmaengine: Don't use runtime private data for dmaengine data

2012-09-03 Thread Liam Girdwood
Use a dedicated member to store dmaengine data so that drivers can use private data for their own purposes. Signed-off-by: Liam Girdwood l...@ti.com Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- include/sound/pcm.h |2 ++ sound/soc/soc-dmaengine-pcm.c |2 +- 2

[RFC 2/3] Fix ASoC: dmaengine: Don't use runtime private data for dmaengine data

2012-09-03 Thread Russell King
The above commit was not initializing the correct substream runtime member with the ASoC DMA engine runtime data. Fix that. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- sound/soc/soc-dmaengine-pcm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[RFC 3/3] ASoC: first stab at converting OMAP PCM driver to use dmaengine

2012-09-03 Thread Russell King
Note that certain features of the original driver are not supported: 1. Non-packet mode sync 2. No period wakeup mode DMA engine has no way to communicate this information through standard channels. 3. Pause 4. Resume OMAP DMA engine backend does not support pausing and resuming an

Re: [PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-03 Thread Marc Kleine-Budde
On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adds suspend resume support to DCAN driver which enables DCAN power down mode bit (PDR). Then DCAN will ack the local power-down mode by setting PDA bit in STATUS register. Also adds a status flag to know the status of DCAN module, whether it is

Re: [PATCH 3/4] ARM: AM33XX: board-generic: Add of_dev_auxdata to pass d_can raminit

2012-09-03 Thread Marc Kleine-Budde
On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Add of_dev_auxdata to pass d_can raminit callback APIs to initialize d_can RAM. D_CAN RAM initialization bits are present in CONTROL module address space, which can be accessed by platform specific code. So callback functions are added to serve this

[PATCH 2/4] mfd: introduce retu-mfd driver

2012-09-03 Thread Aaro Koskinen
Retu is a multi-function device found on Nokia Internet Tablets implementing at least watchdog, RTC, headset detection and power button functionality. This patch implements minimum functionality providing register access, IRQ handling and power off functions. Cc: sa...@linux.intel.com Acked-by:

[PATCH 0/4] cbus/retu drivers to mainline

2012-09-03 Thread Aaro Koskinen
This patch set introduces drivers for CBUS access and Retu multifunction chip found on Nokia Internet Tablets (770, N800, N810). It would be nice get these patches applied as the functionality of these devices is severely lacking without Retu. E.g. watchdog support is mandatory at least on Nokia

[PATCH 3/4] watchdog: introduce retu_wdt driver

2012-09-03 Thread Aaro Koskinen
Introduce Retu watchdog driver. Cc: linux-watch...@vger.kernel.org Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/watchdog/Kconfig| 12 +++ drivers/watchdog/Makefile |1 + drivers/watchdog/retu_wdt.c | 188

[PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-03 Thread Aaro Koskinen
Add i2c driver to enable access to devices behind CBUS on Nokia Internet Tablets. The patch also adds CBUS I2C configuration for N8x0 which is one of the users of this driver. Cc: linux-...@vger.kernel.org Acked-by: Felipe Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com

[PATCH 4/4] input: misc: introduce retu-pwrbutton

2012-09-03 Thread Aaro Koskinen
Add Retu power button driver. Cc: linux-in...@vger.kernel.org Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/input/misc/Kconfig | 10 +++ drivers/input/misc/Makefile |1 + drivers/input/misc/retu-pwrbutton.c | 127 +++ 3

Re: [alsa-devel] [RFC 1/3] ASoC: dmaengine: Don't use runtime private data for dmaengine data

2012-09-03 Thread Lars-Peter Clausen
On 09/03/2012 06:59 PM, Liam Girdwood wrote: Use a dedicated member to store dmaengine data so that drivers can use private data for their own purposes. The idea was that we'll eventually get to a point where we won't need private data for the drivers using the generic dmaengine code. But for

Re: [PATCH 2/4] can: c_can: Add d_can raminit support

2012-09-03 Thread Marc Kleine-Budde
On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM. DCAN RAM holds all the message objects during transmission or receiving of data. This initialization/de-initialization should be done in synchronous with D_CAN clock. Signed-off-by:

Re: [PATCH 1/4] can: c_can: Adopt pinctrl support

2012-09-03 Thread Marc Kleine-Budde
On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adopt pinctrl support to c_can driver based on c_can device pointer, pinctrl driver configure SoC pins to d_can mode according to definitions provided in .dts file. In device specific device tree file 'pinctrl-names = default;' and 'pinctrl-0 =

Re: [alsa-devel] [RFC 1/3] ASoC: dmaengine: Don't use runtime private data for dmaengine data

2012-09-03 Thread Russell King - ARM Linux
On Mon, Sep 03, 2012 at 10:25:49PM +0200, Lars-Peter Clausen wrote: On 09/03/2012 06:59 PM, Liam Girdwood wrote: Use a dedicated member to store dmaengine data so that drivers can use private data for their own purposes. The idea was that we'll eventually get to a point where we won't

Re: [PATCH 0/3] gpio-twl4030: add new device tree properties

2012-09-03 Thread Florian Vaussard
Hi Benoit, Nit #2: the DTS file does not belong to the gpio subsystem. So you should prefix them using the *convention* for ARM DTS patches: arm/dts: omap3: Add gpio-twl4030 properties for BeagleBoard and omap3-EVM Or maybe ARM: dts: because it looks like most people are using that nowadays.

Re: [alsa-devel] [RFC 1/3] ASoC: dmaengine: Don't use runtime private data for dmaengine data

2012-09-03 Thread Lars-Peter Clausen
On 09/03/2012 10:43 PM, Russell King - ARM Linux wrote: On Mon, Sep 03, 2012 at 10:25:49PM +0200, Lars-Peter Clausen wrote: On 09/03/2012 06:59 PM, Liam Girdwood wrote: Use a dedicated member to store dmaengine data so that drivers can use private data for their own purposes. The idea was

Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-03 Thread David Härdeman
Hej, On Mon, Sep 03, 2012 at 01:36:53PM +0100, Sean Young wrote: On Sun, Sep 02, 2012 at 11:08:20PM +0300, Timo Kokkonen wrote: I guess the assumption is to avoid breaking the transmission in the middle in case the process is signaled. And that's why we shouldn't use interruptible waits.

RE: Without MACH_ option Early printk (DEBUG_LL)

2012-09-03 Thread Nicolas Pitre
On Mon, 3 Sep 2012, Mohammed, Afzal wrote: Hi, On Fri, Aug 31, 2012 at 23:53:32, Nicolas Pitre wrote: On Fri, 31 Aug 2012, Hiremath, Vaibhav wrote: On Fri, Aug 31, 2012 at 22:43:36, Russell King - ARM Linux wrote: On Fri, Aug 31, 2012 at 08:24:51PM +0530, Vaibhav Hiremath wrote:

Re: [PATCH v2 1/8] ARM/dts: OMAP2: Add McBSP entries for OMAP2420 and OMAP2430 SoC

2012-09-03 Thread Vaibhav Hiremath
On 9/3/2012 8:16 PM, Benoit Cousson wrote: Hi Peter, The overall series looks good to me, but I do have a couple of comments. On 08/29/2012 03:31 PM, Peter Ujfalusi wrote: The McBSP IP within OMAP2420 and 2430 is different we need to create separate dtsi files for them. Signed-off-by:

RE: Without MACH_ option Early printk (DEBUG_LL)

2012-09-03 Thread Hiremath, Vaibhav
On Tue, Sep 04, 2012 at 07:34:21, Nicolas Pitre wrote: On Mon, 3 Sep 2012, Mohammed, Afzal wrote: Hi, On Fri, Aug 31, 2012 at 23:53:32, Nicolas Pitre wrote: On Fri, 31 Aug 2012, Hiremath, Vaibhav wrote: On Fri, Aug 31, 2012 at 22:43:36, Russell King - ARM Linux wrote: On Fri,

RE: [PATCH 0/3] gpio-twl4030: add new device tree properties

2012-09-03 Thread Hiremath, Vaibhav
On Mon, Sep 03, 2012 at 19:58:09, Cousson, Benoit wrote: + Vaibhav for the omap3-evm Reviewing and testing it now... Thanks, Vaibhav Hi Florian, On 09/03/2012 03:54 PM, Florian Vaussard wrote: A number of platform data are missing when using twl4030/gpio from a device tree. Yeah,

Re: [PATCH 0/5] ARM: OMAP: Few device tree patches for 3.7

2012-09-03 Thread Shilimkar, Santosh
On Mon, Sep 3, 2012 at 8:04 AM, Benoit Cousson b-cous...@ti.com wrote: Hi Santosh, Sorry for the delay, I missed that email :-( On 08/23/2012 09:32 AM, Santosh Shilimkar wrote: Benoit, On Monday 13 August 2012 04:30 PM, Santosh Shilimkar wrote: These are the few device tree related

Re: [PATCH] ARM: dts: OMAP4: Cleanup and move GIC outside of the OCP node

2012-09-03 Thread Shilimkar, Santosh
On Mon, Sep 3, 2012 at 9:20 AM, Benoit Cousson b-cous...@ti.com wrote: Remove a useless comment and move GIC controller outside of the OCP node since it does use the MPU internal bus and not the OCP. This will not change the functionality but will reflect the reality more accurately.

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-03 Thread Shilimkar, Santosh
On Sun, Aug 26, 2012 at 6:29 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Sun, Aug 26, 2012 at 3:53 PM, NeilBrown ne...@suse.de wrote: On Sun, 26 Aug 2012 09:47:50 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: + Jon, On Sat, Aug 25, 2012 at 5:14 PM, NeilBrown