[PATCH v2] ARM: v6: avoid remaining accesses to missing CP15 registers on ARM1136 r0

2013-07-28 Thread Paul Walmsley
Ensure that the remaining callers of read_cpuid_ext can't attempt an extended CP15 register read on ARMv6 cores that don't support it. The only one that appears dodgy is tlb_ops_need_broadcast(). While here, convert feat_v6_fixup() to use cpu_is_arm1136_r0() to save a few lines of code.

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.06.2013 17:27, schrieb Javier Martinez Canillas: When a GPIO is defined as an interrupt line using Device Tree, a call to irq_create_of_mapping() is made that calls irq_create_mapping(). So, is not necessary to do the mapping for all OMAP GPIO lines and explicitly call irq_create_mapping()

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 12:58 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.06.2013 17:27, schrieb Javier Martinez Canillas: When a GPIO is defined as an interrupt line using Device Tree, a call to irq_create_of_mapping() is made that calls irq_create_mapping(). So, is not necessary

Re: [PATCH] ARM: v6: avoid read_cpuid_ext() on ARM1136r0 in cache_ops_need_broadcast()

2013-07-28 Thread Russell King - ARM Linux
On Sun, Jul 28, 2013 at 12:10:38PM +0100, Will Deacon wrote: Hi Paul, Cheers for sticking with this! On Sun, Jul 28, 2013 at 06:43:24AM +0100, Paul Walmsley wrote: Commit 621a0147d5c921f4cc33636ccd0602ad5d7cbfbc (ARM: 7757/1: mm: don't flush icache in switch_mm with hardware

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 13:14, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 12:58 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.06.2013 17:27, schrieb Javier Martinez Canillas: When a GPIO is defined as an interrupt line using Device Tree, a call to irq_create_of_mapping() is made that

Re: N900 device tree conversion: how to do first step

2013-07-28 Thread Pavel Machek
Hi! I'd like to convert Nokia N900 to device tree. Unfortunately, serial port is not easily available (very special cable would be needed, does someone know where to get one?) One way to get one is building it yourself. I finished mine yesterday:

Re: [PATCH v2] N900: add device tree

2013-07-28 Thread Pavel Machek
On Mon 2013-07-15 01:28:19, Aaro Koskinen wrote: Hi, On Sat, Jul 13, 2013 at 02:17:09PM +0200, Pavel Machek wrote: This adds device tree with neccessary support to boot with functional video (on both emulator and real N900 device). Signed-off-by: Pavel Machek pa...@ucw.cz You

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 2:59 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 13:14, schrieb Linus Walleij: What shall we do with this mess now? (...) Hmm, maybe something which adds a mapping for a IRQ when gpio_to_irq() is called would help. I think this bug is pointing back

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 12:58, schrieb Alexander Holler: This patch basically broke every usage of irq = gpio_to_irq(gpio); request[_threaded]_irq(irq, ...); because request[_threaded]_irq(irq, ...) now fails because of a missing irq_domain (no mapping = no domain). A prominent victim of this

RE: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Shilimkar, Santosh
(Sorry for the top posting) Linus, Auto request GPIO as an input line when used as IRQ line for DT case has been broken and we did discuss the issue on couple of threads. Javier's intermediate approach with $subject series was addressing this long standing issue. But while fixing that case,

[PATCH 07/11] spi/hspi: Convert to core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-sh-hspi.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index daf2bf2..0b68cb5 100644 ---

[PATCH 11/11] spi/tegra20-slink: Use core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-tegra20-slink.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c index

[PATCH 04/11] spi/omap2: Covert to core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-omap2-mcspi.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 5994039..973c1cb 100644

[PATCH 02/11] spi/bcm63xx: Convert to core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-bcm63xx.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index 9fd7a39..4ac028d 100644 ---

[PATCH 06/11] spi/pxa2xx: Convert to core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-pxa2xx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index e0fd6f6..2eb06ee 100644 ---

[PATCH 09/11] spi/tegra114: Use core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-tegra114.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index e7d48a1..2e208dc 100644 ---

[PATCH 03/11] spi/coldfire-qspi: Convert to core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-coldfire-qspi.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c index 0631b9d..e4265ea

[PATCH 10/11] spi/tegra20-sflash: Use core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-tegra20-sflash.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c index

[PATCH 08/11] spi/s3c64xx: Use core for runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-s3c64xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index c9d0b12..62f32c4 100644 ---

[PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Most SPI drivers that implement runtime PM support use identical code to do so: they acquire a runtime PM lock in prepare_transfer_hardware() and then they release it in unprepare_transfer_hardware(). The variations in this are mostly missing error checking and

[PATCH 05/11] spi/pl022: Convert to core runtime PM

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-pl022.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index abef061..07e6db6 100644 ---

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 4:25 PM, Alexander Holler hol...@ahsoftware.de wrote: By the way, if someone decides to touch omap_hsmmc, the driver wrongly assumes that 0 is not a valid IRQ number and it doesn't check if gpio_to_irq() returns a negative value. ;) Zero *is* *not* a valid IRQ number.

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 4:37 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: I think the default OMAP DT files will continue to work with these patches applied and mostly doesn't break anything in default configuration. What does mostly mean? Hm hm. OK I feel a little bit better about

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM, Alexander Holler hol...@ahsoftware.de wrote: By the way, if someone decides to touch omap_hsmmc, the driver wrongly assumes that 0 is not a valid IRQ number and it doesn't check if gpio_to_irq() returns a negative

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 18:29, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:37 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: I think the default OMAP DT files will continue to work with these patches applied and mostly doesn't break anything in default configuration. What does mostly

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Javier Martinez Canillas
Hello, Being the author of these patches I'm ashamed that they are causing a regression. I did my best to make sure that it would work on OMAP1 and OMAP2+ platforms booting with both legacy board files and DT. Also, I didn't come with this solution in a vacuum. This was deeply discussed with Jon

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Javier Martinez Canillas
On Sun, Jul 28, 2013 at 7:33 PM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: Hello, Being the author of these patches I'm ashamed that they are causing a regression. I did my best to make sure that it would work on OMAP1 and OMAP2+ platforms booting with both legacy board files

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Javier Martinez Canillas
On Sun, Jul 28, 2013 at 6:45 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM, Alexander Holler hol...@ahsoftware.de wrote: By the way, if someone decides to touch omap_hsmmc, the driver wrongly assumes that 0 is

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 6:45 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM, Alexander Holler hol...@ahsoftware.de wrote: By the way, if someone decides to touch omap_hsmmc, the driver wrongly assumes that 0 is

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 7:13 PM, Alexander Holler hol...@ahsoftware.de wrote: Having a quick look git grep gpio_to_irq, I've quickly spotted e.g. this in drivers/input/keyboard/gpio_keys.c: irq = gpio_to_irq(button-gpio); if (irq 0) { (again 0 not =0) Hm I

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 7:33 PM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: According to Documentation/devicetree/bindings/mmc/mmc.txt: cd-gpios: Specify GPIOs for card detection, see gpio binding So it just says that it is a GPIO for card detection and not an IRQ so this

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Javier Martinez Canillas
On Sun, Jul 28, 2013 at 8:06 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sun, Jul 28, 2013 at 6:45 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM, Alexander Holler hol...@ahsoftware.de wrote: By the

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Javier Martinez Canillas
On Sun, Jul 28, 2013 at 8:22 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sun, Jul 28, 2013 at 7:33 PM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: According to Documentation/devicetree/bindings/mmc/mmc.txt: cd-gpios: Specify GPIOs for card detection, see gpio binding

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Javier Martinez Canillas
On Sun, Jul 28, 2013 at 8:22 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sun, Jul 28, 2013 at 7:33 PM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: According to Documentation/devicetree/bindings/mmc/mmc.txt: cd-gpios: Specify GPIOs for card detection, see gpio binding

Re: [PATCH] ARM: v6: avoid read_cpuid_ext() on ARM1136r0 in cache_ops_need_broadcast()

2013-07-28 Thread Paul Walmsley
Hi Will On Sun, 28 Jul 2013, Will Deacon wrote: On Sun, Jul 28, 2013 at 06:43:24AM +0100, Paul Walmsley wrote: Commit 621a0147d5c921f4cc33636ccd0602ad5d7cbfbc (ARM: 7757/1: mm: don't flush icache in switch_mm with hardware broadcasting) breaks the boot on OMAP2430SDP with

Re: [PATCH] ARM: v6: avoid read_cpuid_ext() on ARM1136r0 in cache_ops_need_broadcast()

2013-07-28 Thread Paul Walmsley
On Sun, 28 Jul 2013, Russell King - ARM Linux wrote: We don't want to make the asm() itself volatile, because that means the asm() statement can't be optimised away. Adding a memory clobber to that asm seems to place it more appropriately, but again, that's not particularly desirable.

Re: [PATCH v2] ARM: v6: avoid remaining accesses to missing CP15 registers on ARM1136 r0

2013-07-28 Thread Paul Walmsley
On Sun, 28 Jul 2013, Paul Walmsley wrote: Ensure that the remaining callers of read_cpuid_ext can't attempt an extended CP15 register read on ARMv6 cores that don't support it. The only one that appears dodgy is tlb_ops_need_broadcast(). While here, convert feat_v6_fixup() to use

[PATCH] ARM: v6: prevent gcc from reordering extended CP15 reads above is_smp() test

2013-07-28 Thread Paul Walmsley
Commit 621a0147d5c921f4cc33636ccd0602ad5d7cbfbc (ARM: 7757/1: mm: don't flush icache in switch_mm with hardware broadcasting) breaks the boot on OMAP2430SDP with omap2plus_defconfig. Tracked to an undefined instruction abort from the CP15 read in cache_ops_need_broadcast(). It turns out that

Re: [PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 4:43 PM, Mark Brown broo...@kernel.org wrote: Most SPI drivers that implement runtime PM support use identical code to do so: they acquire a runtime PM lock in prepare_transfer_hardware() and then they release it in unprepare_transfer_hardware(). The variations in this

Re: [PATCH 05/11] spi/pl022: Convert to core runtime PM

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 4:43 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org Someone moaned about oneline commit messages in the last LWN... Yours, Linus Walleij --

Re: [PATCH 04/11] spi/omap2: Covert to core runtime PM

2013-07-28 Thread Felipe Balbi
Hi, On Sun, Jul 28, 2013 at 03:43:19PM +0100, Mark Brown wrote: From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCHv5 1/2] drivers: spi: Add qspi flash controller

2013-07-28 Thread Trent Piepho
On Fri, Jul 26, 2013 at 10:15 AM, Sourav Poddar sourav.pod...@ti.com wrote: + +static inline void ti_qspi_read_data(struct ti_qspi *qspi, + unsigned long reg, int wlen, u8 **rxbuf) +{ + switch (wlen) { + case 8: + **rxbuf = readw(qspi-base + reg); +

Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

2013-07-28 Thread Alexander Holler
Am 28.07.2013 20:50, schrieb Javier Martinez Canillas: On Sun, Jul 28, 2013 at 8:06 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sun, Jul 28, 2013 at 6:45 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 28.07.2013 18:25, schrieb Linus Walleij: On Sun, Jul 28, 2013 at 4:25 PM,

OMAP baseline test results for v3.11-rc3

2013-07-28 Thread Paul Walmsley
Here are some basic OMAP test results for Linux v3.11-rc3. Logs and other details at: http://www.pwsan.com/omap/testlogs/test_v3.11-rc3/20130728224046/ Test summary Build: uImage: Pass (14/14): n800_multi_omap2xxx, n800_only_a, omap1_defconfig,

Re: [PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-28 Thread Mark Brown
On Sun, Jul 28, 2013 at 10:51:31PM +0200, Linus Walleij wrote: On Sun, Jul 28, 2013 at 4:43 PM, Mark Brown broo...@kernel.org wrote: + * @auto_runtime_pm: the core should ensure a runtime PM reference is held + * while the hardware is prepared I'd mention here that the