Re: [PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Stephen Boyd
On 03/02/15 13:01, Russell King - ARM Linux wrote: On Mon, Mar 02, 2015 at 11:07:58AM -0800, Stephen Boyd wrote: On 03/02/15 09:06, Russell King wrote: Add a helper to allocate and add a clk_lookup structure. This can not only be used in several places in clkdev.c to simplify the code, but

Re: [PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Sakari Ailus
Hi Laurent and Russell, On Tue, Mar 03, 2015 at 12:33:44AM +0200, Laurent Pinchart wrote: Hi Russell, On Monday 02 March 2015 17:06:06 Russell King wrote: No merged platform supplies xclks via platform data. As we want to slightly change the clkdev interface, rather than fixing this

Re: [PATCH 06/15] twl4030_charger: split uA calculation into a function.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:51, NeilBrown wrote: We will need this calculation in other places, so create functions to map between register value and uA value. Signed-off-by: NeilBrown ne...@suse.de Acked-by: Pavel Machek pa...@ucw.cz +static int regval2ua(int regval, bool cgain) +{ + if

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-02 Thread Pavel Machek
Hi! The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs. If the read fails, which it does sometimes, try again in 50msec. Signed-off-by: NeilBrown ne...@suse.de ---

Re: [PATCH 4/4] usb: phy: twl4030: test ID resistance to see if charger is present.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 14:40:37, NeilBrown wrote: If an 'A' plug is inserted, ID should be pulled to ground. If a 'B' plug, then ID should be floating. If an Accessory Charger Adapter is inserted, then ID will be neither grounded nor floating. In this case tell the USB subsystem that it is an A

Re: [PATCH 08/15] twl4030_charger: distinguish between USB current and 'AC' current

2015-03-02 Thread Pavel Machek
Hi! The twl4030 charger has two current sources, 'USB' and 'AC' (which is really DC of course...). If 'AC' is providing current, we should set the current limit differently to when it isn't (and so USB is used). So split 'cur' into 'usb_cur' and 'ac_cur' and use accordingly. Now we must

Re: [PATCH 11/15] twl4030_charger: enable manual enable/disable of usb charging.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:52, NeilBrown wrote: 'off' or 'auto' to /sys/class/power/twl4030_usb/mode will now enable or disable charging from USB port. Normally this is enabled on 'plug' and disabled on 'unplug'. Unplug will still disable charging. 'plug' will only enable it if 'auto' if

Re: [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:52, NeilBrown wrote: 'max_current' sysfs attributes are created which allow the max to be set. Whenever a current source changes, the default is restored. This will be followed by a uevent, so user-space can decide to update again. Does this need Documentation update?

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Russell King - ARM Linux
On Mon, Mar 02, 2015 at 11:07:58AM -0800, Stephen Boyd wrote: On 03/02/15 09:06, Russell King wrote: Add a helper to allocate and add a clk_lookup structure. This can not only be used in several places in clkdev.c to simplify the code, but more importantly, can be used by callers of the

Re: [PATCH 10/15] twl4030_charger: only draw USB current as negotiated with host.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:52, NeilBrown wrote: If the phy has been told what current it can draw, it tells us and now we use that number. Note that 'vbus_draw' is in mA, while usb_cur is in uA. Signed-off-by: NeilBrown ne...@suse.de Acked-by: Pavel Machek pa...@ucw.cz @@ -609,6 +610,7 @@

Re: [PATCH 13/15] twl4030_charger: add ac/mode to match usb/mode

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:53, NeilBrown wrote: This allows AC charging to be turned off, much like usb charging. continuous (aka linear) mode maps to the CVENAC (constant voltage) feature of the twl4030. Signed-off-by: NeilBrown ne...@suse.de Acked-by: Pavel Machek pa...@ucw.cz ---

Re: [PATCH 2/4] usb: phy: twl4030: allow charger to see usb current draw limits.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 14:40:37, NeilBrown wrote: The charger needs to know when a USB gadget has been enumerated and what the agreed maximum current was so that it can adjust charging accordingly. So define a set_power() function to record the permitted draw, and pass a pointer to that when

Re: [PATCH 15/15] twl4030_charger: assume a 'charger' can supply maximum current.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:53, NeilBrown wrote: If it cannot, we will stop pulling more current when voltage drops. Can you justify it a bit more? I mean... maybe there's a fuse in the charger? Or maybe it will supply the current but overheat in the process? (USB_MAX_CURRENT is 500mA or 1.7A?)

Re: [PATCH 00/10] initial clkdev cleanups

2015-03-02 Thread Stephen Boyd
On 03/02/15 09:05, Russell King - ARM Linux wrote: Here's some initial clkdev cleanups. These are targetted for the next merge window, and while the initial patches can be merged independently, I'd prefer to keep the series together as further work on solving the problems which unique struct

Re: [PATCH 14/15] twl4030_charger: Increase current carefully while watching voltage.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:53, NeilBrown wrote: The USB Battery Charging spec (BC1.2) suggests a dedicated charging port can deliver from 0.5 to 5.0A at between 4.75 and 5.25 volts. To choose the correct current voltage setting requires a trial and error approach: try to draw current and see

Re: [PATCH 12/15] twl4030_charger: add software controlled linear charging mode.

2015-03-02 Thread Pavel Machek
On Tue 2015-02-24 15:33:52, NeilBrown wrote: Add a 'continuous' option for usb charging which enabled the linear charging mode of the twl4030. Documentation/ :-). Linear charging does a good job with not so reliable power sources, since several voltage controlling is then often too

Re: [PATCH] OMAP: DSS: DPI: disable vt-switch on suspend/resume.

2015-03-02 Thread Pavel Machek
Hi! Looking at the drivers/tty/vt/vt_ioctl.c, it sounds to me that we should always do pm_set_vt_switch(0), as omapdss restores everything just fine on resume. Although it makes me wonder how it works if there are two display controllers, one needing the switch and the other not... I

Re: [PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Laurent Pinchart
Hi Russell, On Monday 02 March 2015 17:06:06 Russell King wrote: No merged platform supplies xclks via platform data. As we want to slightly change the clkdev interface, rather than fixing this unused code, remove it instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk There

Re: [PATCH 1/4] usb: phy: twl4030: make runtime pm more reliable.

2015-03-02 Thread Pavel Machek
Hi! + status_changed = + (twl-linkstat == OMAP_MUSB_VBUS_VALID || + twl-linkstat == OMAP_MUSB_ID_GROUND) + != + (status == OMAP_MUSB_VBUS_VALID || + status ==

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-02 Thread Pavel Machek
Hi! + /* ichg values in uA. If any are 'large', we set CGAIN to + * '1' which doubles the range for half the precision. + */ + int ichg_eoc, ichg_lo, ichg_hi, cur; We should really get uA_t. [Plus, this is not kernel comment style, but...] + /*

[PATCH] rtc-twl: add DT support for RTC battery recharge

2015-03-02 Thread Adam YH Lee
This patch introduces device tree binding for the RTC backup battery charger on TWL4030. Tested on Gumstix Overo (OMAP3) Tobi. Signed-off-by: Adam YH Lee adam.yh@gmail.com --- Documentation/devicetree/bindings/rtc/twl-rtc.txt | 20 drivers/rtc/rtc-twl.c

Re: [PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Russell King - ARM Linux
(Combining replies...) On Tue, Mar 03, 2015 at 12:53:37AM +0200, Sakari Ailus wrote: Hi Laurent and Russell, On Tue, Mar 03, 2015 at 12:33:44AM +0200, Laurent Pinchart wrote: Sakari, does it conflict with the omap3isp DT support ? If so, how would you prefer to resolve the conflict ?

[PATCHv2 1/2] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Sebastian Reichel
From: Kai Vehmanen kai.vehma...@nokia.com Introduces the cmt-speech driver, which implements a character device interface for transferring speech data frames over HSI/SSI. The driver is used to exchange voice/speech data between the Nokia N900/N950/N9's modem and its cpu. Signed-off-by: Kai

Re: [PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Laurent Pinchart
Hi Russell, On Monday 02 March 2015 23:54:35 Russell King - ARM Linux wrote: (Combining replies...) On Tue, Mar 03, 2015 at 12:53:37AM +0200, Sakari Ailus wrote: Hi Laurent and Russell, On Tue, Mar 03, 2015 at 12:33:44AM +0200, Laurent Pinchart wrote: Sakari, does it conflict with

Re: [PATCH 10/10] ARM: omap2: use clkdev_add_alias()

2015-03-02 Thread Tony Lindgren
* Russell King rmk+ker...@arm.linux.org.uk [150302 09:10]: When creating aliases of existing clkdev clocks, use clkdev_add_alias() isntead of open coding the lookup and clk_lookup creation. Gave this series a quick try but I get these build errors: arch/arm/mach-omap2/omap_device.c: In

[PATCHv2 2/2] HSI: nokia-modem: Add cmt-speech support

2015-03-02 Thread Sebastian Reichel
Register cmt-speech driver in nokia-modem driver and forward hsi channel information. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/Kconfig | 2 +- drivers/hsi/clients/nokia-modem.c | 31 ++- 2 files changed, 31 insertions(+), 2

[PATCHv2 0/2] N900 Modem Speech Support

2015-03-02 Thread Sebastian Reichel
Hi, This patchset contains the missing speech data support for the Nokia N900 modem. Userland access goes via /dev/cmt_speech. The API is implemented in libcmtspeechdata, which is used by ofono and the freesmartphone.org project. Apart from that the device is also used by the phone binaries

Re: [PATCH v2 1/3] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W

2015-03-02 Thread Paul Walmsley
On Mon, 2 Mar 2015, Vignesh R wrote: From: Poddar, Sourav sourav.pod...@ti.com These adds hwmod data for hdq/1w driver on AM43xx. Signed-off-by: Vignesh R vigne...@ti.com --- Change log: v2: * Add SYSC_HAS_AUTOIDLE flag. arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 36

suspend ethernet only , with WOL (wake on lan)

2015-03-02 Thread Ran Shalit
Hello, I am using OMAP3530 with SMSC911X phy. I see in smsc911 driver that it contain WOL (wake on lan) feature here: http://lxr.free-electrons.com/source/drivers/net/ethernet/smsc/smsc911x.c 1. Is it that to enable WOL I just need ethtool (without configuring anything in kernel) ?

Re: [PATCH 09/21] drm/omap: handle mismatching color format and buffer width

2015-03-02 Thread Tomi Valkeinen
On 02/03/15 12:22, Daniel Stone wrote: I don't know why Rob named it like that. The bpp of the stride? Shrug. It's just the bpp of the pixel format; it's not at all associated with the stride? The comment says this times width is stride, so I thought the naming comes from that train of

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Geert Uytterhoeven
On Mon, Mar 2, 2015 at 6:46 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Mar 02, 2015 at 06:22:31PM +0100, Geert Uytterhoeven wrote: On Mon, Mar 2, 2015 at 6:06 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: --- a/include/linux/clkdev.h +++

Re: [PATCH 0/9] N900 Modem Speech Support

2015-03-02 Thread Sebastian Reichel
Hi, On Mon, Mar 02, 2015 at 08:05:31PM +0100, Pali Rohár wrote: On Monday 02 March 2015 05:38:50 Sebastian Reichel wrote: This patchset contains the missing speech data support for the Nokia N900 modem. [...] Hello, do you have also DT patches? Or no DT changes are needed? No DT

Re: [PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Aaro Koskinen
Hi, On Mon, Mar 02, 2015 at 05:38:51AM +0100, Sebastian Reichel wrote: From: Kai Vehmanen kai.vehma...@nokia.com Introduces the cmt-speech driver, which implements a character device interface for transferring speech data frames over HSI/SSI. The driver is used to exchange voice/speech

[PATCH v2 1/3] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W

2015-03-02 Thread Vignesh R
From: Poddar, Sourav sourav.pod...@ti.com These adds hwmod data for hdq/1w driver on AM43xx. Signed-off-by: Vignesh R vigne...@ti.com --- Change log: v2: * Add SYSC_HAS_AUTOIDLE flag. arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 36 ++

[PATCH v2 2/3] w1: masters: omap_hdq: Add support for 1-wire mode

2015-03-02 Thread Vignesh R
This patches makes following changes to omap_hdq driver - Enable 1-wire mode. - Implement w1_triplet callback to facilitate search rom procedure and auto detection of 1-wire slaves. - Proper enabling and disabling of interrupt. - Cleanups (formatting and return value checks). HDQ mode

[PATCH v2 3/3] ARM: dts: AM4372: update hdq compatible property

2015-03-02 Thread Vignesh R
This patch updates hdq node compatible property to ti,am4372-hdq. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index

Re: [PATCH RFC 6/6] ARM: dts: am335x-boneblack: Use new binding for HDMI

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 16:55, Jyri Sarha wrote: Use new binding for the external tda19988 HDMI encoder. Signed-off-by: Jyri Sarha jsa...@ti.com --- arch/arm/boot/dts/am335x-boneblack.dts | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

Re: [PATCH RFC 4/6] drm/tilcdc: Add DRM_TILCDC_INIT for ti,tilcdc,slave binding support

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 16:55, Jyri Sarha wrote: Adds a DRM_TILCDC_INIT module for ti,tilcdc,slave node conversion. The implementation is in tilcdc_boot_init.c and it uses tilcdc_slave_convert.dts as a basis for creating a DTS overlay. The DTS overlay adds an external tda998x encoder to tilcdc that

Re: [PATCH RFC 1/6] drm/tilcdc: Fix module unloading

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 16:55, Jyri Sarha wrote: Force crtc dpms off before destroying the crtc instead of just checking the dpms state. This fixes warning message and frozen picture after tilcdc module unloading. Signed-off-by: Jyri Sarha jsa...@ti.com --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3

Re: [PATCH 09/21] drm/omap: handle mismatching color format and buffer width

2015-03-02 Thread Tomi Valkeinen
On 27/02/15 16:40, Daniel Stone wrote: Hi, On 27 February 2015 at 13:01, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Feb 26, 2015 at 03:20:17PM +0200, Tomi Valkeinen wrote: omapdrm doesn't check if the width of the framebuffer and the color s/width/pitch/ format's bits-per-pixel

Re: [PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 16:55, Jyri Sarha wrote: Add support for an external compontised DRM encoder. The external encoder can be connected to tilcdc trough device tree graph binding. The binding document for tilcdc has been updated. The support has only been tested with tda998x encoder, but other

Re: [PATCH RFC 5/6] drm/tilcdc: Force building of DRM_TILCDC_INIT

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 16:55, Jyri Sarha wrote: If I read Documentation/kbuild/makefiles.txt section 3.6 right, this patch should not be needed. However, without this patch the objects needed for DRM_TILCDC_INIT are not linked, if DRM_TILCDC is built as module. I also think there's something funny

Re: [PATCH 06/21] drm/omap: check CRTC color format earlier

2015-03-02 Thread Tomi Valkeinen
On 27/02/15 14:07, Daniel Vetter wrote: On Thu, Feb 26, 2015 at 03:20:14PM +0200, Tomi Valkeinen wrote: When setting a color format to a DRM plane, the DRM core checks whether the format is supported by the HW. However, it seems that when setting the color format of a CRTC (i.e. a root plane),

Re: advanced LED controllers

2015-03-02 Thread Pavel Machek
On Wed 2015-02-25 18:06:07, Alexandre Courbot wrote: On Wed, Feb 25, 2015 at 5:25 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: CC linux-gpio, as this looks like the LED equivalent of bulk gpio? Indeed. The LED core could implement something similar to gpiod_set_array() to allow

Re: [PATCH 1/2] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W

2015-03-02 Thread R, Vignesh
Hi, On 3/2/2015 4:39 AM, Paul Walmsley wrote: Hi On Fri, 27 Feb 2015, Vignesh R wrote: From: Poddar, Sourav sourav.pod...@ti.com This patch adds hwmod data for hdq/1w driver on AM43xx. Signed-off-by: Sourav Poddar sourav.pod...@ti.com [vigne...@ti.com: Ported patch to v4.0-rc1]

Re: [PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Oliver Neukum
On Mon, 2015-03-02 at 05:38 +0100, Sebastian Reichel wrote: +static int cs_alloc_cmds(struct cs_hsi_iface *hi) +{ + struct hsi_msg *msg; + u32 *buf; + unsigned int i; + + INIT_LIST_HEAD(hi-cmdqueue); + + for (i = 0; i CS_MAX_CMDS; i++) { + msg

Re: [PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Oliver Neukum
+static ssize_t cs_char_read(struct file *file, char __user *buf, size_t count, + loff_t *unused) +{ + struct cs_char *csdata = file-private_data; + u32 data; + ssize_t retval; + + if (count sizeof(data)) +

Re: [PATCH 14/21] drm/omap: stop connector polling during suspend

2015-03-02 Thread Tomi Valkeinen
On 26/02/15 15:57, grygorii.stras...@linaro.org wrote: Could I ask you to update this patch as below, pls? Your changes look ok to me, but they are not related to my patch so I don't see any reason to merge them. I'll pick your patch to my series. Tomi signature.asc Description: OpenPGP

Re: [PATCH RFC 0/6] Use DRM component API in tilcdc to connect to tda998x

2015-03-02 Thread Tomi Valkeinen
Hi Rob, You weren't cc'd to this series. I don't know if you're still interested in tilcdc, but if you are, any comments appreciated =). Tomi On 26/02/15 16:55, Jyri Sarha wrote: Remove tilcdc slave support and connect to tda998x trough its component DRM API. For dtb backward compatibility

Re: [PATCH 09/21] drm/omap: handle mismatching color format and buffer width

2015-03-02 Thread Daniel Stone
Hi, On 2 March 2015 at 09:50, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 27/02/15 16:40, Daniel Stone wrote: On 27 February 2015 at 13:01, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Feb 26, 2015 at 03:20:17PM +0200, Tomi Valkeinen wrote: omapdrm doesn't check if the width of the

[PATCH v2 0/3] Add support for HDQ-1W on AM43XX

2015-03-02 Thread Vignesh R
Hi, This patch series adds support for HDQ-1W interface on AM43XX. The first patch adds hwmod entries for HDQ-1W on AM43xx. The existing omap_hdq driver does not support 1-wire operations. The second patch enables 1-wire support in the omap_hdq driver. Support to Search ROM addresses and

Re: [PATCH RFC 6/6] ARM: dts: am335x-boneblack: Use new binding for HDMI

2015-03-02 Thread Russell King - ARM Linux
On Mon, Mar 02, 2015 at 02:28:40PM +0200, Tomi Valkeinen wrote: On 26/02/15 16:55, Jyri Sarha wrote: Use new binding for the external tda19988 HDMI encoder. Signed-off-by: Jyri Sarha jsa...@ti.com --- arch/arm/boot/dts/am335x-boneblack.dts | 20 +++- 1 file changed,

Re: [PATCH RFC 3/6] drm/tilcdc: Add support for external compontised DRM encoder

2015-03-02 Thread Russell King - ARM Linux
On Thu, Feb 26, 2015 at 04:55:32PM +0200, Jyri Sarha wrote: + ret = component_bind_all(dev-dev, dev); + if (ret 0) { + dev_err(dev-dev, Binding subcomponents failed: %d\n, ret); Do you need to print this? The component helper is already fairly verbose about what succeeds

Re: [PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Sebastian Reichel
Hi Oliver, On Mon, Mar 02, 2015 at 11:22:33AM +0100, Oliver Neukum wrote: +static ssize_t cs_char_read(struct file *file, char __user *buf, size_t count, + loff_t *unused) +{ + struct cs_char *csdata = file-private_data; +

[PATCH 02/10] SH: use clkdev_add_table()

2015-03-02 Thread Russell King
We have always had an efficient way of registering a table of clock lookups - it's called clkdev_add_table(). However, some people seem to really love writing inefficient and unnecessary code. Convert SH to use the correct interface. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Russell King
No merged platform supplies xclks via platform data. As we want to slightly change the clkdev interface, rather than fixing this unused code, remove it instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/media/platform/omap3isp/isp.c | 18 --

[PATCH 04/10] ARM: lpc32xx: convert to use clkdev_add_table()

2015-03-02 Thread Russell King
We have always had an efficient way of registering a table of clock lookups - it's called clkdev_add_table(). However, some people seem to really love writing inefficient and unnecessary code. Convert LPC32xx to use the correct interface. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk

[PATCH 03/10] clk: versatile: convert Integrator IM/PD-1 to use clkdev_add_table()

2015-03-02 Thread Russell King
We have always had an efficient way of registering a table of clock lookups - it's called clkdev_add_table(). However, some people seem to really love writing inefficient and unnecessary code. Convert Integrator IM-PD/1 to use the correct interface. Signed-off-by: Russell King

[PATCH 07/10] clk: s2mps11: use clkdev_create()

2015-03-02 Thread Russell King
clkdev_create() is a shorter way to write clkdev_alloc() followed by clkdev_add(). Use this instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/clk/clk-s2mps11.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/clk-s2mps11.c

[PATCH 00/10] initial clkdev cleanups

2015-03-02 Thread Russell King - ARM Linux
Here's some initial clkdev cleanups. These are targetted for the next merge window, and while the initial patches can be merged independently, I'd prefer to keep the series together as further work on solving the problems which unique struct clk's has introduced is needed. The initial cleanups

[PATCH 10/10] ARM: omap2: use clkdev_add_alias()

2015-03-02 Thread Russell King
When creating aliases of existing clkdev clocks, use clkdev_add_alias() isntead of open coding the lookup and clk_lookup creation. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-omap2/omap_device.c | 24 +--- 1 file changed, 9 insertions(+), 15

[PATCH 06/10] ASOC: migor: use clkdev_create()

2015-03-02 Thread Russell King
clkdev_create() is a shorter way to write clkdev_alloc() followed by clkdev_add(). Use this instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- sound/soc/sh/migor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/sh/migor.c b/sound/soc/sh/migor.c

Re: [PATCH RFC 6/6] ARM: dts: am335x-boneblack: Use new binding for HDMI

2015-03-02 Thread Tomi Valkeinen
On 02/03/15 18:06, Russell King - ARM Linux wrote: This is missing the output of tda998x. It should have two ports, input and output, output going to hdmi-connector. We don't have that kind of level of modelling in DRM right now - as far as DRM is concerned, the tda998x is both the encoder

[PATCH 08/10] ARM: orion: use clkdev_create()

2015-03-02 Thread Russell King
clkdev_create() is a shorter way to write clkdev_alloc() followed by clkdev_add(). Use this instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/plat-orion/common.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/arm/plat-orion/common.c

[PATCH 09/10] ARM: omap2: use clkdev_create()

2015-03-02 Thread Russell King
Rather than open coding the clkdev allocation, initialisation and addition, use the clkdev_create() helper. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git

[PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Russell King
Add a helper to allocate and add a clk_lookup structure. This can not only be used in several places in clkdev.c to simplify the code, but more importantly, can be used by callers of the clkdev code to simplify their clkdev creation and registration. Signed-off-by: Russell King

Re: [PATCH 02/10] SH: use clkdev_add_table()

2015-03-02 Thread Geert Uytterhoeven
On Mon, Mar 2, 2015 at 6:06 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: We have always had an efficient way of registering a table of clock lookups - it's called clkdev_add_table(). However, some people seem to really love writing inefficient and unnecessary code. Convert SH to use

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Geert Uytterhoeven
On Mon, Mar 2, 2015 at 6:06 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: --- a/include/linux/clkdev.h +++ b/include/linux/clkdev.h @@ -37,6 +37,9 @@ struct clk_lookup *clkdev_alloc(struct clk *clk, const char *con_id, void clkdev_add(struct clk_lookup *cl); void clkdev_drop(struct

Re: [PATCH 06/10] ASOC: migor: use clkdev_create()

2015-03-02 Thread Mark Brown
On Mon, Mar 02, 2015 at 05:06:32PM +, Russell King wrote: clkdev_create() is a shorter way to write clkdev_alloc() followed by clkdev_add(). Use this instead. Acked-by: Mark Brown broo...@kernel.org signature.asc Description: Digital signature

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Russell King - ARM Linux
On Mon, Mar 02, 2015 at 06:22:31PM +0100, Geert Uytterhoeven wrote: On Mon, Mar 2, 2015 at 6:06 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: --- a/include/linux/clkdev.h +++ b/include/linux/clkdev.h @@ -37,6 +37,9 @@ struct clk_lookup *clkdev_alloc(struct clk *clk, const char

Re: [PATCH 14/21] drm/omap: stop connector polling during suspend

2015-03-02 Thread Grygorii Strashko
On 03/02/2015 01:03 PM, Tomi Valkeinen wrote: On 26/02/15 15:57, grygorii.stras...@linaro.org wrote: Could I ask you to update this patch as below, pls? Your changes look ok to me, but they are not related to my patch so I don't see any reason to merge them. I'll pick your patch to my

Re: [PATCH RFC 6/6] ARM: dts: am335x-boneblack: Use new binding for HDMI

2015-03-02 Thread Russell King - ARM Linux
On Mon, Mar 02, 2015 at 07:08:39PM +0200, Tomi Valkeinen wrote: On 02/03/15 18:06, Russell King - ARM Linux wrote: This is missing the output of tda998x. It should have two ports, input and output, output going to hdmi-connector. We don't have that kind of level of modelling in DRM

Re: [PATCH 0/9] N900 Modem Speech Support

2015-03-02 Thread Pali Rohár
On Monday 02 March 2015 05:38:50 Sebastian Reichel wrote: Hi, This patchset contains the missing speech data support for the Nokia N900 modem. Userland access goes via /dev/cmt_speech. The API is implemented in libcmtspeechdata, which is used by ofono and the freesmartphone.org project.

Re: [PATCH 05/10] clkdev: add clkdev_create() helper

2015-03-02 Thread Stephen Boyd
On 03/02/15 09:06, Russell King wrote: Add a helper to allocate and add a clk_lookup structure. This can not only be used in several places in clkdev.c to simplify the code, but more importantly, can be used by callers of the clkdev code to simplify their clkdev creation and registration.