Re: [PATCH 09/21] drm/omap: handle mismatching color format and buffer width

2015-03-02 Thread Daniel Stone
Hi, On 2 March 2015 at 09:50, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 27/02/15 16:40, Daniel Stone wrote: On 27 February 2015 at 13:01, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Feb 26, 2015 at 03:20:17PM +0200, Tomi Valkeinen wrote: omapdrm doesn't check if the width

Re: [PATCH 09/21] drm/omap: handle mismatching color format and buffer width

2015-02-27 Thread Daniel Stone
Hi, On 27 February 2015 at 13:01, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Feb 26, 2015 at 03:20:17PM +0200, Tomi Valkeinen wrote: omapdrm doesn't check if the width of the framebuffer and the color s/width/pitch/ format's bits-per-pixel match. s/match/are compatible/ For example,

[PATCH 2/2] FB: OMAP: Blizzard: Properly disable zoom when necessary

2008-10-09 Thread Daniel Stone
update (show menu or dialog) after a scaled screen update (video overlay), scaling setting are not reset properly and you see this magnifying glass effect if a part of new update overlaps previously scaled area. Signed-off-by: Siarhei Siamashka [EMAIL PROTECTED] Signed-off-by: Daniel Stone [EMAIL

[PATCH 1/2] Input: Touchscreen: Make TSC2005 depend on SPI

2008-10-09 Thread Daniel Stone
Make Kconfig reflect reality. Signed-off-by: Daniel Stone [EMAIL PROTECTED] --- drivers/input/touchscreen/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index d33f450..84ba956 100644

Re: [PATCH 0/2] omapfb bugfixes

2008-10-09 Thread Daniel Stone
On Thu, Oct 09, 2008 at 12:58:55PM +0300, ext Tony Lindgren wrote: * Daniel Stone [EMAIL PROTECTED] [081009 12:39]: Hi, These should be fine for merging, one bugfix from Siarhei and one tiny Kconfig dependency update. OK. Can you also refresh your FB: OMAP: DISPC: Allow multiple

[PATCH 0/2] omapfb bugfixes

2008-10-09 Thread Daniel Stone
Hi, These should be fine for merging, one bugfix from Siarhei and one tiny Kconfig dependency update. Cheers, Daniel signature.asc Description: Digital signature

[PATCH] FB: OMAP: DISPC: Allow multiple external IRQ handlers

2008-10-09 Thread Daniel Stone
masks. Signed-off-by: Daniel Stone [EMAIL PROTECTED] --- drivers/video/omap/dispc.c | 94 ++- drivers/video/omap/dispc.h |7 ++- drivers/video/omap/rfbi.c |6 ++- 3 files changed, 65 insertions(+), 42 deletions(-) diff --git a/drivers/video/omap

Re: [PATCH] kill warnings in gpmc

2008-10-07 Thread Daniel Stone
. Also, the error values returned by the function is not used by the caller. Hence it should not be returning any value. Signed-off-by: Anand Gadiyar [EMAIL PROTECTED] Signed-off-by: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED] Signed-off-by: Daniel Stone [EMAIL PROTECTED] signature.asc

Re: [PATCH 1/3] i2c: lp5521: remove dead code

2008-10-06 Thread Daniel Stone
On Mon, Oct 06, 2008 at 12:11:29PM +0300, ext Felipe Balbi wrote: That LED_CONNECTED_WRONG was never defined so removing. If someone needs those hooks, add back via proper platform_data instead of nasty ifdefery. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Daniel Stone

Re: [PATCH] gpmc: Remove compilation warning

2008-09-29 Thread Daniel Stone
On Mon, Sep 29, 2008 at 06:40:43PM +0530, ext Pakaravoor, Jagadeesh wrote: From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED] Return type of gpmc_init() function is void. Also, the error values returned by the function is not used by the caller. Hence it should not be returning any value.

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-09-12 Thread Daniel Stone
On Wed, Sep 10, 2008 at 05:13:03PM -0700, ext Tony Lindgren wrote: * Daniel Stone [EMAIL PROTECTED] [080827 02:47]: On Wed, Aug 27, 2008 at 12:50:37AM -0600, ext Paul Walmsley wrote: Hello Daniel, On Wed, 27 Aug 2008, Daniel Stone wrote: Yep, looks fine to me: just wasn't

Re: [PATCH 15/29] OMAP3: PM: Move serial console check from omap3_can_sleep to idle loop

2008-09-11 Thread Daniel Stone
On Thu, Sep 11, 2008 at 03:33:59PM +0300, ext Kevin Hilman wrote: Signed-off-by: Git administrator [EMAIL PROTECTED] Oops. :) Cheers, Daniel signature.asc Description: Digital signature

Re: [PATCH] omapfb: setting GOLCD bit for shadow registers to make effect

2008-09-09 Thread Daniel Stone
On Mon, Sep 08, 2008 at 09:02:56PM +0100, ext Måns Rullgård wrote: arun c [EMAIL PROTECTED] writes: + while (dispc_read_reg(DISPC_CONTROL) (1 5)) + continue; + MOD_REG_FLD(DISPC_CONTROL, 1 5, 1 5); + return height * screen_width * bpp / 8; } This looks good.

Re: [PATCH 12/33] Add tsc2005 touchscreen driver

2008-09-01 Thread Daniel Stone
On Mon, Sep 01, 2008 at 03:01:43AM +0200, ext andrzej zaborowski wrote: 2008/8/30 Felipe Balbi [EMAIL PROTECTED]: [roughly 470 irrelevant lines discarded] + /* discard the event if it still is within the previous rect - unless +* if the pressure is harder, but then use

[PATCH 0/2] Minor display fixes

2008-08-26 Thread Daniel Stone
Hi, The following two patches fix two minor display issues. One is that sgx_fck was useless, and didn't work (at least on ES2.0 and above; haven't checked the TRM for pre-ES2.0). The other is that the dispc IRQ handling was rather odd and inflexible, so due to the needs of ... an external

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-08-26 Thread Daniel Stone
On Tue, Aug 26, 2008 at 11:05:42PM -0600, ext Paul Walmsley wrote: Hello Daniel, Hi, On Wed, 27 Aug 2008, Daniel Stone wrote: The GFX/SGX functional and interface clocks have different masks, for some unknown reason, so split EN_SGX_SHIFT into one each for fclk and iclk. thanks

Re: USB driver issue

2008-08-04 Thread Daniel Stone
On Sat, Aug 02, 2008 at 01:51:59AM -0700, ext Emanoil Kotsev wrote: Kernel developers should fix bugs in minor kernel versions as they are meant for this purpous and do major changes only in major version. A bunch of bugfixes I see (not only usb related) are just not in place in

Re: USB driver issue

2008-08-01 Thread Daniel Stone
On Thu, Jul 31, 2008 at 01:38:59PM -0700, ext Emanoil Kotsev wrote: Kernel developers should fix bugs in minor kernel versions as they are meant for this purpous and do major changes only in major version. A bunch of bugfixes I see (not only usb related) are just not in place in minor kernel

Re: USB driver issue

2008-07-30 Thread Daniel Stone
On Wed, Jul 30, 2008 at 07:21:53AM -0700, ext Emanoil Kotsev wrote: Dear Felipe, I just want to tell, that while still developing kernels in the 2.6.2X series a kernel 2.6.22 can not be labeled as old. Actually, it can, as it was released quite a long time ago. Besides it comes along with

Re: USB driver issue

2008-07-30 Thread Daniel Stone
On Wed, Jul 30, 2008 at 09:53:43PM +0530, ext Gadiyar, Anand wrote: Grr. Saying one needs to upgrade to the latest kernel before one can expect support is a bit like certain proprietary OS vendors - and even they do a better job than this. If you want to support people running 2.6.22, good

Re: [PATCH] This patch adds the driver to turn on the TFP410 framer to get DVI output working on the beagleboard

2008-05-16 Thread Daniel Stone
On Fri, May 16, 2008 at 11:12:35AM +0200, ext Koen Kooi wrote: +static int omap3beagle_panel_init(struct lcd_panel *panel, + struct omapfb_device *fbdev) +{ + omap_request_gpio(LCD_PANEL_ENABLE_GPIO); +X ... ? + + return 0; +} signature.asc

Re: [PATCH 0/2] Make N810 keyboard work with console

2008-05-15 Thread Daniel Stone
On Wed, May 14, 2008 at 09:01:17PM -0700, ext Tony Lindgren wrote: Here are few fun patches for N810 hackers to make the integrated keyboard work with console :) This should be done in a generic way and the old behaviour is preserved if optional sticky keys are not passed from platform_data.

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread Daniel Stone
On Wed, Apr 09, 2008 at 09:05:58PM +0300, ext Felipe Balbi wrote: On Wed, Apr 09, 2008 at 07:26:31PM +0200, andrzej zaborowski wrote: Question not really related to this patchset, but in the TSC2005 driver some averaging and limit checks are done to the ADC values. Shouldn't that be done in

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread Daniel Stone
On Thu, Apr 10, 2008 at 01:58:51AM +0200, ext andrzej zaborowski wrote: On 09/04/2008, Lauri Leukkunen [EMAIL PROTECTED] wrote: In my opinion kernel should provide correct data to user-space, not some pseudo-random interference from the LCD. I think this is discutible. There's a number