Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Igor Grinberg
-by: Russell King li...@arm.linux.org.uk Signed-off-by: Ohad Ben-Cohen o...@wizery.com Apart, from the minor comment below, Acked-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-davinci/board-da850-evm.c | 8 ++- arch/arm/mach-omap2/board-4430sdp.c | 7

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Igor Grinberg
On 10/23/12 09:51, Ohad Ben-Cohen wrote: On Tue, Oct 23, 2012 at 9:37 AM, Igor Grinberg grinb...@compulab.co.il wrote: + ret = wl12xx_set_platform_data(wlan_data); + /* bail out silently in case wl12xx isn't configured */ + if (ret == -ENOSYS) + return ret; Since

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-17 Thread Igor Grinberg
Hi Ohad, On 10/17/12 11:10, Ohad Ben-Cohen wrote: On Tue, Oct 16, 2012 at 8:26 PM, Tony Lindgren t...@atomide.com wrote: Hmm looking at it repeats the same code over again. Can you rather add some wl12xx_board_init() helper function to mach-omap2/devices.c to do it? Nice, see below. Note

Re: [RESEND] [PATCH 3.6.0- 3/6] ARM/pxa: use module_platform_driver macro

2012-10-16 Thread Igor Grinberg
On 10/12/12 09:11, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@st.com Acked-by: Igor Grinberg grinb...@compulab.co.il

Re: [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()

2012-10-10 Thread Igor Grinberg
it be static? Fix by implementing Tony's suggestion to add a sideways include to the new location of the debug-devices.h file in arch/arm/mach-omap2/. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Igor Grinberg grinb...@compulab.co.il Cc: Tony Lindgren t...@atomide.com Acked-by: Igor Grinberg

Re: OMAP baseline test results for v3.6-rc7

2012-10-02 Thread Igor Grinberg
On 10/02/12 01:28, Paul Walmsley wrote: On Thu, 27 Sep 2012, Igor Grinberg wrote: Have you tried the nohlt boot parameter? It looks like the wfi is killing those SoCs once you use EMAC. Just tried with nohlt. Didn't help on CM-T3517 with either NFS or MMC root, nor with the 3517EVM

Re: ARM: OMAP: fix new sparse warnings

2012-09-27 Thread Igor Grinberg
Grinberg grinb...@compulab.co.il Cc: Tony Lindgren t...@atomide.com Acked-by: Igor Grinberg grinb...@compulab.co.il -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: OMAP baseline test results for v3.6-rc7

2012-09-27 Thread Igor Grinberg
On 09/24/12 21:21, Paul Walmsley wrote: Here are some basic OMAP boot and power management test results for v3.6-rc6: http://www.pwsan.com/omap/testlogs/test_v3.6-rc6/20120918101040/ Some observations: Boot tests: * CM-T3517: L3 in-band error with IPSS during boot - Cause

Re: Help needed with remaining plat headers

2012-09-21 Thread Igor Grinberg
On 09/21/12 02:29, Tony Lindgren wrote: Hi all, With the recent pull request I sent for v3.7, we now have pretty much all the mach includes fixed up for omap2+ for single zImage support. We still have quite a few plat headers that we need to sort out manually. Please take a look at

Re: OMAP baseline test results for v3.6-rc4

2012-09-07 Thread Igor Grinberg
On 09/05/12 18:44, Paul Walmsley wrote: Here are some basic boot and power management test results for v3.6-rc4: http://www.pwsan.com/omap/testlogs/test_v3.6-rc4/20120904122415/ Some observations: [...] * CM-T3517: L3 in-band error with USB OTG during boot - Cause unknown;

[PATCH] ARM: OMAP: remove unused hwmod function prototypes

2012-09-04 Thread Igor Grinberg
Several hwmod function prototypes appear to not have an implementation because the corresponding functions were removed or renamed. Those prototypes are unneeded anymore - remove them. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/plat-omap/include/plat/omap_hwmod.h |7

Re: [PATCH] ARM: OMAP: timer: obey the !CONFIG_OMAP_32K_TIMER

2012-08-30 Thread Igor Grinberg
On 08/30/12 23:20, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [120829 15:02]: On 08/28/12 01:43, Shilimkar, Santosh wrote: On Mon, Aug 27, 2012 at 3:26 PM, Igor Grinberg grinb...@compulab.co.il wrote: Currently, omap2_sync32k_clocksource_init() function initializes the 32K

Re: [PATCH 6/9] ARM: OMAP1: move omap1_bl pdata out of arch/arm/*

2012-08-29 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/29/12 18:04, Tomi Valkeinen wrote: On Wed, 2012-08-29 at 02:18 +0300, Igor Grinberg wrote: omap1 backlight platform data resides inside plat/board.h while it should be inside include/linux/... Move the omap1 backlight platform data

Re: [PATCH] ARM: OMAP: timer: obey the !CONFIG_OMAP_32K_TIMER

2012-08-29 Thread Igor Grinberg
On 08/28/12 01:43, Shilimkar, Santosh wrote: On Mon, Aug 27, 2012 at 3:26 PM, Igor Grinberg grinb...@compulab.co.il wrote: Currently, omap2_sync32k_clocksource_init() function initializes the 32K timer as the system clock source regardless of the CONFIG_OMAP_32K_TIMER setting. Fix

[PATCH 0/9] ARM: OMAP: cleanup plat/board.h file

2012-08-28 Thread Igor Grinberg
tested with omap1|2plus_defconfig(s). Igor Grinberg (9): ARM: OMAP: cleanup struct omap_board_config_kernel ARM: OMAP: omap3evm: cleanup revision bits ARM: OMAP: remove the sti console workaround ARM: OMAP1: remove the crystal type tag parsing ARM: OMAP: remove the omap custom tags ARM

[PATCH 3/9] ARM: OMAP: remove the sti console workaround

2012-08-28 Thread Igor Grinberg
-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/pm24xx.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/pm24xx.c b/arch/arm/mach-omap2/pm24xx.c index 2edeffc..9e54dc9 100644 --- a/arch/arm/mach-omap2/pm24xx.c +++ b/arch/arm/mach

[PATCH 6/9] ARM: OMAP1: move omap1_bl pdata out of arch/arm/*

2012-08-28 Thread Igor Grinberg
Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap1/board-osk.c |1 + arch/arm/mach-omap1/board-palmte.c |1 + arch/arm/mach-omap1/board-palmtt.c |1 + arch/arm/mach-omap1/board-palmz71.c |1 + arch/arm/plat-omap/include/plat/board.h

[PATCH 1/9] ARM: OMAP: cleanup struct omap_board_config_kernel

2012-08-28 Thread Igor Grinberg
a long time (if ever). Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap1/board-generic.c |5 - arch/arm/mach-omap1/board-voiceblue.c|5 - arch/arm/mach-omap2/board-3430sdp.c |6 -- arch/arm/mach-omap2/board-3630sdp.c |6

[PATCH 2/9] ARM: OMAP: omap3evm: cleanup revision bits

2012-08-28 Thread Igor Grinberg
The omap3evm has its revision information bits inside the plat/board.h file. Those bits are not used anywhere in the upstream tree besides the board-omap3evm.c file. Move the OMAP3EVM_BOARD_GEN_* bits to the board file and remove the get_omap3_evm_rev() function declaration. Signed-off-by: Igor

[PATCH 4/9] ARM: OMAP1: remove the crystal type tag parsing

2012-08-28 Thread Igor Grinberg
The omap1 crystal setting uses the OMAP custom tags. Those tags are not used in upstream kernel and therefore the crystal type is never set by the tag parsing code on upstream kernels. Remove the crystal tag parsing code. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach

[PATCH 7/9] ARM: OMAP1: move lcd pdata out of arch/arm/*

2012-08-28 Thread Igor Grinberg
omap1 lcd platform data resides inside plat/board.h while it should be inside include/linux/... Move the omap1 lcd platform data to include/linux/omapfb.h. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap1/board-ams-delta.c |1 - arch/arm/mach-omap1/board

[PATCH 5/9] ARM: OMAP: remove the omap custom tags

2012-08-28 Thread Igor Grinberg
The omap custom initialization tags are not used anymore (if ever) by the mainline kernel. Thus remove the omap custom initialization tags. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/plat-omap/common.c | 34 arch/arm/plat-omap/include/plat

[PATCH 8/9] ARM: OMAP: move debug_card_init() function

2012-08-28 Thread Igor Grinberg
debug_card_init() function resides in the plat/board.h file. Move it to a separate header file under plat/ so the board.h file can be removed. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-h4.c |2 +- arch/arm/plat-omap/include/plat

[PATCH 9/9] ARM: OMAP: remove plat/board.h file

2012-08-28 Thread Igor Grinberg
plat/board.h file is now empty - remove it. Cc: Jarkko Lavinen jarkko.lavi...@nokia.com Cc: Chris Ball c...@laptop.org Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: linux-...@vger.kernel.org Cc: linux-...@lists.infradead.org Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm

[PATCH] ARM: OMAP: timer: obey the !CONFIG_OMAP_32K_TIMER

2012-08-27 Thread Igor Grinberg
Currently, omap2_sync32k_clocksource_init() function initializes the 32K timer as the system clock source regardless of the CONFIG_OMAP_32K_TIMER setting. Fix this by providing a default implementation for !CONFIG_OMAP_32K_TIMER case. Signed-off-by: Igor Grinberg grinb...@compulab.co.il Reviewed

Re: [PATCH v6 01/10] ARM: OMAP2+: nand: unify init functions

2012-08-21 Thread Igor Grinberg
thomas.weber.li...@googlemail.com reported that value of devkit8000 to be CS0. Overo board was found to be using CS0 based on u-boot, while google grep says omap3touchbook too has CS0. Signed-off-by: Afzal Mohammed af...@ti.com Reviewed-by: Jon Hunter jon-hun...@ti.com Acked-by: Igor Grinberg grinb

Re: [PATCH v2 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards

2012-08-16 Thread Igor Grinberg
On 08/14/12 12:07, Peter Ujfalusi wrote: These boards have similar audio setup and they can all use the same driver for audio support if it is enabled in the kernel config. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Cc: Igor Grinberg grinb...@compulab.co.il Acked-by: Tony Lindgren

Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards

2012-08-09 Thread Igor Grinberg
On 08/09/12 13:21, Peter Ujfalusi wrote: On 08/08/2012 04:06 PM, Igor Grinberg wrote: Well, yes I know we will need to adjust the user space. I wanted to change that for a long time and did not get to it... Now, with your patches, it seems like the best time for doing this. Done for the v2

Re: [PATCH 2/2] ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data

2012-08-09 Thread Igor Grinberg
Hi Timo, On 08/09/12 15:41, Timo Kokkonen wrote: The IR diode on the RX51 is connected to the GPT9. This data is needed for the IR driver to function. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++

Re: [PATCH 1/2] media: rc: Introduce RX51 IR transmitter driver

2012-08-09 Thread Igor Grinberg
On 08/09/12 15:41, Timo Kokkonen wrote: This is the driver for the IR transmitter diode found on the Nokia N900 (also known as RX51) device. The driver is mostly the same as found in the original 2.6.28 based kernel that comes with the device. The following modifications have been made

Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards

2012-08-08 Thread Igor Grinberg
Hi Peter, Thank you very much for the patch series. I probably will have some time to look into it more deeply on the next week. Currently, only a small comment, please see below. On 08/08/12 12:54, Peter Ujfalusi wrote: These boards have similar audio setup and they can all use the same driver

Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards

2012-08-08 Thread Igor Grinberg
On 08/08/12 15:29, Peter Ujfalusi wrote: Hi Igor, On 08/08/2012 03:24 PM, Igor Grinberg wrote: diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 97d7190..b73fa5c 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm

Re: [PATCH] Revert ARM: OMAP3530evm: set pendown_state and debounce time for ads7846

2012-08-07 Thread Igor Grinberg
On 08/07/12 04:42, Zumeng Chen wrote: 于 2012年08月07日 04:22, Igor Grinberg 写道: 1) The above commit introduced a common -get_pendown_state() function into the generic code, but that function was board-specific for the OMAP3EVM and thus broke most other boards using this code. 2) The above

Re: [PATCH] OMAPDSS: OMAPFB: fix framebuffer console colors

2012-08-06 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/12 09:00, Tomi Valkeinen wrote: On Sat, 2012-08-04 at 19:19 +0300, Grazvydas Ignotas wrote: omapfb does not currently set pseudo palette correctly for color depths above 16bpp, making red text invisible, command like echo -e

Re: [PATCH] OMAPDSS: OMAPFB: fix framebuffer console colors

2012-08-06 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/12 14:22, Tomi Valkeinen wrote: On Mon, 2012-08-06 at 13:15 +0300, Igor Grinberg wrote: On 08/06/12 09:00, Tomi Valkeinen wrote: On Sat, 2012-08-04 at 19:19 +0300, Grazvydas Ignotas wrote: omapfb does not currently set pseudo palette

[PATCH] Revert ARM: OMAP3530evm: set pendown_state and debounce time for ads7846

2012-08-06 Thread Igor Grinberg
Chen zumeng.c...@windriver.com Cc: Arnd Bergmann a...@arndb.de Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- Kevin, sorry for the late reply. How about the above commit message and the below patch? The patch applies cleanly to Tony's master branch (6 Aug 2012) or Kevin's kevin-omap-pm

Re: [PATCH] Revert ARM: OMAP3530evm: set pendown_state and debounce time for ads7846

2012-08-06 Thread Igor Grinberg
On 08/06/12 23:52, Kevin Hilman wrote: Igor Grinberg grinb...@compulab.co.il writes: 1) The above commit introduced a common -get_pendown_state() function into the generic code, but that function was board-specific for the OMAP3EVM and thus broke most other boards using this code. 2

Re: [PATCH v1 1/1] ARM: OMAP3: Use OMAP3_HAS_IVA_REGS with OMAP3503

2012-08-02 Thread Igor Grinberg
On 07/31/12 02:50, Juha Kuikka wrote: Similarly to am3703, it seems that omap3503 has an IVA control registers even though the subsystem is non-functional. This patch sets the OMAP3_HAS_IVA_REGS feature to force initialization of there registers. Based in Mark A. Greer's patch ARM:

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-27 Thread Igor Grinberg
On 07/26/12 22:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberg grinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been modified by Arnd in a way that of course will trigger GPIO use without being requested. I'm sorry, I was not available by that time Arnd

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-27 Thread Igor Grinberg
On 07/26/12 22:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberg grinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been modified by Arnd in a way that of course will trigger GPIO use without being requested. I'm sorry, I was not available by that time Arnd

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-27 Thread Igor Grinberg
On 07/27/12 20:46, Kevin Hilman wrote: Igor Grinberg grinb...@compulab.co.il writes: On 07/26/12 22:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberg grinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been modified by Arnd in a way that of course

Re: [PATCH] ARM: OMAP: fix the ads7846 init code

2012-07-23 Thread Igor Grinberg
Hi Kevin, On 07/12/12 02:00, Kevin Hilman wrote: Hi Igor, Igor Grinberg grinb...@compulab.co.il writes: In case a board provides the gpio_pendown and not board_pdata, the GPIO debounce is not taken care of. Fix this by taking care of GPIO debounce in any case. Signed-off-by: Igor

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-23 Thread Igor Grinberg
if the bank has been runtime suspended. This is exctly what happens on Overo platforms (3530 Water, 3730 Overo FireSTORM) since this is the only GPIO used in the bank. To fix, don't free the GPIO at all since it is always in use. Cc: Igor Grinberg grinb...@compulab.co.il Signed-off

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-23 Thread Igor Grinberg
patch (e.g. fixes-non-critical should not receive the patch). Kevin, thanks for the patch. On 07/23/12 15:53, Igor Grinberg wrote: On 07/12/12 02:18, Kevin Hilman wrote: commit 97ee9f01d6 (ARM: OMAP: fix the ads7846 init code) mistakenly frees the pen-down GPIO even though it will be used

Re: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-14 Thread Igor Grinberg
On 06/14/12 07:46, Zumeng Chen wrote: 于 2012年06月13日 20:18, Hiremath, Vaibhav 写道: On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote: From: Zumeng Chenzumeng.c...@windriver.com If we don't set proper debouce time for ads7846, then there are flooded interrupt counters of ads7846 responding to

Re: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-14 Thread Igor Grinberg
On 06/14/12 10:08, Zumeng Chen wrote: 于 2012年06月14日 14:44, Igor Grinberg 写道: On 06/14/12 07:46, Zumeng Chen wrote: 于 2012年06月13日 20:18, Hiremath, Vaibhav 写道: On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote: From: Zumeng Chenzumeng.c...@windriver.com If we don't set proper debouce

[PATCH] ARM: OMAP: fix the ads7846 init code

2012-06-14 Thread Igor Grinberg
In case a board provides the gpio_pendown and not board_pdata, the GPIO debounce is not taken care of. Fix this by taking care of GPIO debounce in any case. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/common-board-devices.c | 22 -- 1 files

Re: [PATCH] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset fix issues.

2012-06-14 Thread Igor Grinberg
Hi Russ, On 06/14/12 14:31, Russ Dill wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' (1fcb57d0) fixes an issue where the ULPI PHYs were not held in reset while initializing the EHCI controller. However, it also changes behavior in omap-usb-host.c omap_usbhs_init by releasing

Re: [PATCH V2 1/5] ARM: OMAP3EVM: Add NAND flash definition

2012-06-13 Thread Igor Grinberg
On 06/13/12 04:44, Zumeng Chen wrote: From: Zumeng Chen zumeng.c...@windriver.com Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Tested-by: Zumeng Chen zumeng.c...@windriver.com --- arch/arm/mach-omap2/board-omap3evm.c | 39 ++ 1 files changed, 39

Re: [PATCH V2 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file

2012-06-13 Thread Igor Grinberg
On 06/13/12 04:44, Zumeng Chen wrote: From: Zumeng Chen zumeng.c...@windriver.com EHCI PHY requires these regulators: EVM Rev =E -- VAUX2 EVM Rev E -- VUSB1V5, VUSB1V8 Adding USB internal LDOs (vusb1v5 vusb1v8) and VAUX2 to omap3evm board file. Also removing

Re: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-13 Thread Igor Grinberg
On 06/13/12 04:44, Zumeng Chen wrote: From: Zumeng Chen zumeng.c...@windriver.com If we don't set proper debouce time for ads7846, then there are flooded interrupt counters of ads7846 responding to one time touch on screen, so the driver couldn't work well. And since most OMAP3 series

Re: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-13 Thread Igor Grinberg
On 06/13/12 12:03, Zumeng Chen wrote: 于 2012年06月13日 15:51, Igor Grinberg 写道: On 06/13/12 04:44, Zumeng Chen wrote: From: Zumeng Chenzumeng.c...@windriver.com If we don't set proper debouce time for ads7846, then there are flooded interrupt counters of ads7846 responding to one time touch

Re: [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set

2012-06-12 Thread Igor Grinberg
On 06/11/12 17:00, Zumeng Chen wrote: A typo fix for this cosmetic change and mute a failed message from a unnecessary setting of some parent clk for usbhs_omap on OMAP3EVM. Signed-off-by: Zumeng Chen zumeng.c...@gmail.com --- drivers/mfd/omap-usb-host.c |4 +++- 1 files changed, 3

Re: [PATCH 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-12 Thread Igor Grinberg
On 06/12/12 05:49, Zumeng Chen wrote: 2012/6/11 Igor Grinberg grinb...@compulab.co.il mailto:grinb...@compulab.co.il Hi, This is input subsystem, add Dmitry and linux-input. On 06/11/12 17:00, Zumeng Chen wrote: If we don't set proper debouce time for ads7846

Re: [PATCH 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-11 Thread Igor Grinberg
Hi, This is input subsystem, add Dmitry and linux-input. On 06/11/12 17:00, Zumeng Chen wrote: If we don't set proper debouce time for ads7846, then there are flooded interrupt counters of ads7846 responding to one time touch on screen, so the driver couldn't work well. And since most

Re: [PATCH] ARM: OMAP2+: OPP: Fix to ensure check of right oppdef after bad one

2012-06-01 Thread Igor Grinberg
Hi Kevin, Nishanth, On 06/01/12 02:15, Kevin Hilman wrote: Nishanth Menon n...@ti.com writes: Commit 9fa2df6b90786301b175e264f5fa9846aba81a65 (ARM: OMAP2+: OPP: allow OPP enumeration to continue if device is not present) makes the logic: for (i = 0; i opp_def_size; i++) { snip

Re: [PATCH 2/2] arm: omap3: am35x: Disable hlt when using Davinci EMAC

2012-05-15 Thread Igor Grinberg
On 05/15/12 00:32, Kevin Hilman wrote: Mark A. Greer mgr...@animalcreek.com writes: On Mon, May 14, 2012 at 11:20:58AM +0300, Igor Grinberg wrote: Hi Mark, Hi Igor. Thanks for the great work! On 05/12/12 00:12, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com The am35x

Re: [PATCH 2/2] arm: omap3: am35x: Disable hlt when using Davinci EMAC

2012-05-14 Thread Igor Grinberg
Hi Mark, Thanks for the great work! On 05/12/12 00:12, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com The am35x family of SoCs has a Davinci EMAC ethernet controller on-chip. Unfortunately, the EMAC is unable to wake the PRCM when there is network activity which leads to

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-09 Thread Igor Grinberg
On 05/08/12 19:24, Greg Kroah-Hartman wrote: On Tue, May 08, 2012 at 10:53:44AM +0300, Igor Grinberg wrote: On 05/07/12 17:48, Alan Stern wrote: On Mon, 7 May 2012, Igor Grinberg wrote: On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry

[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-09 Thread Igor Grinberg
When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Signed-off-by: Igor Grinberg grinb...@compulab.co.il Acked-by: Felipe Balbi ba...@ti.com Tested-by: Govindraj.R govindraj.r...@ti.com Acked

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-08 Thread Igor Grinberg
On 05/07/12 17:48, Alan Stern wrote: On Mon, 7 May 2012, Igor Grinberg wrote: On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) and I'd like

Re: [PATCH] ARM: OMAP3: cm-t35: add support for power off

2012-05-08 Thread Igor Grinberg
ping x2 On 04/19/12 13:40, Igor Grinberg wrote: ping! Tony, can this please, go into 3.5? On 03/28/12 11:51, Igor Grinberg wrote: Enable the power off feature of the TPS65930 on-board PMIC. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t35.c

Re: [PATCH] [OMAP] Cleanup Beagleboard DVI reset gpio

2012-05-08 Thread Igor Grinberg
Hi Russ, On 05/07/12 23:00, Russ Dill wrote: This removes several boot warnings from board-omap3beagle.c: - gpio_request: gpio--22 (DVI reset) status -22 - Unable to get DVI reset GPIO There is a combination of leftover code and revision confusion. Additionally, xM support is currently

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Igor Grinberg
Hi Samuel, On 05/07/12 11:09, Samuel Ortiz wrote: Hi Igor, On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote: Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) Sorry about that. and I'd like this to go into 3.5. Then you may

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Igor Grinberg
On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) and I'd like this to go into 3.5. Also, the dependency patch is already in Linus' tree. It has

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-06 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alan, On 04/20/12 14:57, Felipe Balbi wrote: On Thu, Apr 19, 2012 at 11:01:16AM -0400, Alan Stern wrote: On Thu, 19 Apr 2012, Igor Grinberg wrote: ping Alan, Felipe, Can this go into 3.5? It's okay with me. Acked-by: Alan Stern st

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-04 Thread Igor Grinberg
Hi Russ, On 05/03/12 22:08, Russ Dill wrote: On Wed, May 2, 2012 at 3:38 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Mon, Mar 19, 2012 at

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-04 Thread Igor Grinberg
On 05/04/12 12:06, Russ Dill wrote: On Thu, May 3, 2012 at 11:03 PM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Russ, On 05/03/12 22:08, Russ Dill wrote: On Wed, May 2, 2012 at 3:38 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-04-22 Thread Igor Grinberg
Hi Samuel, On 04/16/12 19:46, Samuel Ortiz wrote: Hi Keshava, On Wed, Apr 11, 2012 at 05:15:03PM +0530, Munegowda, Keshava wrote: On Tue, Mar 27, 2012 at 8:40 PM, Igor Grinberg grinb...@compulab.co.il wrote: On 03/19/12 08:42, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo

Re: AM3517 boot failure

2012-04-19 Thread Igor Grinberg
On 04/19/12 05:07, Paul Walmsley wrote: Hi, just wanted to mention this on the list to see if anyone else was seeing it. I'm using a Compulab CM-T3517 and attempting to use nfsroot, and the boot hangs. Here are the last few lines when booting with initcall_debug: [7.069885]

Re: [PATCH] ARM: OMAP3: cm-t35: add support for power off

2012-04-19 Thread Igor Grinberg
ping! Tony, can this please, go into 3.5? On 03/28/12 11:51, Igor Grinberg wrote: Enable the power off feature of the TPS65930 on-board PMIC. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t35.c |5 + 1 files changed, 5 insertions(+), 0

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-04-19 Thread Igor Grinberg
Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- This patch depends on the patch from Keshava [1]: ARM: OMAP3

Re: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35.

2012-04-05 Thread Igor Grinberg
On 04/03/12 20:43, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [120327 23:37]: On 03/27/12 20:32, Russ Dill wrote: No objection. 10x Russ. I've combined patches 5 - 12 into a single patch as they pretty much do the same thing, and to cut down the patch noise for fixes

Re: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35.

2012-03-30 Thread Igor Grinberg
On 03/28/12 19:03, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [120327 23:36]: Hi Tony, On 03/27/12 19:28, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [120327 08:56]: Hi Russ, This patch works, but can we, please use the attached patch instead? Hmm

Re: OMAP TWL4030/TPS65950 power off

2012-03-30 Thread Igor Grinberg
Hi Ashwin, On 03/30/12 21:04, Ashwin Bihari wrote: Greetings, In one of the older Kernels, there was a twl4030-poweroff driver that provided a hook to shutdown the OMAP when the poweroff or shutdown -h now command was issued in Linux. This also put the TWL4030/TPS65950 into it's power on

Re: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35.

2012-03-28 Thread Igor Grinberg
Hi Tony, On 03/27/12 19:28, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [120327 08:56]: Hi Russ, This patch works, but can we, please use the attached patch instead? Hmm what's the difference here? Do you have some real controllable regulator for one of the smsc911x

Re: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35.

2012-03-28 Thread Igor Grinberg
On 03/27/12 20:32, Russ Dill wrote: No objection. 10x Russ. -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: OMAP3: cm-t35: add support for power off

2012-03-28 Thread Igor Grinberg
Enable the power off feature of the TPS65930 on-board PMIC. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t35.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Igor Grinberg
Hi Shubhrajyoti, On 03/28/12 12:03, Shubhrajyoti wrote: On Tuesday 27 March 2012 07:38 PM, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Why so ? Whats

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Igor Grinberg
On 03/28/12 12:53, Raja, Govindraj wrote: On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value

[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-27 Thread Igor Grinberg
When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- This patch depends on the patch from Keshava [1]: ARM: OMAP3: USB: Fix the EHCI

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-27 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Felipe, Samuel, On 03/20/12 17:55, Felipe Balbi wrote: On Tue, Mar 20, 2012 at 04:53:53PM +0100, Samuel Ortiz wrote: Hi Keshava, On Mon, Mar 19, 2012 at 12:12:47PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-27 Thread Igor Grinberg
driver to EHCI driver. Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com Reviewed-by: Partha Basak part...@india.ti.com Both EHCI ports worked on cm-t3730 previously and no regression is seen with this patch. Tested-by: Igor Grinberg grinb...@compulab.co.il -- Regards, Igor

Re: [PATCH 01/12] Remove odd gpmc_cfg/board_data redirection.

2012-03-27 Thread Igor Grinberg
was copied from gpmc-smc91x.c. Signed-off-by: Russ Dill russ.d...@ti.com Tested-by: Igor Grinberg grinb...@compulab.co.il -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 04/12] Remove regulator support from gmpc-smsc911x

2012-03-27 Thread Igor Grinberg
handling. Now that there is a simple regulator_register_fixed, we can push this registration back into the board files. Signed-off-by: Russ Dill russ.d...@ti.com Tested-by: Igor Grinberg grinb...@compulab.co.il -- Regards, Igor. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 02/12] Fix possible stale smsc911x flags.

2012-03-27 Thread Igor Grinberg
On 03/23/12 11:21, Russ Dill wrote: If this function is called the first time with flags set, and the second time without flags set then the leftover flags from the first called will be used rather than the desired default flags. Signed-off-by: Russ Dill russ.d...@ti.com Tested-by: Igor

Re: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35.

2012-03-27 Thread Igor Grinberg
17 00:00:00 2001 From: Igor Grinberg grinb...@compulab.co.il Date: Fri, 23 Mar 2012 02:21:37 -0700 Subject: [PATCH] ARM: OMAP3: cm-t35: add smsc911x regulators Add dummy regulators for smsc911x Ethernet controllers on both cm-t35/cmt3730 and sb-t35 boards. Signed-off-by: Igor Grinberg grinb

[PATCH] ARM: OMAP: fix section mismatches in usb-host.c

2012-03-26 Thread Igor Grinberg
(). This is often because setup_ehci_io_mux lacks a __init annotation or the annotation of omap_mux_init_signal is wrong. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/usb-host.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach

Re: [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard.

2012-03-23 Thread Igor Grinberg
Hi Russ, Mark, On 03/22/12 20:29, Russ Dill wrote: On Thu, Mar 22, 2012 at 4:37 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 21, 2012 at 10:19:54PM -0700, Russ Dill wrote: +static struct regulator_consumer_supply dummy_supplies[] = { + REGULATOR_SUPPLY(vddvario,

Re: Ethernet problems on AM3517, possible regression?

2012-03-06 Thread Igor Grinberg
Hi, On 03/05/12 19:32, CF Adad wrote: Hi Igor, Thanks for your reply! So are both ports working on the CM-T3517 simultaneously now? Well, you need to apply all the patches I've sent you. Looking at the latest board file for the CM-T3517 (arch/arm/mach-omap2/board-cm-t3517.c), I

Re: Ethernet problems on AM3517, possible regression?

2012-03-05 Thread Igor Grinberg
On 03/04/12 11:41, Igor Grinberg wrote: Hi, On 03/02/12 01:16, CF Adad wrote: We have both a CompuLab CM-T3517 and a Technexion TAM-3517 at the shop. Both boards provide dual Ethernet support in an identical fashion. One port uses the onboard EMAC tied to an SMSC LAN87xx series PHY

Re: Ethernet problems on AM3517, possible regression?

2012-03-04 Thread Igor Grinberg
Hi, On 03/02/12 01:16, CF Adad wrote: We have both a CompuLab CM-T3517 and a Technexion TAM-3517 at the shop. Both boards provide dual Ethernet support in an identical fashion. One port uses the onboard EMAC tied to an SMSC LAN87xx series PHY. The other is the old trusty SMSC LAN911X

[PATCH v3 1/2] ARM: OMAP: move generic EMAC init to separate file

2012-03-01 Thread Igor Grinberg
Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- v3: - use DEFINE_RES_* macros - check error of platform_device_register() - introduce a default MDIO bus frequency define Tony, this patch has been floating for about two months: http://www.spinics.net/lists/linux-omap/msg62160

[PATCH 2/2] ARM: OMAP3: cm-t3517: add EMAC support

2012-03-01 Thread Igor Grinberg
Add support for the EMAC Ethernet controller in the AM35xx SoC. Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t3517.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t3517.c b/arch/arm/mach-omap2

ARM: OMAP: patches for stable

2012-02-24 Thread Igor Grinberg
Hi Greg, There are several patches already in mainline, that should be also applied to stable: 40410715 (ARM: omap: fix oops in drivers/video/omap2/dss/dpi.c) [3.2-stable] d980e0f8 (ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found)

Re: [PATCH v2 5/7] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins

2012-02-23 Thread Igor Grinberg
Hi Tony, Rajendra, On 02/23/12 13:40, Rajendra Nayak wrote: From: Tony Lindgren t...@atomide.com Otherwise omap_device_build() and omap_mux related functions can't be marked as __init when twl is build as a module. If a board is using GPIO pins or regulators configured by an external

Re: [PATCH v2 6/7] ARM: OMAP3: Use .teardown of twl4030-gpio to clean board requests

2012-02-23 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Rajendra, On 02/23/12 13:40, Rajendra Nayak wrote: All OMAP3 boards which register a .setup function with twl4030 gpio driver do not seem to have a .teardown hook implemented. .setup mainly requests a few gpios and also in most cases does a

Re: [PATCH v2 5/7] ARM: OMAP2+: Split omap2_hsmmc_init() to properly support I2C GPIO pins

2012-02-23 Thread Igor Grinberg
On 02/24/12 06:11, Rajendra Nayak wrote: On Friday 24 February 2012 12:17 AM, Tony Lindgren wrote: * Igor Grinberggrinb...@compulab.co.il [120223 05:56]: --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -411,9 +411,9 @@ static struct omap2_hsmmc_info mmc[]

[PATCH] ARM: OMAP: update omap1 and omap2plus defconfigs

2012-02-08 Thread Igor Grinberg
This patch updates omapX_defconfig to 3.3-rc1 and enables the CONFIG_DEBUG_SECTION_MISMATCH. The update is done by: 1) make mrproper make omapX_defconfig 2) Enable the CONFIG_DEBUG_SECTION_MISMATCH 3) make savedefconfig 4) cp defconfig arch/arm/configs/omapX_defconfig Signed-off-by: Igor

Re: [PATCH] ARM: OMAP: update omap1 and omap2plus defconfigs

2012-02-08 Thread Igor Grinberg
Hi Russell, On 02/08/12 12:19, Russell King - ARM Linux wrote: On Wed, Feb 08, 2012 at 12:16:13PM +0200, Igor Grinberg wrote: This patch updates omapX_defconfig to 3.3-rc1 and enables the CONFIG_DEBUG_SECTION_MISMATCH. You shouldn't enable this in the kernel supplied defconfigs. Hmmm... Ok

<    1   2   3   4   >