Re: [PATCH 01/32] arm/omap: use system_wq in mailbox

2011-01-03 Thread Kanigeri, Hari
Tejun, On Mon, Jan 3, 2011 at 7:49 AM, Tejun Heo t...@kernel.org wrote: With cmwq, there's no reason to use a separate workqueue for mailbox. Use the system_wq instead.  mbox-rxq-work is sync flushed in omap_mbox_fini() to make sure it's not running on any cpu, which makes sure that no mbox

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2010-12-20 Thread Kanigeri, Hari
Felipe, On Mon, Dec 20, 2010 at 11:12 AM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with garbage. So, use the existing proc_lock for that. I observed

Re: [PATCH v4 5/5] OMAP: mailbox: use runtime pm for clk and sysc handling

2010-12-16 Thread Kanigeri, Hari
Omar, On Thu, Dec 16, 2010 at 12:47 AM, Omar Ramirez Luna omar.rami...@ti.com wrote: Use runtime pm APIs to enable/disable mailbox clocks and to configure SYSC register. Based on the patch sent by Felipe Contreras: https://patchwork.kernel.org/patch/101662/ Signed-off-by: Omar Ramirez Luna

Re: [PATCH v4 5/5] OMAP: mailbox: use runtime pm for clk and sysc handling

2010-12-16 Thread Kanigeri, Hari
On Thu, Dec 16, 2010 at 11:01 AM, Ramirez Luna, Omar omar.rami...@ti.com wrote: Hi, On Thu, Dec 16, 2010 at 10:32 AM, Kanigeri, Hari h-kanige...@ti.com wrote: @@ -130,12 +120,6 @@ static int omap2_mbox_startup(struct omap_mbox *mbox)        l = mbox_read_reg(MAILBOX_REVISION

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

2010-12-15 Thread Kanigeri, Hari
OMAP: iommu: create new api to set valid da range Kanigeri, Hari (3): OMAP: mailbox: fix checkpatch warnings OMAP: mailbox: send message in process context OMAP: mailbox: add notification support for multiple readers Omar Ramirez Luna (2): OMAP: mailbox: remove unreachable

Re: [PATCHv7 0/4] omap: iovmm - fixes for iovmm module

2010-12-14 Thread Kanigeri, Hari
Fernando, For omap patches, follow the convention OMAP: iommu: subject OMAP: iovmm: subject Ref: http://www.spinics.net/lists/linux-omap/msg39956.html On Tue, Dec 14, 2010 at 6:53 PM, Fernando Guzman Lugo fernando.l...@ti.com wrote: Misc fixes found while working with iovmm module. They are

Re: [GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

2010-12-13 Thread Kanigeri, Hari
On Sun, Dec 12, 2010 at 5:20 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote: Ruseell, On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: On Thu, Dec 2, 2010 at 9:20 AM, Russell King

Re: [PATCH v3 5/5] OMAP: mailbox: add omap_device latency information

2010-12-13 Thread Kanigeri, Hari
-       mbox_ick_handle = clk_get(NULL, mailboxes_ick); -       if (IS_ERR(mbox_ick_handle)) { -               printk(KERN_ERR Could not get mailboxes_ick: %ld\n, -                       PTR_ERR(mbox_ick_handle)); -               return PTR_ERR(mbox_ick_handle); -       } -      

Re: Inconsistent lock state caused by omap_mbox_msg_send() called from tidspbridge

2010-12-13 Thread Kanigeri, Hari
On Mon, Dec 13, 2010 at 2:49 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, Dec 13, 2010 at 6:45 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com On Sun, Dec 12, 2010 at 4:15 PM, Ionut Nicu ionut.n...@mindbit.ro wrote: I noticed this too, but this patch should fix it:

Re: [GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

2010-12-06 Thread Kanigeri, Hari
- ARM Linux li...@arm.linux.org.uk wrote: On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote: Hi Tony, The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:   Linus Torvalds (1):         Linux 2.6.37-rc4 are available in the git repository

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

2010-12-02 Thread Kanigeri, Hari
full flag per mailbox queue instead of global omap: iovmm - no gap checking for fixed address omap: iovmm - add superpages support to fixed da address omap: iovmm - replace __iounmap with omap_iounmap omap: iommu - create new api to set valid da range Kanigeri, Hari (3

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-01 Thread Kanigeri, Hari
On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha ch...@ti.com wrote: David, +               if (!oh) +                       goto error; + +               data-base = oh-_mpu_rt_va; not required. Make use of platform_get APIs in probe to extract the base, dma and irq info using

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-01 Thread Kanigeri, Hari
On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari h-kanige...@ti.com wrote: On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha ch...@ti.com wrote: David, +               if (!oh) +                       goto error; + +               data-base = oh-_mpu_rt_va; not required. Make use

Re: [PATCH v4 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-24 Thread Kanigeri, Hari
On Tue, Nov 23, 2010 at 11:21 PM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 02:56, Hari Kanigeri h-kanige...@ti.com wrote: From: Fernando Guzman Lugo x0095...@ti.com The variable rq_full flag is a global variable, so if there are multiple mailbox users there will be

Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-24 Thread Kanigeri, Hari
On Wed, Nov 24, 2010 at 2:50 AM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 13:52, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 24, 2010 at 10:46:04AM +0530, Varadarajan, Charulatha wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index

Re: [PATCH v4 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-24 Thread Kanigeri, Hari
On Tue, Nov 23, 2010 at 11:29 PM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 02:56, Hari Kanigeri h-kanige...@ti.com wrote: In the current mailbox driver, the mailbox internal pointer for callback can be directly manipulated by the Users, so a second User can easily

Re: [PATCH v4 4/5] OMAP: mailbox: send message in process context

2010-11-24 Thread Kanigeri, Hari
On Tue, Nov 23, 2010 at 11:26 PM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 02:56, Hari Kanigeri h-kanige...@ti.com wrote: Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process

Re: [PATCH v4 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-24 Thread Kanigeri, Hari
On Wed, Nov 24, 2010 at 7:12 AM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 18:39, Kanigeri, Hari h-kanige...@ti.com wrote: On Tue, Nov 23, 2010 at 11:29 PM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 02:56, Hari Kanigeri h-kanige...@ti.com

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-22 Thread Kanigeri, Hari
On Mon, Nov 22, 2010 at 4:08 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 19, 2010 at 03:50:02PM +0100, Cousson, Benoit wrote: Most of the time, we do not want to use the IP revision because it is un-accurate and does not reflect the change we'd like to track. For example some time a

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-22 Thread Kanigeri, Hari
Felipe, On Mon, Nov 22, 2010 at 5:51 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Nov 22, 2010 at 05:46:53AM -0600, Kanigeri, Hari wrote: From the dmtimer stuff, it looks like the driver defines the version types, which hwmod uses to define the rev field. /* timer ip constants

Re: DSP Bridge video decode of above VGA videos

2010-11-22 Thread Kanigeri, Hari
James, On Mon, Nov 22, 2010 at 7:14 AM, James Adams james.r.ad...@gmail.com wrote: Hi All, We are running Android on a custom Gumstix Overo Water platform. We have ported the 25.12 Zoom2 release to do this. It is almost working except that when trying to decode H264 videos with resolution

Re: [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-20 Thread Kanigeri, Hari
Felipe, On Sat, Nov 20, 2010 at 5:31 AM, Felipe Balbi m...@felipebalbi.com wrote: Hi Hari, On Fri, 2010-11-19 at 22:01 -0600, Kanigeri, Hari wrote: Of course :), profiling was done before releasing this code and no difference observed with or without blocking notifier. All the OMAP4 would

Re: [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-19 Thread Kanigeri, Hari
Felipe, On Fri, Nov 19, 2010 at 2:50 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Nov 18, 2010 at 01:15:42PM -0600, Hari Kanigeri wrote: In the current mailbox driver, the mailbox internal pointer for callback can be directly manipulated by the Users, so a second User can easily

Re: [PATCH v3 3/5] OMAP: mailbox: fix checkpatch warnings

2010-11-19 Thread Kanigeri, Hari
Felipe, On Fri, Nov 19, 2010 at 2:33 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Nov 18, 2010 at 01:15:40PM -0600, Hari Kanigeri wrote: Fix the checkpatch warnings observed in mailbox module you should put which warnings are those here :-) Sure, will add some descriptions in next

Re: [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-19 Thread Kanigeri, Hari
Felipe, I think handling of per-message callback should be handled at one level above mailbox, like in IPC modules such as dspbridge, syslink..etc. then you'll have duplication of functionality :-) yes in mailbox :). One solution doesn't fit all and this should be handled at IPC driver.

Re: [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-19 Thread Kanigeri, Hari
Felipe, On Fri, Nov 19, 2010 at 6:53 AM, Felipe Balbi ba...@ti.com wrote: Hi Hari, On Fri, Nov 19, 2010 at 06:29:39AM -0600, Kanigeri, Hari wrote: How do you know that a response is received for a particular sender ? think of it as FIFO. So the first completed message is the first in your

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-19 Thread Kanigeri, Hari
Felipe, On Fri, Nov 19, 2010 at 2:32 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Nov 18, 2010 at 06:07:40PM -0600, Kanigeri, Hari wrote: Benoit, On Thu, Nov 18, 2010 at 5:28 PM, Cousson, Benoit b-cous...@ti.com wrote: On 11/18/2010 8:15 PM, Hari Kanigeri wrote: disabling rx interrupt

Re: [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-19 Thread Kanigeri, Hari
Felipe, On Fri, Nov 19, 2010 at 8:25 AM, Felipe Balbi m...@felipebalbi.com wrote: Hi, (at home already), On Fri, 2010-11-19 at 07:57 -0600, Kanigeri, Hari wrote: think of it as FIFO. So the first completed message is the first in your list of requests. Ain't that easy ? :-) Actually

Re: [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-19 Thread Kanigeri, Hari
Felipe, On Fri, Nov 19, 2010 at 5:07 PM, Felipe Balbi m...@felipebalbi.com wrote: Hi Hari, On Fri, 2010-11-19 at 08:44 -0600, Kanigeri, Hari wrote: Not really :). Please let me know if if I am wrong, what you addressing is getting the confirmation that a message is sent and what I am

Re: [PATCH] OMAP4: clocks: add dummy clock for mailbox

2010-11-18 Thread Kanigeri, Hari
Benoit, OK, that one is easy but... I will still have to update the script to generate it, so: Sure, thank you. Best regards, Hari Kanigeri -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-18 Thread Kanigeri, Hari
Benoit, On Thu, Nov 18, 2010 at 5:28 PM, Cousson, Benoit b-cous...@ti.com wrote: On 11/18/2010 8:15 PM, Hari Kanigeri wrote: disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing

RE: [PATCH 3/3] omap: add hwspinlock device

2010-10-21 Thread Kanigeri, Hari
Mugdha, This does not require any smart IPC and it will allow us to get rid of the omap_hwspinlock_request_specific() API and its early-callers requirement. Yes, that would indeed simplify things. Balaji, Nishant, are you OK with this ? The problem with this approach is

RE: [PATCH 05/11] omap3: Remove non-existent config option

2010-09-27 Thread Kanigeri, Hari
Felipe, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Felipe Contreras Sent: Monday, September 27, 2010 10:56 AM To: Marathe, Yogesh Cc: Premi, Sanjeev; Tony Lindgren; linux-arm-ker...@lists.infradead.org;

RE: Query on clock naming conventions in clockxxxx_data.c

2010-09-24 Thread Kanigeri, Hari
Archit, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Taneja, Archit Sent: Friday, September 24, 2010 7:41 AM To: Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Guruswamy, Senthilvadivu Subject: Query on clock

RE: [RFC v.4] omap: hwspinlock: Added hwspinlock driver

2010-09-22 Thread Kanigeri, Hari
Ohad, Sorry for the late response, was away from linux-omap mailing list last few days. Please see my response. It would probably make more sense to call pm_runtime_get_sync during hwspinlock_request{_specific}, and then call pm_runtime_put during hwspinlock_free. I agree, this looks like

RE: [PATCH 3/4 v2] omap: hwspinlock: Created driver for OMAP hardware spinlock.

2010-09-22 Thread Kanigeri, Hari
Tony, Thanks for your comments. * Que, Simon s...@ti.com [100811 17:22]: Created driver for OMAP hardware spinlock. - Reserved spinlocks for internal use - Dynamic allocation of unreserved locks - Lock, unlock, and trylock functions, with or without disabling irqs/preempt -

RE: [PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread Kanigeri, Hari
Kishore, +int twl6030_mmc_card_detect(struct device *dev, int slot) +{ + int ret = -EIO; + u8 read_reg = 0; + struct platform_device *pdev = to_platform_device(dev); + + switch (pdev-id) { + case 0: + /* + * BIT0 of REG_MMC_CTRL +

RE: [PATCH] omap:iommu-load cam register before flushing the entry

2010-08-20 Thread Kanigeri, Hari
Sergio -Original Message- From: Aguirre, Sergio Sent: Friday, August 20, 2010 5:09 PM To: Kanigeri, Hari; Hiroshi Doyu; Linux omap Subject: RE: [PATCH] omap:iommu-load cam register before flushing the entry Hi Hari, -Original Message- From: linux-omap-ow

RE: [RFC v.4] omap: hwspinlock: Added hwspinlock driver

2010-08-11 Thread Kanigeri, Hari
Partha and Benoit, +/* Attempt to acquire a spinlock once */ +int hwspinlock_trylock(struct hwspinlock *handle) +{ + int retval = 0; + + if (WARN_ON(handle == NULL)) + return -EINVAL; + + if (WARN_ON(in_irq())) + return -EPERM; +

RE: [PATCH] omap3: Remove non-existent config option

2010-08-05 Thread Kanigeri, Hari
Hiroshi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Hiroshi DOYU Sent: Wednesday, August 04, 2010 6:20 AM To: t...@atomide.com Cc: Marathe, Yogesh; linux-omap@vger.kernel.org; Premi, Sanjeev Subject: Re:

RE: [PATCH 3/5] omap:hwspinlock-added hwspinlock driver

2010-08-01 Thread Kanigeri, Hari
Thank you, Best regards, Hari -Original Message- From: Marathe, Yogesh Sent: Friday, July 30, 2010 1:53 AM To: Kanigeri, Hari; Premi, Sanjeev; Linux Omap; Tony Lindgren Cc: Shilimkar, Santosh; Cousson, Benoit; Que, Simon Subject: RE: [PATCH 3/5] omap:hwspinlock-added hwspinlock

RE: [PATCH 3/5] omap:hwspinlock-added hwspinlock driver

2010-07-29 Thread Kanigeri, Hari
Yogesh, Nice to see your email. +/* Release a spinlock */ +int hwspinlock_unlock(struct hwspinlock *handle) +{ + if (WARN_ON(handle == NULL)) + return -EINVAL; + + /* Release it by writing 0 to it */ + writel(0, handle-lock_reg); [[Yogesh

RE: [PATCH 3/5] omap:hwspinlock-added hwspinlock driver

2010-07-29 Thread Kanigeri, Hari
Sanjeev, Thanks for your comments. -Original Message- From: Premi, Sanjeev Sent: Wednesday, July 28, 2010 11:58 AM To: Kanigeri, Hari; Linux Omap; Tony Lindgren Cc: Shilimkar, Santosh; Cousson, Benoit; Que, Simon Subject: RE: [PATCH 3/5] omap:hwspinlock-added hwspinlock driver

RE: [PATCH 2/5] omap:hwspinlock-define HWSPINLOCK base address

2010-07-28 Thread Kanigeri, Hari
Sanjeev, -Original Message- From: Premi, Sanjeev Sent: Wednesday, July 28, 2010 9:12 AM To: Kanigeri, Hari; Linux Omap; Tony Lindgren Cc: Shilimkar, Santosh; Cousson, Benoit; Que, Simon Subject: RE: [PATCH 2/5] omap:hwspinlock-define HWSPINLOCK base address -Original

RE: [PATCH 2/5] omap:hwspinlock-define HWSPINLOCK base address

2010-07-28 Thread Kanigeri, Hari
Sanjeev, @@ -49,5 +49,10 @@ #define OMAP44XX_MAILBOX_BASE (L4_44XX_BASE + 0xF4000) #define OMAP44XX_HSUSB_OTG_BASE (L4_44XX_BASE + 0xAB000) +#define OMAP4_MMU1_BASE0x55082000 +#define OMAP4_MMU2_BASE

RE: [PATCH 5/5] omap:hwspinlocks-ensure the order of registration

2010-07-28 Thread Kanigeri, Hari
Sanjeev, Thanks for your comments. -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kanigeri, Hari Sent: Monday, July 19, 2010 10:20 PM To: Linux Omap; Tony Lindgren Cc: Shilimkar, Santosh; Cousson, Benoit; Que

RE: [PATCH 2/5] omap:hwspinlock-define HWSPINLOCK base address

2010-07-27 Thread Kanigeri, Hari
Sanjeev, @@ -49,5 +49,10 @@ #define OMAP44XX_MAILBOX_BASE (L4_44XX_BASE + 0xF4000) #define OMAP44XX_HSUSB_OTG_BASE(L4_44XX_BASE + 0xAB000) +#define OMAP4_MMU1_BASE0x55082000 +#define OMAP4_MMU2_BASE0x4A066000 [sp]

RE: [PATCH 3/5] omap:hwspinlock-added hwspinlock driver

2010-07-26 Thread Kanigeri, Hari
Benoit and Santosh, Thanks for your comments. I will get back after reviewing your comments. Thank you, Best regards, Hari -Original Message- From: Cousson, Benoit Sent: Saturday, July 24, 2010 11:44 AM To: Kanigeri, Hari Cc: Linux Omap; Tony Lindgren; Shilimkar, Santosh; Que

RE: [PATCH 0/5] omap:hwspinlock support-omap4

2010-07-20 Thread Kanigeri, Hari
Santosh, Hari Kanigeri (1): omap:hwspinlocks-ensure the order of registration Simon Que (4): omap:hwmod-hwspinlock-enable omap:hwspinlock-define HWSPINLOCK base address I think you should fold patch 1/5 , 2/5 into patch 3/5. At least patch 2/5 o.w git-bisect will break Can

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-07-02 Thread Kanigeri, Hari
Fernando, -Original Message- From: Guzman Lugo, Fernando Sent: Friday, July 02, 2010 11:27 AM To: Kanigeri, Hari; linux-omap@vger.kernel.org; linux- ker...@vger.kernel.org Cc: o...@wizery.com; hiroshi.d...@nokia.com; ameya.pala...@nokia.com; felipe.contre...@nokia.com Subject: RE

RE: [PATCHv3 5/9] dspbridge: add mmufault support

2010-07-01 Thread Kanigeri, Hari
Hi Fernando, +int mmu_fault_isr(struct iommu *mmu) -/* - * mmu_check_if_fault === - * Check to see if MMU Fault is valid TLB miss from DSP - * Note: This function is called from an ISR - */ -static bool mmu_check_if_fault(struct bridge_dev_context *dev_context) { +

RE: [PATCHv3 5/9] dspbridge: add mmufault support

2010-07-01 Thread Kanigeri, Hari
+ da = iommu_read_reg(mmu, MMU_FAULT_AD); + iommu_write_reg(mmu, 0, MMU_IRQENABLE); -- Isn't the MMU already enabled at this point when the function callback is called by iommu ? This line is actually disabling the interrupts. I am writing 0x0 in the MMU_IRQENABLE. -- oops !

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-07-01 Thread Kanigeri, Hari
Fernando, - for_each_sg(sgt-sgl, sg, sgt-nents, i) - sg_set_page(sg, usr_pgs[i], PAGE_SIZE, 0); + da = iommu_vmap(mmu, da, sgt, IOVMF_ENDIAN_LITTLE | + IOVMF_ELSZ_32); -- iommu_vmap does the Kernel mapping to the

RE: [PATCH 22/33] Removing dead MPU_{BRIDGE,TESLA}_IOMMU

2010-06-30 Thread Kanigeri, Hari
-Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Wednesday, June 30, 2010 1:24 PM To: sicce...@cs.fau.de; Kanigeri, Hari Cc: t...@atomide.com; li...@arm.linux.org.uk; linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-ker

RE: [PATCH 1/4] omap mailbox: extend API to take a callback param

2010-06-24 Thread Kanigeri, Hari
Looks good. Iommu get has similar signature, probably we could change that too to take the mmu fault notification function as a function argument. Thank you, Best regards, Hari -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On

RE: [PATCH 3/4] omap mailbox: remove mbox_configured scheme

2010-06-24 Thread Kanigeri, Hari
Ohad, mbox_configured is global and therefore does not support concurrent usage of multiple mailbox instances. -- Why do you say that it doesn't support concurrent usage of multiple mailbox instances ? If you take example of OMAP4, we have 2 mailbox instances, one talking to DSP and other to

RE: [PATCH 1/4] omap mailbox: extend API to take a callback param

2010-06-24 Thread Kanigeri, Hari
Ohad, On Thu, Jun 24, 2010 at 6:02 PM, Kanigeri, Hari h-kanige...@ti.com wrote: Looks good. PCMIIW: from your other mail, I now understand that on OMAP4 you call omap_mbox_get several times to allow several concurrent mbox senders. I don't know what PCMIIW stands for :). omap_mbox_get

RE: [PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

2010-05-20 Thread Kanigeri, Hari
Hi Kevin -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, May 20, 2010 12:13 PM To: Kanigeri, Hari Cc: Paul Walmsley; Linux Omap Subject: Re: [PATCH] omap:hwmod-remove prm header from prm-regbits- headers Hari Kanigeri h-kanige

RE: [PATCH 2/2] omap: iommu-add functionality to get TLB miss interrupt

2010-05-19 Thread Kanigeri, Hari
Hi Hiroshi, -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Wednesday, May 19, 2010 4:28 AM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; t...@atomide.com; Gupta, Ramesh Subject: Re: [PATCH 2/2] omap: iommu-add functionality to get TLB miss

omap: hwmod questions

2010-05-19 Thread Kanigeri, Hari
Hi, I have few questions regarding hwmod usage. Can any one please respond to this. 1. I see omap_device_build function doing the platform_device_register, but I didn't find the equivalent function that does platform_device_unregister. Is this expected? 2. What is the purpose of

RE: [PATCH 1/2] omap: iommu-update irq mask to be specific about twl

2010-05-18 Thread Kanigeri, Hari
Hi Hiroshi, -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Tuesday, May 18, 2010 1:12 AM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; t...@atomide.com Subject: Re: [PATCH 1/2] omap: iommu-update irq mask to be specific about twl Update the irq

RE: [PATCH 2/2] omap: iommu-add functionality to get TLB miss interrupt

2010-05-18 Thread Kanigeri, Hari
Hi Hiroshi, -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Tuesday, May 18, 2010 1:12 AM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; t...@atomide.com; Gupta, Ramesh Subject: Re: [PATCH 2/2] omap: iommu-add functionality to get TLB miss interrupt

RE: [PATCH v2 08/17] omap: mailbox: only compile for configured archs

2010-05-14 Thread Kanigeri, Hari
- if (cpu_is_omap3430()) { + if (false); -- Is this statement needed ? +#if defined(CONFIG_ARCH_OMAP3430) + else if (cpu_is_omap3430()) { list = omap3_mboxes; list[0]-irq = res[1].start; Thank you, Best regards, Hari -- To unsubscribe

RE: [PATCHv2] DSPBRIDGE: Include missing info in MMU Fault debugging trace

2010-05-13 Thread Kanigeri, Hari
Ernesto @@ -2136,6 +2138,7 @@ dsp_status dump_dsp_stack(struct bridge_dev_context *bridge_context) total_size = MAX_MMU_DBGBUFF; buffer = kzalloc(total_size, GFP_ATOMIC); + buffer_beg = buffer; buffer_end = buffer + total_size

RE: [PATCH 1/5] omap iommu: Reject unaligned physical address at setting page table entry

2010-05-07 Thread Kanigeri, Hari
Hiroshi, From: Hiroshi DOYU hiroshi.d...@nokia.com This rejects unaligned physical address at setting page table entry and informs error to caller. Otherwise, a wrong address may be used by IO device. Signed-off-by: Hiroshi DOYU hiroshi.d...@nokia.com ---

RE: [RFC/PATCH 6/8] omap: mailbox: more more stuff to omap2_mbox_init

2010-05-03 Thread Kanigeri, Hari
Felipe, Small suggestion...if we are re-organizing can we make it look similar to how iommu is structured? This way we can maintain consistency. Thank you, Best regards, Hari -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On

RE: [RFC/PATCH 6/8] omap: mailbox: more more stuff to omap2_mbox_init

2010-05-03 Thread Kanigeri, Hari
: Felipe Contreras [mailto:felipe.contre...@gmail.com] Sent: Monday, May 03, 2010 10:09 AM To: Kanigeri, Hari Cc: linux-omap; Tony Lindgren; Hiroshi Doyu; Ohad Ben-Cohen Subject: Re: [RFC/PATCH 6/8] omap: mailbox: more more stuff to omap2_mbox_init On Mon, May 3, 2010 at 4:42 PM, Kanigeri

RE: [Query][omap iommu] Consulting iommu if a physical region is mappable before actually mapping it

2010-05-03 Thread Kanigeri, Hari
Sergio, Can the iommu driver be consulted if a certain area (contiguous or not) can be mapped or not, before even trying to do it? -- As long as there are physical pages backing the area it should be mappable right ? Thank you, Best regards, Hari -- To unsubscribe from this list: send

RE: [PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock

2010-04-30 Thread Kanigeri, Hari
To: linux-omap@vger.kernel.org Cc: Kanigeri, Hari; Hiroshi Doyu; Ohad Ben-Cohen Subject: [PATCH 1/4] omap: mailbox cleanup: convert rwlocks to spinlock rwlocks are slower and have potential starvation issues so spinlocks are generally preferred Signed-off-by: Ohad Ben-Cohen o...@wizery.com

RE: [PATCH] ARM:iommu support for OMAP4

2010-04-27 Thread Kanigeri, Hari
Hi, -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Monday, April 19, 2010 1:50 AM To: Kanigeri, Hari; p...@pwsan.com; khil...@deeprootsystems.com Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh; t...@atomide.com Subject: Re: [PATCH] ARM:iommu support

RE: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support

2010-04-26 Thread Kanigeri, Hari
Hi Hiroshi, -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Saturday, April 24, 2010 1:45 AM To: Kanigeri, Hari Cc: Gupta, Ramesh; linux-omap@vger.kernel.org Subject: Re: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support From: ext Kanigeri

RE: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support

2010-04-23 Thread Kanigeri, Hari
Hi Hiroshi, -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Friday, April 23, 2010 7:34 AM To: Kanigeri, Hari Cc: Gupta, Ramesh; linux-omap@vger.kernel.org Subject: Re: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support Hi Hari, From: ext Hari

RE: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support

2010-04-23 Thread Kanigeri, Hari
Hi Hiroshi, diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c index 1e83fac..d09a0a1 100644 --- a/arch/arm/plat-omap/iommu.c +++ b/arch/arm/plat-omap/iommu.c @@ -25,6 +25,9 @@ #include iopgtable.h +#define for_each_iotlb_cr(obj, n, i, cr)

RE: [PATCH 2/4][v3] OMAP:iommu support for OMAP4

2010-04-21 Thread Kanigeri, Hari
Tony, -Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Wednesday, April 21, 2010 5:05 PM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh; Felipe Contreras; Hiroshi DOYU Subject: Re: [PATCH 2/4][v3] OMAP:iommu support for OMAP4

RE: [PATCH 4/4][v3] OMAP:iommu- add TLB preservation support

2010-04-21 Thread Kanigeri, Hari
Hi Hiroshi, @@ -241,6 +238,11 @@ int load_iotlb_entry(struct iommu *obj, struct iotlb_entry *e) break; } + if (l.base == obj-nr_tlb_entries) { + dev_dbg(obj-dev, %s: preserve entries full\n, __func__); + err = -EBUSY; I am afraid

[PATCH 0/3][V2] OMAP: IOMMU patches to support OMAP4 and TLB preservation support

2010-04-20 Thread Kanigeri, Hari
Following are the revised patches addressing the comments from Santosh, Felipe, and Hiroshi. The detailed changed list is: Hari Kanigeri(3): OMAP:iommu support for OMAP4 OMAP:iommu - missing check for TLB valid entry OMAP:iommu- add TLB preservation support

[PATCH 1/3][v2] OMAP:iommu support for OMAP4

2010-04-20 Thread Kanigeri, Hari
From 9a6f91b0c108fd010afdb6bddcae92579c87fcbd Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Tue, 20 Apr 2010 12:03:03 -0500 Subject: [PATCH 1/3] OMAP:iommu support for OMAP4 This patch provides the iommu support for OMAP4 co-processors. This includes changes to

[PATCH 3/3][v2] OMAP:iommu- add TLB preservation support

2010-04-20 Thread Kanigeri, Hari
From 2cecc5abd54c7a139495d135260a6a66810318e8 Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Tue, 20 Apr 2010 12:11:16 -0500 Subject: [PATCH 3/3] OMAP:iommu- add TLB preservation support This patch adds TLB preservation support to IOMMU module Signed-off-by: Hari Kanigeri

RE: [PATCH 1/3][v2] OMAP:iommu support for OMAP4

2010-04-20 Thread Kanigeri, Hari
Felipe, -Original Message- From: Felipe Contreras [mailto:felipe.contre...@gmail.com] Sent: Tuesday, April 20, 2010 4:49 PM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh; Hiroshi DOYU; t...@atomide.com Subject: Re: [PATCH 1/3][v2] OMAP:iommu support

RE: [PATCH 1/3][v2] OMAP:iommu support for OMAP4

2010-04-20 Thread Kanigeri, Hari
Felipe, -Original Message- From: Felipe Contreras [mailto:felipe.contre...@gmail.com] Sent: Tuesday, April 20, 2010 4:49 PM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh; Hiroshi DOYU; t...@atomide.com Subject: Re: [PATCH 1/3][v2] OMAP:iommu support

[PATCH 0/4][V3] OMAP: IOMMU patches to support OMAP4 and TLB preservation support

2010-04-20 Thread Kanigeri, Hari
Following are the revised patches addressing the comments from Santosh, Felipe, and Hiroshi. The detailed changed list is: Hari Kanigeri (4) OMAP:iommu renamed omap3-iommu to omap-iommu OMAP:iommu support for OMAP4 OMAP:iommu - missing check for TLB valid entry

[PATCH 1/4] [v3]OMAP:iommu renamed omap3-iommu to omap-iommu

2010-04-20 Thread Kanigeri, Hari
From ea10f0d6550d521ff575e0ea03d5ca4fc258b80e Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Tue, 20 Apr 2010 17:30:09 -0500 Subject: [PATCH 1/4] OMAP:iommu renamed omap3-iommu to omap-iommu This patch includes changes to omap3-iommu.c file to make it generic for all OMAPs.

[PATCH 2/4][v3] OMAP:iommu support for OMAP4

2010-04-20 Thread Kanigeri, Hari
From 9a2bcae7a2de6890884c23c45563eece1e6838de Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Tue, 20 Apr 2010 17:39:18 -0500 Subject: [PATCH 2/4] OMAP:iommu support for OMAP4 This patch provides the iommu support for OMAP4 co-processors. Signed-off-by: Hari Kanigeri

[PATCH 3/4][v3] OMAP:iommu - missing check for TLB valid entry

2010-04-20 Thread Kanigeri, Hari
From 76471c57074ff5a816ad590aca64e3958ed487fa Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Tue, 20 Apr 2010 12:08:26 -0500 Subject: [PATCH 3/4] OMAP:iommu - missing check for TLB valid entry Added the missing TLB valid entry setting for cam register Signed-off-by: Hari

RE: [PATCH 03/13] DSPBRIDGE: Moving functions from mem.c to drv.c

2010-04-16 Thread Kanigeri, Hari
Ivan, In the commit 702b94bff3c50542a6e4ab9a4f4cef093262fe65 (2.6.34) the functions dmac_inv_range and dmac_clean_range were removed. I'm wondering how to fix this in order to rebase to 2.6.34. Thanks 2 options: 1. Replace dmac_inv_range and dmac_clean_range functions with the new dma

[PATCH] ARM:iommu support for OMAP4

2010-04-16 Thread Kanigeri, Hari
From 708914e1a82a608d423b050cb31b4deb46eb8411 Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Mon, 8 Mar 2010 17:55:21 -0600 Subject: [PATCH] ARM:iommu support for OMAP4 This patch provides the iommu support for OMAP4 co-processors. Signed-off-by: Hari Kanigeri

[PATCH] ARM: OMAP add TLB preservation support to IOMMU

2010-04-16 Thread Kanigeri, Hari
From bcdd232666a163d2661d704f9c21d055bacfd178 Mon Sep 17 00:00:00 2001 From: Hari Kanigeri h-kanige...@ti.com Date: Mon, 8 Mar 2010 18:00:36 -0600 Subject: [PATCH] ARM: OMAP add TLB preservation support to IOMMU This patch adds TLB preservation support to IOMMU module Signed-off-by: Hari

RE: PATCH] OMAP3: add mailbox initialization for 3630

2010-03-25 Thread Kanigeri, Hari
Fernando, + if (cpu_is_omap2420() || cpu_is_omap3430() || + cpu_is_omap3630() || cpu_is_omap44xx()) looks like this check is applied to all OMAPS. Can we just remove this check ? Thank you, Best regards, Hari -- To unsubscribe from this list: send the line

RE: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB

2010-01-08 Thread Kanigeri, Hari
, Fernando; Ramos Falcon, Ernesto; Kanigeri, Hari; Aguilar Pena, Leed Subject: Re: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB On Fri, Jan 08, 2010 at 02:00:35AM +0100, Omar Ramirez Luna wrote: From: Hari Kanigeri h-kanige...@ti.com This patch increases the DMM from 64MB to 256MB

RE: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB

2010-01-08 Thread Kanigeri, Hari
Sent: Friday, January 08, 2010 8:28 AM To: Kanigeri, Hari Cc: Ramirez Luna, Omar; linux-omap; Hiroshi Doyu; Ameya Palande; Felipe Contreras; Guzman Lugo, Fernando; Ramos Falcon, Ernesto; Aguilar Pena, Leed Subject: Re: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB Kanigeri, Hari had

RE: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB

2010-01-07 Thread Kanigeri, Hari
: linux-omap; Hiroshi Doyu; Ameya Palande; Felipe Contreras; Guzman Lugo, Fernando; Ramos Falcon, Ernesto; Kanigeri, Hari; Aguilar Pena, Leed Subject: Re: [PATCH 3/8] DSPBRIDGE: Increased DMM size to 256MB Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following: From: Hari Kanigeri h

RE: [DSPBRIDGE RFC] Combining Reserve and Map into a new IOCTL

2009-09-02 Thread Kanigeri, Hari
The initial idea behind DSPProcessor_ReserveMemory call was to provide the User's the option of doing DSP buffer management for a pool of memory by themselves. So, call Reserve one time, and do map/unmap multiple times within that region, and call Unreserve only once you are done using the

RE: [PATCH v1 1/3] ARM:OMAP4 iommu:changes in iommu for OMAP4

2009-08-05 Thread Kanigeri, Hari
Russell, Tony, Santosh, Russell / Tony, -Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Wednesday, August 05, 2009 12:50 PM To: Russell King - ARM Linux Cc: Kanigeri, Hari; linux-omap@vger.kernel.org; Hiroshi DOYU; Shilimkar, Santosh Subject: Re

RE: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu

2009-08-05 Thread Kanigeri, Hari
Hi Russell and Hiroshi, Thanks for your comments. Please see my below comments. -Original Message- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Tuesday, August 04, 2009 11:36 PM To: Kanigeri, Hari Cc: linux-omap@vger.kernel.org; t...@atomide.com; li...@arm.linux.org.uk

[PATCH v1 0/3] ARM:OMAP4 iommu-provide support for OMAP4

2009-08-04 Thread Kanigeri, Hari
Hi, Please find the revised set of patches based on the comments received on initial patch set. Reference: http://marc.info/?l=linux-omapm=124845609532585w=2 This patch set fixes the following issues in the original patch set. - Use if

[PATCH v1 1/3] ARM:OMAP4 iommu:changes in iommu for OMAP4

2009-08-04 Thread Kanigeri, Hari
This patch has the changes to iommu module to make iommu functional on OMAP4 simulator. The changes included using stubbed clock interface and commenting out reading the MMU soft reset register. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/iommu2.c |8 +---

[PATCH v1 2/3] ARM:OMAP4 iommu:add omap4 support in iommu

2009-08-04 Thread Kanigeri, Hari
This patch adds omap4 support in iommu module. This creates OMAP4 platform specific file for iommu and defines the Ducati MMU fault interrupt. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/omap4-iommu.c | 110

[PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu

2009-08-04 Thread Kanigeri, Hari
This patch provides build support to build OMAP4 IOMMU module. This also adds the changes to Kconfig file to make iommu option visible in menuconfig. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/Makefile |2 +- arch/arm/plat-omap/Kconfig |7 +-- 2 files

RE: [RFC][PATCH 2/3] ARM:OMAP4 iommu:add omap4 support in iommu

2009-07-28 Thread Kanigeri, Hari
- From: Hiroshi DOYU [mailto:hiroshi.d...@nokia.com] Sent: Monday, July 27, 2009 1:48 AM To: Kanigeri, Hari Cc: t...@atomide.com; linux-omap@vger.kernel.org; Gupta, Ramesh; r...@arm.linux.org.uk; Pasam, Vijay Subject: Re: [RFC][PATCH 2/3] ARM:OMAP4 iommu:add omap4 support in iommu From: ext

RE: [RFC][PATCH 2/3] ARM:OMAP4 iommu:add omap4 support in iommu

2009-07-26 Thread Kanigeri, Hari
will include this change in my revised patch. Thank you, Best regards, Hari -Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Friday, July 24, 2009 1:27 PM To: Kanigeri, Hari Cc: t...@atomide.com; Doyu Hiroshi (Nokia-D/Helsinki); linux- o...@vger.kernel.org; Gupta

  1   2   >