Re: [PATCH v2] perf: Use pre-empt safe cpu_get/put insted of smp_processor_id

2012-09-10 Thread Kevin Hilman
Roger Quadros rog...@ti.com writes: gets rid of below messages with CONFIG_DEBUG_PREEMPT enabled [ 28.832916] debug_smp_processor_id: 18 callbacks suppressed [ 28.832946] BUG: using smp_processor_id() in preemptible [] code: modprobe/1763 [ 28.841491] caller is

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-10 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: On Sat, Sep 8, 2012 at 3:07 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Neil, NeilBrown ne...@suse.de writes: On Thu, 6 Sep 2012 11:18:09 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Thu, Sep 6, 2012 at 8:35

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-10 Thread Kevin Hilman
that we have separate flags for GPIO should wake from deep idle and GPIO should wake from suspend. With this patch, the GPIO from my touch screen doesn't wake my device any more, which is what I want. Cc: Kevin Hilman khil...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Santosh Shilimkar

Re: [PATCH v4 00/21] OMAP UART Patches

2012-09-07 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Thu, Sep 06, 2012 at 03:44:13PM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Hi guys, here's v4 of the omap uart patchset. No changes other than a rebase on top of Greg's tty-next branch and Tony's Acked-by being added

Re: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-07 Thread Kevin Hilman
AnilKumar, Chimata anilku...@ti.com writes: Hi Kevin, On Fri, Sep 07, 2012 at 05:07:56, Kevin Hilman wrote: AnilKumar Ch anilku...@ti.com writes: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-07 Thread Kevin Hilman
suspend wakeups. However, I have a few questions/doubts below... Cc: Kevin Hilman khil...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Cousson Benoit b-cous...@ti.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Tarun Kanti DebBarma tarun.ka

Re: [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting

2012-09-07 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: On Mon, 2012-08-06 at 12:14 +0200, Jean Pihet wrote: Hi Tero, On Mon, Jul 30, 2012 at 10:40 AM, Tero Kristo t-kri...@ti.com wrote: On Fri, 2012-07-27 at 12:36 -0700, Kevin Hilman wrote: Tero Kristo t-kri...@ti.com writes: mpu / core powerdomain

Re: [PATCH] perf: Use pre-empt safe cpu_get/put insted of smp_processor_id

2012-09-07 Thread Kevin Hilman
Roger Quadros rog...@ti.com writes: Hi Jean, My bad, I didn't follow up with this. My guess is that it has not been picked up. Tony, Kevin? Wasn't picked up by me (but should've been, sorry.) Care to refresh against v3.6-rc4 and resend? Thanks, Kevin On 09/06/2012 09:59 PM, Jean

Re: [PATCHv2 1/2] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-09-07 Thread Kevin Hilman
Venkatraman S svenk...@ti.com writes: omap hsmmc controller IP has a built in timer that can be programmed to guard against unresponsive operations. But its range is very narrow, and the maximum countable time is a few seconds. Card maintenance operations like BKOPS and MMC_ERASE and long

Re: [PATCH v2] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

2012-09-07 Thread Kevin Hilman
. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Kevin Hilman khil...@ti.com Tony, can you pick this one up for fixes? Thanks, Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v2] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()

2012-09-07 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@deeprootsystems.com [120907 15:07]: Wei Yongjun weiyj...@gmail.com writes: From: Wei Yongjun yongjun_...@trendmicro.com.cn pdata and pdata-regs have been allocated in this function and should be freed before leaving

Re: [PATCH v4 20/21] serial: omap: move uart_omap_port definition to C file

2012-09-06 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: nobody needs to access the uart_omap_port structure other than omap-serial.c file. Let's move that structure definition to the C source file in order to prevent anyone from accessing our structure. Tested-by: Shubhrajyoti D shubhrajy...@ti.com Acked-by:

Re: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-06 Thread Kevin Hilman
AnilKumar Ch anilku...@ti.com writes: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned off. Signed-off-by: AnilKumar Ch anilku...@ti.com I'm not familar with the

Re: debug needed: twl4030 RTC wakeups: repeated attempts fail on Beagle

2012-08-13 Thread Kevin Hilman
NeilBrown ne...@suse.de writes: On Fri, 10 Aug 2012 11:49:27 -0700 Kevin Hilman khil...@ti.com wrote: Hello, In doing some automated testing of suspend/resume I noticed that repeated attempts to suspend and resume via RTC wakeup fail on 3530/Beagle and 3730/Beagle-xM, but work fine

[GIT PULL] ARM: OMAP: PM fixes for v3.6-rc

2012-08-10 Thread Kevin Hilman
: OMAP4: Register the OPP table only for 4430 device (2012-08-09 08:07:54 -0700) Kevin Hilman (2): ARM: OMAP3: TWL4030: ensure sys_nirq1 is mux'd and wakeup enabled Revert ARM: OMAP3: PM: call pre/post transition per

[PATCH v2 0/3] ARM: OMAP: omap_device: track driver bound status

2012-08-10 Thread Kevin Hilman
, the omap_device layer implements PM domains for all omap_devices, and knowing whether or not a driver is bound is needed to know whether or not a drivers callbacks are valid, especially in cases of failed driver probe. Kevin Hilman (3): ARM: OMAP: omap_device: keep track of driver bound status

[PATCH v2 2/3] ARM: OMAP: omap_device: don't attempt late suspend if no driver bound

2012-08-10 Thread Kevin Hilman
Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/omap_device.c |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c index 1d1b5ff..150112e 100644 --- a/arch/arm/plat-omap/omap_device.c

[PATCH v2 1/3] ARM: OMAP: omap_device: keep track of driver bound status

2012-08-10 Thread Kevin Hilman
Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/include/plat/omap_device.h |2 ++ arch/arm/plat-omap/omap_device.c | 14 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/arch/arm/plat-omap/include/plat

debug needed: twl4030 RTC wakeups: repeated attempts fail on Beagle

2012-08-10 Thread Kevin Hilman
Hello, In doing some automated testing of suspend/resume I noticed that repeated attempts to suspend and resume via RTC wakeup fail on 3530/Beagle and 3730/Beagle-xM, but work fine on 3430/n900, 3530/Overo, 3730/OveroSTORM and 4430/Panda. When RTC wakeup fails, a UART wakeup will work, and in

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-09 Thread Kevin Hilman
DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Wed, Aug 8, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: Add *remove* callback so that necessary cleanup operations are performed when device is unregistered. The device is deleted

Re: [PATCH v2 1/2] cpufreq: OMAP: Handle missing frequency table on SMP systems

2012-08-09 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Thursday, August 09, 2012, Rajendra Nayak wrote: On OMAP4, if the first CPU fails to get a valid frequency table (this could happen if the platform does not register any OPP table), the subsequent CPU instances end up dealing with a NULL freq_table

Re: [PATCH 2/2] ARM: OMAP4: Register the OPP table only for 4430 device

2012-08-09 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: Hi Kevin, On Wednesday 08 August 2012 10:48 PM, Kevin Hilman wrote: The 4430 OPP table was being registered for all other OMAP4 variants too, like 4460 and 4470 causing issues with cpufreq driver enabled. 4460 and 4470 devices have different OPPs

Re: [PATCH v2 1/2] cpufreq: OMAP: Handle missing frequency table on SMP systems

2012-08-09 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Thursday, August 09, 2012, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Thursday, August 09, 2012, Rajendra Nayak wrote: On OMAP4, if the first CPU fails to get a valid frequency table (this could happen if the platform does

Re: [PATCH v2] Revert ARM: OMAP3: PM: call pre/post transition per powerdomain

2012-08-08 Thread Kevin Hilman
Grazvydas Ignotas nota...@gmail.com writes: On Wed, Aug 8, 2012 at 1:47 AM, Kevin Hilman khil...@ti.com wrote: This reverts commit 58f0829b7186150318c79515f0e0850c5e7a9c89. Converstion to per-pwrdm per/post transition calls was a bit premature. Only tracking MPU, PER CORE in the idle path

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-08 Thread Kevin Hilman
the irq_free_desc() api. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Reported-by: Paul Walmsley p...@pwsan.com Reviewed-by: Jon Hunter jon-hun...@ti.com Cc: Kevin Hilman khil...@ti.com Cc: Rajendra Nayak rna...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Cousson, Benoit b

Re: [PATCH] ARM: OMAP4: sleep: Save the complete used register stack frame

2012-08-08 Thread Kevin Hilman
it will lead to corrupted stack frame. Fix it by saving used registers. Reported-by: Grygorii Strashko grygorii.stras...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com Cc: Kevin Hilman khil...@ti.com Please add a brief comment in the code as well explaining why the additional

Re: [PATCH 2/2] ARM: OMAP4: Register the OPP table only for 4430 device

2012-08-08 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: The 4430 OPP table was being registered for all other OMAP4 variants too, like 4460 and 4470 causing issues with cpufreq driver enabled. 4460 and 4470 devices have different OPPs as compared to 4430, and they should be populated seperately. As long as that

Re: [PATCH 1/2] cpufreq: OMAP: Handle missing frequency table on SMP systems

2012-08-08 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: On Wed, Aug 8, 2012 at 4:24 PM, Rajendra Nayak rna...@ti.com wrote: On OMAP4, if the first CPU fails to get a valid frequency table (this could happen if the platform does not register any OPP table), the subsequent CPU instances end up

Re: [PATCH] ARM: OMAP2+: Fix dmtimer set source clock failure

2012-08-07 Thread Kevin Hilman
the timer. Note that this will not be seen on OMAP1 devices, because these devices do not use the clock framework for dmtimers. Signed-off-by: Jon Hunter jon-hun...@ti.com Acked-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/dmtimer.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH] Revert ARM: OMAP3: PM: call pre/post transition per powerdomain

2012-08-07 Thread Kevin Hilman
in the idle path. Cc: Jean Pihet jean.pi...@newoldbits.com Cc: Tero Kristo t-kri...@ti.com Cc: Rajendra Nayak rna...@ti.com Reported-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2/pm34xx.c | 19 --- 1 file changed, 4 insertions

Re: DSS and USBHOST powerdomains not entering low-power states on 37xx EVM

2012-08-07 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin, On Mon, 6 Aug 2012, Kevin Hilman wrote: Is this only happening on this 37xx platform?Just curious, because it seems to be a problem on any OMAP3xxx SoC. So far I've only run the baseline tests on 37xx, so wanted to state only what

Re: nfsroot problems with v3.6-rc1 on 37xx EVM and dynamic off-mode

2012-08-07 Thread Kevin Hilman
Hi Paul, Paul Walmsley p...@pwsan.com writes: NFS is broken on 37xx EVM with v3.6-rc1 after return from off-mode with dynamic idle. System suspend (echo mem /sys/power/state) with off-mode enabled seems to work fine. No obvious ideas here as to what could have broken this. It worked in

Re: [PATCH 1/3] ARM: OMAP: omap_device: keep track of driver bound status

2012-08-07 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin a couple of minor comments On Tue, 10 Jul 2012, Kevin Hilman wrote: Use the bus notifier to keep track of driver bound status by adding a new internal field to struct omap_device: _driver_staus. _driver_status This will be useful

Re: [PATCH] Revert ARM: OMAP3: PM: call pre/post transition per powerdomain

2012-08-07 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: This reverts commit 58f0829b7186150318c79515f0e0850c5e7a9c89. Converstion to per-pwrdm per/post transition calls was a bit premature. Only tracking MPU, PER CORE in the idle path means we lose the accounting for all the other powerdomains which may also

[PATCH v2] Revert ARM: OMAP3: PM: call pre/post transition per powerdomain

2012-08-07 Thread Kevin Hilman
: Rajendra Nayak rna...@ti.com Reported-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2/pm34xx.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c

Re: OMAP3: USB: EHCI broken on 3.5?

2012-08-06 Thread Kevin Hilman
Hi Joe, Joe Woodward j...@terrafix.co.uk writes: I have a GUMSTIX Overo AirSTORM (AM3703-based). When running a 3.4 kernel the USB host works just fine! However when switching to 3.5 I get a few new warning messages and USB host no longer works. As usual, thanks for the bug/problem

Re: [PATCH] Revert ARM: OMAP3530evm: set pendown_state and debounce time for ads7846

2012-08-06 Thread Kevin Hilman
a slightly different problem/bug, I think the gpio_free() in common-board-devices.c should still be unconditonal since the gpio_request() is now unconditional. That can be a separate patch though. Acked-by: Kevin Hilman khil...@ti.com Tested-by: Kevin Hilman khil...@ti.com Tested on 3430/n900, 3530/Overo

Re: DSS and USBHOST powerdomains not entering low-power states on 37xx EVM

2012-08-06 Thread Kevin Hilman
Hi Paul, Paul Walmsley p...@pwsan.com writes: On v3.6-rc1 on 37xx EVM, DSS and USBHOST powerdomains aren't entering low-power states. Test log is below. Is this only happening on this 37xx platform?Just curious, because it seems to be a problem on any OMAP3xxx SoC. [...] # echo mem

Re: [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking

2012-08-06 Thread Kevin Hilman
for usecount tracking on powerdomain level and autoidle flag for clocks that are hardware controlled and should be skipped in usecount calculations. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com [...] /* Clock control for DPLL

Re: [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting

2012-08-06 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: Tero Kristo t-kri...@ti.com writes: mpu / core powerdomain usecounts are now statically increased by 1 during MPU activity. This allows the domains to reflect actual usage, and will allow the usecount to reach 0 just before all CPUs are ready to idle

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-08-06 Thread Kevin Hilman
Hi Wolfram, Kevin Hilman khil...@ti.com writes: In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. Without this, after a failed xfer, the runtime PM usecount will have been incremented, but not decremented causing the usecount to never reach zero after a failure

Re: [GPIO] Crashed when not using

2012-07-30 Thread Kevin Hilman
Poddar, Sourav sourav.pod...@ti.com writes: On Mon, Jul 30, 2012 at 3:04 PM, DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: Sourav, On Mon, Jul 30, 2012 at 2:13 PM, Poddar, Sourav sourav.pod...@ti.com wrote: Hi All, I tried using gpio as an interrupt line for my driver

Re: [RFC 0/6] ARM: OMAP3+: minor PM core code cleanup

2012-07-30 Thread Kevin Hilman
Tero, Paul, Tero Kristo t-kri...@ti.com writes: Hi, Following set moves some PRM related code away from PM core code to PRM / HWMOD. This requires the hwmod cleanup set from Paul that implements the setup_preprogram hooks for hwmods. Sending as RFC for initial commenting. What is the

Re: [RFC 1/6] ARM: OMAP3: PRM: move prcm interrupt handlers to PRM driver code

2012-07-30 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: PM code doesn't really care about the PRCM wakeup + io interrupts on OMAP3, as these are used only for acking PRCM internal events, and the IO chain handler is taken care of by hwmod code. Thus move the interrupt handling logic from pm34xx.c to

Re: [PATCH] ARM: OMAP3xxx: clockdomain: fix software supervised wakeup/sleep

2012-07-27 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: Paul, On Fri, Jul 27, 2012 at 2:34 AM, Paul Walmsley p...@pwsan.com wrote: Commit 4da71ae6 (OMAP: clockdomain: Arch specific funcs for clkdm_clk_enable/disable) called the OMAP2xxx-specific functions for clockdomain wakeup and sleep. This would

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-27 Thread Kevin Hilman
Igor Grinberg grinb...@compulab.co.il writes: On 07/26/12 22:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberg grinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been modified by Arnd in a way that of course will trigger GPIO use without being requested

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-27 Thread Kevin Hilman
Igor Grinberg grinb...@compulab.co.il writes: On 07/26/12 22:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberg grinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been modified by Arnd in a way that of course will trigger GPIO use without being requested

Re: [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking

2012-07-27 Thread Kevin Hilman
for usecount tracking on powerdomain level and autoidle flag for clocks that are hardware controlled and should be skipped in usecount calculations. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com Minor nit: please avoid using BUG_ON

Re: [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting

2012-07-27 Thread Kevin Hilman
are propageted to voltagedomain level also, and will allow vc callbacks to be triggered at right point of time. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com IMO, the idea is fine, but I'm not crazy about the implementation in powerdomain.c

Re: [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support

2012-07-27 Thread Kevin Hilman
. This patch also provices a way to do printk dumps from kernel code, by calling the pm_dbg_dump_X functions. The plan is to call these functions once an error condition is detected, e.g. failed suspend. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil

Re: [PATCHv4 7/8] ARM: OMAP: clockdomain: add support for preventing autodep delete

2012-07-27 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: On Wednesday 18 July 2012 01:35 PM, Tero Kristo wrote: On Wed, 2012-07-18 at 12:45 +0530, Rajendra Nayak wrote: On Tuesday 17 July 2012 08:26 PM, Tero Kristo wrote: Anyway, it also looks like this fix is no longer needed with the latest kernel, something

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-27 Thread Kevin Hilman
Igor Grinberg grinb...@compulab.co.il writes: On 07/27/12 20:46, Kevin Hilman wrote: Igor Grinberg grinb...@compulab.co.il writes: On 07/26/12 22:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberg grinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been

Re: [GIT PULL] OMAP4 coupled CPUidle support for v3.6

2012-07-27 Thread Kevin Hilman
, 2012 at 2:37 PM, Kevin Hilman khil...@ti.com wrote: Hi Arnd, Olof, I know it is late, but I'm really hoping this can still make it for v3.6, so consider this a [GIT PLEA]. ;) New features submitted halfway through the merge window? Yeah, that's late. I'll pull it in as late2/pm once the below

Re: [RFC 2/4] ARM: OMAP: PM: Get rid of Powerdomain book-keeping from cpuidle

2012-07-26 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: On Thursday 26 July 2012 04:13 AM, Kevin Hilman wrote: Tero Kristot-kri...@ti.com writes: On Fri, 2012-07-20 at 13:38 +0530, Rajendra Nayak wrote: On Friday 20 July 2012 12:55 PM, Shilimkar, Santosh wrote: On Fri, Jul 20, 2012 at 11:34 AM, Rajendra

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-26 Thread Kevin Hilman
with a touchscreen in my board farm. Kevin From 85516c6a3354967caf4cff434d28c3001cd411eb Mon Sep 17 00:00:00 2001 From: Kevin Hilman khil...@ti.com Date: Thu, 26 Jul 2012 12:15:38 -0700 Subject: [PATCH 2/2] ARM: OMAP2+: ads7846: fix -get_pendown_state() to work on all boards commit 16aced80f6 (ARM

[GIT PULL] OMAP4 coupled CPUidle support for v3.6

2012-07-26 Thread Kevin Hilman
to b93d70aeb8f3b5ed2d74643f5009239a55634e1d: ARM: OMAP4: CPUidle: Open broadcast clock-event device. (2012-07-25 16:06:08 -0700) Kevin Hilman (1): ARM: OMAP4: CPUidle: add synchronization for coupled idle states Santosh Shilimkar (3): ARM

Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-26 Thread Kevin Hilman
zumeng.chen zc...@windriver.com writes: On 2012年07月27日 03:30, Kevin Hilman wrote: + Zumeng Chen Igor Grinberggrinb...@compulab.co.il writes: Hi Kevin, I've just noticed that the patch has been modified by Arnd in a way that of course will trigger GPIO use without being requested. I'm

Re: [RFC 2/4] ARM: OMAP: PM: Get rid of Powerdomain book-keeping from cpuidle

2012-07-25 Thread Kevin Hilman
be addressed sooner rather than later. Kevin [1] Specifically, see: commit 58f0829b7186150318c79515f0e0850c5e7a9c89 Author: Kevin Hilman khil...@ti.com Date: Fri May 11 15:47:17 2012 -0700 ARM: OMAP3: PM: call pre/post transition per powerdomain We only need to call the pre/post transtion

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-16 Thread Kevin Hilman
Linus Walleij linus.wall...@linaro.org writes: On Thu, Jul 12, 2012 at 7:48 PM, Kevin Hilman khil...@ti.com wrote: In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see some acks/tested tags from any of - Santosh Shilimkar santosh.shilim

Re: [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support

2012-07-16 Thread Kevin Hilman
Javier Martinez Canillas jav...@dowhile0.org writes: commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775 Author: Russell King rmk+ker...@arm.linux.org.uk Date: Sat Apr 21 22:41:10 2012 +0100 mmc: omap: remove private DMA API implementation removed the private DMA API implementation from

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-16 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@ti.com [120711 14:34]: Omar Ramirez Luna omar.l...@linaro.org writes: On 11 July 2012 12:07, Kevin Hilman khil...@ti.com wrote: ... [2.311004] omap_hsmmc omap_hsmmc.0: Failed to get debounce clk [2.317382

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-16 Thread Kevin Hilman
Linus Walleij linus.wall...@linaro.org writes: On Mon, Jul 16, 2012 at 7:10 PM, Kevin Hilman khil...@ti.com wrote: Subject: [PATCH] MAINTAINERS: add entry OMAP GPIO driver Since I've been maintaining this, making it official at the request of the GPIO maintainers. Cc: Grant Likely

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-12 Thread Kevin Hilman
Hi Linus, Linus Walleij linus.wall...@linaro.org writes: On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman khil...@ti.com wrote: There is quite a bit of other things to do in remove to properly cleanup what is done in probe. OK I'm dropping this patch for now... Thanks. For future reference

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-12 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: ...snip... Hmm, interesting, I don't see this on my 3730-based Over FireSTORM. But, after converting mine into an AirStorm[1], I see the same errors as you're seeing. We're obviously doing something wrong when IVA and/or SGX are not present,

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-11 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel I have sent that patch to disable the ehci in

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-11 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: -Original Message- From: Kevin Hilman khil...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: linux-omap\@vger.kernel.org linux-omap@vger.kernel.org Date: Tue, 10 Jul 2012 16:58:18 -0700 Subject: Re: PM/RTC 3.5-rc5: System suspends fails when

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-11 Thread Kevin Hilman
Mark A. Greer mgr...@animalcreek.com writes: On Wed, Jul 11, 2012 at 10:07:06AM -0700, Kevin Hilman wrote: Joe Woodward j...@terrafix.co.uk writes: -Original Message- From: Kevin Hilman khil...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: linux-omap\@vger.kernel.org linux

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-11 Thread Kevin Hilman
+Paul Kevin Hilman khil...@ti.com writes: Joe Woodward j...@terrafix.co.uk writes: -Original Message- From: Kevin Hilman khil...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: linux-omap\@vger.kernel.org linux-omap@vger.kernel.org Date: Tue, 10 Jul 2012 16:58:18 -0700 Subject

mismerge of 'omap-cleanup-for-v3.6' into tmp-merge

2012-07-11 Thread Kevin Hilman
Hi Tony, In your current master branch, commit 3dd50d054 (Merge tag 'omap-cleanup-for-v3.6' into tmp-merge) added back the mpu_3xxx_clkdm into the common clockdomains that was removed by commit 16e5e2c47 (ARM: OMAP AM35x: clockdomain data: Fix clockdomain dependencies) This causes duplicate

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-11 Thread Kevin Hilman
Omar Ramirez Luna omar.l...@linaro.org writes: On 11 July 2012 12:07, Kevin Hilman khil...@ti.com wrote: ... [2.311004] omap_hsmmc omap_hsmmc.0: Failed to get debounce clk [2.317382] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62 [2.325256] omap_hsmmc

Re: suspend broken on 3.5-rc1?

2012-07-11 Thread Kevin Hilman
Omar Ramirez Luna omar.l...@linaro.org writes: On 12 June 2012 07:01, Rajendra Nayak rna...@ti.com wrote: [...] ..anyone knows of any more fixes going around? I'm seeing the same thing, it gets stuck trying to enable CPU1, tried this with pm-20120710 from linux-omap-pm and current LO

Re: [PATCH] ARM: OMAP: fix the ads7846 init code

2012-07-11 Thread Kevin Hilman
is freed here so I'm not sure I follow, but it seems to me that once this GPIO is requesed, it should not be freed as long as it's used, otherwise PM faults can occur. Kevin From bb87c3b5586950e480d0699504997a9ad587fd85 Mon Sep 17 00:00:00 2001 From: Kevin Hilman khil...@ti.com Date: Wed, 11 Jul

[PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO

2012-07-11 Thread Kevin Hilman
...@compulab.co.il Signed-off-by: Kevin Hilman khil...@ti.com --- Tony, this applies on top of your current fixes-non-critical branch and should probably go in to v3.5-rc since the patch which introduced the problem did as well. arch/arm/mach-omap2/common-board-devices.c |3 --- 1 file changed, 3 deletions

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-11 Thread Kevin Hilman
. Also, what about runtime PM? In short, this seems very premature and I suspect untested. Kevin Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Reported-by: Paul Walmsley p...@pwsan.com Reviewed-by: Jon Hunter jon-hun...@ti.com Cc: Kevin Hilman khil...@ti.com Cc: Rajendra Nayak rna

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-10 Thread Kevin Hilman
S, Venkatraman svenk...@ti.com writes: On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman khil...@ti.com wrote: Due to the way the driver core takes runtime PM references during probe, a driver's runtime PM callbacks may not be called until probe returns. During probe, drvdata is set to the 'host

Re: [CFT 03/11] mmc: omap_hsmmc: remove private DMA API implementation

2012-07-10 Thread Kevin Hilman
From af7537997b46ee3991985fecd4b4a302bdc0df31 Mon Sep 17 00:00:00 2001 From: Kevin Hilman khil...@ti.com Date: Tue, 10 Jul 2012 14:30:18 -0700 Subject: [PATCH] mmc: omap_hsmmc: ensure probe returns error if DMA channel request fails If dma_request_channel() fails (e.g. because DMA engine

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-10 Thread Kevin Hilman
S, Venkatraman svenk...@ti.com writes: On Tue, Jul 10, 2012 at 7:47 PM, Kevin Hilman khil...@ti.com wrote: S, Venkatraman svenk...@ti.com writes: On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman khil...@ti.com wrote: Due to the way the driver core takes runtime PM references during probe

[PATCH 1/3] ARM: OMAP: omap_device: keep track of driver bound status

2012-07-10 Thread Kevin Hilman
Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/include/plat/omap_device.h |2 ++ arch/arm/plat-omap/omap_device.c | 14 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/arch/arm/plat-omap/include/plat

[PATCH 2/3] ARM: OMAP: omap_device: don't attempt late suspend if no driver bound

2012-07-10 Thread Kevin Hilman
Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/omap_device.c |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c index 1d1b5ff..150112e 100644 --- a/arch/arm/plat-omap/omap_device.c

[PATCH 3/3] ARM: OMAP: omap_device: idle devices with no driver bound

2012-07-10 Thread Kevin Hilman
...@pwsan.com Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap/omap_device.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c index 150112e..28ab6af 100644 --- a/arch/arm/plat-omap

[PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-10 Thread Kevin Hilman
value, the driver core assumes probe was successful and will bind the driver to the device. Fix this by ensuring that probe returns an error code in this failure path. Signed-off-by: Kevin Hilman khil...@ti.com --- drivers/mmc/host/omap_hsmmc.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-10 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: I've got 3.5-rc5 with the following patches applied to get system suspend working on OMAP3: - fix the DSS: OMAPDSS: Use PM notifiers for system suspend - fix the 32KHz clock: ARM: OMAP2+: hwmod code/clockdomain data: fix 32K sync timer This

Re: [PATCH] ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it

2012-07-09 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: * Kevin Hilman khil...@ti.com [120706 11:25]: The EHCI driver is not stable enough to be enabled by default. In v3.5, it has at least the following problems: - warning dump during bootup - hang during suspend - prevents CORE powerdomain from

Re: [PATCH 3/3] Watchdog: Omap: get the bootstatus for OMAP2Plus

2012-07-09 Thread Kevin Hilman
Zumeng Chen zumeng.c...@windriver.com writes: The offset of WKUP_MOD is not right for the PRM_RSTST of OMAP3. So here put the right one to match to the actual physical addr 0x48307258, which defined in PRCM Registers section. And there is a MPU_WD_RST bit in PRM_RSTST(0x48307258) holding the

Re: [PATCH v2 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2

2012-07-09 Thread Kevin Hilman
Peter Ujfalusi peter.ujfal...@ti.com writes: On 07/06/2012 04:33 PM, Shilimkar, Santosh wrote: Since this is TWL6030 specific, it should rather be done in TWL code like I did for sys_nirq1: http://marc.info/?l=linux-omapm=134090312118873w=2 That would avoid having to do this in both

Re: [PATCH v2 02/14] ARM: OMAP: counter-32k: Select the CR register offset using the IP scheme.

2012-07-09 Thread Kevin Hilman
Santosh Shilimkar santosh.shilim...@ti.com writes: From: R Sricharan r.sricha...@ti.com OMAP socs has a legacy and a highlander version of the 32k sync counter IP. The register offsets vary between the highlander and the legacy scheme. So use the 'SCHEME' bits(30-31) of the revision

Re: [PATCH] OMAP: config : disable the usb host configuration in omap2plus_defconfig

2012-07-06 Thread Kevin Hilman
Keshava Munegowda keshava_mgo...@ti.com writes: The usb host is disabled in the omap2 build; This is because usb host is causing the retention to break in cpu idle. ... and causes warnings during boot, and hangs in suspend, can't suspend using NFSroot, etc. etc. Thank you for disabling this

Re: [PATCH v2 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2

2012-07-06 Thread Kevin Hilman
Peter Ujfalusi peter.ujfal...@ti.com writes: The sys_nirq2 is used for twl6040, make sure the pin is configured correctly. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |3 +++ 1 files

[PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

2012-07-06 Thread Kevin Hilman
to the IRQ flags. Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake to wake from system suspend multiple times. Signed-off-by: Kevin Hilman khil...@ti.com --- Resending to broader audience and including Andrew. Since, I understand that drivers/rtc is somewhat orphaned, Andrew, can

[PATCH] ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it

2012-07-06 Thread Kevin Hilman
that this driver has not been thoroughly tested and therfore should not be enabled in the default defconfig. In addition, the problems above cause new PM regressions which need be addressed before this driver should be enabled in the default defconfig. Signed-off-by: Kevin Hilman khil...@ti.com --- Tony

[GIT PULL] gpio/omap: final fixes for v3.5

2012-07-06 Thread Kevin Hilman
Hi Grant, Here's a couple (hopefully) final OMAP GPIO fixes for v3.5-rc. Thanks, Kevin The following changes since commit 6b16351acbd415e66ba16bf7d473ece1574cf0bc: Linux 3.5-rc4 (2012-06-24 12:53:04 -0700) are available in the git repository at:

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-05 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Benoît On Wed, 4 Jul 2012, Benoit Cousson wrote: @@ -1141,8 +1144,16 @@ static void _enable_sysc(struct omap_hwmod *oh) sf = oh-class-sysc-sysc_flags; if (sf SYSC_HAS_SIDLEMODE) { - idlemode = (oh-flags HWMOD_SWSUP_SIDLE) ?

[GIT PULL] OMAP: PM: one more fix for 3.5-rc

2012-07-05 Thread Kevin Hilman
Tony, Hopefully this is the last one. This one fixes a problem where the CORE power domain does not hit retention during suspend. This has been known since v3.5 came out, but there has been some discussion about the proper fix. The solution has now been agreed upon, so I'd like to see this

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-04 Thread Kevin Hilman
Munegowda, Keshava keshava_mgo...@ti.com writes: On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman khil...@ti.com wrote: Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes

Re: 3.5-rc3: PM/DSS broken (was vdd_mpu_iva warnings)

2012-07-04 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: ...snip... # Thanks for testing this out. I was going through Tomi's queue for the 3.6 merge window: git://gitorious.org/linux-omap-dss2/linux.git master There is a commit called: 2b8501d777346ce1d4fe99167e9b3c0e42aae7a8 OMAPDSS: Use

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Kevin Hilman
code. This patch is a collaboration between Kevin Hilman khil...@ti.com and Paul Walmsley p...@pwsan.com. Thanks to Vaibhav Hiremath hvaib...@ti.com for providing comments on an earlier version of this patch. Thanks to Tero Kristo t-kri...@ti.com for identifying a bug in an earlier version

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Kevin Hilman
Felipe, Keshava, Kevin Hilman khil...@ti.com writes: Felipe Balbi ba...@ti.com writes: [...] Keshava is reverting a fix for a HW errata. I can't accept it as it will cause regressions. Granted, regression by regression, there's no change, but I simply can't knowingly cause a regression

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-07-02 Thread Kevin Hilman
+0530 DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Thu, Jun 14, 2012 at 5:45 AM, NeilBrown ne...@suse.de wrote: On Fri, 11 May 2012 17:30:48 -0700 Kevin Hilman khil...@ti.com wrote: Hi Grant, Here's the final round of GPIO cleanups for v3.5.  This branch is based

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-07-02 Thread Kevin Hilman
On 07/02/2012 10:37 AM, Kevin Hilman wrote: DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Mon, Jun 25, 2012 at 11:48 AM, NeilBrown ne...@suse.de wrote: On Thu, 21 Jun 2012 12:04:26 +0530 DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Thu, Jun 21, 2012 at 8:46 AM, NeilBrown ne

Re: [PATCH RESEND] ARM: OMAP2+: Fix Wake-up power domain power status

2012-07-02 Thread Kevin Hilman
on OMAP4460 panda. - Boot tested on OMAP3430 beagle and validated CORE RET still working (using Paul's 32k timer patch [1]). [1] http://marc.info/?l=linux-omapm=13453229888w=2 Signed-off-by: Jon Hunter jon-hun...@ti.com Acked-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2

<    2   3   4   5   6   7   8   9   10   11   >