Re: [PATCH 5/7] mfd: twl4030-power: Add support for board specific configuration

2014-05-20 Thread Lee Jones
. Cc: Peter De Schrijver pdeschrij...@nvidia.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/mfd/twl4030-power.c | 21 + include/linux/i2c/twl.h | 1 + 2 files changed, 22

Re: [PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier

2014-05-20 Thread Lee Jones
Ujfalusi peter.ujfal...@ti.com Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/mfd/twl4030-power.c | 6 ++ 1 file changed, 6 insertions(+) Can't vouch for the semantics of the patch, but the code looks good. Acked-by: Lee Jones lee.jo...@linaro.org Can I

Re: [PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier

2014-05-20 Thread Lee Jones
be easier if I update and re-tag the original one. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip

2014-05-19 Thread Lee Jones
backlight drivers are also doing. Signed-off-by: Tony Lindgren t...@atomide.com Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH] mfd: twl6040: Correct HPPLL configuration for 19.2 and 38.4 MHz mclk

2014-05-09 Thread Lee Jones
deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [RESEND 1/3] mfd: twl6040: Select i2c fast mode as default with regmap patch

2014-04-28 Thread Lee Jones
/twl6040.c | 9 +++-- include/linux/mfd/twl6040.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [RESEND 2/3] mfd: twl6040: Move register patching earlier in probe

2014-04-28 Thread Lee Jones
deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [RESEND 3/3] mfd: twl6040: Clear the interrupt ID register before requesting IRQ

2014-04-28 Thread Lee Jones
) will ensure that the chip will operate normally in this case as well. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/mfd/twl6040.c | 3 +++ 1 file changed, 3 insertions(+) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCH 1a/4] mfd: twl4030-power: Add generic reset configuration

2014-04-28 Thread Lee Jones
robertcnel...@gmail.com Cc: Peter De Schrijver pdeschrij...@nvidia.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- Sorry this got accidentally left out, should be the first patch in the series. diff --git

Re: [PATCH 1/4] mfd: twl4030-power: Add recommended idle configuration

2014-04-28 Thread Lee Jones
later on after it has been tested. Cc: Peter De Schrijver pdeschrij...@nvidia.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- .../devicetree/bindings/mfd/twl4030-power.txt | 4 + drivers/mfd/twl4030

Re: [PATCH 2/4] mfd: twl4030-power: Add support for board specific configuration

2014-04-28 Thread Lee Jones
With the recommended twl4030 configuration added, we can now add board specific changes as modifications to the recommended configuration. Cc: Peter De Schrijver pdeschrij...@nvidia.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren

Re: [PATCH 3/4] mfd: twl4030power: Add a configuration to turn off oscillator during off-idle

2014-04-28 Thread Lee Jones
: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- .../devicetree/bindings/mfd/twl4030-power.txt | 6 ++ drivers/mfd/twl4030-power.c | 19 +++ Code in drivers/mfd

Re: [PATCH 1/4] mfd: twl4030-power: Add recommended idle configuration

2014-04-28 Thread Lee Jones
On Mon, 28 Apr 2014, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [140428 04:42]: These settings are based on the Recommended Sleep Sequences for the Zoom Platform pdf at: http://omappedia.com/wiki/File:Recommended_Sleep_Sequences_Zoom.pdf These settings assume most

[GIT PULL] arm: omap: Immutable branch between MFD and ARM OMAP due for the v3.16 merge-window

2014-04-23 Thread Lee Jones
| 60 drivers/mfd/twl-core.c | 15 +++ 2 files changed, 15 insertions(+), 60 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH 10/11] mfd: twl-core: Fix idle mode signaling for omaps when booted with device tree

2014-04-17 Thread Lee Jones
. Cc: Kevin Hilman khil...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Nishanth Menon n...@ti.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Paul Walmsley p...@pwsan.com Cc: Tero Kristo t-kri...@ti.com Signed-off-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/omap_twl.c | 60

Re: [PATCH] mfd: twl-core: Fix accessibility of some twl4030 audio registers

2014-03-18 Thread Lee Jones
mainline? This fixes twl4030 audio regression at least on boards using HandsfreeL for audio. I think it's a little late in the cycle to send this to the -rcs. Stable will be Cc'ed however. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-13 Thread Lee Jones
+-- drivers/mfd/omap-usb-tll.c | 2 +- 9 files changed, 136 insertions(+), 114 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH] mfd: twl-core: Fix accessibility of some twl4030 audio registers

2014-03-11 Thread Lee Jones
/twl-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH] mfd: twl-core: Fix accessibility of some twl4030 audio registers

2014-03-11 Thread Lee Jones
/twl-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) In future, please don't forget to CC LKML. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Lee Jones
a immutable branch pull-request to the other maintainers. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Lee Jones
branch pull-request to the other maintainers. Awesome. That would be great, thanks. That does mean I need a) all of the Maintainer Acks and b) you to tell me which ones need to go through a single tree. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCHv8 0/4] power_supply: Introduce power supply charging driver

2014-03-10 Thread Lee Jones
mode 100644 drivers/power/power_supply_charger.c create mode 100644 drivers/power/power_supply_charger.h create mode 100644 include/linux/power/bq24261-charger.h create mode 100644 include/linux/power/power_supply_charger.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org

Re: [PATCH v9 1/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-03-10 Thread Lee Jones
. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com CC: Tero Kristo t-kri...@ti.com Acked-by: Mike Turquette mturque...@linaro.org [OMAP3 CLK data] Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/mach-omap2/cclock3xxx_data.c | 4 drivers/clk/ti/clk

Re: [PATCH v9 2/9] mfd: omap-usb-host: Always fail on clk_get() error

2014-03-10 Thread Lee Jones
Be more strict and always fail on clk_get() error. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 62 + 1 file changed, 40 insertions

Re: [PATCH v9 3/9] mfd: omap-usb-host: Use proper clock name instead of alias

2014-03-10 Thread Lee Jones
Use the proper clock name 'usbhost_120m_fck' instead of the alias 'ehci_logic_fck' Get rid of the 'ehci_logic_fck' alias from the OMAP3 hwmod data as well. CC: Paul Walmsley p...@pwsan.com CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger

Re: [PATCH v9 4/9] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-03-10 Thread Lee Jones
Use a meaningful name for the reference clocks so that it indicates the function. Update the OMAP4+ USB Host node as well to be in sync with the changes. CC: Benoît Cousson bcous...@baylibre.com CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off

Re: [PATCH v8 03/14] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-25 Thread Lee Jones
Use a meaningful name for the reference clocks so that it indicates the function. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [PATCH v8 03/14] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-25 Thread Lee Jones
Use a meaningful name for the reference clocks so that it indicates the function. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 12 ++-- 1 file changed, 6 insertions

Re: [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision

2014-02-25 Thread Lee Jones
Not all revisions have all the clocks so get the necessary clocks based on hardware revision. This should avoid un-necessary clk_get failure messages that were observed earlier. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog

Re: [PATCH v8 02/14] mfd: omap-usb-host: Always fail on clk_get() error

2014-02-25 Thread Lee Jones
Be more strict and always fail on clk_get() error. For OMAP3 platforms, get the 120MHz EHCI clock by its proper name 'usbhost_120m_fck' instead of its alias 'ehci_logic_fck'. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog

Re: [PATCH v8 02/14] mfd: omap-usb-host: Always fail on clk_get() error

2014-02-25 Thread Lee Jones
On Tue, 25 Feb 2014, Lee Jones wrote: Be more strict and always fail on clk_get() error. For OMAP3 platforms, get the 120MHz EHCI clock by its proper name 'usbhost_120m_fck' instead of its alias 'ehci_logic_fck'. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa

Re: [PATCH 1/2] mfd: twl6040: Check for error when reading revision register

2014-02-25 Thread Lee Jones
We may have an error when reading the revision register, so check for the returned value. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl6040.c | 5 + 1 file changed, 5 insertions(+) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team

Re: [PATCH 2/2] mfd: twl6040: Remove duplicate register write

2014-02-25 Thread Lee Jones
...@epfl.ch --- drivers/mfd/twl6040.c | 1 - 1 file changed, 1 deletion(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH 0/2] mfd: twl6040: Small clean-ups

2014-02-25 Thread Lee Jones
Applied both with Peter's Ack. Florian Vaussard (2): mfd: twl6040: Check for error when reading revision register mfd: twl6040: Remove duplicate register write drivers/mfd/twl6040.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- Lee Jones Linaro

Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-18 Thread Lee Jones
Use a meaningful name for the reference clocks so that it indicates the function. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v7 01/12] mfd: omap-usb-host: Use resource managed clk_get()

2014-02-14 Thread Lee Jones
Use devm_clk_get() instead of clk_get(). CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/omap-usb-host.c | 81 + 1

Re: [PATCH v7 02/12] mfd: omap-usb-host: Get clocks based on hardware revision

2014-02-14 Thread Lee Jones
of functionality changes into two different patches. In future it would be preferred. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 92 +++-- 1

Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-14 Thread Lee Jones
Use a meaningful name for the reference clocks so that it indicates the function. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-14 Thread Lee Jones
Use a meaningful name for the reference clocks so that it indicates the function. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v2 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2014-02-07 Thread Lee Jones
/tps65218.h | 284 ++ 4 files changed, 581 insertions(+) create mode 100644 drivers/mfd/tps65218.c create mode 100644 include/linux/mfd/tps65218.h Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software

Re: [PATCH v2 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2014-02-06 Thread Lee Jones
/tps65912-spi.c drivers/mfd/tps80031.c Perhaps some consolidating might be in order? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v6 00/10] USB Host support for OMAP5 uEVM (for 3.14)

2014-01-21 Thread Lee Jones
This patchset brings up USB Host ports and Ethernet port on the OMAP5 uEVM board. I'd keep hold of this and send it out again when the merge-window is closed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH v5 3/9] mfd: omap-usb-host: Update DT clock binding information

2014-01-10 Thread Lee Jones
On Thu, 09 Jan 2014, Roger Quadros wrote: The omap-usb-host driver expects certained named clocks. Add this information to the DT binding document. Use clock names as per function for reference clocks. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off

Re: [PATCH v5 1/9] mfd: omap-usb-host: Use resource managed clk_get()

2014-01-10 Thread Lee Jones
Use devm_clk_get() instead of clk_get(). CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 81 + 1 file changed, 16 insertions(+), 65

Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-10 Thread Lee Jones
Not all revisions have all the clocks so get the necessary clocks based on hardware revision. This should avoid un-necessary clk_get failure messages that were observed earlier. Be more strict and always fail on clk_get() error. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa

Re: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision

2014-01-10 Thread Lee Jones
On Fri, 10 Jan 2014, Arnd Bergmann wrote: On Friday 10 January 2014, Lee Jones wrote: - need_logic_fck = false; + /* Set all clocks as invalid to begin with */ + omap-ehci_logic_fck = omap-init_60m_fclk = ERR_PTR(-EINVAL); + omap-utmi_p1_gfclk = omap

Re: [PATCH v2] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2014-01-08 Thread Lee Jones
-by: Roger Quadros rog...@ti.com Tested-by: Tomi Valkeinen tomi.valkei...@ti.com Cc: sta...@vger.kernel.org # 3.9+ --- drivers/mfd/omap-usb-tll.c | 36 1 file changed, 12 insertions(+), 24 deletions(-) Patch looks good to me now. Applied, thanks. -- Lee

Re: [PATCH] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2013-12-18 Thread Lee Jones
); return 0; } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 07/10] mfd: menelaus: Start to use irqdomain

2013-12-17 Thread Lee Jones
removed in patch 6? return 0; } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 08/10] mfd: menelaus: Switch all children to threaded_irq

2013-12-17 Thread Lee Jones
Now that we have our own irq_chip, all children can use traditional request_threaded_irq(). Is it possible to convert these to managed resources (*_devm)? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-16 Thread Lee Jones
Are you planning on re-submitting this patch-set anytime soon? I thought Tony said it was important? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain

2013-12-11 Thread Lee Jones
On Tue, 10 Dec 2013, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [131210 10:39]: Introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). While at that, some better error handling had

Re: [PATCH v3 07/15] mfd: menelaus: Limit the usage of the_menelaus

2013-12-11 Thread Lee Jones
On Tue, 10 Dec 2013, Felipe Balbi wrote: On Tue, Dec 10, 2013 at 08:57:01AM +, Lee Jones wrote: Pass a menelaus_chip pointer as argument to most functions so we can minimize the usage of the global the_menelaus pointer. Tested-by: Aaro Koskinen aaro.koski...@iki.fi Signed-off

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-10 Thread Lee Jones
insinuated that you failed to meet all of the criteria, but they definitely fell short of the mark. But fair enough, I'll fix those up and add Aaro's Tested-by Thank you. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH v3 07/15] mfd: menelaus: Limit the usage of the_menelaus

2013-12-10 Thread Lee Jones
++--- 1 file changed, 142 insertions(+), 123 deletions(-) How is this different from patch 6? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions

2013-12-10 Thread Lee Jones
++ 1 file changed, 30 insertions(+), 27 deletions(-) Same here. I think this should be done in one fell swoop. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list

Re: [PATCH v3 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage

2013-12-10 Thread Lee Jones
+++--- 1 file changed, 27 insertions(+), 23 deletions(-) I see a theme forming. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus - time helpers

2013-12-10 Thread Lee Jones
Koskinen aaro.koski...@iki.fi Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) Same. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain

2013-12-10 Thread Lee Jones
this process either (usually *_irq_unmap()) snip - mutex_init(m-lock); - This doesn't belong in this patch. It should have been removed with the final use of the lock was. snip -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH v3 15/15] mfd: menelaus: Use devm_request_threaded_irq()

2013-12-10 Thread Lee Jones
, + NULL, menelaus_irq, IRQF_ONESHOT, DRIVER_NAME, m); No need for a separate patch here. Convert straight from request_irq() to devm_request_threaded_irq() in patch 3. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq

2013-12-10 Thread Lee Jones
-irq, NULL, menelaus_irq, + IRQF_ONESHOT, DRIVER_NAME, menelaus); devm_* managed resources please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH v3 15/15] mfd: menelaus: Use devm_request_threaded_irq()

2013-12-10 Thread Lee Jones
On Tue, 10 Dec 2013, Felipe Balbi wrote: On Tue, Dec 10, 2013 at 09:30:42AM +, Lee Jones wrote: On Mon, 09 Dec 2013, Felipe Balbi wrote: By using devm_request_threaded_irq() we can drop a few extra lines of code and rely on device managed resources layer to free our IRQ for us

Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain

2013-12-10 Thread Lee Jones
on ARM platforms. Is that true? it was made *only* for Nokia to use on their ARM-only internet tablets. If the IP is genuinely not reusable, them I'm fine with it. I see that the Kconfig is setup in the correct way too, so we're good. -- Lee Jones Linaro STMicroelectronics Landing Team Lead

Re: [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions

2013-12-10 Thread Lee Jones
On Tue, 10 Dec 2013, Felipe Balbi wrote: On Tue, Dec 10, 2013 at 09:00:21AM +, Lee Jones wrote: On Mon, 09 Dec 2013, Felipe Balbi wrote: Those functions are static and can receive a menelaus_chip pointer very easily. Tested-by: Aaro Koskinen aaro.koski...@iki.fi Signed

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-09 Thread Lee Jones
- Please use the full 72 char (or there abouts) width of the buffer. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Lee Jones
a different structure to of_tps65218_match_table, please ensure they're the same. I prefer spaces after '{' and before '}'. snip -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 1/4] mfd: DT bindings for TPS65218 PMIC

2013-12-03 Thread Lee Jones
in bindings/regulator/regulator.txt + +Example: + xyz: regulator@0 { Genuine question: Is the @0 meaningful? + compatible = ti,tps65218-dcdc1; + regulator-min-microvolt = 100; + regulator-max-microvolt = 300; + }; -- Lee Jones Linaro

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-03 Thread Lee Jones
The code looks mostly fine, but the implementation of the commit logs seems lazy. Please submit a v3 using coherent sentences with full explanations and correct punctuation. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-03 Thread Lee Jones
certainly not 40 chars however. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 1/4] mfd: DT bindings for TPS65218 PMIC

2013-12-03 Thread Lee Jones
-compatible'? I referred tps65217.txt the predecessors and used the compatible. I also referred twl-regulator.txt. That doesn't mean that they are correct/better. ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Lee Jones
'{' and before '}'. Ok. I will add a space after '{' and before '}'. Sorry I did not follow tps65218_id_table being different than of_tps65218_match_table. One is of the type of_device_id and the other i2c_device_id. Shouldn't matter, it's just a formatting thing. -- Lee Jones Linaro

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-12-02 Thread Lee Jones
is no longer being used. It might be worth checking if we do have bindings in place for all of that, or if some of it may still be needed to be passed as auxdata while we wait for the bindings. Ruslan, do you know the answer to these concerns? -- Lee Jones Linaro STMicroelectronics Landing Team

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-12-02 Thread Lee Jones
with yours and Tony's responses. Patch applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-11-29 Thread Lee Jones
platform, so I would like a second opinion on this. Tony would you be kind enough to oblige? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-28 Thread Lee Jones
Awesome, should I add your tested-by ? I also added a few extra patches on top which I'll send soon. When you next submit, can you capitalise the first character of the subject line after the final ':' also please, it will save me the trouble. -- Lee Jones Linaro STMicroelectronics Landing

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-11-27 Thread Lee Jones
)) - return PTR_ERR(child); - - } - if (IS_ENABLED(CONFIG_CHARGER_TWL4030) pdata-bci !(features (TPS_SUBSET | TWL5031))) { child = add_child(TWL_MODULE_MAIN_CHARGE, twl4030_bci, -- Lee Jones Linaro STMicroelectronics Landing

Re: [PATCH 1/5] mfd: twl-core: Fix passing of platform data in the device tree case

2013-11-21 Thread Lee Jones
On Mon, 18 Nov 2013, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [131118 11:10]: Are you Acking this patch by the way? If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base

Re: [PATCH 1/5] mfd: twl-core: Fix passing of platform data in the device tree case

2013-11-21 Thread Lee Jones
Lindgren (1): mfd: twl-core: Fix passing of platform data in the device tree case drivers/mfd/twl-core.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro

Re: [PATCH 1/5] mfd: twl-core: Fix passing of platform data in the device tree case

2013-11-18 Thread Lee Jones
. Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- Samuel Lee, I'd like to merge this fix via arm-soc tree if this looks OK to you as I have other patches that depend on this. --- drivers/mfd/twl-core.c | 15

Re: [RFC 12/23] mfd: omap-usb-tll: raw read and write endian fix

2013-11-18 Thread Lee Jones
victor.kamen...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- drivers/mfd/omap-usb-tll.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM

Re: [RFC 11/23] mfd: omap-usb-host: raw read and write endian fix

2013-11-18 Thread Lee Jones
victor.kamen...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- drivers/mfd/omap-usb-host.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software

Re: [PATCH 1/5] mfd: twl-core: Fix passing of platform data in the device tree case

2013-11-18 Thread Lee Jones
. The latter issue is less likely to be resolved. :) Are you Acking this patch by the way? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/5] mfd: twl-core: Fix passing of platform data in the device tree case

2013-11-18 Thread Lee Jones
sort it out. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/5] mfd: twl-core: Fix passing of platform data in the device tree case

2013-11-18 Thread Lee Jones
On Mon, 18 Nov 2013, Tony Lindgren wrote: * Lee Jones lee.jo...@linaro.org [131118 11:10]: Are you Acking this patch by the way? If this looks acceptable to you guys, I'd like to merge this via my fixes branch this week with your acks if that works for you. That way I can base

Re: [PATCH] typo fixes (coordiante - coordinate) in am335x

2013-11-05 Thread Lee Jones
On Tue, 05 Nov 2013, Jan Lübbe wrote: On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote: This is the first time this patch has been sent to me. I need Dmitry's input (no pun intended) on how he's like to deal with this. At a bare minimum I'd like his Ack. Is there anything I can do

Re: [PATCH] typo fixes (coordiante - coordinate) in am335x

2013-11-05 Thread Lee Jones
On Tue, 05 Nov 2013, Jan Lübbe wrote: On Tue, 2013-11-05 at 17:15 +, Lee Jones wrote: On Tue, 05 Nov 2013, Jan Lübbe wrote: On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote: This is the first time this patch has been sent to me. I need Dmitry's input (no pun intended

Re: [PATCH] typo fixes (coordiante - coordinate) in am335x

2013-10-22 Thread Lee Jones
binding. Samuel or Lee: Could you take this patch? This is the first time this patch has been sent to me. I need Dmitry's input (no pun intended) on how he's like to deal with this. At a bare minimum I'd like his Ack. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source

Re: [PATCH 12/22] ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

2013-08-14 Thread Lee Jones
: Remove '0x's from OMAP2420 H4 DTS file Nope, looks good. Thanks Benoit. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 16/22] ARM: dts: Remove '0x's from OMAP3430 SDP DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke On Mon, 22 Jul 2013, Lee Jones wrote: Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap3430-sdp.dts | 22 +++--- 1 file changed

Re: [PATCH 17/22] ARM: dts: Remove '0x's from OMAP4 DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke On Mon, 22 Jul 2013, Lee Jones wrote: Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 15/22] ARM: dts: Remove '0x's from OMAP3 DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke On Mon, 22 Jul 2013, Lee Jones wrote: Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap3.dtsi | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 14/22] ARM: dts: Remove '0x's from OMAP3 IGEP0030 DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke On Mon, 22 Jul 2013, Lee Jones wrote: Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap3-igep0030.dts | 8 1 file changed, 4

Re: [PATCH 13/22] ARM: dts: Remove '0x's from OMAP3 IGEP0020 DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke On Mon, 22 Jul 2013, Lee Jones wrote: Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap3-igep0020.dts | 8 1 file changed, 4

Re: [PATCH 12/22] ARM: dts: Remove '0x's from OMAP2420 H4 DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke On Mon, 22 Jul 2013, Lee Jones wrote: Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap2420-h4.dts | 6 +++--- 1 file changed, 3 insertions

Re: [PATCH 18/22] ARM: dts: Remove '0x's from OMAP5 DTS file

2013-08-13 Thread Lee Jones
Tony, Benoit, Poke Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/omap5.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot

Re: [PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler

2013-07-24 Thread Lee Jones
); + If request_threaded_irq() fails, isn't there a chance that twl6030_irq_base will be allocated, but twl_irq will still be undefined? return 0; } -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 3/4] mfd: twl6030-irq: convert to use linear irq_domain

2013-07-24 Thread Lee Jones
); + free_irq(twl_irq, NULL); } Ah yes, that's better. - - free_irq(twl_irq, NULL); - return 0; } -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send

Re: [PATCH 4/4] mfd: twl6030-irq: Add interrupt mapping table for the twl6032

2013-07-24 Thread Lee Jones
= TWL6030_NR_IRQS; -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler

2013-07-24 Thread Lee Jones
(dev, could not claim irq %d: %d\n, irq_num, status); goto fail_irq; } -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/4] mfd: twl6030-irq: migrate to IRQ threaded handler

2013-07-24 Thread Lee Jones
be better if you still fixed up this patch to be correct though. Even if you break it out and add it as [PATCH 1/x]. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

<    1   2   3   >