Re: [PATCH 1/1] ARM: only call smp_send_stop() on SMP

2012-06-24 Thread Russell King - ARM Linux
See this thread: http://lists.arm.linux.org.uk/lurker/thread/20120523.200015.2fdfd505.en.html There are times when I wonder why I bother replying to email on mailing lists. No patch ever came from my responses on this subject. Not going to repeat it again. Fed up. On Sun, Jun 24, 2012 at 06:2

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-22 Thread Russell King - ARM Linux
Before this goes much further... one fairly obvious and important point must be made. You're designing an API here. You're designing it *WITHOUT* involving the two most important people in its design that there are. The DMA engine maintainers. Is this how we go about designing APIs - behind mai

Re: [RFC 0/3] Add cyclic DMA support to OMAP DMA engine driver

2012-06-22 Thread Russell King - ARM Linux
On Fri, Jun 22, 2012 at 01:30:13PM +0100, Mark Brown wrote: > On Fri, Jun 22, 2012 at 09:59:11AM +0100, Russell King - ARM Linux wrote: > > > As v3.5-rc is horribly broken on my OMAP platforms, I've had to back out > > all the sound/soc/omap changes from the last me

Re: [RFC 0/3] Add cyclic DMA support to OMAP DMA engine driver

2012-06-22 Thread Russell King - ARM Linux
On Fri, Jun 22, 2012 at 09:59:11AM +0100, Russell King - ARM Linux wrote: > These three patches add support for returning the residue and cyclic DMA > support to the OMAP DMA engine driver. > > As v3.5-rc is horribly broken on my OMAP platforms, I've had to back out > al

[RFC 0/3] Add cyclic DMA support to OMAP DMA engine driver

2012-06-22 Thread Russell King - ARM Linux
These three patches add support for returning the residue and cyclic DMA support to the OMAP DMA engine driver. As v3.5-rc is horribly broken on my OMAP platforms, I've had to back out all the sound/soc/omap changes from the last merge window to test this, inspite of Peter Ujfalusi maintaining tha

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-06-21 Thread Russell King - ARM Linux
On Thu, Jun 21, 2012 at 09:36:12PM +0300, Ujfalusi, Peter wrote: > Hi Russel, > > On Thu, Jun 21, 2012 at 4:22 PM, Russell King - ARM Linux > wrote: > >> Okay, reverting back to v3.4-rc4 works. > > > > As does reverting to v3.4, of course.  So, it was broken

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-06-21 Thread Russell King - ARM Linux
On Thu, Jun 21, 2012 at 02:16:42PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 21, 2012 at 01:59:03PM +0100, Russell King - ARM Linux wrote: > > On Mon, Apr 30, 2012 at 10:26:45AM +0300, Peter Ujfalusi wrote: > > > On 04/29/2012 11:35 PM, Russell King - ARM Linux wrote:

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-06-21 Thread Russell King - ARM Linux
On Thu, Jun 21, 2012 at 01:59:03PM +0100, Russell King - ARM Linux wrote: > On Mon, Apr 30, 2012 at 10:26:45AM +0300, Peter Ujfalusi wrote: > > On 04/29/2012 11:35 PM, Russell King - ARM Linux wrote: > > > Please can someone at TI take a current mainline kernel, build it, and &g

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-06-21 Thread Russell King - ARM Linux
On Mon, Apr 30, 2012 at 10:26:45AM +0300, Peter Ujfalusi wrote: > On 04/29/2012 11:35 PM, Russell King - ARM Linux wrote: > > Please can someone at TI take a current mainline kernel, build it, and > > test out audio support on the 4430SDP - specifically output through the > >

Re: [PATCH v2 2/4] ARM: add flush_mem api for ARMv6

2012-06-20 Thread Russell King - ARM Linux
On Tue, Jun 19, 2012 at 04:51:16PM +0530, Gupta, Ramesh wrote: > >From 630a3a8f341eb7f58f9a63bf786d732b5bdfd01e Mon Sep 17 00:00:00 2001 > From: Ramesh Gupta G > Date: Fri, 15 Jun 2012 16:39:21 +0530 > Subject: [PATCH v2 2/4] ARM: add flush_mem api for ARMv6 > > Added flush_mem cache maintenance

Re: [PATCH v2 1/4] ARM: new cache maintenance api for iommu mem flush

2012-06-20 Thread Russell King - ARM Linux
On Tue, Jun 19, 2012 at 04:51:07PM +0530, Gupta, Ramesh wrote: > >From 785a1f2854002ce7c1c8880bc5d8d92a7868bf1c Mon Sep 17 00:00:00 2001 > From: Ramesh Gupta G > Date: Fri, 15 Jun 2012 16:37:20 +0530 > Subject: [PATCH v2 1/4] ARM: new cache maintenance api for iommu mem flush > > non-coherent IOM

Re: [PATCH] SPI: OMAP: fix over-eager devm_xxx() conversion (was: Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support)

2012-06-16 Thread Russell King - ARM Linux
Okay, I'm going to queue this up in my tree for -rc as no one seems to be listening to any of the emails I've sent on Thursday. On Thu, Jun 14, 2012 at 03:07:12PM +0100, Russell King - ARM Linux wrote: > From: Russell King > Subject: [PATCH] SPI: OMAP: fix over-eager devm_

[PATCH] SPI: OMAP: fix over-eager devm_xxx() conversion (was: Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support)

2012-06-14 Thread Russell King - ARM Linux
From: Russell King Subject: [PATCH] SPI: OMAP: fix over-eager devm_xxx() conversion 1a77b127ae (OMAP : SPI : use devm_* functions) converted the SPI device controller state to use devm_kzalloc(). Unfortunately, this is used against an unbound struct device, which results in the following when th

Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 01:08:43PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 14, 2012 at 12:53:35PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 07, 2012 at 12:08:35PM +0100, Russell King wrote: > > > Add DMA engine support to the OMAP SPI driver. Th

Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 12:53:35PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 07, 2012 at 12:08:35PM +0100, Russell King wrote: > > Add DMA engine support to the OMAP SPI driver. This supplements the > > private DMA API implementation contained within this driver, and the

Re: [CFT 07/11] spi: omap2-mcspi: add DMA engine support

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 07, 2012 at 12:08:35PM +0100, Russell King wrote: > Add DMA engine support to the OMAP SPI driver. This supplements the > private DMA API implementation contained within this driver, and the > driver can be independently switched at build time between using DMA > engine and the private

Re: [PATCH 15/17] i2c: omap: always return IRQ_HANDLED

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 04:48:56PM +0530, Shilimkar, Santosh wrote: > On Thu, Jun 14, 2012 at 3:50 PM, Felipe Balbi wrote: > > otherwise we could get our IRQ line disabled due > > to many spurious IRQs. > > > > Signed-off-by: Felipe Balbi > > --- > >  drivers/i2c/busses/i2c-omap.c |    2 +- > >  

Re: [PATCH 09/17] i2c: omap: ack IRQ in parts

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 01:20:42PM +0300, Felipe Balbi wrote: > According to flow diagrams on OMAP TRMs, > we should ACK the IRQ as they happen. You don't explain that you're adding a new dev_err() statement into the driver for a missing acknowledge. What if you're probing for a device - can this

Re: [PATCH 06/17] i2c: omap: improve 1p153 errata handling

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 01:20:39PM +0300, Felipe Balbi wrote: > -static int errata_omap3_1p153(struct omap_i2c_dev *dev, u16 *stat, int *err) > +static int errata_omap3_1p153(struct omap_i2c_dev *dev) > { > - unsigned long timeout = 1; > + unsigned long timeout = 1; > + u16

Re: [PATCH 04/17] i2c: omap: simplify omap_i2c_ack_stat()

2012-06-14 Thread Russell King - ARM Linux
On Thu, Jun 14, 2012 at 01:20:37PM +0300, Felipe Balbi wrote: > stat & BIT(1) is the same as BIT(1), so let's > simplify things a bit by removing "stat &" from > all omap_i2c_ack_stat() calls. This doesn't feel right, and the explanation is definitely wrong. "stat & BIT(1)" is not the same as "BI

Fwd: Re: Broken builds

2012-06-13 Thread Russell King - ARM Linux
orwarded message from Tony Lindgren - Date: Tue, 5 Jun 2012 01:22:18 -0700 From: Tony Lindgren To: Russell King - ARM Linux Cc: linux-omap@vger.kernel.org, Tomi Valkeinen Subject: Re: Broken builds Delivery-date: Tue, 05 Jun 2012 09:22:25 +0100 * Russell King - ARM Linux [120603 11:05]: > Lo

Re: Broken builds

2012-06-11 Thread Russell King - ARM Linux
On Wed, Jun 06, 2012 at 12:58:00AM -0700, Tony Lindgren wrote: > * Tomi Valkeinen [120605 06:24]: > > Hi, > > > > On Tue, 2012-06-05 at 01:22 -0700, Tony Lindgren wrote: > > > * Russell King - ARM Linux [120603 11:05]: > > > > Looks like the DSS stuf

Re: Broken builds

2012-06-11 Thread Russell King - ARM Linux
On Tue, Jun 05, 2012 at 04:20:00PM +0300, Tomi Valkeinen wrote: > Hi, > > On Tue, 2012-06-05 at 01:22 -0700, Tony Lindgren wrote: > > * Russell King - ARM Linux [120603 11:05]: > > > Looks like the DSS stuff has broken OMAP builds again during this > > > merge w

Re: RFC: changing DMA slave configuration API

2012-06-11 Thread Russell King - ARM Linux
On Mon, Jun 11, 2012 at 10:20:49AM +0530, Vinod Koul wrote: > I think it is a good idea. And I would like to extend it even a little > bit. Do we have any users of peripheral to peripheral slave dma? > IIRC that is not the case, or does anyone know of existence or plans > for such a h/w? > > If n

Re: RFC: changing DMA slave configuration API

2012-06-10 Thread Russell King - ARM Linux
On Sun, Jun 10, 2012 at 07:19:47PM +0800, Barry Song wrote: > 2012/6/10 Russell King - ARM Linux : > > Dan, Vinod, > > > > There's a change I would like to do to the DMA slave configuration. > > It's currently a pain to have the source and destination p

RFC: changing DMA slave configuration API

2012-06-10 Thread Russell King - ARM Linux
Dan, Vinod, There's a change I would like to do to the DMA slave configuration. It's currently a pain to have the source and destination parameters in the dma_slave_config structure as separate elements; it means when you want to extract them, you end up with code in DMA engine drivers like: +

Re: [CFT 05/31] dmaengine: PL08x: clean up get_signal/put_signal

2012-06-10 Thread Russell King - ARM Linux
On Thu, Jun 07, 2012 at 11:47:23AM +0100, Russell King wrote: > Try to avoid dereferencing the DMA engine's channel struct in these > platform helpers; instead, pass a pointer to the channel data into > get_signal(), and the returned signal number to put_signal(). > > Signed-off-by: Russell King

Re: [CFT 11/11] Add feature removal of old OMAP private DMA implementation

2012-06-09 Thread Russell King - ARM Linux
On Fri, Jun 08, 2012 at 01:37:11PM -0500, Rob Landley wrote: > On 06/07/2012 06:09 AM, Russell King wrote: > > Acked-by: Linus Walleij > > Signed-off-by: Russell King > > --- > > Documentation/feature-removal-schedule.txt | 11 +++ > > 1 files changed, 11 insertions(+), 0 deletions(-)

Re: [CFT 01/11] dmaengine: add OMAP DMA engine driver

2012-06-08 Thread Russell King - ARM Linux
On Fri, Jun 08, 2012 at 03:30:23PM +0530, Shilimkar, Santosh wrote: > On Fri, Jun 8, 2012 at 2:32 PM, Russell King - ARM Linux > wrote: > > On Thu, Jun 07, 2012 at 12:06:32PM +0100, Russell King wrote: > >> Tested-by: Tony Lindgren > >> Signed-off-by: Russell Ki

Re: [CFT 01/11] dmaengine: add OMAP DMA engine driver

2012-06-08 Thread Russell King - ARM Linux
On Thu, Jun 07, 2012 at 12:06:32PM +0100, Russell King wrote: > Tested-by: Tony Lindgren > Signed-off-by: Russell King > --- > drivers/dma/Kconfig |6 + > drivers/dma/Makefile |1 + > drivers/dma/omap-dma.c | 522 > ++ > include/li

Re: [CFT 09/11] mtd: omap2: add DMA engine support

2012-06-07 Thread Russell King - ARM Linux
On Thu, Jun 07, 2012 at 03:49:35PM +0300, Artem Bityutskiy wrote: > On Thu, 2012-06-07 at 12:09 +0100, Russell King wrote: > > Add DMA engine support to the OMAP2 NAND driver. This supplements the > > private DMA API implementation contained within this driver, and the > > driver can be independen

[CFT] OMAP patches

2012-06-07 Thread Russell King - ARM Linux
And the last set - the OMAP patches. Documentation/feature-removal-schedule.txt | 11 + arch/arm/mach-omap1/board-h2-mmc.c |1 - arch/arm/mach-omap1/board-h3-mmc.c |1 - arch/arm/mach-omap1/board-nokia770.c |1 - arch/arm/mach-omap2/board-n8x0.c |

Re: [CFT] PL08x patches

2012-06-07 Thread Russell King - ARM Linux
Here's the PL08x patches. drivers/dma/Kconfig|1 + drivers/dma/amba-pl08x.c | 941 ++-- include/linux/amba/pl08x.h | 156 +--- 3 files changed, 482 insertions(+), 616 deletions(-) -- To unsubscribe from this list: send the line "unsubsc

[CFT] SA11x0 patches

2012-06-07 Thread Russell King - ARM Linux
Updates to the SA11x0 DMA engine driver. This fixes the residue calculation, and implements cyclic transfers. drivers/dma/sa11x0-dma.c | 153 -- 1 files changed, 121 insertions(+), 32 deletions(-) -- To unsubscribe from this list: send the line "unsu

[CFT] DMA engine patches

2012-06-07 Thread Russell King - ARM Linux
I am intending to post the _entire_ set of DMA patches I have so far. I'm going to be doing this in a slightly different way to normal, because of the way the branches are structured. What will come first is a set of three common patches to all the branches. Following on from that will be the ind

New randconfig build failures in OMAP

2012-06-05 Thread Russell King - ARM Linux
I pulled Linus' tree at 7am UTC, and reran the builds after updating the build tree with that (plus my pending devel stuff). The resulting randconfig spat out this: arch/arm/mach-omap2/dsp.c: In function 'omap_dsp_reserve_sdram_memblock': arch/arm/mach-omap2/dsp.c:58: error: implicit declaration

Broken builds

2012-06-03 Thread Russell King - ARM Linux
Looks like the DSS stuff has broken OMAP builds again during this merge window: drivers/video/omap2/dss/core.c:197: error: static declaration of 'dss_debugfs_create_file' follows non-static declaration drivers/video/omap2/dss/dss.h:166: error: previous declaration of 'dss_debugfs_create_file' wa

[PATCH] Fix OMAP4 boot regression

2012-05-24 Thread Russell King - ARM Linux
Fix a boot regression in existing kernels causing: genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq XXX caused by 1c6c6952 (genirq: Reject bogus threaded irq requests). Signed-off-by: Russell King -- drivers/mmc/host/omap_hsmmc.c |2 +- drivers/rtc/rtc-twl.c |

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-17 Thread Russell King - ARM Linux
On Thu, May 17, 2012 at 02:52:36PM +0100, Mark Brown wrote: > On Thu, May 17, 2012 at 02:22:23PM +0100, Russell King - ARM Linux wrote: > > > DMA on the other hand seems to have cases where you can make a choice > > between two or more providers of the service. The i

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-17 Thread Russell King - ARM Linux
On Wed, May 16, 2012 at 07:42:20PM +, Arnd Bergmann wrote: > On Wednesday 16 May 2012, Jassi Brar wrote: > > The assumed model of the DMAC, in this binding, has P peripheral > > interfaces (P request signals) that could request a data transfer > > and C physical channels that actually do the d

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-17 Thread Russell King - ARM Linux
On Thu, May 10, 2012 at 11:00:53AM -0600, Stephen Warren wrote: > To solve Russell's HW, we need some way of representing the mux directly > in DT irrespective of how the DMA controller or DMA client specify what > they're connected to. Anything else isn't representing the HW in DT. Note that it's

Re: [RFC 00/12] OMAP DMA engine conversion

2012-05-15 Thread Russell King - ARM Linux
On Tue, May 15, 2012 at 02:29:27PM +0530, Vinod Koul wrote: > On Tue, 2012-05-15 at 08:41 +0100, Russell King - ARM Linux wrote: > > It's not ready for merging. While it allows some of the OMAP drivers > > to be converted, there's others which need changes to omap-dma.

Re: [RFC 00/12] OMAP DMA engine conversion

2012-05-15 Thread Russell King - ARM Linux
On Tue, May 15, 2012 at 09:49:24AM +0530, Vinod Koul wrote: > On Mon, 2012-04-23 at 17:04 +0100, Russell King - ARM Linux wrote: > > For the full text, please see > > > > http://lists.arm.linux.org.uk/lurker/message/20120418.100954.7fa7acf8.en.html > > > > This

New OMAP build warning

2012-05-11 Thread Russell King - ARM Linux
arch/arm/plat-omap/usb.c: In function 'omap_otg_init': arch/arm/plat-omap/usb.c:40: warning: unused variable 'status' caused by: commit eeb3711b89d68e147e05e7b43a49ecc5009dc157 Author: Paul Walmsley Date: Fri Apr 13 06:34:32 2012 -0600 ARM: OMAP2+: clean up some cppcheck warnings -- To u

Re: [PATCH] ARM: decompressor: Fix mmu mapping for non-DRAM address space.

2012-05-10 Thread Russell King - ARM Linux
On Thu, May 10, 2012 at 12:41:35PM +0530, Santosh Shilimkar wrote: > Are you planning to merge below patch as is or split > the patch like 1) Refactoring 2) ARMv7 fix I don't see any point in splitting this up, especially as the ARMv7 fix would involve merely changing two lines (the domain registe

Re: [PATCH 00/19] ARM: OMAP4 device off support

2012-05-09 Thread Russell King - ARM Linux
On Wed, May 09, 2012 at 03:46:02PM -0700, Kevin Hilman wrote: > Tero Kristo writes: > > > Hi, > > > > First version for this work. Applies on top of mainline + iochain set + > > OMAP4 core retention set. Working tree available here: > > tree: git://gitorious.org/~kristo/omap-pm/omap-pm-work.git >

Re: [PATCH] ARM: decompressor: Fix mmu mapping for non-DRAM address space.

2012-05-09 Thread Russell King - ARM Linux
On Wed, May 09, 2012 at 03:44:08PM -0500, Buckley, Bryan wrote: > On Wed, May 9, 2012 at 10:48 AM, Russell King - ARM Linux > wrote: > > > > On Wed, May 09, 2012 at 06:00:10PM +0530, Shilimkar, Santosh wrote: > > > On Wed, May 9, 2012 at 5:53 PM, Russell King - ARM Lin

Re: [PATCH] ARM: decompressor: Fix mmu mapping for non-DRAM address space.

2012-05-09 Thread Russell King - ARM Linux
On Wed, May 09, 2012 at 06:00:10PM +0530, Shilimkar, Santosh wrote: > On Wed, May 9, 2012 at 5:53 PM, Russell King - ARM Linux > wrote: > > On Wed, May 09, 2012 at 02:20:28PM +0530, Shilimkar, Santosh wrote: > >> The only change done common code is  clearing 'XN' b

Re: [PATCH] ARM: decompressor: Fix mmu mapping for non-DRAM address space.

2012-05-09 Thread Russell King - ARM Linux
On Wed, May 09, 2012 at 02:20:28PM +0530, Shilimkar, Santosh wrote: > The only change done common code is clearing 'XN' bit for DRAM > region in page table entries. The other change of setting the DACR > register is done in ARMv7 specific code. Yes, XN is an ARMv6+ thing. Before ARMv5, it was im

Re: [PATCH] ARM: decompressor: Fix mmu mapping for non-DRAM address space.

2012-05-08 Thread Russell King - ARM Linux
On Tue, May 08, 2012 at 07:31:57PM +0530, Shilimkar, Santosh wrote: > Ok. Assuming you mean " it's _not_ cleaner to have two domains where > manager overrides XN attributes" Note that DRAM can be in the middle of > 4GB address space, so we need to take care of bottom and top address > space. > > U

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-04 Thread Russell King - ARM Linux
On Fri, May 04, 2012 at 10:06:53AM -0500, Jon Hunter wrote: > The thought here was that some DMAs may distinguish between devices by a > request ID or a channel ID or both. In the case of say an OMAP4, we have > 32 channels and 127 request IDs. From a h/w perspective we need to know > both. Each of

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-05-03 Thread Russell King - ARM Linux
On Thu, May 03, 2012 at 04:26:12PM -0600, Stephen Warren wrote: > On 04/30/2012 03:17 PM, Jon Hunter wrote: > > +Example: > > + > > + sdma: dmaengine@4800 { > > + compatible = "ti,omap4-sdma" > > + reg = <0x4800 0x1000>; > > + interrupts = <4>; > > +

Re: [PATCH 2/7] ARM: OMAP2+: Clean up wrapping multiple objects in Makefile

2012-05-02 Thread Russell King - ARM Linux
On Wed, May 02, 2012 at 03:18:08PM +0530, Santosh Shilimkar wrote: > Signed-off-by: Santosh Shilimkar > --- > arch/arm/mach-omap2/Makefile | 160 - > 1 files changed, 78 insertions(+), 82 deletions(-) > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/a

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-05-01 Thread Russell King - ARM Linux
On Mon, Apr 30, 2012 at 10:26:45AM +0300, Peter Ujfalusi wrote: > On 04/29/2012 11:35 PM, Russell King - ARM Linux wrote: > > Please can someone at TI take a current mainline kernel, build it, and > > test out audio support on the 4430SDP - specifically output through the > >

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-29 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 08:31:29PM +0100, Russell King - ARM Linux wrote: > and the 'noise' from the small loudspeakers is just about recognizable - > but is not what I was expecting (it's slow, plus it sounds on those small > speakers that it's horribly distorted.)

Re: [PATCH 07/12] mmc: omap: add DMA engine support

2012-04-28 Thread Russell King - ARM Linux
On Mon, Apr 23, 2012 at 05:13:30PM -0700, Tony Lindgren wrote: > * Russell King [120423 09:11]: > > Add DMA engine support to the OMAP driver. This supplements the > > private DMA API implementation contained within this driver, and the > > driver can be switched at build time between using DMA e

Re: [PATCH 2/8] dmaengine: amba-pl08x: ensure physical channels are properly held

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 10:38:08PM +0200, Linus Walleij wrote: > On Wed, Apr 18, 2012 at 12:19 PM, Russell King - ARM Linux > wrote: > > > Oops, this patch wasn't supposed to be part of this set... > > ...however it gives me the impression that you have a patch se

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 07:31:16PM +0100, Russell King - ARM Linux wrote: > I don't have that in the branch I'm building because I started the > DMA engine work against v3.4-rc3. > > > This is the second patch to separate the twl6040 from twl-core. > > If you are

Re: [PATCH 05/12] mmc: omap_hsmmc: add DMA engine support

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 09:00:22PM +0200, Linus Walleij wrote: > On Mon, Apr 23, 2012 at 6:05 PM, Russell King > wrote: > > > Add DMA engine support to the OMAP HSMMC driver.  This supplements the > > private DMA API implementation contained within this driver, and the > > driver can be switched

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 09:14:23PM +0300, Ujfalusi, Peter wrote: > On Fri, Apr 27, 2012 at 8:19 PM, Russell King - ARM Linux > wrote: > > root@omap-4430sdp:~# lsmod > > Module                  Size  Used by > > snd_soc_dmic            1492  0 > > s

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 08:04:52PM +0300, Ujfalusi, Peter wrote: > On Fri, Apr 27, 2012 at 7:50 PM, Russell King - ARM Linux > wrote: > >> You need to load the DMIC driver as well: > >> insmod snd-soc-omap-dmic.ko > > > > You must be joking... > > W

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 07:32:42PM +0300, Ujfalusi, Peter wrote: > On Fri, Apr 27, 2012 at 7:04 PM, Russell King - ARM Linux > wrote: > > Right, so the only platform I have out of that (as I said above) is > > SDP4430. > > > > And as I've already said, it doe

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 06:53:39PM +0300, Ujfalusi, Peter wrote: > Hi Russell, > > On Fri, Apr 27, 2012 at 4:58 PM, Russell King - ARM Linux > wrote: > > Can someone please hint on what audio is supported on these two OMAP > > boards?  From what I can tell, the answe

Re: Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
On Fri, Apr 27, 2012 at 03:56:42PM +0100, Liam Girdwood wrote: > On Fri, 2012-04-27 at 19:45 +0530, Shilimkar, Santosh wrote: > > + Peter and Liam to comment > > > > On Fri, Apr 27, 2012 at 7:28 PM, Russell King - ARM Linux > > wrote: > > > Can someone pleas

Audio support on OMAP 3430LDP or 4430SDP boards

2012-04-27 Thread Russell King - ARM Linux
Can someone please hint on what audio is supported on these two OMAP boards? From what I can tell, the answer is either "nothing" or "hdmi", both of which are useless to me if someone wants me to convert the OMAP ASoC driver to DMA engine. >From what I can see on the 4430SDP, there's a 3.5mm head

Build error: undefined reference to `snd_soc_unregister_codec'

2012-04-27 Thread Russell King - ARM Linux
When building ALSA as modules: drivers/built-in.o: In function `omapdss_hdmihw_remove': omap_hwspinlock.c:(.text+0x23da8): undefined reference to `snd_soc_unregister_codec' drivers/built-in.o: In function `omapdss_hdmihw_probe': omap_hwspinlock.c:(.text+0x24248): undefined reference to `snd_soc_

Re: [PATCH v9 11/25] gpio/omap: cleanup omap_gpio_mod_init function

2012-04-25 Thread Russell King - ARM Linux
On Wed, Apr 25, 2012 at 06:24:14PM +0530, DebBarma, Tarun Kanti wrote: > On Wed, Apr 25, 2012 at 12:09 PM, Shilimkar, Santosh > wrote: > > On Wed, Apr 25, 2012 at 10:04 AM, DebBarma, Tarun Kanti > > wrote: > >> On Tue, Apr 24, 2012 at 9:34 PM, Tony Lindgren wrote: > >>> * DebBarma, Tarun Kanti

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Russell King - ARM Linux
On Wed, Apr 25, 2012 at 01:47:21AM +0300, Grazvydas Ignotas wrote: > On Tue, Apr 24, 2012 at 7:51 PM, Tony Lindgren wrote: > > * Russell King - ARM Linux [120424 03:42]: > >> Here's another patch - for the OMAP NAND driver. > >> > >> One thing t

Re: [PATCH 06/12] mmc: omap_hsmmc: remove private DMA API implementation

2012-04-24 Thread Russell King - ARM Linux
On Wed, Apr 25, 2012 at 12:51:09AM +0300, Grazvydas Ignotas wrote: > On Mon, Apr 23, 2012 at 7:06 PM, Russell King > wrote: > > Remove the private DMA API implementation from omap_hsmmc, making it > > use entirely the DMA engine API. > > > > Signed-off-by: Russell King > > Since the driver becom

Re: [PATCH 3/8] dmaengine: split out virtual channel DMA support from sa11x0 driver

2012-04-24 Thread Russell King - ARM Linux
On Tue, Apr 24, 2012 at 04:05:29PM +0530, Laxman Dewangan wrote: > On Wednesday 18 April 2012 03:41 PM, Russell King wrote: >> +/** >> + * vchan_cookie_complete - report completion of a descriptor >> + * vd: virtual descriptor to update >> + * >> + * vc.lock must be held by caller >> + */ >> +stati

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Russell King - ARM Linux
Here's another patch - for the OMAP NAND driver. One thing this doesn't do is configure up the source/destination bursts, which the old code did: omap_set_dma_dest_burst_mode(info->dma_ch, OMAP_DMA_DATA_BURST_16);

[RFC 00/12] OMAP DMA engine conversion

2012-04-23 Thread Russell King - ARM Linux
For the full text, please see http://lists.arm.linux.org.uk/lurker/message/20120418.100954.7fa7acf8.en.html This version contains updates for some of the comments received from the previous round, and adds the OMAP1/2 MMC and SPI drivers to the conversion. I've also added a note to feature-remo

Re: [PATCH] staging: tidspbridge: fix build errors for OMAP2_L4_IO_ADDRESS

2012-04-23 Thread Russell King - ARM Linux
On Mon, Apr 23, 2012 at 05:34:14PM +0300, Felipe Contreras wrote: > drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start': > drivers/staging/tidspbridge/core/tiomap3430.c:425: error: implicit > declaration of function 'OMAP2_L4_IO_ADDRESS' > drivers/staging/tidspbridge/core

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-23 Thread Russell King - ARM Linux
On Mon, Apr 23, 2012 at 07:30:48AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120423 07:17]: > > On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote: > > > Then something like this is still needed on top of your original mmc > > > driv

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-23 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 03:22:33PM -0700, Tony Lindgren wrote: > * Russell King [120418 03:14]: > > Using coherent DMA memory with the OMAP DMA engine results in > > unpredictable behaviour due to memory ordering issues; as things stand, > > there is no guarantee that data written to coherent DMA

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-23 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote: > Then something like this is still needed on top of your original mmc driver > patch for omap2420: > > --- a/drivers/mmc/host/omap.c > +++ b/drivers/mmc/host/omap.c > @@ -1617,11 +1617,14 @@ static int __init mmc_omap_probe(struct >

Re: [RFC 0/8] DMA engine conversion

2012-04-23 Thread Russell King - ARM Linux
Here's a patch which converts the SPI driver to use dma engine support. It's more or less a mechanical replacement in this driver. Tested on OMAP4430SDP ethernet (which basically means that udhcpc works.) One thing to note: the old DMA code programmed the DMA hardware for an element count of N an

tidspbridge in drivers/staging

2012-04-22 Thread Russell King - ARM Linux
I've noticed these failure from time to time in my omap4 randconfig builds: drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start': drivers/staging/tidspbridge/core/tiomap3430.c:425: error: implicit declaration of function 'OMAP2_L4_IO_ADDRESS' drivers/staging/tidspbridge/c

Re: [PATCH 5/8] mmc: omap_hsmmc: release correct resource

2012-04-21 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 10:35:59PM -0400, Chris Ball wrote: > Hi, > > On Fri, Apr 20 2012, Chris Ball wrote: > > On Fri, Apr 20 2012, Tony Lindgren wrote: > >> * Russell King [120418 03:15]: > >>> res can be one of several resources, as this variable is re-used several > >>> times during probe.

Re: [PATCH] arm: omap: fix trivial warnings for dspbridge

2012-04-20 Thread Russell King - ARM Linux
On Sat, Apr 21, 2012 at 01:04:18AM +0300, Felipe Contreras wrote: > arch/arm/plat-omap/devices.c: In function 'omap_dsp_reserve_sdram_memblock': > arch/arm/plat-omap/devices.c:170: warning: format '%x' expects type 'unsigned > int', but argument 3 has type 'phys_addr_t' > arch/arm/mach-omap2/dsp.c

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 09:43:07AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120420 08:41]: > > --- a/drivers/dma/omap-dma.c > > +++ b/drivers/dma/omap-dma.c > > @@ -83,11 +84,11 @@ static void omap_dma_start_sg(struct omap_chan *c, > > struct omap_desc

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 08:26:25AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120420 08:15]: > > On Thu, Apr 19, 2012 at 11:07:42AM -0700, Tony Lindgren wrote: > > > There's some information in the omap5912 trm on pages 717 and 718: > > > > >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Russell King - ARM Linux
On Thu, Apr 19, 2012 at 11:07:42AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120419 10:46]: > > On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote: > > > Cool, you almost got it. Got it working for n800 and 770 with the > > > following > &

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-19 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote: > Cool, you almost got it. Got it working for n800 and 770 with the following > patch. Only extremely light testing done now so careful with this patch too.. > > Had to hack in support for the src_port and dst_port that's needed for >

Re: [PATCH] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields"

2012-04-19 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:43:46PM +0530, Archit Taneja wrote: > On Wednesday 18 April 2012 01:36 PM, Tomi Valkeinen wrote: >> Hi, >> >> On Mon, 2012-04-09 at 12:41 +0530, Archit Taneja wrote: >>> This reverts commit 46f8c3c7e95c0d30d95911e7975ddc4f93b3e237. >>> >>> The commit above swapped the DSI

Re: [PATCH 12/12] ARM: OMAP2xxx: hwmod data: start to fix the IVA1, IVA2 and DSP

2012-04-19 Thread Russell King - ARM Linux
On Thu, Apr 19, 2012 at 03:18:27AM -0600, Paul Walmsley wrote: > N800 logs this message on boot: > > [0.182281] omap_hwmod: iva: cannot be enabled for reset (3) > > Fix by creating basic IVA1 and DSP hwmods for OMAP2420, and a basic IVA2 > hwmod for OMAP2430. There is still more information

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote: > I don't think it has to in this case, though I am thinking that we > may have to adjust the frame size for other peripherals. > > In the case of the OMAP1 MMC driver, let me pull out that chun

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120418 13:28]: > > I'd like to have the same thing happen on OMAP1 as well (it's actually > > quite simple to do) and it means that this DMA engine implementation > > detail

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote: > The scatterlist entries are separate DMA requests on omap1, there's no > chaining support in the DMA hardware on omap1. So yes, it's for every > scatterlist entry on omap1. There's no direct scatterlist support on OMAP2 either (omap_

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote: > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > wrote: > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > >> Hi, > >> > >> drivers/mmc/ho

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote: > * T Krishnamoorthy, Balaji [120418 08:39]: > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > wrote: > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > >

Re: [PATCH 6/8] mmc: omap_hsmmc: add DMA engine support

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 11:11:12AM -0700, Tony Lindgren wrote: > * Russell King [120418 03:15]: > > Add DMA engine support to the OMAP HSMMC driver. This supplements the > > private DMA API implementation contained within this driver, and the > > driver can be switched at build time between using

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > Hi, > > drivers/mmc/host/omap.c is also using dma_mask should that also be removed Does this driver make use of this platform data? If so, it needs converting to DMA engine _before_ this patch (which is one reason why it

Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 07:21:33AM -0700, Kevin Hilman wrote: > "Raja, Govindraj" writes: > > > On Wed, Apr 18, 2012 at 4:55 AM, Kevin Hilman wrote: > >> "Govindraj.R" writes: > >> > >>> From: "Govindraj.R" > >>> > >>> The wakeups can be left enabled by default and should be disabled > >>> onl

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:18:55PM +0300, Felipe Balbi wrote: > On Wed, Apr 18, 2012 at 11:17:33AM +0100, Russell King - ARM Linux wrote: > > Has anyone seen a problem (other than me when trying to get DMA engine > > working with omap-serial transmit paths) ? > > probably

Re: [PATCH 2/8] dmaengine: amba-pl08x: ensure physical channels are properly held

2012-04-18 Thread Russell King - ARM Linux
Oops, this patch wasn't supposed to be part of this set... On Wed, Apr 18, 2012 at 11:10:55AM +0100, Russell King wrote: > Ensure that physical channels are held while there are descriptors for > them to process. This is needed when we split the pending queue into > separate pending and issued qu

Re: [PATCH 1/8] ARM: OMAP: fix DMA vs memory ordering

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:15:20PM +0300, Felipe Balbi wrote: > On Wed, Apr 18, 2012 at 11:10:35AM +0100, Russell King wrote: > > Using coherent DMA memory with the OMAP DMA engine results in > > unpredictable behaviour due to memory ordering issues; as things stand, > > there is no guarantee that

[RFC 0/8] DMA engine conversion for omap_hsmmc

2012-04-18 Thread Russell King - ARM Linux
This series is the preliminary conversion of OMAPs private DMA API to DMAengine. It focuses on the OMAP HSMMC driver, as I believe that is the only DMA-capable driver which is used on the platforms I have available (3430LDP and 4430SDP). For the OMAP DMAengine driver, there's a few short-comings:

Re: [PATCH 1/3] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 03:19:11PM +0530, Venkatraman S wrote: > From: Russell King - ARM Linux Please correct this to "Russell King " > > res can be one of several resources, as this variable is re-used several > times during probe. This can cause the wrong resource par

Re: omap-serial: transmission of x-char with DMA (and other issues)

2012-04-16 Thread Russell King - ARM Linux
On Mon, Apr 16, 2012 at 04:39:09PM +0530, Raja, Govindraj wrote: > On Fri, Apr 13, 2012 at 4:11 PM, Russell King - ARM Linux > wrote: > > Can someone tell me how this works with the current omap-serial driver > > please?  It looks to me like this has been broken when DMA suppor

<    2   3   4   5   6   7   8   9   10   11   >