Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 10:48 PM, Felipe Balbi wrote: > On Fri, Sep 21, 2012 at 10:47:30PM +0530, S, Venkatraman wrote: >> On Fri, Sep 21, 2012 at 10:45 PM, S, Venkatraman wrote: >> > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: >> >> The EDMA DMAC has a har

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 10:45 PM, S, Venkatraman wrote: > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: >> The EDMA DMAC has a hardware limitation that prevents supporting >> scatter gather lists with any number of segments. Since the EDMA >> DMA Engine driver sets th

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > Note: this can be removed once the DM

Re: [PATCH] mmc: omap_hsmmc: fix max value of clkd

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 8:51 PM, Balaji T K wrote: > clock divisor can take a max value of 1023 > update code as per TRM so that card init can be handled with > higher IP clock frequencies from which clock to the card is > derived. > This is difficult to read without some punctuation / capitalizat

Re: [PATCH V2] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-17 Thread S, Venkatraman
On Thu, Sep 13, 2012 at 12:01 PM, Hebbar, Gururaja wrote: > From: Vaibhav Bedia > > In some cases mmc_suspend_host() is not able to claim the > host and proceed with the suspend process. The core returns > -EBUSY to the host controller driver. Unfortunately, the > host controller driver does not

Re: [PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code

2012-09-17 Thread S, Venkatraman
On Mon, Sep 17, 2012 at 1:45 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccine

Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja wrote: > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > Other platforms like TI81xx, OMAP4 may need this as-well. This depends > on the HSMMC IP timing closure done for the high speed cards. > > From AM335x TRM (SPRUH73F - 1

Re: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-10 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja wrote: > From: Vaibhav Bedia > > In some cases mmc_suspend_host() is not able to claim the > host and proceed with the suspend process. The core returns > -EBUSY to the host controller driver. Unfortunately, the > host controller driver does not pa

Re: [PATCHv2 1/2] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-09-09 Thread S, Venkatraman
On Sat, Sep 8, 2012 at 3:29 AM, Kevin Hilman wrote: > Venkatraman S writes: > >> omap hsmmc controller IP has a built in timer that can be programmed to >> guard against unresponsive operations. But its range is very narrow, >> and the maximum countable time is a few seconds. >> >> Card maintenan

Re: [PATCH 06/10] mmc: omap_hsmmc: remove access to SYSCONFIG register

2012-08-27 Thread S, Venkatraman
On Tue, Aug 21, 2012 at 9:08 PM, Shubhrajyoti Datta wrote: > Hi Venkat, > Some doubts below. > > On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S wrote: >> SYSCONFIG register of HSMMC IP is managed by the omap hwmod >> abstraction layer. > > At init only right? Yes. > > >> Resetting the IP and con

Re: [PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs

2012-08-27 Thread S, Venkatraman
On Tue, Aug 21, 2012 at 8:51 PM, T Krishnamoorthy, Balaji wrote: > On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S wrote: >> Flushing spurious IRQs from HSMMC IP is done twice in >> omap_hsmmc_irq and omap_hsmmc_do_irq. > > spurious IRQ is flushed in start of omap_hsmmc_do_irq > and irq acked at

Re: [PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer

2012-08-22 Thread S, Venkatraman
On Tue, Aug 21, 2012 at 4:12 PM, Felipe Balbi wrote: > On Sat, Aug 18, 2012 at 12:22:29AM +0530, Venkatraman S wrote: >> omap hsmmc controller IP has an inbuilt timer that can be programmed to > ^^^ > built-in >> guard against

Re: [PATCH] omap-hsmmc: Implementation of i761 errata

2012-08-19 Thread S, Venkatraman
On Fri, Aug 17, 2012 at 11:43 PM, Puttagunta, Viswanath wrote: > On Fri, Aug 17, 2012 at 12:28 PM, S, Venkatraman wrote: >> On Fri, Aug 17, 2012 at 9:35 PM, Semen Protsenko >> wrote: >>> Errata description: >>> Due to a bad behavior of an internal sig

Re: [PATCH] omap-hsmmc: Implementation of i761 errata

2012-08-17 Thread S, Venkatraman
On Fri, Aug 17, 2012 at 9:35 PM, Semen Protsenko wrote: > Errata description: > Due to a bad behavior of an internal signal, the Card Error interrupt bit > MMCHS_STAT[28] CERR may not be set sometimes when an error occurred in the > card response. > > Workaround: > After responses of type R1/R1b f

Re: rmk back but still recovering (was Re: Reminder - rmk still on vacation)

2012-07-30 Thread S, Venkatraman
On Mon, Jul 30, 2012 at 8:14 PM, Russell King - ARM Linux wrote: > On Mon, Jul 30, 2012 at 04:37:09PM +0200, Shilimkar, Santosh wrote: >> On Mon, Jul 30, 2012 at 4:33 PM, Russell King - ARM Linux >> wrote: >> > So I take that as you wanting exactly what is in linux-next merged without >> > any fu

Re: rmk back but still recovering (was Re: Reminder - rmk still on vacation)

2012-07-29 Thread S, Venkatraman
On Sat, Jul 28, 2012 at 1:40 PM, Shilimkar, Santosh wrote: > On Fri, Jul 27, 2012 at 6:50 PM, Russell King - ARM Linux > wrote: >> On Fri, Jul 27, 2012 at 06:08:13PM +0200, Shilimkar, Santosh wrote: >>> On Fri, Jul 27, 2012 at 3:42 PM, Russell King - ARM Linux >>> wrote: >>> > On Wed, Jul 25, 20

Re: NFS mount issue with OMAP4 on linux-next

2012-07-23 Thread S, Venkatraman
On Tue, Jul 24, 2012 at 11:48 AM, Archit Taneja wrote: > Hi, > > Comparing with working logs, I see this difference: > > [1.502166] spi spi1.0: no RX DMA engine channel for McSPI > [1.507904] omap2_mcspi omap2_mcspi.1: can't setup spi1.0, status -11 > [1.514862] omap2_mcspi omap2_mcspi

Re: [PATCH 12/25] mmc/omap_hsmmc: add a const qualifier

2012-07-23 Thread S, Venkatraman
On Mon, Jul 23, 2012 at 2:43 PM, Uwe Kleine-König wrote: > This prepares *of_device_id.data becoming const. Without this change > the following warning would occur: > > drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_probe': > drivers/mmc/host/omap_hsmmc.c:1808: warning: ini

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-20 Thread S, Venkatraman
On Fri, Jul 20, 2012 at 2:58 PM, S, Venkatraman wrote: > On Thu, Jul 19, 2012 at 5:02 PM, Tony Lindgren wrote: >> * Shilimkar, Santosh [120718 02:49]: >>> >>> "The patch simply make them depend on DMA_OMAP since DMA_OMAP >>> will select DMA_ENGINE aut

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-20 Thread S, Venkatraman
On Thu, Jul 19, 2012 at 5:02 PM, Tony Lindgren wrote: > * Shilimkar, Santosh [120718 02:49]: >> >> "The patch simply make them depend on DMA_OMAP since DMA_OMAP >> will select DMA_ENGINE automatically" >> >> This won't be true if the DMA selection are not done >> at ARCH_OMAP level as discussed i

Re: [PATCH] MMC: OMAP: make MMC_OMAP* depend on DMA_OMAP

2012-07-19 Thread S, Venkatraman
On Thu, Jul 19, 2012 at 10:35 AM, Chris Ball wrote: > Hi Venkat -- please could you ACK/review this patch? > Chris, I think we have to hold on to this patch just for today. There's another thread about this same issue on linux-omap > On Wed, Jul 04 2012, Ming Lei wrote: >> Recent commits on oma

Re: am3517: geting MMC working

2012-07-19 Thread S, Venkatraman
On Thu, Jul 19, 2012 at 1:45 PM, Yegor Yefremov wrote: > Am 19.07.2012 09:43, schrieb S, Venkatraman: >> On Thu, Jul 19, 2012 at 12:58 PM, Yegor Yefremov >> wrote: >>> Am 19.07.2012 09:07, schrieb Shilimkar, Santosh: >>>> On Thu, Jul 19, 2012 at 12:25 PM,

Re: am3517: geting MMC working

2012-07-19 Thread S, Venkatraman
On Thu, Jul 19, 2012 at 12:58 PM, Yegor Yefremov wrote: > Am 19.07.2012 09:07, schrieb Shilimkar, Santosh: >> On Thu, Jul 19, 2012 at 12:25 PM, Yegor Yefremov >> wrote: >>> Am 19.07.2012 08:34, schrieb Shilimkar, Santosh: On Thu, Jul 19, 2012 at 11:54 AM, Yegor Yefremov wrote: > Wh

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-18 Thread S, Venkatraman
t; wrote: >>>> On Wed, Jul 18, 2012 at 1:14 PM, S, Venkatraman wrote: >>>>> On Wed, Jul 18, 2012 at 12:40 PM, Tony Lindgren wrote: >>>>>> * Shilimkar, Santosh [120718 00:09]: >>>>>>> On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren

Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default

2012-07-18 Thread S, Venkatraman
On Wed, Jul 18, 2012 at 12:40 PM, Tony Lindgren wrote: > * Shilimkar, Santosh [120718 00:09]: >> On Wed, Jul 18, 2012 at 12:29 PM, Tony Lindgren wrote: >> > * Javier Martinez Canillas [120716 23:56]: >> >> On Tue, Jul 17, 2012 at 8:45 AM, Shilimkar, Santosh >> >> wrote: >> >> > Hi, >> >> > >>

Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-11 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman wrote: > If platform_get_resource_by_name() fails, driver probe is aborted an > should return an error so the driver is not bound to the device. > > However, in the current error path of platform_get_resource_by_name(), > probe returns zero since the r

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-10 Thread S, Venkatraman
On Tue, Jul 10, 2012 at 7:47 PM, Kevin Hilman wrote: > "S, Venkatraman" writes: > >> On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman wrote: >>> Due to the way the driver core takes runtime PM references during >>> probe, a driver's runtime PM callba

Re: [PATCH v2] mmc: omap: add clk_prepare and clk_unprepare

2012-07-09 Thread S, Venkatraman
On Wed, Jun 27, 2012 at 2:19 PM, Rajendra Nayak wrote: > In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() > and clk_unprepare() for the hsmmc clocks. > > Signed-off-by: Rajendra Nayak > Cc: Chris Ball > Cc: Balaji T K > Cc: > Cc: Paul Walmsley > Cc: Mike Turquette

Re: [PATCH] mmc: omap_hsmmc: fix runtime suspend crash: add host checks in callbacks

2012-07-09 Thread S, Venkatraman
On Sat, Jul 7, 2012 at 5:56 AM, Kevin Hilman wrote: > Due to the way the driver core takes runtime PM references during > probe, a driver's runtime PM callbacks may not be called until probe > returns. During probe, drvdata is set to the 'host' pointer but if > probe fails, drvdata is set to NULL

Re: New compiler warnings with v3.5-rc

2012-06-28 Thread S, Venkatraman
On Thu, Jun 28, 2012 at 2:35 PM, Tero Kristo wrote: > On Thu, 2012-06-28 at 02:47 -0600, Paul Walmsley wrote: >> Hi Tero, >> >> there are some new compiler warnings added in the v3.5-rc kernels: >> >> arch/arm/mach-omap2/twl-common.c:51:12: warning: 'twl_set_voltage' defined >> but not used >> ar

Re: [PATCH 02/11] mmc: omap: add clk_prepare and clk_unprepare

2012-06-22 Thread S, Venkatraman
On Fri, Jun 22, 2012 at 7:18 PM, Rajendra Nayak wrote: > In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare() > and clk_unprepare() for the mmc and hsmmc clocks as part of the drivers > probe() and remove() routines. > > Signed-off-by: Rajendra Nayak > Cc: Chris Ball > Cc

Re: [CFT 03/11] mmc: omap_hsmmc: remove private DMA API implementation

2012-06-07 Thread S, Venkatraman
On Thu, Jun 7, 2012 at 4:37 PM, Russell King wrote: > Remove the private DMA API implementation from omap_hsmmc, making it > use entirely the DMA engine API. > > Signed-off-by: Russell King Tested this on 4430SDP with rootfs usage, untarring the kernel source and compiling it natively. Tested-b

Re: [CFT 01/11] dmaengine: add OMAP DMA engine driver

2012-06-07 Thread S, Venkatraman
On Thu, Jun 7, 2012 at 6:10 PM, S, Venkatraman wrote: > On Thu, Jun 7, 2012 at 4:36 PM, Russell King > wrote: >> Tested-by: Tony Lindgren >> Signed-off-by: Russell King >> --- >>  drivers/dma/Kconfig      |    6 + >>  drivers/dma/Makefile     |    1 +

Re: [CFT 01/11] dmaengine: add OMAP DMA engine driver

2012-06-07 Thread S, Venkatraman
On Thu, Jun 7, 2012 at 4:36 PM, Russell King wrote: > Tested-by: Tony Lindgren > Signed-off-by: Russell King > --- >  drivers/dma/Kconfig      |    6 + >  drivers/dma/Makefile     |    1 + >  drivers/dma/omap-dma.c   |  522 > ++ >  include/linux/omap-

Re: [PATCH] Fix OMAP4 boot regression

2012-05-24 Thread S, Venkatraman
On Thu, May 24, 2012 at 2:34 PM, Russell King - ARM Linux wrote: > Fix a boot regression in existing kernels causing: > > genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq XXX > > caused by 1c6c6952 (genirq: Reject bogus threaded irq requests). > > Signed-off-by: Russell King

Re: [PATCH -next] mmc: omap_hsmmc: pass IRQF_ONESHOT to request_threaded_irq

2012-05-17 Thread S, Venkatraman
On Thu, May 17, 2012 at 7:57 AM, Ming Lei wrote: > The flag of IRQF_ONESHOT should be passed to request_threaded_irq, > otherwise the following failure message should be dumped because > hardware handler is defined as NULL: > > [    3.383483] genirq: Threaded irq requested with handler=NULL and >

Re: [PATCHv2 00/16] [FS, MM, block, MMC]: eMMC High Priority Interrupt Feature

2012-05-11 Thread S, Venkatraman
On Wed, May 9, 2012 at 6:15 AM, Minchan Kim wrote: > On 05/09/2012 01:31 AM, S, Venkatraman wrote: > >> On Tue, May 8, 2012 at 1:16 PM, Minchan Kim wrote: >>> On 05/03/2012 11:22 PM, Venkatraman S wrote: >>> >>>> Standard eMMC (Embedded MultiMedia Card)

Re: [PATCH v2 14/16] mmc: block: Implement HPI invocation and handling logic.

2012-05-09 Thread S, Venkatraman
On Wed, May 9, 2012 at 2:05 PM, wrote: > >> +static bool mmc_can_do_foreground_hpi(struct mmc_queue *mq, >> +                     struct request *req, unsigned int thpi) >> +{ >> + >> +     /* >> +      * If some time has elapsed since the issuing of previous write >> +      * command, or if the

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-08 Thread S, Venkatraman
On Tue, May 8, 2012 at 11:58 AM, mani wrote: > How about adding the AS_DMPG flag in the file -> address_space when getting > a filemap_fault() > so that we can treat the page fault pages as the high priority pages over > normal read requests. > How about changing below lines for the support of the

Re: [PATCHv2 00/16] [FS, MM, block, MMC]: eMMC High Priority Interrupt Feature

2012-05-08 Thread S, Venkatraman
On Tue, May 8, 2012 at 1:16 PM, Minchan Kim wrote: > On 05/03/2012 11:22 PM, Venkatraman S wrote: > >> Standard eMMC (Embedded MultiMedia Card) specification expects to execute >> one request at a time. If some requests are more important than others, they >> can't be aborted while the flash proce

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-07 Thread S, Venkatraman
Mon, May 7, 2012 at 5:01 AM, Dave Chinner wrote: > On Thu, May 03, 2012 at 07:53:00PM +0530, Venkatraman S wrote: >> From: Ilan Smith >> >> Add attribute to identify demand paging requests. >> Mark readpages with demand paging attribute. >> >> Signed-off-by: Ilan Smith >> Signed-off-by: Alex Lem

Re: [PATCH v2 06/16] block: treat DMPG and SWAPIN requests as special

2012-05-03 Thread S, Venkatraman
On Thu, May 3, 2012 at 8:08 PM, Jeff Moyer wrote: > Venkatraman S writes: > >> From: Ilan Smith >> >> When exp_swapin and exp_dmpg are set, treat read requests >> marked with DMPG and SWAPIN as high priority and move to >> the front of the queue. >> > [...] >> +     if (bio_swapin(bio) && blk_qu

Re: [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs

2012-04-18 Thread S, Venkatraman
On Thu, Apr 19, 2012 at 5:34 AM, Chris Ball wrote: > Hi, > > On Wed, Apr 18 2012, Venkatraman S wrote: >> From: Viswanath Puttagunta >> >> Add mmc functional clock frequency to list of >> internal state variables to display for debug. >> >> Signed-off-by: Viswanath Puttagunta >> Signed-off-by: V

Re: [PATCH 1/3] mmc: omap_hsmmc: release correct resource

2012-04-18 Thread S, Venkatraman
On Wed, Apr 18, 2012 at 3:28 PM, Russell King - ARM Linux wrote: > On Wed, Apr 18, 2012 at 03:19:11PM +0530, Venkatraman S wrote: >> From: Russell King - ARM Linux > > Please correct this to "Russell King " > Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body

Re: [PATCH] mmc: omap_hsmmc: release correct resource

2012-04-16 Thread S, Venkatraman
On Sat, Apr 14, 2012 at 7:11 PM, Russell King - ARM Linux wrote: > res can be one of several resources, as this variable is re-used several > times during probe.  This can cause the wrong resource parameters to be > passed to release_mem_region(). > > Get the original memory resource before callin

Re: [PATCH 00/19] I2C updates

2012-04-10 Thread S, Venkatraman
On Tue, Apr 10, 2012 at 4:26 PM, Shubhrajyoti D wrote: > The patch series does the following > > - Warn fixes if CONFIG_PM_RUNTIME is not selected. > - I2C register restore only if context if the context is lost > - Bus busy recovery mechanism. > - the reset is not done in init. > > v2 changes > -

Re: [PATCH RESEND] Input: omap-keypad: dynamically handle register offsets

2012-04-06 Thread S, Venkatraman
On Tue, Apr 3, 2012 at 10:52 AM, Sourav Poddar wrote: > From: G, Manjunath Kondaiah > > Keypad controller register offsets are different for omap4 > and omap5. Handle these offsets through static mapping and > assign these mappings during run time. > > Signed-off-by: Felipe Balbi > Signed-off-by

Re: [PATCH 0/8][git pull] mmc: omap: Assorted fixes for 3.4 merge window

2012-04-02 Thread S, Venkatraman
On Sun, Apr 1, 2012 at 10:10 AM, Chris Ball wrote: > Hi, > > On Fri, Mar 16 2012, Venkatraman S wrote: >> Chris, >>    Here are a group of fixes posted by Felipe and Balaji for the >> OMAP hsmmc driver in the past few days. >>    I've rebased them to the lastest mmc-next and posted them >> here ag

Re: Occasional crashes in suspend-resume with MMC transactions

2012-03-25 Thread S, Venkatraman
On Thu, Mar 22, 2012 at 9:43 PM, Bedia, Vaibhav wrote: > On Thu, Mar 22, 2012 at 21:36:36, S, Venkatraman wrote: >> On Thu, Mar 22, 2012 at 8:13 PM, Bedia, Vaibhav wrote: >> > On Thu, Mar 22, 2012 at 19:57:16, S, Venkatraman wrote: >> > [...] >> >> >&g

Re: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread S, Venkatraman
On Thu, Mar 22, 2012 at 8:13 PM, Bedia, Vaibhav wrote: > On Thu, Mar 22, 2012 at 19:57:16, S, Venkatraman wrote: > [...] >> >> I see (in 3.3) that the host controller driver does a "return ret" and >> that means the errors is propagated. >> Where is the r

Re: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread S, Venkatraman
On Thu, Mar 22, 2012 at 6:50 PM, Bedia, Vaibhav wrote: > On Thu, Mar 22, 2012 at 09:53:23, Bedia, Vaibhav wrote: >> Hi, >> >> I am trying to do suspend-resume test with a file copy on MMC/SD going on >> in the background. The test involves simply copying a 450MB file on an ext3 >> partition to the

Re: [PATCH v2 5/8] mmc: host: omap_hsmmc: trivial cleanups

2012-03-19 Thread S, Venkatraman
On Mon, Mar 19, 2012 at 11:27 AM, Hebbar, Gururaja wrote: > On Fri, Mar 16, 2012 at 19:09:01, S, Venkatraman wrote: >> From: Felipe Balbi >> >> a bunch of non-functional cleanups to the omap_hsmmc >> driver. >> >> It basically decreases indentation level

Re: [PATCH v2 1/8] mmc: omap: Enable Auto CMD12

2012-03-16 Thread S, Venkatraman
On Fri, Mar 16, 2012 at 7:21 PM, Felipe Balbi wrote: > On Fri, Mar 16, 2012 at 07:08:57PM +0530, Venkatraman S wrote: >> From: Balaji T K >> >> Enable Auto-CMD12 for multi block read/write on HSMMC >> Tested on OMAP4430, OMAP3430 and OMAP2430 SDP >> >> Signed-off-by: Balaji T K >> Signed-off-by:

Re: [PATCH RESEND 8/8] mmc: omap4: hsmmc: fix module re-insertion

2012-03-16 Thread S, Venkatraman
On Thu, Mar 15, 2012 at 8:34 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 15, 2012 at 08:03:42PM +0530, Venkatraman S wrote: >> From: Balaji T K >> >> OMAP4 and OMAP3 HSMMC IP registers differ by 0x100 offset. >> Addng the offset to platform_device resource structure >> increments the start addr

Re: [PATCH RESEND 1/8] mmc: omap: Enable Auto CMD12

2012-03-15 Thread S, Venkatraman
On Thu, Mar 15, 2012 at 8:27 PM, Felipe Balbi wrote: > On Thu, Mar 15, 2012 at 08:03:35PM +0530, Venkatraman S wrote: >> From: Balaji T K >> >> Enable Auto-CMD12 for multi block read/write on HSMMC >> Tested on OMAP4430, OMAP3430 and OMAP2430 SDP >> >> Signed-off-by: Balaji T K > > BTW, since pa

Re: [PATCH] ARM: OMAP: hsmmc: add max_freq field

2012-03-02 Thread S, Venkatraman
On Fri, Mar 2, 2012 at 12:41 PM, S, Venkatraman wrote: > +Chris queues all MMC patches including omap_hsmmc. > Ping ? > Just realized that it's already queued in mmc-next http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commitdiff;h=25d6ba8171995230b3757c78c7470fa76a931b9

Re: [PATCH] ARM: OMAP: hsmmc: add max_freq field

2012-03-01 Thread S, Venkatraman
+Chris queues all MMC patches including omap_hsmmc. Ping ? On Fri, Mar 2, 2012 at 5:41 AM, Tony Lindgren wrote: > Hi, > > * Daniel Mack [120217 05:13]: >> ping? Could anyone care for queueing this please? > > I suggest Rajendra queue up omap_hsmmc.c patches as he's already > patching it. > > Re

Re: [PATCH V2 1/1] mmc: start removing enable / disable API

2012-03-01 Thread S, Venkatraman
On Wed, Feb 29, 2012 at 12:47 PM, Adrian Hunter wrote: > Most parts of the enable / disable API are no longer used and > can be removed. > > Cc: Rajendra Nayak > Cc: Venkatraman S > Cc: Kukjin Kim > Cc: Thomas Abraham > Cc: Kyungmin Park > Cc: Sekhar Nori > Cc: Kevin Hilman > Signed-off-by:

Re: [PATCH v2 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply

2012-02-21 Thread S, Venkatraman
On Tue, Feb 21, 2012 at 3:33 PM, Rajendra Nayak wrote: > > MMC1 is not the only instance that can be used/wired for SD. > So remove this assumption from the driver. > > Now that all the mmc id based usage is removed, get rid > of all the DEVID defines and also the 'id' field from the > omap_hsmmc_

Re: [PATCH 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply

2012-02-07 Thread S, Venkatraman
On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak wrote: > MMC1 is not the only instance that can be used/wired for SD. > So remove this assumption from the driver. > > Signed-off-by: Rajendra Nayak > --- >  drivers/mmc/host/omap_hsmmc.c |   14 -- >  1 files changed, 0 insertions(+), 14

Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id

2012-02-07 Thread S, Venkatraman
On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak wrote: > This series mainly cleans up all instances of hardcoding's in > the driver based on pdev->id. This is cleanup leading to the > DT adaptation of omap_hsmmc driver. > > Patches are based on 3.3-rc2 and can be found here > git://gitorious.org/om

Re: omap_hsmmc.c and MMC_CAP_SDIO_IRQ

2012-01-29 Thread S, Venkatraman
On Fri, Jan 27, 2012 at 7:39 PM, Steve Sakoman wrote: > On Tue, Jan 24, 2012 at 6:33 AM, Michael Hunold wrote: >> Hi, >> >> I am experimenting with an SDIO card on the Beagleboard. I have started >> my experiments with Linux-3.1.4 some time ago and basically everything >> is working. >> >> Except

Re: OMAP CRAP: The Continuing Story Of Brokenness

2011-11-07 Thread S, Venkatraman
On Sun, Nov 6, 2011 at 5:48 PM, Russell King - ARM Linux wrote: > Yet again I find that I'm having to email about crap on OMAP3. > > I'm getting really fed up with OMAP stuff which keeps breaking in > idiotic ways - and the way there's fatal build errors at EVERY merge > window.  The OMAP workflow

Re: OMAP CRAP: The Continuing Story Of Brokenness

2011-11-06 Thread S, Venkatraman
On Sun, Nov 6, 2011 at 5:48 PM, Russell King - ARM Linux wrote: > Yet again I find that I'm having to email about crap on OMAP3. > > I'm getting really fed up with OMAP stuff which keeps breaking in > idiotic ways - and the way there's fatal build errors at EVERY merge > window.  The OMAP workflow

Re: [PATCH] omap_hsmmc: fix missing parenthesis in pr_info

2011-11-03 Thread S, Venkatraman
On Thu, Nov 3, 2011 at 5:29 AM, Kevin Hilman wrote: > Hi Chris, > > Chris Ball writes: > > [...] > >> Oops.  Thank you; I've pushed this to mmc-next now, and will send the >> fix to Linus.  I've checked for other errors in the original patch. > > Where did you push this fix? > > I don't see this

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-14 Thread S, Venkatraman
On Tue, Sep 13, 2011 at 1:26 AM, Per Forlin wrote: > On 1 September 2011 21:05, Venkatraman S wrote: >> Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in >> omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a >> single location in post_req function, to prevent double unm

Re: [PATCH 1/2] omap: hsmmc: Normalize dma cleanup operations

2011-09-13 Thread S, Venkatraman
On Tue, Sep 13, 2011 at 1:26 AM, Per Forlin wrote: > On 1 September 2011 21:05, Venkatraman S wrote: >> Reuse omap_hsmmc_dma_cleanup even for normal dma teardown in >> omap_hsmmc_dma_cb. Consolidate multiple points of dma unmap into a >> single location in post_req function, to prevent double unm

Re: [PATCH 0/2] OMAP: Update nr_irqs field in machine descriptors

2011-08-25 Thread S, Venkatraman
On Thu, Aug 25, 2011 at 5:19 PM, Cousson, Benoit wrote: > Hi Venkat, > > On 8/24/2011 9:46 PM, S, Venkatraman wrote: >> >> As part of an effort to get single ARM kernel binary [1], >> multiple  definitions of NR_IRQS under various platforms >> have to be reconcile

Re: [PATCHv4 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-07-13 Thread S, Venkatraman
On Wed, Jul 13, 2011 at 8:29 PM, Kevin Hilman wrote: > "Dong, Chuanxiao" writes: > > [...] > >>> >>> Basially, the question is: can the driver be reworked such that a system >>> suspend does not need to runtime resume the device?  For most devices, >>> we kind of expect that if the device is runt

Re: [PATCHv4 0/3] OMAP: HSMMC: cleanup and runtime pm

2011-07-04 Thread S, Venkatraman
> From: Kevin Hilman > Date: Fri, Jul 1, 2011 at 11:24 PM > Subject: Re: [PATCHv4 0/3] OMAP: HSMMC: cleanup and runtime pm > To: c...@laptop.org > Cc: Balaji T K , linux-omap@vger.kernel.org, > linux-...@vger.kernel.org, t...@atomide.com, madhu...@ti.com, > b-cous...@ti.com, p...@pwsan.com, kishor

Re: [PATCH] MMC: OMAP: change HSMMC maintainence to Orphan

2011-07-04 Thread S, Venkatraman
On Fri, Jul 1, 2011 at 11:06 PM, Kevin Hilman wrote: > From: Madhusudhan Chikkature > > Update the OMAP HS MMC entry from the MAINTAINERS file as I will > no longer be able to maintain this driver. > > Signed-off-by: Madhusudhan Chikkature > [khil...@ti.com: change to Orphan rather than complete

Re: [PATCH] OMAP: HSMMC maintainence

2011-06-30 Thread S, Venkatraman
On Fri, Jul 1, 2011 at 2:37 AM, wrote: > From: Madhusudhan Chikkature > > Removing the OMAP HS MMC entry from the MAINTAINERS file as I will > no longer be able to maintain this driver. > > Signed-off-by: Madhusudhan Chikkature > --- >  MAINTAINERS |    6 -- >  1 files changed, 0 insertions

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread S, Venkatraman
On Thu, Jun 30, 2011 at 6:10 AM, Paul Walmsley wrote: > + Venkat > > Hi Balaji > > On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: > >> On Wed, Jun 29, 2011 at 2:00 AM, Kevin Hilman wrote: >> > "T Krishnamoorthy, Balaji" writes: >> >> >> >> I have seen some instabilities if delay is very le

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread S, Venkatraman
On Thu, Jun 30, 2011 at 1:37 AM, Paul Walmsley wrote: > cc'ing lakml > > Hi Venkat, Balaji, > > On Wed, 29 Jun 2011, S, Venkatraman wrote: > >> On Wed, Jun 29, 2011 at 9:08 PM, Paul Walmsley wrote: >> > On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread S, Venkatraman
On Wed, Jun 29, 2011 at 9:08 PM, Paul Walmsley wrote: > On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: > >> There have been some experiments on our customer programs to reduce this >> value to a few ms and infrequent crashes were observed (stress testing >> for several hours) while trying to

Re: [PATCH] OMAP: HSMMC: Fix GPIO muxing

2011-06-28 Thread S, Venkatraman
On Tue, Jun 28, 2011 at 2:15 PM, Silesh C V wrote: > Use generic gpio call to check the validity of the gpio. Note that > this includes gpio 0 also which was missing before. > > Signed-off-by: Silesh C V > --- >  arch/arm/mach-omap2/hsmmc.c |    7 +++ >  1 files changed, 3 insertions(+), 4 de

Re: Testing cbus in N800

2011-06-05 Thread S, Venkatraman
Here is one attached which was known to be working (a few months ago, I haven't tested recently) Best regards, Venkat. On Mon, Jun 6, 2011 at 3:45 AM, Nicolau Werneck wrote: > Hello. I wanted to try the latest cbus patches in my N800. I > downloaded the branch from > > git://gitorious.org/usb/us

Re: cross compiling on Pandaboard

2011-05-30 Thread S, Venkatraman
Hi, On Mon, May 30, 2011 at 2:56 PM, sureshbalijepalli wrote: > > Hi, > Iam very new to the omap platforms . recetly i got(pandaboard). I > ported ubuntu on it . > please direct me how can i make a croos compilation . > > I am not clear what exactly you are looking for.. The websites www.pandaboa

Re: [PATCH 08/22] mmc: omap_hsmmc: correct debug report error status mnemonics

2011-05-06 Thread S, Venkatraman
On Thu, May 5, 2011 at 5:21 PM, Adrian Hunter wrote: > CERR and BADA were in the wrong place and there are only > 32 not 35. > > Signed-off-by: Adrian Hunter > --- >  drivers/mmc/host/omap_hsmmc.c |   19 +++ >  1 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/dri

Re: SDHC card affected by preemption model in 2.6.35

2011-02-20 Thread S, Venkatraman
On Sun, Feb 20, 2011 at 10:42 PM, S, Venkatraman wrote: > > On Fri, Feb 18, 2011 at 6:27 PM, Thomas Weber wrote: >> >> Hello Mathieu, hello Venkat, >> >> I hope it is not too old and you remember this: >> > >> >   This provides a good 100ms wind

Re: newbie: can I ask a question about linux-omap-pm on this mailing list?

2010-11-22 Thread S, Venkatraman
> Hi. > > I want to ask a newbie questions regarding linux-omap-pm > repositories(http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary). > > I know this mailing list is for the linux-omap repository. I have searched > the web for a mailing list specific for linux-omap-pm

build error: omap_ctrl_readl and omap_ctrl_writel undefined

2010-09-29 Thread S, Venkatraman
I am trying to build the master branch on linux-omap and I am getting the following error on 'make modules' Git log: 2365f1f | Wed, 29 Sep 2010 11:19:10 -0700 | Tony Lindgren | Linux-omap rebuilt: Updated to v2.6.36-rc6, merged in few more patches acc012f | Wed, 29 Sep 2010 11:19:00 -0700 | Tony

RE: [PATCH RESEND] update omap3 features bitmap and API to generic names

2010-05-10 Thread S, Venkatraman
> -Original Message- > From: menon.nisha...@gmail.com > [mailto:menon.nisha...@gmail.com] On Behalf Of Menon, Nishanth > Sent: Tuesday, May 11, 2010 5:02 AM > To: S, Venkatraman > Cc: linux-omap@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Tony Li

RE: [Patch v4] OMAP: sDMA driver: descriptor autoloading feature

2010-01-07 Thread S, Venkatraman
> Venkatraman S wrote: > > On Wed, Jan 6, 2010 at 6:46 PM, Adrian Hunter > > > > wrote: > > > Venkatraman S wrote: > > > > > > > > On Tue, Dec 29, 2009 at 3:18 AM, Tony Lindgren > > > wrote: > > > > > > > > > > * Venkatraman S [091211 07:01]: > > > > > > > > > > > > Here is the most up

[PATCH v3] OMAP4: sDMA driver: descriptor autoloading feature

2009-09-03 Thread S, Venkatraman
Comments received and fixed after previous posts http://marc.info/?l=linux-omap&m=125012097403050&w=2 (v1) http://marc.info/?l=linux-omap&m=125137152606644&w=2 (v2) Summary: OMAP sDMA driver changes for descriptor autoloading feature. Signed-off-by: Venkatraman S --- diff --git a/arch/arm/plat

RE: [PATCH v2][RFC] OMAP4: sDMA driver: descriptor autoloading feature

2009-09-03 Thread S, Venkatraman
> -Original Message- > From: Shilimkar, Santosh > Sent: Monday, August 31, 2009 11:41 PM > To: S, Venkatraman; linux-omap@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH v2][RFC] OMAP4: sDMA driver: descriptor > autoloading featu

RE: [PATCH v2][RFC] OMAP4: sDMA driver: descriptor autoloading feature

2009-09-01 Thread S, Venkatraman
Santosh, > -Original Message- > From: Shilimkar, Santosh > Sent: Monday, August 31, 2009 11:41 PM > To: S, Venkatraman; linux-omap@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH v2][RFC] OMAP4: sDMA driver: descriptor > autoloadin

[PATCH v2][RFC] OMAP4: sDMA driver: descriptor autoloading feature

2009-08-27 Thread S, Venkatraman
(Updated version of previous patch: http://marc.info/?l=linux-omap&m=125012097403050&w=2) Add sDMA driver support for descriptor autoloading feature. Descriptor autoloading is OMAP4 sDMA hardware capability that can be exploited for scatter gather scenarios. The feature works as described belo

[RFC][PATCH 2/2] OMAP4: sDMA driver: descriptor autoloading feature

2009-08-12 Thread S, Venkatraman
This patch adds the essential APIs for using the linked list mode of OMAP4 sDMA. Signed-off-by: Venkatraman S --- arch/arm/plat-omap/dma.c | 284 + arch/arm/plat-omap/include/mach/dma.h | 100 2 files changed, 384 insertions(+), 0 dele

[RFC][PATCH 1/2] OMAP4: sDMA drvier: adding OMAP kConfig option CONFIG_OMAP_DMA_DESCRIPTOR_LOAD

2009-08-12 Thread S, Venkatraman
The hardware feature is available on OMAP4430 and also expected to be in OMAP3630. Hence the feature flag will control the inclusion of the additional functions. Addition of omap kconfig option CONFIG_OMAP_DMA_DESCRIPTOR_LOAD. Signed-off-by: Venkatraman S --- arch/arm/configs/omap_4430sdp_def

[RFC][PATCH 0/2] OMAP4: sDMA driver updates for descriptor autoloading feature

2009-08-12 Thread S, Venkatraman
This patch series provides OMAP sDMA driver changes for descriptor autoloading feature. Descriptor autoloading is OMAP4 sDMA hardware capability that can be exploited for scatter gather scenarios. The feature works as described below 1) A sDMA channel is programmed to be in 'linked list' mode