Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-17 Thread Catalin Marinas
On 16 November 2012 18:39, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 16, 2012 at 06:09:28PM +, Catalin Marinas wrote: On Fri, Nov 16, 2012 at 09:59:21AM +, Russell King - ARM Linux wrote: On Thu, Nov 15, 2012 at 08:31:33AM -0600, Rob Herring wrote: So we

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-16 Thread Russell King - ARM Linux
On Thu, Nov 15, 2012 at 08:31:33AM -0600, Rob Herring wrote: So we should make all these work-arounds depend on !MULTI_PLATFORM then. No, because some of the work-arounds don't require setting bits in magic registers. Also realise this: we test for the revision of the CPU to which they're

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-16 Thread Russell King - ARM Linux
On Thu, Nov 15, 2012 at 09:37:08AM -0600, Rob Herring wrote: Does that work for Versatile Express CA9? It needs ARM_ERRATA_751472. On VE Linux runs in secure mode, so it's fine. WTF? You are contradicting yourself. No, it's already been explained; the problem is lack of understanding.

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-16 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [121116 02:07]: So, we don't detect whether we're running in secure mode or not; as I've already stated, we don't have a way to do that. We instead only apply work-arounds which aren't already enabled prior to the kernel booting. So, even on

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-16 Thread Catalin Marinas
On Fri, Nov 16, 2012 at 09:59:21AM +, Russell King - ARM Linux wrote: On Thu, Nov 15, 2012 at 08:31:33AM -0600, Rob Herring wrote: So we should make all these work-arounds depend on !MULTI_PLATFORM then. No, because some of the work-arounds don't require setting bits in magic registers.

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-16 Thread Russell King - ARM Linux
On Fri, Nov 16, 2012 at 06:09:28PM +, Catalin Marinas wrote: On Fri, Nov 16, 2012 at 09:59:21AM +, Russell King - ARM Linux wrote: On Thu, Nov 15, 2012 at 08:31:33AM -0600, Rob Herring wrote: So we should make all these work-arounds depend on !MULTI_PLATFORM then. No, because

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-16 Thread Russell King - ARM Linux
On Fri, Nov 16, 2012 at 09:13:33AM -0800, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [121116 02:07]: So, we don't detect whether we're running in secure mode or not; as I've already stated, we don't have a way to do that. We instead only apply work-arounds

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Russell King - ARM Linux
On Wed, Nov 14, 2012 at 02:21:59PM -0800, Tony Lindgren wrote: No idea if assuming that zero value for the diagnostic register is safe.. What's the default value of the diagnostic register supposed to be? No, that's not safe. What if your pre-kernel code has asked the secure monitor to set

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Catalin Marinas
On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM, Tony Lindgren wrote: Checking for the bit already set should work in this case, I'll post a patch for

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Siarhei Siamashka
On Thu, Nov 15, 2012 at 1:01 PM, Catalin Marinas catalin.mari...@arm.com wrote: On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM, Tony Lindgren wrote:

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Russell King - ARM Linux
On Thu, Nov 15, 2012 at 02:41:43PM +0200, Siarhei Siamashka wrote: BTW, I always wondered about what could be preventing TI and the other silicon vendors from using something like an SMC API based on asymmetric cryptography? The answer is... nothing. But it didn't happen and we're stuck with

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Catalin Marinas
On Thu, Nov 15, 2012 at 12:41:43PM +, Siarhei Siamashka wrote: On Thu, Nov 15, 2012 at 1:01 PM, Catalin Marinas catalin.mari...@arm.com wrote: On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Rob Herring
On 11/15/2012 05:01 AM, Catalin Marinas wrote: On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM, Tony Lindgren wrote: Checking for the bit already set should

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Catalin Marinas
On Thu, Nov 15, 2012 at 02:31:33PM +, Rob Herring wrote: On 11/15/2012 05:01 AM, Catalin Marinas wrote: On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM,

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Måns Rullgård
Catalin Marinas catalin.mari...@arm.com writes: On Thu, Nov 15, 2012 at 12:41:43PM +, Siarhei Siamashka wrote: BTW, I always wondered about what could be preventing TI and the other silicon vendors from using something like an SMC API based on asymmetric cryptography? My understanding is

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Rob Herring
On 11/15/2012 08:37 AM, Catalin Marinas wrote: On Thu, Nov 15, 2012 at 02:31:33PM +, Rob Herring wrote: On 11/15/2012 05:01 AM, Catalin Marinas wrote: On Thu, Nov 15, 2012 at 12:54:48AM +, Rob Herring wrote: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-15 Thread Catalin Marinas
On Thu, Nov 15, 2012 at 03:37:08PM +, Rob Herring wrote: On 11/15/2012 08:37 AM, Catalin Marinas wrote: On Thu, Nov 15, 2012 at 02:31:33PM +, Rob Herring wrote: Does that work for Versatile Express CA9? It needs ARM_ERRATA_751472. On VE Linux runs in secure mode, so it's fine.

[PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Tony Lindgren
Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an earlier r1p2: CPU: ARMv7 Processor [411fc092] revision 2 (ARMv7), cr=10c53c7d Unfortunately I don't have the details of errata 751472, but I'm guessing we need to disable it for

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2012 at 10:53:35AM -0800, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an earlier r1p2: CPU: ARMv7 Processor [411fc092] revision 2 (ARMv7), cr=10c53c7d Unfortunately I don't have the

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Jon Hunter
On 11/14/2012 12:53 PM, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an earlier r1p2: CPU: ARMv7 Processor [411fc092] revision 2 (ARMv7), cr=10c53c7d Unfortunately I don't have the details of errata

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [121114 11:03]: On Wed, Nov 14, 2012 at 10:53:35AM -0800, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an earlier r1p2: CPU: ARMv7 Processor

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Tony Lindgren
* Jon Hunter jon-hun...@ti.com [121114 11:09]: On 11/14/2012 12:53 PM, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an earlier r1p2: CPU: ARMv7 Processor [411fc092] revision 2 (ARMv7), cr=10c53c7d

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2012 at 01:06:53PM -0600, Jon Hunter wrote: On 11/14/2012 12:53 PM, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an earlier r1p2: CPU: ARMv7 Processor [411fc092] revision 2 (ARMv7),

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [121114 12:24]: On Wed, Nov 14, 2012 at 01:06:53PM -0600, Jon Hunter wrote: On 11/14/2012 12:53 PM, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot when enabled. The ARM core on it is an

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Rob Herring
On 11/14/2012 02:32 PM, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [121114 12:24]: On Wed, Nov 14, 2012 at 01:06:53PM -0600, Jon Hunter wrote: On 11/14/2012 12:53 PM, Tony Lindgren wrote: Looks like enabling CONFIG_ARM_ERRATA_751472 causes omap4 blaze to not boot

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Tony Lindgren
* Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM, Tony Lindgren wrote: Checking for the bit already set should work in this case, I'll post a patch for that shortly. Can you actually read the state of the diagnostic register in non-secure mode? If you can on

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Rob Herring
On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM, Tony Lindgren wrote: Checking for the bit already set should work in this case, I'll post a patch for that shortly. Can you actually read the state of the diagnostic

Re: [PATCH] ARM: Fix errata 751472 handling on Cortex-A9 r1p*

2012-11-14 Thread Tony Lindgren
* Rob Herring robherri...@gmail.com [121114 16:56]: On 11/14/2012 04:21 PM, Tony Lindgren wrote: * Rob Herring robherri...@gmail.com [121114 13:59]: On 11/14/2012 02:32 PM, Tony Lindgren wrote: Checking for the bit already set should work in this case, I'll post a patch for that