Re: [PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-12 Thread David Brownell
On Sunday 07 September 2008, Bryan Wu wrote: > For Blackfin, the register MUSB_CONFIGDATA is not exported out to software. > So in the musb driver, Blackfin code can not access the MUSB_CONFIGDATA. > The configuration is fixed in the software. So an musb_read_configdata() inline could normally rea

Re: [PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-10 Thread Bryan Wu
On Thu, Sep 11, 2008 at 3:01 AM, Felipe Balbi <[EMAIL PROTECTED]> wrote: > On Mon, Sep 08, 2008 at 11:12:24AM +0800, Bryan Wu wrote: >> On Sun, Sep 7, 2008 at 1:04 PM, David Brownell <[EMAIL PROTECTED]> wrote: >> > On Thursday 04 September 2008, Gadiyar, Anand wrote: >> >> From: Anand Gadiyar <[EMA

Re: [PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-10 Thread Felipe Balbi
On Mon, Sep 08, 2008 at 11:12:24AM +0800, Bryan Wu wrote: > On Sun, Sep 7, 2008 at 1:04 PM, David Brownell <[EMAIL PROTECTED]> wrote: > > On Thursday 04 September 2008, Gadiyar, Anand wrote: > >> From: Anand Gadiyar <[EMAIL PROTECTED]> > >> > >> The Index register needs to be zero to access CONFIGD

Re: [PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-07 Thread Bryan Wu
On Sun, Sep 7, 2008 at 1:04 PM, David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 04 September 2008, Gadiyar, Anand wrote: >> From: Anand Gadiyar <[EMAIL PROTECTED]> >> >> The Index register needs to be zero to access CONFIGDATA. >> musb_ep_select()will not set the MUSB_INDEX register unless

Re: [PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-06 Thread David Brownell
On Thursday 04 September 2008, Gadiyar, Anand wrote: > From: Anand Gadiyar <[EMAIL PROTECTED]> > > The Index register needs to be zero to access CONFIGDATA. > musb_ep_select()will not set the MUSB_INDEX register unless INDEXED > mode addressing is used. This change will set the register correctly

[PATCH] MUSB: Set INDEX register to 0 before accessing CONFIGDATA

2008-09-04 Thread Gadiyar, Anand
From: Anand Gadiyar <[EMAIL PROTECTED]> The Index register needs to be zero to access CONFIGDATA. musb_ep_select()will not set the MUSB_INDEX register unless INDEXED mode addressing is used. This change will set the register correctly in INDEXED as well as FLAT mode. Signed-off-by: Anand Gadiyar