Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-08-05 Thread Tony Lindgren
Hi, Sorry for the long delay on replying to this one. * Wang Sawsd-A24013 cqw...@motorola.com [090602 02:25]: This patch adds irq_enable and irq_disable for OMAP GPIO IRQ chip, and also only enable WAKEUPEN When GPIO edge detection is enabled, also clear the gpio event triggering

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-08-05 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: Hi, Sorry for the long delay on replying to this one. Tony, this one has been superceded, and the irq_enable/disable stuff no longer is needed due to the patch OMAP: GPIO: clear/restore level/edge detect settings on mask/unmask from my PM fixes

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-08-05 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [090805 17:36]: Tony Lindgren t...@atomide.com writes: Hi, Sorry for the long delay on replying to this one. Tony, this one has been superceded, and the irq_enable/disable stuff no longer is needed due to the patch OMAP: GPIO:

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-05 Thread Wang Sawsd-A24013
Could you try this patch with your TS GPIO configured as level-triggered? Kevin I tried the below patch, it can solve the issue also. commit f8eb69a2edd684c9e0b72bc3c84c6af9718bd4a4 Author: Kevin Hilman khil...@deeprootsystems.com Date: Thu Jun 4 15:57:10 2009 -0700 OMAP:

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-05 Thread Kevin Hilman
Wang Sawsd-A24013 cqw...@motorola.com writes: Could you try this patch with your TS GPIO configured as level-triggered? I tried the below patch, it can solve the issue also. Thanks for testing. This whole time, you're probably wondering... why doesn't Kevin just add the disable and

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-05 Thread Wang Sawsd-A24013
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: 2009年6月6日 5:35 To: Wang Sawsd-A24013 Cc: linux-omap@vger.kernel.org; n...@ti.com; Mike Chan Subject: Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable Wang Sawsd-A24013

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-04 Thread Kevin Hilman
Wang Sawsd-A24013 cqw...@motorola.com writes: Kevin, See below for more comments/explanations: I still think there at least a couple different problems going on and I think you are addressing some symptoms but not the root cause. I understand that combine these two changes in one patch

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-04 Thread Wang Sawsd-A24013
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: 2009年6月5日 1:04 Dumb question: Why use level? Why not use falling edge for this? A good question, :-) We did use edge interrupt before, see the reason below. The issue is, after the touch driver

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-04 Thread Wang Sawsd-A24013
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Wang Sawsd-A24013 Sent: 2009年6月5日 1:43 To: Kevin Hilman Cc: linux-omap@vger.kernel.org; n...@ti.com; Mike Chan Subject: RE: [PATCH] OMAP2/3 Avoid GPIO pending irq

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-04 Thread Kevin Hilman
Subject: RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: 2009年6月5日 1:04 Dumb question: Why use level? Why not use falling edge for this? A good question, :-) We

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-04 Thread Wang Sawsd-A24013
What do you think about disabling the level/edge detection when disable_irq_wake() is called instead? This seems more logical and expected. Kevin, if we look at the current code, enable_irq_wake and disable_irq_wake Does not even touch any GPIO WAKEEN register, it seems it is intended To

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-04 Thread Kevin Hilman
Wang Sawsd-A24013 cqw...@motorola.com writes: What do you think about disabling the level/edge detection when disable_irq_wake() is called instead? This seems more logical and expected. Kevin, if we look at the current code, enable_irq_wake and disable_irq_wake Does not even touch any

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-03 Thread Wang Sawsd-A24013
Kevin, See below for more comments/explanations: I still think there at least a couple different problems going on and I think you are addressing some symptoms but not the root cause. I understand that combine these two changes in one patch may cause Some confusion, so this time I separate

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-02 Thread Kevin Hilman
Wang Sawsd-A24013 cqw...@motorola.com writes: Resend because of the content format issues in last mail---sorry for inconvenience. This version is line-wrapped and otherwise confusing as well so does not apply cleanly. Could you try using 'git format-patch' to generate your patch? It looks

RE: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-02 Thread Wang Sawsd-A24013
Wang Sawsd-A24013 cqw...@motorola.com writes: Resend because of the content format issues in last mail---sorry for inconvenience. This version is line-wrapped and otherwise confusing as well so does not apply cleanly. Could you try using 'git format-patch' to generate your patch? It

Re: [PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-02 Thread Kevin Hilman
Wang Sawsd-A24013 cqw...@motorola.com writes: Wang Sawsd-A24013 cqw...@motorola.com writes: Resend because of the content format issues in last mail---sorry for inconvenience. This version is line-wrapped and otherwise confusing as well so does not apply cleanly. Could you try using

[PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-01 Thread Wang Sawsd-A24013
This patch adds irq_enable and irq_disable for OMAP GPIO IRQ chip, and also only enable WAKEUPEN When GPIO edge detection is enabled, also clear the gpio event triggering configurations to avoid Pending interrupt status which is generated regardless of the IRQEN and WKUPEN bit, the pending IRQ

[PATCH] OMAP2/3 Avoid GPIO pending irq status been set after irq_disable

2009-06-01 Thread Wang Sawsd-A24013
Resend because of the content format issues in last mail---sorry for inconvenience. This patch adds irq_enable and irq_disable for OMAP GPIO IRQ chip, and also only enable WAKEUPEN When GPIO edge detection is enabled, also clear the gpio event triggering configurations to avoid Pending interrupt